Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 35 users
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug


Sign in to add a comment
Delete XP and Vista code
Project Member Reported by scottmg@chromium.org, Jan 19 2016 Back to list
Following the announcement of deprecation of XP/Vista http://chrome.blogspot.ca/2015/11/updates-to-chrome-platform-support.html
we can start removing and simplifying our code base to only support Windows 7 and above.

This is a meta-bug, there will be a variety of different subtasks.
 
Blockedon: chromium:579265
Blockedon: chromium:579532
Blockedon: chromium:579495
Blockedon: chromium:579678
Comment 6 by jam@chromium.org, Jan 20 2016
hmm, seems like we need to differentiate between tasks that are part of this bug (i.e. if xp bots are gone, we can delete xp sandbox code) vs bugs that block any removal of xp code (i.e. nacl sandbox testing, about to file a bug).
Comment 7 by jam@chromium.org, Jan 20 2016
Blockedon: chromium:579701
Comment 8 by mmenke@chromium.org, Jan 22 2016
Blockedon: chromium:580691
Project Member Comment 9 by bugdroid1@chromium.org, Jan 23 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc19b441cd83dc3fea697696d8f1b35bf6f65f5e

commit fc19b441cd83dc3fea697696d8f1b35bf6f65f5e
Author: jam <jam@chromium.org>
Date: Sat Jan 23 23:28:35 2016

Remove WebKit XP from Blink tooling in prepartion from removing that builder.

BUG=579196

Review URL: https://codereview.chromium.org/1612623002

Cr-Commit-Position: refs/heads/master@{#371156}

[modify] http://crrev.com/fc19b441cd83dc3fea697696d8f1b35bf6f65f5e/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py

Blockedon: chromium:580945
Project Member Comment 11 by bugdroid1@chromium.org, Jan 25 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/2852b11bd633b38b4351a29258d269f10a3744f4

commit 2852b11bd633b38b4351a29258d269f10a3744f4
Author: jam@chromium.org <jam@chromium.org>
Date: Mon Jan 25 15:56:04 2016

Remove XP and Vista bots from chromium.win and chromium.webkit waterfalls.

BUG=579196

Review URL: https://codereview.chromium.org/1608713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@298385 0039d316-1c4b-4281-b951-d872f2087c98

[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/masters/master.chromium.webkit/master_win_webkit_latest_cfg.py
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/masters/master.chromium.webkit/slaves.cfg
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/masters/master.chromium.win/master_win_cfg.py
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/masters/master.chromium.win/slaves.cfg
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/masters/master.tryserver.chromium.win/master.cfg
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/masters/master.tryserver.chromium.win/slaves.cfg
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/gatekeeper.json
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win_Builder.json
[delete] http://crrev.com/d28a4e1fb5175f0d12253b965a7ea0e58cdf14ad/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_XP.json
[delete] http://crrev.com/d28a4e1fb5175f0d12253b965a7ea0e58cdf14ad/scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__1_.json
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json
[delete] http://crrev.com/d28a4e1fb5175f0d12253b965a7ea0e58cdf14ad/scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__1_.json
[modify] http://crrev.com/2852b11bd633b38b4351a29258d269f10a3744f4/scripts/slave/recipes/chromium.py
[delete] http://crrev.com/d28a4e1fb5175f0d12253b965a7ea0e58cdf14ad/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_vista_rel_ng.json
[delete] http://crrev.com/d28a4e1fb5175f0d12253b965a7ea0e58cdf14ad/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_vista_rel_ng_analyze.json
[delete] http://crrev.com/d28a4e1fb5175f0d12253b965a7ea0e58cdf14ad/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_xp_rel_ng.json
[delete] http://crrev.com/d28a4e1fb5175f0d12253b965a7ea0e58cdf14ad/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_xp_rel_ng_analyze.json

Comment 12 by jam@chromium.org, Jan 25 2016
btw comment #8 is now done; since xp & vista bots are off the waterfall, code can land to remove support for them.
Comment 14 by e...@chromium.org, Jan 27 2016
Cc: e...@chromium.org
Comment 16 by bsep@chromium.org, Jan 29 2016
 Issue 426573  has been merged into this issue.
Blockedon: chromium:584969
Blockedon: chromium:587964
Blockedon: 602655
Comment 24 by tin...@google.com, Apr 12 2016
Labels: Proj-Nightfall
Project Member Comment 25 by bugdroid1@chromium.org, Apr 27 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cc0ed088316197c71ad14eb29f17915c2a85fc2

commit 4cc0ed088316197c71ad14eb29f17915c2a85fc2
Author: scottmg <scottmg@chromium.org>
Date: Wed Apr 27 23:24:37 2016

Make Power(Create|Set|Clear)Request direct calls

Previously had to be GetProcAddress()d for pre-Win7, but we no longer
run on pre-Win7.

BUG=579196

Review-Url: https://codereview.chromium.org/1928593003
Cr-Commit-Position: refs/heads/master@{#390231}

[modify] https://crrev.com/4cc0ed088316197c71ad14eb29f17915c2a85fc2/content/browser/power_save_blocker_win.cc

Project Member Comment 26 by bugdroid1@chromium.org, Jun 9 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d1fae2deb4a053c1e572e036b7a9b033136e945

commit 4d1fae2deb4a053c1e572e036b7a9b033136e945
Author: robliao <robliao@chromium.org>
Date: Thu Jun 09 21:29:35 2016

Use IsOS(OS_DOMAINMEMBER) to Check for Domain Membership

The IsOS check and the NetGetJoinInformation check are equivalent.

BUG=579196

Review-Url: https://codereview.chromium.org/2048083003
Cr-Commit-Position: refs/heads/master@{#399019}

[modify] https://crrev.com/4d1fae2deb4a053c1e572e036b7a9b033136e945/base/BUILD.gn
[modify] https://crrev.com/4d1fae2deb4a053c1e572e036b7a9b033136e945/base/win/win_util.cc

Project Member Comment 27 by bugdroid1@chromium.org, Jun 15 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d1fae2deb4a053c1e572e036b7a9b033136e945

commit 4d1fae2deb4a053c1e572e036b7a9b033136e945
Author: robliao <robliao@chromium.org>
Date: Thu Jun 09 21:29:35 2016

Use IsOS(OS_DOMAINMEMBER) to Check for Domain Membership

The IsOS check and the NetGetJoinInformation check are equivalent.

BUG=579196

Review-Url: https://codereview.chromium.org/2048083003
Cr-Commit-Position: refs/heads/master@{#399019}

[modify] https://crrev.com/4d1fae2deb4a053c1e572e036b7a9b033136e945/base/BUILD.gn
[modify] https://crrev.com/4d1fae2deb4a053c1e572e036b7a9b033136e945/base/win/win_util.cc

Project Member Comment 28 by bugdroid1@chromium.org, Jul 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83a3c26417896b207efe22b116a03a9a162c0ca5

commit 83a3c26417896b207efe22b116a03a9a162c0ca5
Author: tomhudson <tomhudson@google.com>
Date: Thu Jul 07 14:15:18 2016

Remove NativeThemeWin::PaintIndirect

We don't seem to actually use this complicated codepath in practice.

In particular:

1. // This block will only get hit with --enable-accelerated-drawing flag.
That flag is obsolete, and its replacement also seems to no longer exist.

2. // Scrollbar components on Windows Classic theme (on all Windows versions)
   // have particularly problematic alpha values, so always draw them
   // indirectly.
Turning on the Windows Classic theme on 64b Windows 7, I can't cause the block
to be hit today.

3. // In addition, scrollbar thumbs and grippers for the Windows XP
   // theme (available only on Windows XP) also need their alpha values
   // fixed.
We're no longer supporting XP and have been cleared to remove relevant code.

Once it's gone, so are several copies of functions that paint the
same UI element in different ways depending on whether they're drawing
to HDC or SkCanvas: Gutter, MenuSeparator, MenuBackground, and
MenuItemBackground.

R=pkasting@chromium.org
BUG=543755,579196, 622692 

Review-Url: https://codereview.chromium.org/2090003003
Cr-Commit-Position: refs/heads/master@{#404155}

[modify] https://crrev.com/83a3c26417896b207efe22b116a03a9a162c0ca5/ui/native_theme/native_theme_win.cc
[modify] https://crrev.com/83a3c26417896b207efe22b116a03a9a162c0ca5/ui/native_theme/native_theme_win.h

Owner: scottmg@chromium.org
Status: Started
Marking this as started to keep it off the triage list. scottmg@ as owner, since he initially filed it.
Project Member Comment 30 by bugdroid1@chromium.org, Jul 26 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d5fd19c90eb5e1715cd553b4161dc24d093eb23

commit 3d5fd19c90eb5e1715cd553b4161dc24d093eb23
Author: tomhudson <tomhudson@google.com>
Date: Tue Jul 26 01:42:05 2016

Revert of Remove NativeThemeWin::PaintIndirect (patchset #3 id:40001 of https://codereview.chromium.org/2090003003/ )

Reason for revert:
Directly causes  crbug.com/628574 , which is ship-blocking; we'll have to find another way to clean up the mess.

Original issue's description:
> Remove NativeThemeWin::PaintIndirect
>
> We don't seem to actually use this complicated codepath in practice.
>
> In particular:
>
> 1. // This block will only get hit with --enable-accelerated-drawing flag.
> That flag is obsolete, and its replacement also seems to no longer exist.
>
> 2. // Scrollbar components on Windows Classic theme (on all Windows versions)
>    // have particularly problematic alpha values, so always draw them
>    // indirectly.
> Turning on the Windows Classic theme on 64b Windows 7, I can't cause the block
> to be hit today.
>
> 3. // In addition, scrollbar thumbs and grippers for the Windows XP
>    // theme (available only on Windows XP) also need their alpha values
>    // fixed.
> We're no longer supporting XP and have been cleared to remove relevant code.
>
> Once it's gone, so are several copies of functions that paint the
> same UI element in different ways depending on whether they're drawing
> to HDC or SkCanvas: Gutter, MenuSeparator, MenuBackground, and
> MenuItemBackground.
>
> R=pkasting@chromium.org
> BUG=543755,579196, 622692 
>
> Committed: https://crrev.com/83a3c26417896b207efe22b116a03a9a162c0ca5
> Cr-Commit-Position: refs/heads/master@{#404155}

TBR=pkasting@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=543755,579196, 622692 

Review-Url: https://codereview.chromium.org/2181153002
Cr-Commit-Position: refs/heads/master@{#407679}

[modify] https://crrev.com/3d5fd19c90eb5e1715cd553b4161dc24d093eb23/ui/native_theme/native_theme_win.cc
[modify] https://crrev.com/3d5fd19c90eb5e1715cd553b4161dc24d093eb23/ui/native_theme/native_theme_win.h

Project Member Comment 31 by bugdroid1@chromium.org, Aug 2 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9

commit 5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9
Author: scottmg <scottmg@chromium.org>
Date: Tue Aug 02 20:49:05 2016

Allow handles through for official builds too (partial revert)

This is a (very) partial revert of
https://codereview.chromium.org/1291553003 to fix the crash reported in
https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I
started trying to dig into making renderers log, but it's still a hairy
mess.

R=wfh@chromium.org
BUG= 625172 , 358267, 579196
TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash.

Review-Url: https://codereview.chromium.org/2198603002
Cr-Commit-Position: refs/heads/master@{#409318}

[modify] https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9/base/process/launch_win.cc
[modify] https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9/content/common/sandbox_win.cc
[modify] https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9/content/test/content_browser_test_test.cc

Project Member Comment 32 by bugdroid1@chromium.org, Mar 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117

commit 00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117
Author: scottmg <scottmg@chromium.org>
Date: Tue Mar 21 19:38:37 2017

Revert of Allow handles through for official builds too (partial revert) (patchset #3 id:40001 of https://codereview.chromium.org/2198603002/ )

Reason for revert:
Potentially causing https://crbug.com/645319.

Graph to watch to see if it helps: https://goto.google.com/nezdg

BUG=645319

Original issue's description:
> Allow handles through for official builds too (partial revert)
>
> This is a (very) partial revert of
> https://codereview.chromium.org/1291553003 to fix the crash reported in
> https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I
> started trying to dig into making renderers log, but it's still a hairy
> mess.
>
> R=wfh@chromium.org
> BUG= 625172 , 358267, 579196
> TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash.
>
> Committed: https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9
> Cr-Commit-Position: refs/heads/master@{#409318}

TBR=wfh@chromium.org,sky@chromium.org,thestig@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 625172 , 358267, 579196

Review-Url: https://codereview.chromium.org/2767663002
Cr-Commit-Position: refs/heads/master@{#458513}

[modify] https://crrev.com/00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117/base/process/launch_win.cc
[modify] https://crrev.com/00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117/content/common/sandbox_win.cc
[modify] https://crrev.com/00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117/content/test/content_browser_test_test.cc

Project Member Comment 33 by bugdroid1@chromium.org, Apr 10
Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b8448f77e91f2ef81e4c36929454c321895ecd7

commit 7b8448f77e91f2ef81e4c36929454c321895ecd7
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Apr 10 20:25:14 2017

Revert of Allow handles through for official builds too (partial revert) (patchset #3 id:40001 of https://codereview.chromium.org/2198603002/ )

Reason for revert:
Potentially causing https://crbug.com/645319.

Graph to watch to see if it helps: https://goto.google.com/nezdg

BUG=645319

Original issue's description:
> Allow handles through for official builds too (partial revert)
>
> This is a (very) partial revert of
> https://codereview.chromium.org/1291553003 to fix the crash reported in
> https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I
> started trying to dig into making renderers log, but it's still a hairy
> mess.
>
> R=wfh@chromium.org
> BUG= 625172 , 358267, 579196
> TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash.
>
> Committed: https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9
> Cr-Commit-Position: refs/heads/master@{#409318}

TBR=wfh@chromium.org,sky@chromium.org,thestig@chromium.org
BUG= 625172 , 358267, 579196

Review-Url: https://codereview.chromium.org/2767663002
Cr-Commit-Position: refs/heads/master@{#458513}
(cherry picked from commit 00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117)

Review-Url: https://codereview.chromium.org/2810903002 .
Cr-Commit-Position: refs/branch-heads/3029@{#653}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7b8448f77e91f2ef81e4c36929454c321895ecd7/base/process/launch_win.cc
[modify] https://crrev.com/7b8448f77e91f2ef81e4c36929454c321895ecd7/content/common/sandbox_win.cc
[modify] https://crrev.com/7b8448f77e91f2ef81e4c36929454c321895ecd7/content/test/content_browser_test_test.cc

Project Member Comment 34 by bugdroid1@chromium.org, Jun 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab

commit dddfcf1b9e97593f1321a6744a37e91e8a32d7ab
Author: pmonette <pmonette@chromium.org>
Date: Fri Jun 02 22:38:43 2017

Removing useless Win7 checks + standardize its use

For example, if the comment mention Win8+, the check
will be base::win::GetVersion() >= base::win::VERSION_WIN8.

BUG=579196

Review-Url: https://codereview.chromium.org/2909943003
Cr-Commit-Position: refs/heads/master@{#476823}

[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/base/files/file_enumerator_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/base/path_service_unittest.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/base/test/test_shortcut_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/base/win/shortcut.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/base/win/shortcut.h
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/base/win/shortcut_unittest.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/download/download_status_updater_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/password_manager/password_manager_util_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/prefs/incognito_mode_prefs.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/shell_integration_win_unittest.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/pdf/adobe_reader_info_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/views/frame/browser_window_property_manager_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/views/frame/taskbar_decorator_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/unload_browsertest.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/web_applications/update_shortcut_worker_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/browser/web_applications/web_app_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/chrome/utility/importer/edge_database_reader_unittest_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/cloud_print/virtual_driver/win/install/setup.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/components/metrics/drive_metrics_provider_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/content/browser/renderer_host/legacy_render_widget_host_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/content/common/sandbox_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/device/gamepad/gamepad_platform_data_fetcher_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/device/power_save_blocker/power_save_blocker_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/media/gpu/gpu_video_decode_accelerator_factory.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/remoting/base/auto_thread_unittest.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/rlz/test/rlz_test_helpers.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/sandbox/win/src/process_mitigations_test.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/ui/base/win/shell.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/ui/events/blink/web_input_event_builders_win_unittest.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/ui/gl/vsync_provider_win.cc
[modify] https://crrev.com/dddfcf1b9e97593f1321a6744a37e91e8a32d7ab/ui/views/win/hwnd_message_handler.cc

Comment 35 Deleted
Comment 36 Deleted
Project Member Comment 37 by bugdroid1@chromium.org, Jul 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bea7178baa44e7506cdf7afaedb9fffa04007842

commit bea7178baa44e7506cdf7afaedb9fffa04007842
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Jul 11 17:29:31 2017

Remove useless references to unsupported windows versions (2)

This CL goes over the ui/ directory.

Bug: 579196
Change-Id: I028c2d04d9851e0861ca0f53832f7bafe4e99098
Reviewed-on: https://chromium-review.googlesource.com/565958
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485665}
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/base/ime/win/tsf_input_scope.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/base/l10n/l10n_util_unittest.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/base/l10n/l10n_util_win.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/base/webui/web_ui_util.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/gfx/animation/animation_unittest.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/gfx/animation/animation_win.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/native_theme/native_theme_win.cc
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/strings/app_locale_settings.grd
[modify] https://crrev.com/bea7178baa44e7506cdf7afaedb9fffa04007842/ui/views/controls/textfield/textfield_model_unittest.cc

Project Member Comment 38 by bugdroid1@chromium.org, Jul 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab240ec5732236f4906e8f3734d07dd643832727

commit ab240ec5732236f4906e8f3734d07dd643832727
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Jul 13 22:49:14 2017

Remove useless references to unsupported windows versions (5)

This CL goes over the base/ and chrome/ directory.

Bug: 579196
Change-Id: Icc97c5709072e833a62c1e0f75a28f2917d1dd19
Reviewed-on: https://chromium-review.googlesource.com/565962
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486502}
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/base/files/file_util_unittest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/base/process/process_util_unittest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/base/process/process_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/base/win/startup_information.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/base/win/startup_information_unittest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/base/win/win_util_unittest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/app/chromium_strings.grd
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/apps/app_url_redirector_browsertest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/diagnostics/recon_diagnostics.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/metrics/thread_watcher.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/net/net_error_diagnostics_dialog_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/ui/browser_focus_uitest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/ui/views/constrained_window_views_browsertest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/ui/views/elevation_icon_setter.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/ui/views/status_icons/status_icon_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/ui/views/status_icons/status_tray_state_changer_interactive_uitest_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/browser/ui/webui/help/version_updater_win.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/installer/setup/setup_util.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/installer/setup/setup_util_unittest.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/installer/util/shell_util.cc
[modify] https://crrev.com/ab240ec5732236f4906e8f3734d07dd643832727/chrome/utility/importer/ie_importer_win.cc

Project Member Comment 39 by bugdroid1@chromium.org, Jul 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4272e0fd06fa417c03289344a49c75054ea4b5f1

commit 4272e0fd06fa417c03289344a49c75054ea4b5f1
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Jul 14 21:23:14 2017

Remove useless references to unsupported windows versions (3)

This CL goes over the content/ directory.

Bug: 579196, 304193
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I8e87c220e424ff469c42abc09fa86746176b1812
Reviewed-on: https://chromium-review.googlesource.com/565944
Reviewed-by: James Forshaw <forshaw@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486891}
[modify] https://crrev.com/4272e0fd06fa417c03289344a49c75054ea4b5f1/content/browser/frame_host/frame_tree_browsertest.cc
[modify] https://crrev.com/4272e0fd06fa417c03289344a49c75054ea4b5f1/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/4272e0fd06fa417c03289344a49c75054ea4b5f1/content/browser/web_contents/web_contents_view_aura_browsertest.cc
[modify] https://crrev.com/4272e0fd06fa417c03289344a49c75054ea4b5f1/content/common/sandbox_win.cc
[modify] https://crrev.com/4272e0fd06fa417c03289344a49c75054ea4b5f1/content/renderer/pepper/pepper_plugin_instance_metrics.cc
[modify] https://crrev.com/4272e0fd06fa417c03289344a49c75054ea4b5f1/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/4272e0fd06fa417c03289344a49c75054ea4b5f1/content/test/content_browser_test_test.cc

Project Member Comment 40 by bugdroid1@chromium.org, Jul 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eb91df14a130769ef277d00eadb589a437d96ca

commit 7eb91df14a130769ef277d00eadb589a437d96ca
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Jul 28 19:10:24 2017

Remove useless references to unsupported windows versions (4)

This CL goes over the components/ directory.

Bug: 579196
Change-Id: Ice3f3fd7ee147c00ab6c6f6c6856ac296be76744
Reviewed-on: https://chromium-review.googlesource.com/565945
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490483}
[modify] https://crrev.com/7eb91df14a130769ef277d00eadb589a437d96ca/components/browser_watcher/watcher_client_win_unittest.cc
[modify] https://crrev.com/7eb91df14a130769ef277d00eadb589a437d96ca/components/crash/content/tools/crash_service.cc
[modify] https://crrev.com/7eb91df14a130769ef277d00eadb589a437d96ca/components/nacl/browser/pnacl_translation_cache_unittest.cc
[modify] https://crrev.com/7eb91df14a130769ef277d00eadb589a437d96ca/components/spellcheck/browser/spellcheck_host_metrics_unittest.cc

Project Member Comment 41 by bugdroid1@chromium.org, Jul 29
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af4d0ad7d9233c1023b34c21540256aa424e7773

commit af4d0ad7d9233c1023b34c21540256aa424e7773
Author: Patrick Monette <pmonette@chromium.org>
Date: Sat Jul 29 02:38:47 2017

Remove useless references to unsupported windows versions (1)

This CL goes over all directories excluding base/ chrome/ content/
components/ and ui/.

Bug: 579196
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4c792972b546b9de10669b7c3f66e85ab79cea94
Reviewed-on: https://chromium-review.googlesource.com/565897
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490593}
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/gpu/config/gpu_info_collector_win.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/gpu/config/gpu_test_config.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/media/audio/win/audio_output_win_unittest.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/mojo/edk/embedder/platform_channel_pair_win.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/mojo/edk/test/multiprocess_test_helper.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/rlz/win/lib/process_info.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/rlz/win/lib/registry_util.cc
[modify] https://crrev.com/af4d0ad7d9233c1023b34c21540256aa424e7773/services/device/battery/battery_status_manager_win.cc

Sign in to add a comment