New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
link

Issue 578890: [ozone/wayland] Ozone platform for Wayland.

Reported by spang@chromium.org, Jan 18 2016 Project Member

Issue description

We can support running chromium on wayland natively by adding a new platform //ui/ozone/platform/wayland.

It can be done by upstreaming (with any changes requested during review) https://github.com/01org/ozone-wayland

Eventually, we can have a linux chromium that runs on either x11 or wayland based on runtime environment.

We actually already have wayland in third_party for //components/exo.

UPD(msisov@igalia.com): this effort is currently being done by Igalia by upstreaming patches from https://github.com/igalia/chromium, and working on other missing bits directly in the upstream.
 
Showing comments 50 - 149 of 149 Older

Comment 50 by msi...@igalia.com, May 17 2018

Blockedon: 843924

Comment 51 by msi...@igalia.com, May 17 2018

Blockedon: 843018

Comment 52 by msi...@igalia.com, May 17 2018

Blockedon: 820047

Comment 53 by bugdroid1@chromium.org, May 18 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c3b009c32b14f0d84ddb19f49b5aba3399d0845

commit 6c3b009c32b14f0d84ddb19f49b5aba3399d0845
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri May 18 06:11:40 2018

[ozone/wayland] Reset implicit grab only after an event has been sent.

Reset implicit grab only after the event has been sent. Otherwise, we
may end up in a situation, when a target checks for a pointer grab on the
MouseRelease event type, and fails to release mouse pressed handlers
and reset capture with a capture controller.

TEST=./out/OzoneLinux/ozone_unittests --gtest_filter=
XdgVersionV5Test/WaylandPointerTest.ButtonPressAndCheckCapture/0
XdgVersionV5Test/WaylandPointerTest.ButtonReleaseAndCheckCapture/0
XdgVersionV6Test/WaylandPointerTest.ButtonPressAndCheckCapture/0 (1 ms)
XdgVersionV6Test/WaylandPointerTest.ButtonReleaseAndCheckCapture/0

Bug: 578890

Change-Id: Ia8810e5bac46bc49b356e7f79d3bba875dc72416
Reviewed-on: https://chromium-review.googlesource.com/1051787
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#559815}
[modify] https://crrev.com/6c3b009c32b14f0d84ddb19f49b5aba3399d0845/ui/ozone/platform/wayland/wayland_pointer.cc
[modify] https://crrev.com/6c3b009c32b14f0d84ddb19f49b5aba3399d0845/ui/ozone/platform/wayland/wayland_pointer.h
[modify] https://crrev.com/6c3b009c32b14f0d84ddb19f49b5aba3399d0845/ui/ozone/platform/wayland/wayland_pointer_unittest.cc

Comment 54 by bugdroid1@chromium.org, May 18 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54fd69310e96d63efdbde3d77c8fe0b31eae46c9

commit 54fd69310e96d63efdbde3d77c8fe0b31eae46c9
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri May 18 09:10:37 2018

[ozone/platform/wayland] Call OnNativeWidgetDestroying on destruction.

DesktopWindowTreeHostPlatform must notify native widget delegate
about destruction. This allows to properly release resources,
and fixes a AccessebilityChecker in browser_tests.

Bug: 578890
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I316fda5a2b2f35c865e192fc12274bc57cc2f1bf
Reviewed-on: https://chromium-review.googlesource.com/1059208
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559839}
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/components/viz/service/display_embedder/software_output_device_ozone_unittest.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/gpu/ipc/service/direct_composition_surface_win_unittest.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/services/ui/ws/platform_display_default.h
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/services/ui/ws/platform_display_mirror.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/services/ui/ws/platform_display_mirror.h
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/aura/window_tree_host_platform.h
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/compositor/test/test_compositor_host_ozone.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/gl/gl_surface_egl_unittest.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/ozone/demo/demo_window.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/ozone/demo/demo_window.h
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/ozone/platform/wayland/wayland_window_unittest.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/ozone/test/mock_platform_window_delegate.h
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/platform_window/platform_window_delegate.h
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc
[modify] https://crrev.com/54fd69310e96d63efdbde3d77c8fe0b31eae46c9/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.h

Comment 55 by bugdroid1@chromium.org, May 28 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71010c620e56596419e3447f480f29200e85cfaf

commit 71010c620e56596419e3447f480f29200e85cfaf
Author: Maksim Sisov <msisov@igalia.com>
Date: Mon May 28 12:33:40 2018

fixup! [ozone/platform/wayland] Call OnNativeWidgetDestroying on destruction.

Don't manually destroy widget to avoid confusing Wayland compositor
and getting errors from it.

TBR=rjkroege@chromium.org

Bug: 578890
Change-Id: I97ec928181ed813f30fe7478a5dc3fdf44acaa58
Reviewed-on: https://chromium-review.googlesource.com/1075049
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#562236}
[modify] https://crrev.com/71010c620e56596419e3447f480f29200e85cfaf/ui/ozone/platform/wayland/wayland_window.cc

Comment 56 by bugdroid1@chromium.org, May 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62190d478a25e16cf3f18326026a0d1bd8b63c64

commit 62190d478a25e16cf3f18326026a0d1bd8b63c64
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Tue May 29 03:50:12 2018

Added stopped_propagation condition at input_method_minial

It added event->stopped_propagation() condition at input_method_minimal
to avoid inserting character when stopped_propagation is set while
DispatchKeyEventPostIME is working. input_method_minial works on Ozone
with wayland.
It also added input_method_minimal_unittests.cc and introduced
'InputMethodMinimalTest.StopPropagationTest' to verify that
character's not inserted to text input when the event is
set with stopped_propagation.

TEST=ui_base_unittests

Bug:  843924 , 578890
Change-Id: I2d8f6d408a04cd7affd8089157b7b0efa07379d5
Reviewed-on: https://chromium-review.googlesource.com/1063417
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#562332}
[modify] https://crrev.com/62190d478a25e16cf3f18326026a0d1bd8b63c64/ui/base/BUILD.gn
[modify] https://crrev.com/62190d478a25e16cf3f18326026a0d1bd8b63c64/ui/base/ime/input_method_minimal.cc
[add] https://crrev.com/62190d478a25e16cf3f18326026a0d1bd8b63c64/ui/base/ime/input_method_minimal_unittest.cc

Comment 57 by msi...@igalia.com, May 30 2018

Blockedon: 847740

Comment 58 by je_julie.kim@chromium.org, May 31 2018

Blockedon: 848131

Comment 59 by je_julie.kim@chromium.org, Jun 5 2018

Blockedon: 849596

Comment 60 by toniki...@chromium.org, Jun 13 2018

Cc: -msi...@igalia.com toniki...@chromium.org
Owner: msi...@igalia.com
Setting Maksim as owner. I will be supporting the team.

Comment 61 by bugdroid1@chromium.org, Jun 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d45bfc35850cc63db278b6aa331bf9f70b8ad596

commit d45bfc35850cc63db278b6aa331bf9f70b8ad596
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri Jun 15 10:47:58 2018

[ozone/platform] Add support for menu window type

In particular, there is now a PlatformWindowInitProperties structure,
which brings initial properties to ozone windows. It can be initialized
(in the future, when other code is in place) with a desired window type,
bounds and parenting model, which is very important for Wayland's
xdg_popup windows (used for menu windows, for example).

Bug: 578890
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
Change-Id: I573912d462d698b19b1bb09cf687971965e951e0
Reviewed-on: https://chromium-review.googlesource.com/1068746
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567601}
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/chrome/browser/vr/testapp/vr_testapp.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/services/ui/ws/platform_display.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/aura/window_tree_host_platform.h
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/compositor/test/test_compositor_host_ozone.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/demo/demo_window.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/platform/cast/ozone_platform_cast.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/platform/headless/ozone_platform_headless.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/platform/windows/ozone_platform_windows.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/platform/x11/ozone_platform_x11.cc
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/ozone/public/ozone_platform.h
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/platform_window/BUILD.gn
[add] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/platform_window/platform_window_init_properties.h
[modify] https://crrev.com/d45bfc35850cc63db278b6aa331bf9f70b8ad596/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Comment 62 by bugdroid1@chromium.org, Jun 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b914bd2c8b8f301bc9ad5073de592c34dcbac25f

commit b914bd2c8b8f301bc9ad5073de592c34dcbac25f
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri Jun 15 11:53:51 2018

[ozone/wayland] Add support for menu window type

It's now possible to create menu/popup windows in ozone/wayland.

What is more, Ozone/Wayland now implements xdg popup objects, which are
used for such windows as menus. Basically, popup windows are the only
windows, which clients are able to set to whatever place they want on
top of a parent window (global coordinates are not available).

The FakeServer has also been extended to support xdg popup and positioner
objects. What is more, ownership model for the new added objects is a bit
different. Instead of keeping them owned by surfaces, they are making use
of helper template methods with wl_resource_set_implementation, which
automatically take and release unique_ptrs.

In the future, all the other mock objects must be turned to that model for
simplicity.

TEST=XdgVersionV5Test or XdgVersionV6Test
WaylandWindowTest.CreateAndDestroyMenuWindow/0,
WaylandWindowTest.CreateAndDestroyNestedMenuWindow/0,
WaylandWindowTest.CanDispatchEventToMenuWindowNested/0,
WaylandWindowTest.CanDispatchEventToMenuWindowNonNested/0 (1 ms)

Bug: 578890
Change-Id: Ia644862cce34375d3a758d8c0ff398c75dd47772
Reviewed-on: https://chromium-review.googlesource.com/1075309
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567608}
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/BUILD.gn
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/fake_server.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/fake_server.h
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_connection.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_connection.h
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_keyboard.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_object.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_object.h
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_pointer_unittest.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_test.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_window.h
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/wayland_window_unittest.cc
[add] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_popup_wrapper.h
[add] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_popup_wrapper_v5.cc
[add] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_popup_wrapper_v5.h
[add] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_popup_wrapper_v6.cc
[add] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_popup_wrapper_v6.h
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_surface_wrapper.h
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_surface_wrapper_v5.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_surface_wrapper_v5.h
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_surface_wrapper_v6.cc
[modify] https://crrev.com/b914bd2c8b8f301bc9ad5073de592c34dcbac25f/ui/ozone/platform/wayland/xdg_surface_wrapper_v6.h

Comment 63 by msi...@igalia.com, Jun 20 2018

Blockedon: 854564

Comment 64 by bugdroid1@chromium.org, Jun 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/289afd805a5fd0f001d7076d94177bc8a8b99f04

commit 289afd805a5fd0f001d7076d94177bc8a8b99f04
Author: Maksim Sisov <msisov@igalia.com>
Date: Thu Jun 21 09:39:03 2018

fixup! [ozone/wayland] Add support for menu window type.

Remove accidentely added CHECK in the popup wrapper v6.
added in https://chromium-review.googlesource.com/107530

TBR=rjkroege@chromium.org

Bug: 578890
Change-Id: I375668380a91b71665873bd682c909dad9e7f50a
Reviewed-on: https://chromium-review.googlesource.com/1109516
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#569198}
[modify] https://crrev.com/289afd805a5fd0f001d7076d94177bc8a8b99f04/ui/ozone/platform/wayland/xdg_popup_wrapper_v6.cc

Comment 65 by bugdroid1@chromium.org, Jun 27 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45e7562cd3e91702ecd8f05e8b2cec69141adda4

commit 45e7562cd3e91702ecd8f05e8b2cec69141adda4
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Jun 27 11:58:33 2018

[ozone/wayland] Implement support to Tooltips using sub-surfaces

CL makes use of the sub-surface functionality to implement support for
tooltips in Ozone/Wayland.
A sub-surface has one parent surface, but its size and position are not
limited to that of the parent. This means that, the content of a sub-surface
is not automatically clipped to its parent's area.

Additionally, by default, the input region of a sub-surface is empty.
This causes all input events to be reported on the main surface, instead.

TEST=Very basic UI feature: simply hover over any item that shows a tooltip.

TBR=sadrul@chromium.org

BUG=578890

Change-Id: I09a0eb7c79516a995cc3a4994f4959cf15b37736
Reviewed-on: https://chromium-review.googlesource.com/1110098
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570734}
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/ozone/platform/wayland/wayland_connection.cc
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/ozone/platform/wayland/wayland_connection.h
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/ozone/platform/wayland/wayland_object.cc
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/ozone/platform/wayland/wayland_object.h
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/ozone/platform/wayland/wayland_window.h
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/platform_window/platform_window_init_properties.h
[modify] https://crrev.com/45e7562cd3e91702ecd8f05e8b2cec69141adda4/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Comment 66 by bugdroid1@chromium.org, Jul 26 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36473a64b436dcc24ccc94c271422a1da5f288d5

commit 36473a64b436dcc24ccc94c271422a1da5f288d5
Author: Maksim Sisov <msisov@igalia.com>
Date: Thu Jul 26 09:43:11 2018

[ozone/wayland] Fix crash with html drop-down menus.

html drop-down menus are represented by XDG popup windows, which don't
have a parent window associated in aura. Thus, null accelerated widget is passed,
which can't be used to find a parent. Instead, a currently focused window
must be used.

Actually, it is so in the WaylandWindow::GetParentWindow, but
there is a redundant check, which doesn't call the GetParentWindow if the
parent widget is null.

Fix: remove the if check and always call the GetParentWindow.

TBR=rjkroege@chromium.org

Bug: 578890
Change-Id: I0ecab40d80929fd4ca4445cbb3ae753e00b3d458
Reviewed-on: https://chromium-review.googlesource.com/1149363
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#578249}
[modify] https://crrev.com/36473a64b436dcc24ccc94c271422a1da5f288d5/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/36473a64b436dcc24ccc94c271422a1da5f288d5/ui/ozone/platform/wayland/wayland_window_unittest.cc

Comment 67 by msi...@igalia.com, Jul 31 2018

Blockedon: 869286

Comment 68 by bugdroid1@chromium.org, Aug 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe

commit 137b83a431e1b3f7eb88ad2781126b14c2f1e6fe
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Fri Aug 10 03:53:42 2018

Add implementation for GetRestoredBounds for DesktopWindowTreeHostPlatform

This CL introduces SetRestoredBoundsInPixels/GetRestoredBoundsInPixels
in PlatformWindow to communicate with DesktopWindowTreeHostPlatform
and makes DesktopWindowTreeHostPlatform use PlatformWindow::
GetRestoredBoundsInPixels() to get restored bounds.

When WaylandWindow is created, HandleSurfaceConfigure() is always
called without any state setting and |state_| is normal at first.
In order to know the right time when the state is changed, this
patch also updates the initial value for |state_| of WaylandWindow
to 'PLATFORM_WINDOW_STATE_NORMAL'. With this, it clears
|restored_bounds_| correctly.

--ozone-platform=wayland --in-process-gpu, see  crbug.com/848131 
for more details.

Test: ozone_unittests and manual testing with ./out/ozone/chrome
Bug:  848131 , 578890
Change-Id: Ifc27e60e24865a2237a0a49d5dc0f1452702c716
Reviewed-on: https://chromium-review.googlesource.com/1080354
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#582041}
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/drm/host/drm_window_host.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/drm/host/drm_window_host.h
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/wayland/wayland_window.h
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/wayland/wayland_window_unittest.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/platform_window.h
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/stub/stub_window.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/stub/stub_window.h
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/win/win_window.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/win/win_window.h
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/x11/x11_window_base.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/x11/x11_window_base.h
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc
[modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.h

Comment 69 by bugdroid1@chromium.org, Aug 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac76759cde3d2ca7ce73e10a74e28db5ac64c201

commit ac76759cde3d2ca7ce73e10a74e28db5ac64c201
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri Aug 10 08:00:15 2018

[ozone/wayland] Fix crash when right-clicking on the window decoration area.

On chrome/x11, right-clicking on the window decoration bar toggles a
context menu whose one of the menu items allows switching between
builtin and system/native window decorations.

Today, chrome/ozone/wayland crashes when building the menu because it tried to
read a preference only registered in use_x11: kUseCustomChromeFrame.

So this CL does two things:

- registers the preference [1] based on PlatformProperties in case of USE_OZONE.

- checks whether using system title bar[2] is supported by underlying ozone platform.
By default, ozone platforms have this feature disabled.

[1] kUseCustomChromeFrame
[2] IDC_USE_SYSTEM_TITLE_BAR

Based on tonikitoo@igalia.com's patch.

Bug: 578890,  849596 
Change-Id: Ib05d2057f1193a9e41580d0133e35dff4bc2ea77
Reviewed-on: https://chromium-review.googlesource.com/1167045
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582087}
[modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/DEPS
[modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/ac76759cde3d2ca7ce73e10a74e28db5ac64c201/ui/ozone/public/ozone_platform.h

Comment 70 by msi...@igalia.com, Aug 17

Blockedon: 875161

Comment 71 by msi...@igalia.com, Aug 17

Components: Internals>PlatformIntegration
Labels: Wayland

Comment 72 by msi...@igalia.com, Aug 17

Summary: [ozone/wayland[ Ozone platform for Wayland. (was: upstream wayland backend for ozone)

Comment 73 by msi...@igalia.com, Aug 17

Blockedon: 875164

Comment 74 by msi...@igalia.com, Aug 17

Blockedon: 875165

Comment 75 by msi...@igalia.com, Aug 17

Blockedon: 845818

Comment 76 by msi...@igalia.com, Aug 17

Summary: [ozone/wayland] Ozone platform for Wayland. (was: [ozone/wayland[ Ozone platform for Wayland.)

Comment 77 by bugdroid1@chromium.org, Aug 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514383a2188ae3b4f2fdc7f466abfa3ebb9880af

commit 514383a2188ae3b4f2fdc7f466abfa3ebb9880af
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Fri Aug 17 13:45:32 2018

[ozone/wayland] Add a helper function to WaylandDataDevice to read the data from FD

It moves the code to read the data from FD to 'ReadDataFromFD' in
WaylandDataDevice to reuse it for drag-and-drop, as WaylandDataDevice
is the class to handle not only copy-and-paste but drag-and-drop and
drag-and-drop needs to read the data from FD as well.

It doesn't bring behavioral changes.

Bug: 578890, 875164
Change-Id: I460ab9df2b4d32bbdb0e71c753cb19c572df12ab
Reviewed-on: https://chromium-review.googlesource.com/1179505
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584047}
[modify] https://crrev.com/514383a2188ae3b4f2fdc7f466abfa3ebb9880af/ui/ozone/platform/wayland/wayland_data_device.cc
[modify] https://crrev.com/514383a2188ae3b4f2fdc7f466abfa3ebb9880af/ui/ozone/platform/wayland/wayland_data_device.h

Comment 78 by bugdroid1@chromium.org, Aug 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1d779496e6d7caefd1780f4946aced1e22401c

commit 2f1d779496e6d7caefd1780f4946aced1e22401c
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Sun Aug 19 02:46:10 2018

[ozone/wayland] Add wayland_util.cc/h to create utiliy APIs

It introduces wayland_util.cc/h and moves the code to create shared
memory buffer and draw bitmap on it from WaylandCursor, as it could
be used generally rather than specific to cursor area.
On upcoming patch for drag and drop on Wayland, it's also required
to pass the drag icon surface to Wayland.

It doesn't bring behavioral changes.

Bug: 578890, 875164
Change-Id: I0cd4603c2abacaa899a9fcf19d97186d6f493146
Reviewed-on: https://chromium-review.googlesource.com/1179487
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584328}
[modify] https://crrev.com/2f1d779496e6d7caefd1780f4946aced1e22401c/ui/ozone/platform/wayland/BUILD.gn
[modify] https://crrev.com/2f1d779496e6d7caefd1780f4946aced1e22401c/ui/ozone/platform/wayland/wayland_cursor.cc
[modify] https://crrev.com/2f1d779496e6d7caefd1780f4946aced1e22401c/ui/ozone/platform/wayland/wayland_cursor.h
[add] https://crrev.com/2f1d779496e6d7caefd1780f4946aced1e22401c/ui/ozone/platform/wayland/wayland_util.cc
[add] https://crrev.com/2f1d779496e6d7caefd1780f4946aced1e22401c/ui/ozone/platform/wayland/wayland_util.h

Comment 79 by rjkroege@chromium.org, Aug 23

Blockedon: 877251

Comment 80 by van...@gmail.com, Aug 24

I hope this can actually solve X11 longstanding tooltip issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=877508

Comment 81 by msi...@igalia.com, Aug 28

Blockedon: 791920

Comment 82 by je_julie.kim@chromium.org, Aug 31

Blockedon: 879448

Comment 83 by bugdroid1@chromium.org, Sep 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dc2f03d8086a9b60136c3585abb83aca356a676

commit 9dc2f03d8086a9b60136c3585abb83aca356a676
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri Sep 07 09:36:33 2018

[ozone/common] Make gbm_wrapper to be compiled with system libgbm

This patch makes use of new minigbm APi names, which are aligned with
Linux libgbm.

Also, it defines certain definitions, which are different between
libgbm and minigbm.

What is more, it adds USING_MINIGBM for internal usage to be able
to distinguish between system linux gbm and minigbm.

Last but not least, drmPrimeHandleToFd is used in case of linux
system libgbm in order to be able to get mappable fds per each
plane, which is neede to add GpuMemoryBuffers support.

Bug:  869206 , 578890, 820047
Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585
Reviewed-on: https://chromium-review.googlesource.com/1158234
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589475}
[modify] https://crrev.com/9dc2f03d8086a9b60136c3585abb83aca356a676/ui/ozone/common/linux/gbm_wrapper.cc

Comment 84 by bugdroid1@chromium.org, Sep 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/816f0e1e5c15d7fce9389a428cbd49bbdf158501

commit 816f0e1e5c15d7fce9389a428cbd49bbdf158501
Author: Ryo Hashimoto <hashimoto@chromium.org>
Date: Wed Sep 19 04:46:16 2018

Revert "[ozone/common] Make gbm_wrapper to be compiled with system libgbm"

This reverts commit 9dc2f03d8086a9b60136c3585abb83aca356a676.

Reason for revert: causes crash loop on grunt

Original change's description:
> [ozone/common] Make gbm_wrapper to be compiled with system libgbm
> 
> This patch makes use of new minigbm APi names, which are aligned with
> Linux libgbm.
> 
> Also, it defines certain definitions, which are different between
> libgbm and minigbm.
> 
> What is more, it adds USING_MINIGBM for internal usage to be able
> to distinguish between system linux gbm and minigbm.
> 
> Last but not least, drmPrimeHandleToFd is used in case of linux
> system libgbm in order to be able to get mappable fds per each
> plane, which is neede to add GpuMemoryBuffers support.
> 
> Bug:  869206 , 578890, 820047
> Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585
> Reviewed-on: https://chromium-review.googlesource.com/1158234
> Commit-Queue: Maksim Sisov <msisov@igalia.com>
> Reviewed-by: Michael Spang <spang@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589475}

TBR=rjkroege@chromium.org,spang@chromium.org,msisov@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  869206 , 578890, 820047
Change-Id: Idd0f9e4aa584bc1e353d3947cef12e4ee8839385
Reviewed-on: https://chromium-review.googlesource.com/1232881
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592321}
[modify] https://crrev.com/816f0e1e5c15d7fce9389a428cbd49bbdf158501/ui/ozone/common/linux/gbm_wrapper.cc

Comment 85 by msi...@igalia.com, Sep 22

Description: Show this description

Comment 86 by bugdroid1@chromium.org, Sep 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f58561bfd061239d5e8ed2f8100c994ecca5cf3

commit 9f58561bfd061239d5e8ed2f8100c994ecca5cf3
Author: Maksim Sisov <msisov@igalia.com>
Date: Wed Sep 26 07:06:15 2018

[ozone/wayland] Override kEnableOzoneDrmMojo to enabled by default.

Ozone/Wayland relies on the mojo communication when running in the
!single_process mode. Thus, to avoid messing up with ifdefs in the
features::IsOzoneDrmMojo(), override the feature in the
OzonePlatformWayland::InitializeUI if the !single_process condition is
true.

Bug: 578890
Change-Id: I8d1515cae2fc117dd171d3ca3443c9a098192985
Reviewed-on: https://chromium-review.googlesource.com/1228999
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594235}
[modify] https://crrev.com/9f58561bfd061239d5e8ed2f8100c994ecca5cf3/ui/ozone/platform/wayland/DEPS
[modify] https://crrev.com/9f58561bfd061239d5e8ed2f8100c994ecca5cf3/ui/ozone/platform/wayland/ozone_platform_wayland.cc

Comment 87 by msi...@igalia.com, Sep 28

Blockedon: 890276

Comment 88 by msi...@igalia.com, Sep 28

Blockedon: 875168

Comment 89 by msi...@igalia.com, Sep 28

Blockedon: 890284

Comment 90 by msi...@igalia.com, Oct 2

Blockedon: 891205

Comment 91 by msi...@igalia.com, Oct 2

Blockedon: 878692

Comment 92 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e0643492de1007123725353a8417e961bd12a80

commit 2e0643492de1007123725353a8417e961bd12a80
Author: Maksim Sisov <msisov@igalia.com>
Date: Wed Oct 03 10:35:06 2018

[ozone/wayland] Use PlatformProperties to know if mojo is required.

Relying on OzoneDrmMojo feature is not a very good idea, because
it is mostly intended to be used with the Ozone/Drm platform, which can use both
the legacy IPC and mojo for communication. It happened once that the
Ozone/Wayland platform regressed due to misunderstandings why that
feature flag was used with ifdefs.

In Ozone/Wayland, the mojo IPC is a requirement to be able to run
the browser in a multi-process mode(there is a separate GPU process).
Thus, use PlatformProperties to know if the platform requires mojo communication
before the gpu is started. At the moment, only Ozone/Wayland
platform requires mojo communication in addition to the Ozone/Drm
platform, which can use both legacy IPC and mojo and uses OzoneDrmMojo
feature instead.

Bug: 578890
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1f0fccb19ec2fc69a50320b55014979556739c2c
Reviewed-on: https://chromium-review.googlesource.com/c/1254209
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596174}
[modify] https://crrev.com/2e0643492de1007123725353a8417e961bd12a80/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/2e0643492de1007123725353a8417e961bd12a80/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/2e0643492de1007123725353a8417e961bd12a80/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/2e0643492de1007123725353a8417e961bd12a80/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/2e0643492de1007123725353a8417e961bd12a80/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/2e0643492de1007123725353a8417e961bd12a80/ui/ozone/public/ozone_platform.h

Comment 93 by msi...@igalia.com, Oct 12

Blockedon: 894727

Comment 94 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f99be2213ca6958f558add3eaf4494101a4c1821

commit f99be2213ca6958f558add3eaf4494101a4c1821
Author: Maksim Sisov <msisov@igalia.com>
Date: Tue Oct 16 06:50:03 2018

[ozone/common] Make planar import work with 0x5505 and 0x5504.

This is first step to migrate minigbm to use
GBM_BO_IMPORT_FD_MODIFIER instead of GBM_BO_IMPORT_FD_PLANAR.

Ones ChromeOS will start using the newest chrome, we can
finally add GBM_BO_IMPORT_FD_MODIFIER 0x5504 to minigbm and
get rid of GBM_BO_IMPORT_FD_PLANAR.

See comment from Tomasz in https://crrev.com/c/1273455

Bug:  869206 , 578890, 820047
Change-Id: Ibac5c0c874c523e845675ff944561d3e2a3ec530
Reviewed-on: https://chromium-review.googlesource.com/c/1278400
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599893}
[modify] https://crrev.com/f99be2213ca6958f558add3eaf4494101a4c1821/ui/ozone/common/linux/gbm_wrapper.cc

Comment 95 by msi...@igalia.com, Oct 16

Blockedon: 895743

Comment 96 by msi...@igalia.com, Oct 18

Blockedon: 896640

Comment 97 by msi...@igalia.com, Oct 18

Blockedon: 896676

Comment 98 by msi...@igalia.com, Oct 19

Cc: -julien.isorce@chromium.org jje_julie.kim@chromium.org

Comment 99 by msi...@igalia.com, Oct 19

Cc: -jje_julie.kim@chromium.org jjulien.isorce@chromium.org je_julie.kim@chromium.org

Comment 100 by msi...@igalia.com, Oct 19

Cc: -jjulien.isorce@chromium.org julien.isorce@chromium.org

Comment 101 by jmukthavaram@chromium.org, Nov 16

Friendly ping to get an update on this issue.
Thanks..!

Comment 102 by j...@igalia.com, Nov 16

Hi, as this is a kind of meta bug, we're filing issues with the specific scenario per each case or feature and adding a relationship with this bug ID.
As for the general status of Ozone/Wayland port, we can build and launch ozone/wayland from chromium ToT.
The build config is below.

use_ozone = true
ozone_platform_wayland = true

You can find the information here,
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ozone_overview.md#linux-desktop-waterfall

If you're interested in any issue related to Ozone/wayland, please let us know.

Comment 103 by rjkroege@chromium.org, Nov 16

Labels: Proj-Ozone-Wayland

Comment 104 by msi...@igalia.com, Nov 27

Blockedon: 908537

Comment 105 by msi...@igalia.com, Dec 4

Blockedon: 910797

Comment 106 by msi...@igalia.com, Jan 15

Blockedon: 921947

Comment 107 by msi...@igalia.com, Jan 15

Blockedon: 921950

Comment 108 by msi...@igalia.com, Jan 15

Cc: nickdi...@igalia.com

Comment 109 by nickdi...@igalia.com, Jan 18

Blockedon: 890272

Comment 110 by msi...@igalia.com, Jan 29

Blockedon: 926101

Comment 111 by msi...@igalia.com, Jan 29

Blockedon: 926152

Comment 112 by msi...@igalia.com, Jan 29

Blockedon: -847740

Comment 113 by msi...@igalia.com, Jan 29

Labels: -Wayland

Comment 114 by msi...@igalia.com, Jan 31

Blockedon: 927195

Comment 115 by msi...@igalia.com, Jan 31

Blockedon: 927274

Comment 116 by msi...@igalia.com, Jan 31

Blockedon: 927280

Comment 117 by msi...@igalia.com, Feb 4

Blockedon: 928234

Comment 118 by msi...@igalia.com, Feb 4

Blockedon: -928234

Comment 119 by msi...@igalia.com, Feb 4

Blockedon: 928260

Comment 120 by msi...@igalia.com, Feb 4

Blockedon: 928272

Comment 121 by msi...@igalia.com, Feb 4

Blockedon: 928274

Comment 122 by msi...@igalia.com, Feb 4

Blockedon: -894727

Comment 123 by msi...@igalia.com, Feb 4

Blockedon: -895743

Comment 124 by msi...@igalia.com, Feb 4

Blockedon: -928260

Comment 125 by msi...@igalia.com, Feb 4

Blockedon: -928272

Comment 126 by msi...@igalia.com, Feb 4

Blockedon: -879448

Comment 127 by msi...@igalia.com, Feb 4

Blockedon: -869286

Comment 128 by msi...@igalia.com, Feb 4

Blockedon: -926101

Comment 129 by msi...@igalia.com, Feb 6

Blockedon: 929018

Comment 130 by msi...@igalia.com, Feb 11

Blockedon: 929632

Comment 131 by msi...@igalia.com, Feb 11

Blockedon: 930662

Comment 132 by msi...@igalia.com, Feb 11

Blockedon: -930662

Comment 133 by msi...@igalia.com, Feb 11

Blockedon: 930664

Comment 134 by msi...@igalia.com, Feb 11

Blockedon: 928269

Comment 135 by msi...@igalia.com, Feb 11

Blockedon: 848385

Comment 136 by msi...@igalia.com, Feb 11

Blockedon: 841539

Comment 137 by msi...@igalia.com, Feb 11

Blockedon: 700309

Comment 138 by msi...@igalia.com, Feb 11

Blockedon: 913422

Comment 139 by bugdroid, Feb 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f36ee77a1e8cb4baebb863d3497d746caabab425

commit f36ee77a1e8cb4baebb863d3497d746caabab425
Author: Maksim Sisov <msisov@igalia.com>
Date: Tue Feb 12 07:51:50 2019

Revert "[ozone/common] Make planar import work with 0x5505 and 0x5504."

This reverts commit f99be2213ca6958f558add3eaf4494101a4c1821.

This commit was incorrect and blocked landing of
https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1454658.

To be more precise, it tried to import 0x5505 modifier, which
required another structure to be used, when the above mentioned
patch was sent to cq. This resulted in unexpected behaviour and crashes.

Thus, just revert this patch, and once 1454658 lands, make it use
updated modifier.

TBR=spang@chromium.org

Bug:  869206 , 578890, 820047
Change-Id: I13617b0eff3f68aa8bdf8eee46c824fedaf7288e
Reviewed-on: https://chromium-review.googlesource.com/c/1466361
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#631144}
[modify] https://crrev.com/f36ee77a1e8cb4baebb863d3497d746caabab425/ui/ozone/common/linux/gbm_wrapper.cc

Comment 140 by msi...@igalia.com, Feb 12

Blockedon: 930302

Comment 141 by nickdi...@igalia.com, Feb 13

Blockedon: 931030

Comment 142 by bugdroid, Feb 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f6016322c762ecb468aff5273bdf716c1adbb16

commit 6f6016322c762ecb468aff5273bdf716c1adbb16
Author: Nick Diego Yamane <nickdiego@igalia.com>
Date: Wed Feb 13 09:00:06 2019

ozone/wayland: Reuse tooltip subsurfaces

This patch modifies WaylandWindow so that it reuses
tooltip subsurfaces instead of recreating/destroying them
every time show/hide functions are called.
This change aims to boost performance of tooltips creation
since we avoid recreating subsurfaces so frequently.
Additionally, this avoids crashing compositors such as Sway
[1], which is getting pretty popular and is known to have
buggy implementation of subsurfaces handling [2]. For example,
some sway crashes have been observed after focus -> unfocus ->
focus again buttons with tooltips for example. This kind of issue
haven't been observed anymore after this change.

[1] https://swaywm.org
[2] https://github.com/swaywm/sway/issues/3195

Bug: 578890
Change-Id: Ic27fb491c446f30f3d60633f4216b56799463896
Reviewed-on: https://chromium-review.googlesource.com/c/1466063
Commit-Queue: Nick Diego Yamane <nickdiego@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#631605}
[modify] https://crrev.com/6f6016322c762ecb468aff5273bdf716c1adbb16/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/6f6016322c762ecb468aff5273bdf716c1adbb16/ui/ozone/platform/wayland/wayland_window.h

Comment 143 by msi...@igalia.com, Feb 14

Blockedon: 932098

Comment 144 by msi...@igalia.com, Feb 14

Blockedon: -932098

Comment 145 by bugdroid, Feb 19 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f45744195db9945e195ef63b84be0a7fd999fb35

commit f45744195db9945e195ef63b84be0a7fd999fb35
Author: Maksim Sisov <msisov@igalia.com>
Date: Tue Feb 19 12:35:00 2019

[ozone/wayland] Fix includes and deps.

Fix BUILD.gn includes and headers usages.

Bug: 578890
Change-Id: Ib8a7626f74d58f7584c8c44aff7f69a512c39a6d
Reviewed-on: https://chromium-review.googlesource.com/c/1477126
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#633234}
[modify] https://crrev.com/f45744195db9945e195ef63b84be0a7fd999fb35/ui/ozone/platform/wayland/BUILD.gn
[modify] https://crrev.com/f45744195db9945e195ef63b84be0a7fd999fb35/ui/ozone/platform/wayland/ozone_platform_wayland.cc

Comment 146 by bugdroid, Yesterday (40 hours ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ea879dcf2a3b22c83794b5d8de25feeb0cd4945

commit 8ea879dcf2a3b22c83794b5d8de25feeb0cd4945
Author: Nick Diego Yamane <nickdiego@igalia.com>
Date: Wed Feb 20 22:38:29 2019

ozone: Fix ScreenOzone::GetWindowAtScreenPoint

Screen::GetWindowAtScreenPoint function is supposed to
return the NativeWindow under a given screen point.
The current ScreenOzone implementation, unlike ScreenAsh,
returns the root window instead of the exact
window corresponding the that point inside the window
hierarchy.

This CL fixes that insconsistency, applying a solution similar
to the one used in ScreenAsh: it relies on ScreenPositionClient
and aura::Window::GetEventHandlerForPoint to get the correct
window within window hierarchy under the specified point.

Bug: 578890
Change-Id: If3b078fb933006f323425bbcd05d9ccb504b8b61
Reviewed-on: https://chromium-review.googlesource.com/c/1477828
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Nick Diego Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#633920}
[modify] https://crrev.com/8ea879dcf2a3b22c83794b5d8de25feeb0cd4945/ui/aura/screen_ozone.cc

Comment 147 by msi...@igalia.com, Yesterday (24 hours ago)

Blockedon: 934253

Comment 148 by adun...@igalia.com, Today (6 hours ago)

Blockedon: 934686

Comment 149 by adun...@igalia.com, Today (5 hours ago)

Blockedon: 934711
Showing comments 50 - 149 of 149 Older

Sign in to add a comment