New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Buried. Ping if important.
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocked on:
issue 400674


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment
link

Issue 576705: Ship the Credential Management API.

Reported by mkwst@chromium.org, Jan 12 2016 Project Member

Issue description

Change description:
The API provides a programmatic interface to the browser's credential manager. In short, an origin can request a user's credentials to sign them in, or can ask the browser to save credentials on the user's behalf. Both of these requests are user-mediated.

Changes to API surface:
Adds `navigator.credential`, defined in https://w3c.github.io/webappsec-credential-management/

Support in other browsers:
Internet Explorer: ??
Firefox: Mixed.
Safari: ???
 

Comment 1 by mkwst@chromium.org, Jan 12 2016

Blockedon: chromium:400674

Comment 3 by bugdroid1@chromium.org, Feb 24 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062c94e083bb1a2ec9df0222cdbdff6b364cb466

commit 062c94e083bb1a2ec9df0222cdbdff6b364cb466
Author: mkwst <mkwst@chromium.org>
Date: Wed Feb 24 12:55:43 2016

Ship the Credential Management API by default

This patch enables the Credential Management API by default.

It also converts the existing CLI flag into a `base::Feature`, which will allow
us to hook it up to Finch as a kill-switch in case it asplodes the internets.
This feature flag can be removed after ~a release, once we're confident that
we're not breaking things.

Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0

BUG= 576705 
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1720403003

Cr-Commit-Position: refs/heads/master@{#377276}

[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/chrome/browser/about_flags.cc
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/content/child/runtime_features.cc
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/content/public/common/content_features.cc
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/content/public/common/content_features.h
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/content/public/common/content_switches.cc
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/content/public/common/content_switches.h
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 4 by mkwst@chromium.org, Mar 2 2016

Labels: -M-50 M-51

Comment 5 by mkwst@chromium.org, Mar 2 2016

Labels: -OS-All OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 6 by bugdroid1@chromium.org, Apr 8 2016

Project Member
Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948

commit f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948
Author: Mike West <mkwst@google.com>
Date: Fri Apr 08 07:16:39 2016

Revert "Ship the Credential Management API by default" from M50.

This reverts commit 062c94e083bb1a2ec9df0222cdbdff6b364cb466, which should
have landed only after the M50 branch point.

> Ship the Credential Management API by default
>
> This patch enables the Credential Management API by default.
>
> It also converts the existing CLI flag into a `base::Feature`, which will allow
> us to hook it up to Finch as a kill-switch in case it asplodes the internets.
> This feature flag can be removed after ~a release, once we're confident that
> we're not breaking things.
>
> Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0
>
> BUG= 576705 
> R=vabr@chromium.org
>
> Committed: https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466
> Cr-Commit-Position: refs/heads/master@{#377276}

BUG= 601130 
TBR=vabr@chromium.org

Review URL: https://codereview.chromium.org/1870943002 .

Cr-Commit-Position: refs/branch-heads/2661@{#524}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/chrome/browser/about_flags.cc
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/content/child/runtime_features.cc
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/content/public/common/content_features.cc
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/content/public/common/content_features.h
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/content/public/common/content_switches.cc
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/content/public/common/content_switches.h
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 7 by rbyers@chromium.org, Nov 18 2016

Components: Blink>SecurityFeature

Comment 8 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge

Comment 9 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 10 by jochen@chromium.org, Nov 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment