New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 575 users

Comments by non-members will not trigger notification emails to users who starred this issue.

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 395297
issue 520947
issue 537393
issue 539339
issue 550554
issue 552556
issue 563760
issue 571680
issue 574221

Blocking:
issue 55218
issue 61140
issue 62833
issue 468747
issue 501568

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 575: Smooth scrolling

Reported by bharat2...@gmail.com, Sep 3 2008

Issue description

Product Version      : 0.2.149.27 (1583)
URLs (if applicable) : http://en.wikipedia.org/wiki/Main_Page
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 3: OK
    Firefox 3: OK
         IE 7: OK

What steps will reproduce the problem?
1. scroll using the scroller
2.
3.

What is the expected result?
should scroll smoothly

What happens instead?
scrolls in steps.not smooth

Please provide any additional information below. Attach a screenshot if 
possible.
 
Showing comments 76 - 175 of 175 Older

Comment 76 by brycesto...@gmail.com, Mar 24 2010

pkasting@ - Are you finished with this bug on the webkit side?

Comment 77 by lauren7...@gmail.com, Mar 24 2010

Sorry to disagree with the people pointing out that the smooth scroll extension fixes things.

I've had the opportunity to use 2 different extensions on both Mac and Windows that advertise 
"smooth scroll", but they only work as smooth as the page contents allows.

On pages longer/heavier pages, with youtube videos (etc) the scroll is usually very jerky.

I believe the smooth scroll should be implemented on a low level on the browser, and not be 
dependent on the performance of the extensions engine.

Extensions tested: "SmoothScroll" and "Chromium Wheel Smooth Scroller"

Comment 78 by gordonby...@gmail.com, Mar 24 2010

The availability of extensions is definitely not a solution. Lack of this ability
makes Chrome inconsistent with all other browsers, as well as their host operating
systems. It needs to be implemented directly. That said, LAUREN7INO, the performance
of existing smooth scrolling extensions seem to be more or less totally dependent on
the browser itself. For instance, until the latest dev build, scrolling on the Mac
version of Chrome was very jerky and slow, regardless of which smooth scrolling
extension was in use. With the latest dev build, it is much improved, without any
changes to the extensions.

Comment 79 by pkasting@chromium.org, Mar 24 2010

This bug has nothing to do with smooth scrolling extensions.  Please stop wasting 
everyone's time by debating about how well extensions work and whether they're 
substitutes for doing things in the browser.  This bug is about implementing smooth 
scrolling in Chrome itself.

@76: The upstream bug is pretty clear about what the state of the world is.

Comment 80 Deleted

Comment 81 by pkasting@chromium.org, Mar 25 2010

This is a bug tracker, and as such its primary purpose is for us to coordinate 
engineering effort.  We have forums (e.g. http://www.google.com/support/chrome/?hl=en-
US ) and mailing lists (e.g. chromium-discuss@chromium.org) for people to discuss 
things and have a sense of community to their heart's content.  In here, however, 
messages go directly to engineers' inboxes, and that means every off-topic message 
directly wastes the time of the people who are trying to make Chrome better.  It is 
therefore extremely important to observe good bug tracker etiquette, and not doing so 
will earn first blunt comments, and then locked-down, read-only bugs if needed.

Comment 82 by phistuck@chromium.org, Apr 2 2010

 Issue 23201  has been merged into this issue.

Comment 83 by fezzesar...@gmail.com, Jun 29 2010

They must like getting the emails, else-wise they would have fixed this two year old bug, not to mention the fact that all the other browsers do smooth scrolling.

Comment 84 by rcdai...@gmail.com, Jun 29 2010

I use the smooth scroll extension because it isn't a built in feature, and on a Core 2 Duo machine with 2GB of RAM, it runs like complete crap. The performance of this feature in an extension is sub-par compared to what it would be as a built-in feature written in good ol C++.

Comment 85 by jackblac...@gmail.com, Jun 29 2010

'Chromium Wheel Smooth Scroller' is a good extension - works with track pads too, but needs tweaking in the options to make it to your preference. On most pages it works well, but looks a little odd on you tube when scrolling. The extension has an iPhone scroll effect, at the end or top of the page it bounces. - The implementation of the extension is good, although by no means perfect - would like to see an Chrome's default scrolling use this method, it's different to other browsers.

Comment 86 by robinbri...@gmail.com, Jun 29 2010

Re: Comment 85 by JackBlack340,

I don't have extensions due to ram security etc. but i tried your suggestion and it was the very good, it felt professional. Surely chrome guys could implement the code into chrome?

Maybe someone could setup a separate bug issue "Implement Chromium Wheel Smooth Scroller Extension into default chrome." for us to follow and be worked on?

Comment 87 by mayhem...@gmail.com, Jun 29 2010

I prefer using SmoothScroll, and that's maybe why Google don't built it in, to let users chose what they prefer.

Comment 88 by wra...@gmail.com, Jun 29 2010

> to let users chose what they prefer.
Just the opposite, Chromium developers are against user-customizable behavior.
And users can't choose anything non-standard for non-http tabs.

Comment 89 by graemeer...@gmail.com, Jun 29 2010

> Chromium developers are against user-customizable behavior

Yeah, that's why they spent so much time and effort implementing themes and extensions, so users couldn't customize their browser. I suspect the real reason they haven't implemented this is because, like comment 87 said, there's a lot of debate over which method is best. Also, some people just don't like smooth scrolling. It's one of those nice-to-have-but-not-essential things that is best left to extensions.

Comment 90 by Deleted ...@, Jun 29 2010

>I prefer using SmoothScroll

not cool bro

Comment 91 by pkasting@chromium.org, Jun 29 2010

Labels: Restrict-AddIssueComment-Commit
There isn't debate over which method is best.  If anyone bothered to read the upstream bug about this you would see that the issue is that we've written a patch that adds smooth scrolling, but the WebKit reviewers are asking that we completely refactor scrolling in WebKit before landing it.  This is simply technically difficult.

Comment 92 by evan@chromium.org, Aug 6 2010

Status: ExternalDependency

Comment 93 by pkasting@chromium.org, Sep 8 2010

Status: Started
The upstream patch has landed.  Once that's merged to Chromium, Windows will have smooth scrolling.  The other platforms don't have it yet, though they could easily turn it on; I think it's prudent to test things for a bit first.

Comment 94 by pkasting@chromium.org, Sep 23 2010

Labels: -Mstone-X Mstone-8
We had to disable this shortly after landing due to several bugs.

I'm hoping to get this in M8, but that's now at risk.

Comment 95 by pkasting@chromium.org, Sep 23 2010

Labels: -Area-UI -WebKitBug-32356 Area-WebKit

Comment 96 by pkasting@chromium.org, Oct 8 2010

Labels: -Mstone-8 Mstone-9

Comment 97 by lafo...@chromium.org, Nov 30 2010

Labels: -Mstone-9 Mstone-10 MovedFrom-9
Moving all mstone:9 bugs that are not ReleaseBlockers to mstone:10

Comment 98 by temp01...@gmail.com, Dec 17 2010

 Issue 67307  has been merged into this issue.

Comment 99 by pkasting@chromium.org, Jan 11 2011

Labels: -Mstone-10 -MovedFrom-9 Mstone-11

Comment 100 by kareng@google.com, Mar 9 2011

Labels: -Mstone-11 MovedFrom-11 Mstone-12
rolling non releaseblocker mstone 11 bugs to mstone 12.

Comment 101 by pkasting@chromium.org, Apr 12 2011

Blocking: 55261

Comment 102 by pkasting@chromium.org, Apr 12 2011

Blocking: 55218

Comment 103 by pkasting@chromium.org, Apr 12 2011

Blocking: 62833

Comment 104 by pkasting@chromium.org, Apr 12 2011

Labels: -Mstone-12 Mstone-14

Comment 105 by pkasting@chromium.org, May 10 2011

Owner: scottbye...@gtempaccount.com
Status: Assigned
Scott's going to look into this.

The primary blocker to enabling the v1 experience is adding a timer heuristic that will auto-disable smooth scrolling when the previous scroll (smooth or not) took "too long", and re-enable it when the previous scroll was fast.  There is not currently a separate bug on this.

Comment 106 by bugdroid1@chromium.org, Jun 23 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=90136

------------------------------------------------------------------------
r90136 | scottbyer@chromium.org | Wed Jun 22 17:05:39 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.h?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=90136&r2=90135&pathrev=90136
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=90136&r2=90135&pathrev=90136

Linux/CrOS smooth scrolling support - behind a flag.

Add runtime flag to control smooth scrolling. Add compile time flag handling for a GYP_DEFINE (enable_smooth_scrolling=1).

BUG= 575 ,61140
TEST=compile still works without the flag. Compiling with the flag works once the WebKit change is landed, and then the flag appears in the about:flags page, and actually turns on that WebKit implementation.


Review URL: http://codereview.chromium.org/7034052
------------------------------------------------------------------------

Comment 107 by k...@google.com, Jul 28 2011

Labels: -Mstone-14 Mstone-15 MovedFrom-14
Punting out non-critical bugs.  Please move back to 14 if you believe this was done in error.

Comment 108 by scottbyer@chromium.org, Aug 30 2011

Labels: -Mstone-15 Mstone-16
Will be on behind a flag for Linux and Windows (Mac is a separate implementation that is already on). On by default for ChromeOS. Moving coming out from behind the flag out to M16.

Comment 109 by bugdroid1@chromium.org, Sep 1 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=99186

------------------------------------------------------------------------
r99186 | thakis@chromium.org | Thu Sep 01 08:23:56 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ppapi_uitest.cc?r1=99186&r2=99185&pathrev=99186
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_browsertest_mac.mm?r1=99186&r2=99185&pathrev=99186
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=99186&r2=99185&pathrev=99186
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=99186&r2=99185&pathrev=99186
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=99186&r2=99185&pathrev=99186
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_switches.h?r1=99186&r2=99185&pathrev=99186
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/test/mock_time_provider.h?r1=99186&r2=99185&pathrev=99186
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_switches.cc?r1=99186&r2=99185&pathrev=99186

Enable smooth scrolling on mac

This confuses a few unit tests, so add some machinery to disable the feature in tests and do so in the tests that need it.

BUG=61140, 575 
TEST=Go to en.wikipedia.org, hit space. Scroll should be animated.

Review URL: http://codereview.chromium.org/7693019
------------------------------------------------------------------------

Comment 110 by laforge@google.com, Oct 24 2011

Labels: -Mstone-16 MovedFrom-16 Mstone-17

Comment 111 by k...@google.com, Dec 19 2011

Labels: -Mstone-17 Mstone-18 MovedFrom-17
Moving bugs marked as Assigned but not blockers from M17 to M18.  Please move back if you think this is a blocker, and add the ReleaseBlock-Stable label.  If you're able.

Comment 112 by scottbyer@chromium.org, Jan 19 2012

Labels: -Mstone-18 Mstone-20 MovedFrom-18
While some progress has been made, there are a number of issues left that need to be fixed before this can come out from behind the flag on Windows and Linux. Everything is under way, the issues are deeper than they first appeared.

Comment 113 by k...@google.com, Apr 27 2012

Labels: -Mstone-20 MovedFrom-20
These bugs have hit their move limit.  Please re-target as appropriate.

Comment 114 by laforge@google.com, Aug 10 2012

Cc: jam...@chromium.org
 Issue 128324  has been merged into this issue.

Comment 116 by laforge@google.com, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Comment 117 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: -Cr-Content Cr-Blink

Comment 118 by briander...@chromium.org, Nov 22 2013

Cc: jdduke@chromium.org briander...@chromium.org
Scott, can you provide a summary of the blocking issues here?

We may want to consider moving the implementation to the Impl thread and using the same mechanisms that fling scroll animations use. It'll be immune to main thread jank and might be easier to implement at this point if fling scroll animations have already solved the remaining issues smooth scrolling needs to solve. It'll also make future development easier if we improvements to one can easily be translated into improvements in the other.

Comment 119 by briander...@chromium.org, Nov 26 2013

I noticed the ScrollAnimatorNone class is already enabled by default on ChromeOS. ScrollANimatorNone is the same class used for Windows and Linux. Is there anything specific about Windows and Linux that prevents us from enabling it by default everywhere?

Comment 120 by scottbyer@chromium.org, Nov 27 2013

ChromeOS is a more controlled environment, some of the things that let smooth scrolling be smooth were enabled there by default along with smooth scrolling, mostly having to do with the compositor. I think we just need to see where things are at.

Comment 121 by briander...@chromium.org, Nov 27 2013

Cc: ajuma@chromium.org
Windows has a threaded compositor now, just like ChromeOS. Linux doesn't have the threaded compositor by default yet, but should soon once LinuxAura arrives.

ChromeOS doesn't have impl-side-painting enabled, so that shouldn't be blocking factor.

+ajuma, who is currently looking into animating scrollTo.

Comment 122 by weiliangc@chromium.org, Mar 25 2014

Cc: danakj@chromium.org davemoore@chromium.org vollick@chromium.org wjmaclean@chromium.org
Is there any update for this? Is the goal to eventually turn it on for all Aura platforms?

Also currently scrollAnimation is only enabled for FrameView (main frame scrollbars). Is that internal or something we want to fix moving forward?

Come across this when working on  Issue 307578 , adding scrollbar thinning/thickening animation for mouse over/away. Since that logic also has to live behind a flag on Aura, I would prefer if there is a way to separate out instead of putting both into ScrollAnimatorNone.

Comment 124 by bugdroid1@chromium.org, Jul 10 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/749cbc62498edd705dba6138f924a82c75274c88

commit 749cbc62498edd705dba6138f924a82c75274c88
Author: skobes@chromium.org <skobes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jul 10 01:06:35 2014

Impl thread smooth scrolling.

This is a first pass at smooth scrolling on the compositor thread.  It adds LayerTreeHostImpl::ScrollAnimated, which kicks off a scroll offset animation through the layer animation controller.

When the --enable-smooth-scrolling flag is present, InputHandlerProxy will call ScrollAnimated for composited wheel scrolls.

Once this is in the next steps are:

(1) Update the animation curve to aim at a new target when a wheel event comes in while a scroll animation is in progress.  (For now we just drop the event.)

(2) Unify the behavior with WebCore::ScrollAnimatorNone.  We should be able to share a lot of logic since cc::ScrollOffsetAnimationCurve is already exposed to Blink through compositor bindings (for  http://crbug.com/243871 ).

BUG= 575 

Review URL: https://codereview.chromium.org/361143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282205 0039d316-1c4b-4281-b951-d872f2087c98

Comment 125 by bugdroid1@chromium.org, Jul 10 2014

Project Member
------------------------------------------------------------------
r282205 | skobes@chromium.org | 2014-07-10T01:06:35.353897Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/input/input_handler_proxy_unittest.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/input/input_handler_proxy.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/input/input_handler_proxy.h?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/animation_delegate.h?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_host_impl_unittest.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_host_impl.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/layer_animation_controller_unittest.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/layer_impl.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/layer_animation_controller.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/input/input_handler.h?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_host_impl.h?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/layers/layer_impl.h?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_impl.cc?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/layer_animation_controller.h?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_impl.h?r1=282205&r2=282204&pathrev=282205
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=282205&r2=282204&pathrev=282205

Impl thread smooth scrolling.

This is a first pass at smooth scrolling on the compositor thread.  It adds LayerTreeHostImpl::ScrollAnimated, which kicks off a scroll offset animation through the layer animation controller.

When the --enable-smooth-scrolling flag is present, InputHandlerProxy will call ScrollAnimated for composited wheel scrolls.

Once this is in the next steps are:

(1) Update the animation curve to aim at a new target when a wheel event comes in while a scroll animation is in progress.  (For now we just drop the event.)

(2) Unify the behavior with WebCore::ScrollAnimatorNone.  We should be able to share a lot of logic since cc::ScrollOffsetAnimationCurve is already exposed to Blink through compositor bindings (for  http://crbug.com/243871 ).

BUG= 575 

Review URL: https://codereview.chromium.org/361143002
-----------------------------------------------------------------

Comment 126 by bugdroid1@chromium.org, Jul 18 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a7d5bec832fd997b6b2eef3ec9c0906b74ef16d

commit 7a7d5bec832fd997b6b2eef3ec9c0906b74ef16d
Author: skobes@chromium.org <skobes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jul 18 22:37:26 2014

Scroll offset animation curve retargeting.

Adds support for updating the target of an in-progress input-triggered impl-side scroll offset animation, keeping the velocity function continuous.

BUG= 575 

Review URL: https://codereview.chromium.org/393713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284228 0039d316-1c4b-4281-b951-d872f2087c98

Comment 127 by bugdroid1@chromium.org, Jul 18 2014

Project Member
------------------------------------------------------------------
r284228 | skobes@chromium.org | 2014-07-18T22:37:26.129864Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/scroll_offset_animation_curve.h?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_host_impl_unittest.cc?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/timing_function.cc?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/trees/layer_tree_host_impl.cc?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/geometry/cubic_bezier_unittest.cc?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/geometry/cubic_bezier.cc?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/timing_function.h?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/geometry/cubic_bezier.h?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/scroll_offset_animation_curve_unittest.cc?r1=284228&r2=284227&pathrev=284228
   M http://src.chromium.org/viewvc/chrome/trunk/src/cc/animation/scroll_offset_animation_curve.cc?r1=284228&r2=284227&pathrev=284228

Scroll offset animation curve retargeting.

Adds support for updating the target of an in-progress input-triggered impl-side scroll offset animation, keeping the velocity function continuous.

BUG= 575 

Review URL: https://codereview.chromium.org/393713002
-----------------------------------------------------------------

Comment 128 by skobes@chromium.org, Jul 18 2014

Owner: skobes@chromium.org
Status: Started

Comment 129 by skobes@chromium.org, Jul 18 2014

Blockedon: chromium:395297

Comment 131 by nduca@chromium.org, Feb 2 2015

Labels: Hotlist-Input-Dev Cr-Internals-Compositing

Comment 133 by bugdroid1@chromium.org, Feb 11 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=190002

------------------------------------------------------------------
r190002 | skobes@chromium.org | 2015-02-11T22:22:23.836895Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/overflow-scroll-animates-expected.txt?r1=190002&r2=190001&pathrev=190002
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayerScrollableArea.h?r1=190002&r2=190001&pathrev=190002
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=190002&r2=190001&pathrev=190002
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/overflow-scroll-animates.html?r1=190002&r2=190001&pathrev=190002
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/precise-delta-no-animate-expected.txt?r1=190002&r2=190001&pathrev=190002
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayerScrollableArea.cpp?r1=190002&r2=190001&pathrev=190002
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPagePopupImpl.cpp?r1=190002&r2=190001&pathrev=190002
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html?r1=190002&r2=190001&pathrev=190002

Respect the smooth scrolling setting in LayerScrollableArea.

This was previously done in http://crrev.com/214953004 but reverted due to
 http://crbug.com/383946 .  With http://crrev.com/831393003 it should be safe to
re-land.  (This is also needed for  http://crbug.com/417782  because everything
will go through the LayerScrollableArea path.)

BUG= 575 , 417782 

Review URL: https://codereview.chromium.org/882813005
-----------------------------------------------------------------

Comment 134 by bugdroid1@chromium.org, Feb 19 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=190451

------------------------------------------------------------------
r190451 | ccameron@chromium.org | 2015-02-19T09:35:14.793580Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=190451&r2=190450&pathrev=190451
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/overflow-scroll-animates.html?r1=190451&r2=190450&pathrev=190451
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/precise-delta-no-animate-expected.txt?r1=190451&r2=190450&pathrev=190451
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayerScrollableArea.cpp?r1=190451&r2=190450&pathrev=190451
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPagePopupImpl.cpp?r1=190451&r2=190450&pathrev=190451
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html?r1=190451&r2=190450&pathrev=190451
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/overflow-scroll-animates-expected.txt?r1=190451&r2=190450&pathrev=190451
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayerScrollableArea.h?r1=190451&r2=190450&pathrev=190451

Revert of Respect the smooth scrolling setting in LayerScrollableArea. (patchset #4 id:120001 of https://codereview.chromium.org/882813005/)

Reason for revert:
Regresses scrolling on Mac:
 http://crbug.com/459739 

Original issue's description:
> Respect the smooth scrolling setting in LayerScrollableArea.
> 
> This was previously done in http://crrev.com/214953004 but reverted due to
>  http://crbug.com/383946 .  With http://crrev.com/831393003 it should be safe to
> re-land.  (This is also needed for  http://crbug.com/417782  because everything
> will go through the LayerScrollableArea path.)
> 
> BUG= 575 , 417782 
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190002

TBR=ajuma@chromium.org,japhet@chromium.org,skobes@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 575 , 417782 

Review URL: https://codereview.chromium.org/933823004
-----------------------------------------------------------------

Comment 135 by bugdroid1@chromium.org, Feb 20 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=190597

------------------------------------------------------------------
r190597 | skobes@chromium.org | 2015-02-20T22:35:38.911343Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/mac/ScrollAnimatorMac.mm?r1=190597&r2=190596&pathrev=190597

Suppress smooth scroll for trackpad scrolls on Mac.

Smooth scrolling doesn't make sense when the event is marked as having precise
scrolling deltas.  This change tells ScrollAnimatorMac to skip smooth scrolls
in this case even if smooth scrolling is otherwise enabled.  There is already
similar code in ScrollAnimatorNone for other platforms.

ScrollAnimatorMac now smooth-scrolls only for line/page/document granularity
(e.g., keyboard-triggered scrolls).  It was disabled for wheel scrolls in
http://trac.webkit.org/changeset/73683.

BUG= 575 , 459739 

Review URL: https://codereview.chromium.org/941843002
-----------------------------------------------------------------

Comment 136 by bugdroid1@chromium.org, Feb 23 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=190675

------------------------------------------------------------------
r190675 | skobes@chromium.org | 2015-02-23T18:37:13.067213Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html?r1=190675&r2=190674&pathrev=190675
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/overflow-scroll-animates-expected.txt?r1=190675&r2=190674&pathrev=190675
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayerScrollableArea.h?r1=190675&r2=190674&pathrev=190675
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=190675&r2=190674&pathrev=190675
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/overflow-scroll-animates.html?r1=190675&r2=190674&pathrev=190675
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/precise-delta-no-animate-expected.txt?r1=190675&r2=190674&pathrev=190675
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayerScrollableArea.cpp?r1=190675&r2=190674&pathrev=190675
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPagePopupImpl.cpp?r1=190675&r2=190674&pathrev=190675

Reland: Respect the smooth scrolling setting in LayerScrollableArea.

This relands https://blink.lc/blink/commit/?id=5668429, which was reverted in
https://blink.lc/blink/commit/?id=a1303a8.

The Mac trackpad regression is addressed by
https://blink.lc/blink/commit/?id=021397d.

BUG= 575 , 417782 

Review URL: https://codereview.chromium.org/882813005
-----------------------------------------------------------------

Comment 138 by tdres...@chromium.org, Mar 19 2015

Blocking: chromium:468747

Comment 139 by tdres...@chromium.org, Mar 19 2015

Blocking: chromium:468754

Comment 140 by bugdroid1@chromium.org, Mar 20 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=192111

------------------------------------------------------------------
r192111 | skobes@chromium.org | 2015-03-18T18:20:13.063587Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=192111&r2=192110&pathrev=192111
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/scroll-behavior/overflow-scroll-animates.html?r1=192111&r2=192110&pathrev=192111

Fix timeout of overflow-scroll-animates.html in virtual/threaded.

When threaded compositing is enabled, the effect of adding or removing a
scroll listener does not happen until the next frame.  To compensate for this,
the test now waits before triggering input with eventSender.

BUG= 458420 , 575 

Review URL: https://codereview.chromium.org/1006423007
-----------------------------------------------------------------

Comment 141 by skobes@chromium.org, May 4 2015

Cc: skobes@chromium.org
 Issue 476309  has been merged into this issue.

Comment 142 by bokan@chromium.org, May 27 2015

Cc: bokan@chromium.org

Comment 143 by matthewyuan@chromium.org, Aug 10 2015

Labels: Hotlist-GPU-Fixit

Comment 144 by matthewyuan@chromium.org, Aug 10 2015

Labels: -Hotlist-GPU-Fixit

Comment 145 by skobes@chromium.org, Aug 18 2015

Blockedon: chromium:520947

Comment 146 by rbyers@chromium.org, Aug 20 2015

Blocking: chromium:501568

Comment 147 by skobes@chromium.org, Oct 1 2015

Blockedon: chromium:537393

Comment 148 by skobes@chromium.org, Oct 15 2015

Blockedon: chromium:539339

Comment 149 by skobes@chromium.org, Oct 20 2015

Blockedon: chromium:545234

Comment 150 by bugdroid1@chromium.org, Oct 27 2015

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46aad144b73e893f8b08a18e689ff444c301a39f

commit 46aad144b73e893f8b08a18e689ff444c301a39f
Author: skobes <skobes@chromium.org>
Date: Tue Oct 27 15:05:50 2015

Make compositor input-driven smooth scrolling smoother and snappier.

The animation time is now constant instead of proportional to the delta, which
felt sluggish.

The velocity matching in UpdateTarget now handles direction changes correctly,
and scales the first control point on the y axis instead of rotating it, which
gives a smoother velocity transition.

BUG= 575 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1420943004

Cr-Commit-Position: refs/heads/master@{#356291}

[modify] http://crrev.com/46aad144b73e893f8b08a18e689ff444c301a39f/cc/animation/animation_host.cc
[modify] http://crrev.com/46aad144b73e893f8b08a18e689ff444c301a39f/cc/animation/scroll_offset_animation_curve.cc
[modify] http://crrev.com/46aad144b73e893f8b08a18e689ff444c301a39f/cc/animation/scroll_offset_animation_curve.h
[modify] http://crrev.com/46aad144b73e893f8b08a18e689ff444c301a39f/cc/animation/scroll_offset_animation_curve_unittest.cc
[modify] http://crrev.com/46aad144b73e893f8b08a18e689ff444c301a39f/cc/trees/layer_tree_host_impl.cc

Comment 151 by ymalik@chromium.org, Nov 2 2015

Blockedon: chromium:550554

Comment 152 by dtapu...@chromium.org, Nov 5 2015

Blocking: -chromium:55261

Comment 153 by skobes@chromium.org, Nov 6 2015

Blockedon: chromium:552556

Comment 154 by bugdroid1@chromium.org, Nov 9 2015

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/529873b0d9581a1981717383d6066a1a9dbfa52f

commit 529873b0d9581a1981717383d6066a1a9dbfa52f
Author: ymalik <ymalik@chromium.org>
Date: Mon Nov 09 08:41:19 2015

Update layout tests to work when smooth scrolling is enabled by default

This CL updates expectations for tests that expect an instant scroll such
that they pass when smooth scroll is enabled.

Note:
- Some of the tests are re-written, but most of them apply the following change:
  shouldBe('scrollLeft', 'expectedScrollLeft)
  shouldBe('scrollTop', 'expectedScrollTop') -->
  shouldBecomeEqual('scrollLeft == expectedScrollLeft && scrollTop ==
    expectedScrollTop', 'true')
'shouldBecomeEqual' waits asynchronously until the condition is true.
- Some of the tests just expect a certain scroll offset and are not really
testing scroll-behavior. For those tests, the scrollAnimatorEnabled setting
is turned off by default.
  internals.settings.setScrollAnimatorEnabled(false)

BUG= 575 

Review URL: https://codereview.chromium.org/1413493005

Cr-Commit-Position: refs/heads/master@{#358572}

[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/editing/input/reveal-contenteditable-on-input-vertically.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/editing/input/reveal-edit-on-input-vertically.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/dom/vertical-scrollbar-in-rtl-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/dom/vertical-scrollbar-in-rtl.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/node-event-anchor-lock.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-in-scrolling-div-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-in-scrolling-div.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-div-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-div.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-page.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-basic-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-scrolling-div.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/repaint/overflow-auto-in-overflow-auto-scrolled.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-behind-scrollbar-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-behind-scrollbar.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/editor-command-scroll-page-scale.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/fixed-position-behind-scrollbar-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/fixed-position-behind-scrollbar.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/hover-during-scroll-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/hover-during-scroll.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/listbox-wheel-event.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/overflow-scrollability-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/overflow-scrollability.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-prevent-default-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-prevent-default.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/http/tests/navigation/same-document-scroll-position-restore-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/http/tests/navigation/same-document-scroll-position-restore.html
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/platform/win/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/platform/win/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt
[modify] http://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f/third_party/WebKit/LayoutTests/resources/js-test.js

Comment 155 by rbyers@chromium.org, Nov 17 2015

Blockedon: chromium:552037

Comment 156 by skobes@chromium.org, Dec 1 2015

Blockedon: chromium:563759

Comment 157 by skobes@chromium.org, Dec 1 2015

Blockedon: chromium:563760

Comment 158 by rbyers@chromium.org, Dec 4 2015

Labels: -MovedFrom-11 -MovedFrom-14 -MovedFrom-16 -MovedFrom-17 -MovedFrom-18 -MovedFrom-20 M-49
We hope to have this in Chrome 49 (though may of course take longer) - https://www.chromium.org/developers/design-documents/input-dev/input-objectives

Comment 159 by agoode@chromium.org, Dec 16 2015

On 49.0.2587.3 I think I see smooth scrolling. A few notes:

1. It feels sluggish with a mouse wheel. The scrolling is nice but maybe the acceleration curve is too low.

2. Feedly scrolls in a very jerky way. When I spin the mouse wheel, nothing happens for a moment, then the page scrolls quickly, then scrolls one more time. It is very hard to navigate with this behavior.

Comment 160 by agoode@chromium.org, Dec 16 2015

Feedly seems to be working smoothly after a reload of the page. But I did notice that smooth scrolling acts strangely if an infinite scroll is being extended during the scroll.

Comment 161 by skobes@chromium.org, Dec 16 2015

@160: do you mind filing a separate bug with details?

Comment 162 by agoode@chromium.org, Dec 17 2015

Blockedon: chromium:570549

Comment 163 by agoode@chromium.org, Dec 17 2015

I cannot reproduce the issue I had before but did file a bug for strange behavior I am having with an external mouse wheel.

Comment 164 by agoode@chromium.org, Dec 19 2015

Blockedon: chromium:571238

Comment 165 by ymalik@chromium.org, Dec 22 2015

Blockedon: chromium:571680

Comment 166 by bugdroid1@chromium.org, Dec 30 2015

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a78fdc918ae09ee12096d99dc75a42b949f6b5de

commit a78fdc918ae09ee12096d99dc75a42b949f6b5de
Author: skobes <skobes@chromium.org>
Date: Wed Dec 30 23:03:14 2015

Tweak the math in ScrollOffsetAnimationCurve::UpdateTarget.

The existing division-by-0 guard was not correct, since MaximumDimension can
return negative values.  This led to occasional wild jumps when scrolling up and
down quickly (because new_velocity had the wrong sign).

This patch addresses the sign issue and improves handling of cases where we have
a large current velocity and a small delta to the new target.

BUG= 575 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1553603003

Cr-Commit-Position: refs/heads/master@{#367200}

[modify] http://crrev.com/a78fdc918ae09ee12096d99dc75a42b949f6b5de/cc/animation/scroll_offset_animation_curve.cc
[modify] http://crrev.com/a78fdc918ae09ee12096d99dc75a42b949f6b5de/cc/animation/scroll_offset_animation_curve_unittest.cc

Comment 167 by ymalik@chromium.org, Jan 4 2016

Cc: ymalik@chromium.org

Comment 168 by skobes@chromium.org, Jan 4 2016

Labels: Hotlist-SmoothScroll

Comment 169 by skobes@chromium.org, Jan 4 2016

Comment 170 by skobes@chromium.org, Jan 4 2016

Blockedon: chromium:574221

Comment 171 by ymalik@chromium.org, Jan 4 2016

Blockedon: -chromium:570549

Comment 172 by skobes@chromium.org, Jan 5 2016

Blockedon: -chromium:552037

Comment 173 by skobes@chromium.org, Jan 5 2016

Blockedon: -chromium:571238

Comment 175 by skobes@chromium.org, Mar 16 2018

Blocking: -468754
Showing comments 76 - 175 of 175 Older

Sign in to add a comment