New issue
Advanced search Search tips

Issue 573494 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

acc name not produced for labelable elements that have multiple associated labels

Project Member Reported by faulkner...@gmail.com, Dec 31 2015

Issue description

Version: 47
OS: windows 10

What steps will reproduce the problem?
1.go to http://thepaciellogroup.github.io/AT-browser-tests/test-files/label2.html
2. check the accessible name for the text input using an accessibility object inspection tool or chrome://accessibility


What is the expected output? 

accessible name: "name"

What do you see instead?

"name First name only"

http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#input-type-text-input-type-password-input-type-search-input-type-tel-input-type-url-and-textarea-element

http://www.w3.org/TR/html5/forms.html#the-label-element


 
NOTE: got the expected and what I see around wrong way, here is right way:

What is the expected output? 

accessible name: "name First name only" 

What do you see instead?

acc name: "name"
Owner: nek...@chromium.org
Status: Available (was: Untriaged)
Cc: -dmazz...@chromium.org
Owner: dmazz...@chromium.org
Owner: ----
Interesting. I forgot there can be more than one label for a form control.

It looks like we could switch to using LabelableElement::labels() and get rid of getElementByLabelForAttribute entirely.

Status: Started (was: Available)
https://codereview.chromium.org/1939303002
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/054bdb4ca5858d7b65188f961a52b8b04e94078d

commit 054bdb4ca5858d7b65188f961a52b8b04e94078d
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Jun 06 11:38:02 2016

Enable accessible name of a control to include multiple <label> elements.

The spec allows a form control element to have multiple <label> elements,
but we only supported one in accessibility code. Fix it by switching to
using the LabelableElement interface rather than some redundant code that
kept track of label elements in TreeScope, which allows us to get rid of
that now-unused code.

BUG= 573494 

Review-Url: https://codereview.chromium.org/1939303002
Cr-Commit-Position: refs/heads/master@{#398005}

[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/LayoutTests/accessibility/name-calc-inputs.html
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-expected.txt
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input.html
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/core/dom/DocumentOrderedMap.h
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/core/dom/LiveNodeList.h
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/core/dom/TreeScope.h
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/core/html/HTMLLabelElement.h
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/054bdb4ca5858d7b65188f961a52b8b04e94078d/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Labels: NewComponent-Accessibility-Blink NewComponent-Accessibility
Components: Blink>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-blink -newcomponent-accessibility
Labels: triage-alice
Labels: -triage-alice
Status: Fixed (was: Started)

Sign in to add a comment