New issue
Advanced search Search tips
Starred by 16 users
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 595993



Sign in to add a comment
Unable to set User-Agent header
Reported by bennett.blodinger@gmail.com, Dec 23 2015 Back to list
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36

Steps to reproduce the problem:
1.  Send an XHR or fetch request with the User-Agent header set
2.  XHR continues with an error while fetch continues but does not warn

What is the expected behavior?
User-Agent should be set

What went wrong?
The User-Agent header is no longer on the list of forbidden headers since July 29th: https://fetch.spec.whatwg.org/#forbidden-header-name
Commit: https://github.com/whatwg/fetch/commit/dab09b0c483c46324082df1e54b29ed4c9c02162
Both fetch and XMLHttpRequest use this list.

 Issue 37  on the whatwg spec goes into more detail: https://github.com/whatwg/fetch/issues/37

It works correctly in Firefox, fails in Safari.

Did this work before? N/A 

Chrome version: 47.0.2526.106  Channel: stable
OS Version: OS X 10.11.2
Flash Version: Shockwave Flash 20.0 r0
 
Screen Shot 2015-12-22 at 20.11.52.png
324 KB View Download
Comment 1 by tkent@chromium.org, Dec 28 2015
Labels: -Cr-Blink Cr-Blink-Network-XHR
Labels: -OS-Mac OS-All Cr-Blink-Network-FetchAPI
Status: Untriaged
Status: Available
Blockedon: 595993
Status: Started
This is blocked on bug 595993. If we remove User-Agent from forbidden headers, the guard of Headers stops blocking it and as a result ServiceWorker proxied requests would start issuing preflights due to the spec violation discussed in bug 595993.
Project Member Comment 5 by bugdroid1@chromium.org, Oct 20 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ed034738fe6c86c262e5cb0466b79ca84ab65f

commit a4ed034738fe6c86c262e5cb0466b79ca84ab65f
Author: shimazu <shimazu@chromium.org>
Date: Thu Oct 20 04:43:34 2016

Import w3c tests for the service workers

This patch imports wpt tests @357b83b809e3cbc7a1805e7c3ca108a7980d782f. Many
failures are left as is, so we should file each bugs after this lands.

BUG= 602693 , 618616 ,624278,571722,617886
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug --enable-wptserve imported/wpt/service-workers

Review-Url: https://chromiumcodereview.appspot.com/2415873002
Cr-Commit-Position: refs/heads/master@{#426405}

[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/WPTServeExpectations
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activate-event-after-install-state-change.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activation-after-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activation.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/active.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/appcache-ordering-main.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/claim-not-using-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/claim-using-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/client-navigate.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/client-navigate.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get-cross-origin.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get-cross-origin.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-client-types.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-disconnect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-disconnect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-load.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-load.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-reload.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-reload.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-async-waituntil.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-waituntil.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-cors-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-cors-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-csp.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-csp.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-after-navigation-within-page.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-network-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-frame-resource.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-mixed-content-to-inscope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-mixed-content-to-outscope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-base-url.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-images.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-fallback.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-fallback.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-no-freshness-headers.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-redirect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-resources.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-resources.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-response-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-response-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-waits-for-activate.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistrations.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistrations.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/indexeddb.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/install-event-type.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/installing.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/interfaces.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-blobtype.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-blobtype.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-header.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-header.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/multiple-register.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/multiple-update.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigate-window.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigate-window.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigation-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/onactivate-script-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/performance-timeline.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/performance-timeline.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ready.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/referer.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/referer.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-closed-window.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-default-scope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-same-scope-different-script-url.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-wait-forever-in-install-worker.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-wait-forever-in-install-worker.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-end-to-end.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-events.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-iframe.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/rejections.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resource-timing.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resource-timing.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/404.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.install.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.is-appcached.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.is-appcached.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.manifest
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/blank.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/claim-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigated-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-other-origin.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-client-types-shared-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-shared-worker-interceptor.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-worker-interceptor.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-worker-script.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy.txt
Project Member Comment 6 by bugdroid1@chromium.org, Oct 24 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a97fb88d5ad4c437c60562d0083a87b898547a4

commit 6a97fb88d5ad4c437c60562d0083a87b898547a4
Author: shimazu <shimazu@chromium.org>
Date: Mon Oct 24 02:57:12 2016

Update expectations of imported/wpt/service-workers

As mentioned at  https://crbug.com/602693#c17  and https://crbug.com/657869,
'[ Skip ]' in TestExpectations cannot be overwritten by WPTTestExpectations.
This patch changes '[ Skip ]' to '[ Failure ]' by default in TestExpectations
in order to run the w3c tests on WPTServe bots.

BUG= 602693 , 453190 ,624278,617886,571722, 618616 
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug imported/wpt/service-workers
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests --enable-wptserve -f -t Debug imported/wpt/service-workers

Review-Url: https://codereview.chromium.org/2441963002
Cr-Commit-Position: refs/heads/master@{#427010}

[modify] https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4/third_party/WebKit/LayoutTests/WPTServeExpectations

 Issue 694279  has been merged into this issue.
Owner: tyoshino@chromium.org
I worked on 7m ago but it's left pending due to lack of time.
https://codereview.chromium.org/2254693002/

Needs to figure out better design.

Cc: mkwst@chromium.org
 Issue 749734  has been merged into this issue.
tyoshino@: FWIW, I'm fine with this change as long as it causes a preflight.
Sign in to add a comment