New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Please remove the "won't run without Google play services" pop up from chromium

Reported by kartikey...@gmail.com, Dec 12 2015

Issue description

Steps to reproduce the problem:
1. Just open chromium on a Google liberated android device
2. 
3. 

What is the expected behavior?
No recuuring play services pop up

What went wrong?
Continuously has to be swiped away, annoying

Did this work before? N/A 

Chrome version: 49.0.2588.0  Channel: canary
OS Version: 
Flash Version: 

Please?
 
Cc: klo...@chromium.org
Status: Available

Comment 2 by klo...@chromium.org, Dec 15 2015

Owner: k...@chromium.org
This is caused by chrome/android/java/src/org/chromium/chrome/browser/signin/AccountIdProvider.java doing the check for Play Services like this:

 63         UserRecoverableErrorHandler errorHandler = activity != null                                  
 64                 ? new UserRecoverableErrorHandler.ModalDialog(activity)
 65                 : new UserRecoverableErrorHandler.SystemNotification();
 66         return ExternalAuthUtils.getInstance().canUseGooglePlayServices(ctx, errorHandler);

Rather than using new UserRecoverableErrorHandler.Silent() like other code using Play Services.

Would it be acceptable to simply replace it? Spamming the notification doesn't actually tell the user which feature is unavailable so it's not a useful form of UX. It would make sense to show a dialog within Chromium when attempting to access an unavailable feature like signing in. Alternatively, the features that are unavailable could simply be hidden. It's up to you if you want to advertise that there are missing features they could have, but the notifications are just an annoyance and are incorrect since Chromium does work fine without Play Services now.

Comment 6 by k...@chromium.org, Jan 6 2016

Cc: k...@chromium.org
Labels: -Via-Wizard
Owner: k...@chromium.org
Status: Fixed
Should be fixed now.

Sign in to add a comment