New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 568261 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Feb 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 263308

Blocking:
issue 568218



Sign in to add a comment

Remove or un-deprecate KeyboardEvent.keyLocation

Project Member Reported by rbyers@chromium.org, Dec 9 2015

Issue description

KeyboardEvent.keyLocation was deprecated in  issue 263308 .  Usage counters are high, but we know they're unreliable because of the prevalence of event copying code.

We should either remove keyLocation entirely (to match the spec), or concede that it's required for compat and undeprecate (and perhaps specify) it.

I think we should probably just do an httparchive search and if we fail to find any top sites that really depend on this API, we should try removing it.

Anyone cc'd want to pick this up?


 
Blocking: chromium:568218
Cc: -ch.du...@samsung.com ch.dumez@chromium.org

Comment 3 by phil...@opera.com, Dec 11 2015

I've done a rather exhaustive analysis of hits in the 20150101 httparchive data, and based on that I'm pretty confident we could remove this. Amusingly enough, a lot of the hits were for people copying events but blacklisting this attribute simply to avoid the deprecation message.

I suggest that we remove this early after the next branch point and see how it goes.

Comment 4 by phil...@opera.com, Dec 14 2015

Owner: phil...@opera.com
Status: Assigned
Preparing an Intent to Remove now.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410

commit 263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410
Author: philipj <philipj@opera.com>
Date: Wed Feb 17 02:13:49 2016

Remove KeyboardEvent.prototype.keyLocation (alias of location)

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDMAwAJ

BUG= 568261 

Review URL: https://codereview.chromium.org/1700233002

Cr-Commit-Position: refs/heads/master@{#375759}

[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/Source/core/events/KeyboardEvent.idl
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/Source/core/events/KeyboardEventInit.idl
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] http://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410/third_party/WebKit/Source/core/testing/InternalDictionary.idl

Comment 7 by phil...@opera.com, Feb 17 2016

Status: Fixed

Sign in to add a comment