New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 568093 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Dinosaur game highscore save and sync

Reported by johan.kr...@gmail.com, Dec 9 2015

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.73 Safari/537.36

Steps to reproduce the problem:
1. Network gone
2. run the dinosaur
3. network gone again on another machine
4. run the dinosaur again and be pretty good

What is the expected behavior?
Can see the current highscore and have a goal in life.

What went wrong?
No saved/synced highscore available. Have to keep a log somewhere else...

Did this work before? No 

Chrome version: 47.0.2526.73  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 19.0 r0
 
Labels: Cr-Services-Sync
Status: Untriaged
As the issue of feature request marking it as Untriaged to get more inputs from dev team.

Thanks,

Comment 2 by mmenke@chromium.org, Dec 10 2015

Cc: edwardjung@chromium.org
Status: Assigned
This was a feature we had in mind for a update and I looked at the syncing of high scores across devices a while back but didn't get very far.

If I recall, due to some complexity around getting access to the signed in profile from the renderer process. Meanwhile I've had to work on stuff which was deemed higher priority ;) for Chrome. 

I'll put it in my queue to look at again when things a less hectic.




Comment 4 by zea@chromium.org, Dec 10 2015

We, the Sync team, support this effort.

Comment 5 by zea@chromium.org, Dec 10 2015

Cc: -edwardjung@chromium.org
Owner: edwardjung@chromium.org

Comment 6 by zea@chromium.org, Jan 17 2018

Status: WontFix (was: Assigned)
Maybe one day little dinosaur...but not today.
It's a sad day. :(

Cc: edwardjung@chromium.org
Labels: OS-Android OS-Chrome OS-iOS OS-Mac OS-Windows
Owner: eseckler@chromium.org
Status: Assigned (was: WontFix)
eseckler has started this! Thank you!
Prototype is out for review on https://chromium-review.googlesource.com/c/chromium/src/+/1347283. This works on all platforms except for iOS (sorry, but making this work with Webkit is out of scope).
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5c24e17ea29c7bc442b8fc6490d1be9504bb958

commit a5c24e17ea29c7bc442b8fc6490d1be9504bb958
Author: Eric Seckler <eseckler@chromium.org>
Date: Wed Nov 28 16:09:20 2018

network error: Save easter egg highscore to profile

Save the dino game highscore into a preference in the user's profile.
The highscore will persist across sessions and sync across devices.

Adds a mojo interface that allows setting the highscore preference from
the renderer. NetErrorPageController / NetErrorHelper expose new
functionality to provide the saved score to the error page and update
the saved score when a new highscore is reached.

Also ensures that the maximum high score is chosen on sync conflicts by
extending PrefModelAssociatorClient to allow the embedder to choose the
merging strategy for conflicting preference values.

TBR=sdefresne@chromium.org

Bug:  568093 
Change-Id: Ia6485cbbf03ea210cba11dd3bd5f8be2518997d7
Reviewed-on: https://chromium-review.googlesource.com/c/1347283
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611711}
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/browser/net/net_error_tab_helper.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/browser/net/net_error_tab_helper.h
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/browser/prefs/chrome_pref_model_associator_client.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/browser/prefs/chrome_pref_model_associator_client.h
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/common/BUILD.gn
[add] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/common/network_easter_egg.mojom
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/common/pref_names.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/common/pref_names.h
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/renderer/net/net_error_helper_core.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/renderer/net/net_error_helper_core.h
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/renderer/net/net_error_helper_core_unittest.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/renderer/net/net_error_page_controller.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/chrome/renderer/net/net_error_page_controller.h
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/components/neterror/resources/offline.js
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/components/sync_preferences/pref_model_associator.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/components/sync_preferences/pref_model_associator_client.h
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/components/sync_preferences/pref_model_associator_unittest.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/components/sync_preferences/pref_service_syncable_unittest.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/ios/chrome/browser/prefs/ios_chrome_pref_model_associator_client.cc
[modify] https://crrev.com/a5c24e17ea29c7bc442b8fc6490d1be9504bb958/ios/chrome/browser/prefs/ios_chrome_pref_model_associator_client.h

Status: Fixed (was: Assigned)
Highscore should now be saved & synced on all platforms except for iOS, starting with 72.0.3625.0.
Thanks for taking this on and getting it landed so quickly.
Yes, a big thank you from me and all the other dinosaur enthusiasts!  :)
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef27d52f65163eb0c3193546039462a7e20d4d55

commit ef27d52f65163eb0c3193546039462a7e20d4d55
Author: Eric Seckler <eseckler@chromium.org>
Date: Tue Dec 04 14:45:58 2018

network error: Add infrastructure to clear easter egg high score

Adds mojo + JS infrastructure to clear the dino game high score.
UI to be added by edwardjung@ later.

Bug:  568093 , 911040
Change-Id: If9fc99a3fe3b262c4e4671b3a534b6726d6dcd3e
Reviewed-on: https://chromium-review.googlesource.com/c/1358501
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613546}
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/browser/net/net_error_tab_helper.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/browser/net/net_error_tab_helper.h
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/common/network_easter_egg.mojom
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_page_controller.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_page_controller.h

Labels: -OS-iOS
Removing iOS per comment#29

Sign in to add a comment