New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 23 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task


Sign in to add a comment

Implement Worklets

Project Member Reported by ikilpatrick@chromium.org, Dec 7 2015

Issue description

Change description:
Worklets define a new javascript execution context which is designed to allow developers to write code which is intended to be run synchronously within the rendering engine, however independent of the main user javascript.

Changes to API surface:
New interfaces:
 - Worklet
 - WorkletGlobalScope

Links: https://drafts.css-houdini.org/worklets/
Public standards discussion: https://lists.w3.org/Archives/Public/public-houdini/2015Nov/0002.html

Support in other browsers:
Internet Explorer: not implemented
Firefox: not implemented
Safari: not implemented
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ec7646c06c3266f27ae291db023e006190cc1cc

commit 5ec7646c06c3266f27ae291db023e006190cc1cc
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Fri Dec 25 04:29:06 2015

Rename WorkerGlobalScopeExecutionState to ExecutionState.

As per https://codereview.chromium.org/1535943005/ in preparation for
renaming WorkerScriptController to IsolatedScriptController.

BUG= 567358 

Review URL: https://codereview.chromium.org/1550533002

Cr-Commit-Position: refs/heads/master@{#366854}

[modify] http://crrev.com/5ec7646c06c3266f27ae291db023e006190cc1cc/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp
[modify] http://crrev.com/5ec7646c06c3266f27ae291db023e006190cc1cc/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19

commit 95f7c6dd04e7dd1c817602cfb6a57d8a10721b19
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Wed Jan 06 17:28:02 2016

Rename WorkerScriptController to WorkerOrWorkletScriptController.

As per https://codereview.chromium.org/1535943005/ renaming first.
This CL has no behaviour changes.

BUG= 567358 

Review URL: https://codereview.chromium.org/1561643002

Cr-Commit-Position: refs/heads/master@{#367847}

[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp
[rename] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[rename] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/bindings/core/v8/v8.gypi
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/web/IndexedDBClientImpl.cpp
[modify] http://crrev.com/95f7c6dd04e7dd1c817602cfb6a57d8a10721b19/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb26e4f31ee245612a4a901d7bb366606cd91f1e

commit eb26e4f31ee245612a4a901d7bb366606cd91f1e
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Jan 14 04:28:22 2016

Initial implementation of bindings and basic classes for worklets.

https://drafts.css-houdini.org/worklets/

WorkerScriptController renamed to GlobalScopeScriptController to share
code with WorkletScriptController.

Additional super-class (AbstractGlobalScope) created for
WorkerGlobalScope and WorkletGlobalScope to share ExecutionContext
related implementation.

Notable pieces left to implement:
 - support for Worklet::importScript
 - devtools integration
 - off-main-thread implementation for compositorworklet & audioworklet

Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kl8ct3ub3a8/-WfzBTkCAgAJ

BUG= 567358 

Review URL: https://codereview.chromium.org/1535943005

Cr-Commit-Position: refs/heads/master@{#369323}

[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/core/v8/ToV8.h
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/core/core.gypi
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/modules.gypi
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/worklet/DEPS
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/worklet/Worklet.cpp
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/worklet/Worklet.h
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/worklet/Worklet.idl
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h
[add] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl
[modify] http://crrev.com/eb26e4f31ee245612a4a901d7bb366606cd91f1e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3931071f1feca0ed359ab392b1a4a48ac135e830

commit 3931071f1feca0ed359ab392b1a4a48ac135e830
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Feb 18 21:41:17 2016

Add a basic version of Worklet#import.

Worklets are now spec'd to use the 'module' loading infrastructure instead of the classic scripts.
'module' loading is still getting nailed down, so at the moment just load a 'classic' script.

https://html.spec.whatwg.org/multipage/scripting.html#concept-script-type

There is a large TODO to change this over when 'module' loading becomes mature.

Workers will also (probably) need to support 'module' script loading in the future,
(see: https://github.com/whatwg/html/pull/608 )
so any changes to script controller / script loader will benefit both.

Worklet now inherits from ActiveDOMObject due to script loading.

BUG= 567358 

Review URL: https://codereview.chromium.org/1684303002

Cr-Commit-Position: refs/heads/master@{#376271}

[add] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/LayoutTests/http/tests/worklet/import.html
[add] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/LayoutTests/http/tests/worklet/resources/empty-worklet-script.js
[add] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/LayoutTests/http/tests/worklet/resources/throwing-worklet-script.js
[modify] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/Source/modules/worklet/Worklet.cpp
[modify] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/Source/modules/worklet/Worklet.h
[modify] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/Source/modules/worklet/Worklet.idl
[modify] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp
[modify] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h
[modify] https://crrev.com/3931071f1feca0ed359ab392b1a4a48ac135e830/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ee8e9378635a5859b033bb27729491447a4f4e4

commit 3ee8e9378635a5859b033bb27729491447a4f4e4
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Mon Mar 07 21:18:58 2016

Add console API to worklets.

This is specifically for main thread worklets, as directly adds messages to the parent frame's console.

BUG= 567358 

Review URL: https://codereview.chromium.org/1756623002

Cr-Commit-Position: refs/heads/master@{#379645}

[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/core/frame/Console.idl
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/core/frame/ConsoleBase.h
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/core/frame/ConsoleBase.idl
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/core/frame/Window.idl
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/core/workers/WorkerConsole.idl
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/Worklet.cpp
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/Worklet.h
[add] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/WorkletConsole.cpp
[add] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/WorkletConsole.h
[add] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h
[modify] https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e

commit 9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Fri Mar 18 19:11:42 2016

[Worklets] Add basic debugging to main thread worklets.

This patch introduces MainThreadWorkletGlobalScope which lives in core/
This exposes accessing the parent LocalFrame for the MainThreadDebugger/devtools etc.

Devtools JS interprets this as a page script, will need to follow up with a sane UI for worklets in devtools :)

BUG= 567358 

Review URL: https://codereview.chromium.org/1745253002

Cr-Commit-Position: refs/heads/master@{#382040}

[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[add] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/modules/worklet/Worklet.cpp
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp
[modify] https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9279e2d0a23065e1b2f8f12a36843388cced503

commit f9279e2d0a23065e1b2f8f12a36843388cced503
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Tue Mar 29 03:43:08 2016

Make constructors in Worklets be properly exposed on the global.

Add global listing test case for Worklets.

BUG= 567358 

Review URL: https://codereview.chromium.org/1841633002

Cr-Commit-Position: refs/heads/master@{#383664}

[add] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
[add] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet.html
[add] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/resources/global-interface-listing-worklet.js
[modify] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/Source/bindings/idl.gni
[modify] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/Source/bindings/modules/generated.gyp
[modify] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/Source/bindings/modules/generated.gypi
[modify] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/Source/bindings/modules/modules.gni
[modify] https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h

Project Member

Comment 9 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7288f608152c4a9b546056e0db0fbb8932a89cfa

commit 7288f608152c4a9b546056e0db0fbb8932a89cfa
Author: glebl <glebl@chromium.org>
Date: Fri May 27 17:57:23 2016

Notify InspectorInstrumentation on successfully imported Worklet's script.

This ensures the type of the script in the devtools resource panel

BUG= 567358 

Review-Url: https://codereview.chromium.org/2017703002
Cr-Commit-Position: refs/heads/master@{#396506}

[modify] https://crrev.com/7288f608152c4a9b546056e0db0fbb8932a89cfa/third_party/WebKit/Source/modules/worklet/Worklet.cpp
[modify] https://crrev.com/7288f608152c4a9b546056e0db0fbb8932a89cfa/third_party/WebKit/Source/modules/worklet/Worklet.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a781795afd30e7c931ecf0a2276f76b411d58b

commit b3a781795afd30e7c931ecf0a2276f76b411d58b
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Fri Jun 03 16:21:26 2016

Previously the inheritance for WorkletGlobalScopes was:

core/workers/WorkerOrWorkletGlobalScope
  -> core/workers/MainThreadWorkletGlobalScope
  -> modules/worklet/WorkletGlobalScope

With ThreadedWorkletGlobalScope, not all global scopes will exist on the main thread.

MainThreadWorkletGlobalScope exists in core/workers as the MainThreadDebugger & friends need to access it's LocalFrame from core/

The new inheritance is:
core/workers/WorkerOrWorkletGlobalScope
  -> core/workers/WorkletGlobalScope
  -> core/workers/MainThreadWorkletGlobalScope

This moves WorkletGlobalScope into core and a few other classes. ThreadedWorkletGlobalScope will exist in modules and inherit from WorkletGlobalScope.

Implementation Doc:
https://docs.google.com/document/d/14hEO_BqQRBne3tBD2xghEEo02nz2csLqY4SS6x6rmjA/edit

BUG= 567358 

Review-Url: https://codereview.chromium.org/2029163002
Cr-Commit-Position: refs/heads/master@{#397722}

[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[add] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[rename] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[rename] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h
[rename] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/workers/WorkletGlobalScope.idl
[add] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.h
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/worklet/Worklet.cpp
[modify] https://crrev.com/b3a781795afd30e7c931ecf0a2276f76b411d58b/third_party/WebKit/Source/modules/worklet/Worklet.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 29 2016

Blockedon: 627945
Components: Blink>Workers
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9639129aab764e7597ab62c98dc27605d0a0b668

commit 9639129aab764e7597ab62c98dc27605d0a0b668
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Tue Jul 26 21:00:18 2016

[worklets] Make WorkerThread handle both Worker and Worklet global scopes.

This is to allow the WorkerThread infrastructure be used for ThreadedWorkletGlobalScope (see WIP here: https://codereview.chromium.org/2171973002/)

This class could also be renamed to something like ThreadScriptEnvironment or ThreadContextEnvironment, but can also be done later in just a rename patch.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2116113002
Cr-Commit-Position: refs/heads/master@{#407911}

[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/SharedWorkerThread.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/9639129aab764e7597ab62c98dc27605d0a0b668/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0177e05c812a52e8554678bd33fc4c0397b8b9df

commit 0177e05c812a52e8554678bd33fc4c0397b8b9df
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Wed Jul 27 23:43:52 2016

[worklets] Change WorkerInspectorController to accept a WorkerThread.

This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well.

The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2171973006
Cr-Commit-Position: refs/heads/master@{#408278}

[modify] https://crrev.com/0177e05c812a52e8554678bd33fc4c0397b8b9df/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/0177e05c812a52e8554678bd33fc4c0397b8b9df/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/0177e05c812a52e8554678bd33fc4c0397b8b9df/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27

commit 9febb56d38fc23e6f7e18f7a2886c2d5876a8a27
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Jul 28 23:51:15 2016

[worklets] Add stub classes for window.animationWorklet

This adds the code necessary just to return a Worklet object from the
window.animationWorklet attribute.

Followup patches will actually perform the wiring between this and
creating the background WorkerThread.

(Alternatively we could also start with audioWorklet as well, up to the
 reviewers; either or :).

BUG= 567358 

Review-Url: https://codereview.chromium.org/2186203002
Cr-Commit-Position: refs/heads/master@{#408508}

[modify] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
[add] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[add] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
[modify] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/compositorworker/DEPS
[add] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp
[add] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
[add] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.idl
[modify] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/modules.gypi
[add] https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27/third_party/WebKit/Source/modules/worklet/ThreadedWorkletGlobalScopeProxy.h

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d18989c467785e5585093e7e9aad15f6abcab09

commit 9d18989c467785e5585093e7e9aad15f6abcab09
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Fri Jul 29 02:51:53 2016

[worklets] Change paintWorklet method to non-const to remove mutable member.

Similar change occurred for WindowAnimationWorklet.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2193103002
Cr-Commit-Position: refs/heads/master@{#408562}

[modify] https://crrev.com/9d18989c467785e5585093e7e9aad15f6abcab09/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
[modify] https://crrev.com/9d18989c467785e5585093e7e9aad15f6abcab09/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.h

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b456ae94c7e484d0ad50584333914c1e1b5f462f

commit b456ae94c7e484d0ad50584333914c1e1b5f462f
Author: glebl <glebl@chromium.org>
Date: Tue Aug 02 17:50:26 2016

Refactor Worklet class to use ScriptResource.

Following the recommendations discussed in http://crrev.com/2146633002, this patch switches Worklet.cpp to use ScriptResource to load a worklet script, so it can follow the code path defined in FrameFetchContext::canRequest for CSP checks.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2178223002
Cr-Commit-Position: refs/heads/master@{#409232}

[add] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/worklet-import-blocked-expected.txt
[add] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/worklet-import-blocked.html
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.idl
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.h
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.idl
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/worklet/ThreadedWorkletGlobalScopeProxy.h
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/worklet/Worklet.cpp
[modify] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/worklet/Worklet.h
[add] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp
[add] https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f/third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f70f4aa155228044960e6521266c22e9f4e5539

commit 4f70f4aa155228044960e6521266c22e9f4e5539
Author: glebl <glebl@chromium.org>
Date: Fri Aug 05 02:51:47 2016

Check that the local frame is not null before instantiating AnimationWorklet.

This patch fixes the crash in blink::LocalFrame::document.
See https://cluster-fuzz.appspot.com/testcase?key=5879802211074048 for more details.

This is simlar to what we already do in WindowPaintWorklet::paintWorklet.

BUG= 567358 , 634253 

Review-Url: https://codereview.chromium.org/2212003002
Cr-Commit-Position: refs/heads/master@{#409973}

[modify] https://crrev.com/4f70f4aa155228044960e6521266c22e9f4e5539/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e7cd75500ae29a36da17b854eea4f42c93186a

commit 03e7cd75500ae29a36da17b854eea4f42c93186a
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Mon Aug 08 13:54:54 2016

[worklets] Implement isJSExecutionIsForbidden call for WorkletGlobalScope.

This method is currently unreachable for worklets (no events).

Additionally moves isClosing method.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2223623002
Cr-Commit-Position: refs/heads/master@{#410343}

[modify] https://crrev.com/03e7cd75500ae29a36da17b854eea4f42c93186a/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/03e7cd75500ae29a36da17b854eea4f42c93186a/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/03e7cd75500ae29a36da17b854eea4f42c93186a/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80

commit c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Tue Aug 09 20:52:41 2016

[worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2220213002
Cr-Commit-Position: refs/heads/master@{#410812}

[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/SharedWorkerThread.h
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp
[modify] https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d82384e62af55a9aae1182b4ae4c19dac325910a

commit d82384e62af55a9aae1182b4ae4c19dac325910a
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Wed Aug 10 16:29:47 2016

[worklets] Split apart CompositorWorkerThread for sharing with AnimationWorkletThread.

This splits apart CompositorWorkerThread into:
 - CompositorWorkerThread
 - AbstractAnimationWorkletThread

And add AnimationWorkletThread which inherits from AbstractAnimationWorkletThread.

AnimationWorkletThread is basically a place holder class at the moment
which needs createWorkerGlobalScope and consoleMessageStorage
implemented (which will be implemented once AnimationWorkletGS is
checked in).

BUG= 567358 

Review-Url: https://codereview.chromium.org/2214263007
Cr-Commit-Position: refs/heads/master@{#411052}

[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp
[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h
[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp
[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.h
[modify] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp
[modify] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h
[modify] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d82384e62af55a9aae1182b4ae4c19dac325910a

commit d82384e62af55a9aae1182b4ae4c19dac325910a
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Wed Aug 10 16:29:47 2016

[worklets] Split apart CompositorWorkerThread for sharing with AnimationWorkletThread.

This splits apart CompositorWorkerThread into:
 - CompositorWorkerThread
 - AbstractAnimationWorkletThread

And add AnimationWorkletThread which inherits from AbstractAnimationWorkletThread.

AnimationWorkletThread is basically a place holder class at the moment
which needs createWorkerGlobalScope and consoleMessageStorage
implemented (which will be implemented once AnimationWorkletGS is
checked in).

BUG= 567358 

Review-Url: https://codereview.chromium.org/2214263007
Cr-Commit-Position: refs/heads/master@{#411052}

[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp
[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h
[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp
[add] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.h
[modify] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp
[modify] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h
[modify] https://crrev.com/d82384e62af55a9aae1182b4ae4c19dac325910a/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6142503bf4368e18be7181bf96af791ca57d8c66

commit 6142503bf4368e18be7181bf96af791ca57d8c66
Author: nhiroki <nhiroki@chromium.org>
Date: Mon Aug 22 06:45:49 2016

Worklet: Move common worklet code from modules/worklet to core/workers

After ThreadedWorklet is introduced, worklet code gets more tied up with
worker code, so it'd be reasonable that they are located in the same directory.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2262483003
Cr-Commit-Position: refs/heads/master@{#413413}

[modify] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/core/core.gypi
[rename] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScopeProxy.h
[rename] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/core/workers/Worklet.cpp
[rename] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/core/workers/Worklet.h
[rename] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/core/workers/Worklet.idl
[rename] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/core/workers/WorkletScriptLoader.cpp
[rename] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/core/workers/WorkletScriptLoader.h
[modify] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
[modify] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/modules/compositorworker/DEPS
[modify] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/modules/csspaint/DEPS
[modify] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
[modify] https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66/third_party/WebKit/Source/modules/modules.gypi
[delete] https://crrev.com/0494f634cad9c20494a458e79120f10cca315582/third_party/WebKit/Source/modules/worklet/DEPS
[delete] https://crrev.com/0494f634cad9c20494a458e79120f10cca315582/third_party/WebKit/Source/modules/worklet/OWNERS

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbc47ca435e2b5aba33485cbd62a75dd3683b622

commit dbc47ca435e2b5aba33485cbd62a75dd3683b622
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Aug 25 20:12:14 2016

[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

The ThreadedWorkletGlobalScope is simpler than a WorkerGlobalScope as
 - It doesn't need to report exceptions to the main thread they can just be logged to the console.

AnimationWorkletGlobalScope doesn't have anything on it at the moment, but is used in the AnimationWorkletThreadTest (which is a clone of the CompositorWorkerThreadTest).

BUG= 567358 

Review-Url: https://codereview.chromium.org/2254593002
Cr-Commit-Position: refs/heads/master@{#414517}

[modify] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
[modify] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/core/dom/ExecutionContext.h
[add] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
[add] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.h
[add] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.cpp
[add] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.h
[add] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.idl
[modify] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp
[add] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
[modify] https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e

commit e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Wed Sep 07 00:58:38 2016

[worklets] Remove InProcessWorkerGlobalScopeProxy, and rename classes/methods.

As discussed in https://codereview.chromium.org/2310673002 removing the
InProcessWorkerGlobalScopeProxy interface class entirely.

Also renames a bunch of the methods/classes whose name came from
GlobalScopeProxy. (s/GlobalScopeProxy/MessagingProxy).

BUG= 567358 

Review-Url: https://codereview.chromium.org/2312273002
Cr-Commit-Position: refs/heads/master@{#416809}

[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/BUILD.gn
[rename] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.cpp
[rename] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.h
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h
[delete] https://crrev.com/abc167aee99d4f7a20452064b2ca3ab9ed7c6ff3/third_party/WebKit/Source/core/workers/InProcessWorkerGlobalScopeProxy.h
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/Worker.cpp
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/core/workers/Worker.h
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.h
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/web/BUILD.gn
[rename] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp
[rename] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.h
[modify] https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e/third_party/WebKit/Source/web/WebViewImpl.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89b9278e35bf785df739d89efb9587961a95f776

commit 89b9278e35bf785df739d89efb9587961a95f776
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Sep 08 02:04:47 2016

[worklets] Split up InProcessWorkerMessagingProxy into a base+worker class.

This pulls out all of the lifetime logic for the WorkerThread into the base class ThreadedMessagingProxyBase.

This will allow us to re-use all of the lifetime logic (I've created a followup demo patch which does this https://codereview.chromium.org/2312493002/)

BUG= 567358 

Review-Url: https://codereview.chromium.org/2310673002
Cr-Commit-Position: refs/heads/master@{#417161}

[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/BUILD.gn
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[add] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[add] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89b9278e35bf785df739d89efb9587961a95f776

commit 89b9278e35bf785df739d89efb9587961a95f776
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Sep 08 02:04:47 2016

[worklets] Split up InProcessWorkerMessagingProxy into a base+worker class.

This pulls out all of the lifetime logic for the WorkerThread into the base class ThreadedMessagingProxyBase.

This will allow us to re-use all of the lifetime logic (I've created a followup demo patch which does this https://codereview.chromium.org/2312493002/)

BUG= 567358 

Review-Url: https://codereview.chromium.org/2310673002
Cr-Commit-Position: refs/heads/master@{#417161}

[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/BUILD.gn
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[add] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[add] https://crrev.com/89b9278e35bf785df739d89efb9587961a95f776/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8

commit 4bd1a1b4e1d321526cfe0c10adc15f507a661bb8
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Sep 15 02:34:41 2016

[worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.

This patch does the plumbing from the animationworklet to the globalscope to import scripts etc.

BUG= 567358 

Review-Url: https://codereview.chromium.org/2312493002
Cr-Commit-Position: refs/heads/master@{#418765}

[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/LayoutTests/http/tests/worklet/animation-worklet-import.html
[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/LayoutTests/http/tests/worklet/paint-worklet-import.html
[rename] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
[modify] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/core/workers/BUILD.gn
[modify] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScopeProxy.h
[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp
[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.h
[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp
[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h
[modify] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.cpp
[add] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.h
[modify] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/third_party/WebKit/Source/modules/compositorworker/BUILD.gn

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43271670088ea8fa31ff8151670fb000d0b0f613

commit 43271670088ea8fa31ff8151670fb000d0b0f613
Author: yutak <yutak@chromium.org>
Date: Thu Sep 15 07:40:31 2016

Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. (patchset #8 id:180001 of https://codereview.chromium.org/2312493002/ )

Reason for revert:
Caused leaks in a number of layout tests.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22941

Original issue's description:
> [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.
>
> This patch does the plumbing from the animationworklet to the globalscope to import scripts etc.
>
> BUG= 567358 
>
> Committed: https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8
> Cr-Commit-Position: refs/heads/master@{#418765}

TBR=nhiroki@chromium.org,hongchan@chromium.org,yhirano@chromium.org,majidvp@chromium.org,ikilpatrick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 567358 

Review-Url: https://codereview.chromium.org/2342013002
Cr-Commit-Position: refs/heads/master@{#418799}

[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/LayoutTests/http/tests/worklet/animation-worklet-import.html
[rename] https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613/third_party/WebKit/LayoutTests/http/tests/worklet/import.html
[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/LayoutTests/http/tests/worklet/paint-worklet-import.html
[modify] https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613/third_party/WebKit/Source/core/workers/BUILD.gn
[modify] https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScopeProxy.h
[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp
[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.h
[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp
[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h
[modify] https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.cpp
[delete] https://crrev.com/6c5aae893b0dea189b18412f3795dba30d12f721/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.h
[modify] https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613/third_party/WebKit/Source/modules/compositorworker/BUILD.gn

Comment 31 by glebl@chromium.org, Sep 20 2016

Cc: glebl@chromium.org
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9f3e18e97d2726023ab6e8016935fc8617a489e

commit a9f3e18e97d2726023ab6e8016935fc8617a489e
Author: glebl <glebl@chromium.org>
Date: Fri Sep 30 01:53:23 2016

Make CSSStyleImageValue a member of CanvasImageSource.

This will make it possible to call BaseRenderingContext2D.drawImage with CSSOM Style Image object as an argument.

BUG= 567358 
TEST=third_party/WebKit/LayoutTests/csspaint/paint2d-image.html

Review-Url: https://codereview.chromium.org/2351363002
Cr-Commit-Position: refs/heads/master@{#422010}

[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.pattern.image.string-expected.txt
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.pattern.image.undefined-expected.txt
[add] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/LayoutTests/csspaint/paint2d-image-expected.html
[add] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/LayoutTests/csspaint/paint2d-image.html
[add] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/LayoutTests/csspaint/resources/html5.png
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour-expected.txt
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-broken-image-expected.txt
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.cpp
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.h
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/a9f3e18e97d2726023ab6e8016935fc8617a489e/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a49dbd327c02c506b07bc9c024e2492b34a4c779

commit a49dbd327c02c506b07bc9c024e2492b34a4c779
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Fri Sep 30 19:50:19 2016

[worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.

This patch does the plumbing from the animationworklet to the globalscope to import scripts etc.

BUG= 567358 

Committed: https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8
Review-Url: https://codereview.chromium.org/2312493002
Cr-Original-Commit-Position: refs/heads/master@{#418765}
Cr-Commit-Position: refs/heads/master@{#422192}

[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/LayoutTests/http/tests/worklet/paint-worklet-import.html
[rename] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/README.txt
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html
[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/BUILD.gn
[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScopeProxy.h
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.h
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h
[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.cpp
[add] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.h
[modify] https://crrev.com/a49dbd327c02c506b07bc9c024e2492b34a4c779/third_party/WebKit/Source/modules/compositorworker/BUILD.gn

Comment 34 by horo@chromium.org, Oct 4 2016

Blockedon: 652535
The virtual/threaded/http/tests/worklet/animation-worklet-import.html test is very flaky and leads to frequent renderer crashes on WebKit Linux Trusty Leak. Can you please investigate? 

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Fhttp%2Ftests%2Fworklet%2Fanimation-worklet-import.html&testType=webkit_tests
Blockedon: 670307
#36: Filed  bug 670307  to track the crashes in that test.
Blockedon: 726576
Blockedon: 710837
Blockedon: 719303
Blockedon: 724907
Blockedon: 738769
Blockedon: 738770

Comment 45 Deleted

Blockedon: 469639
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Project Member

Comment 48 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e6e3cff7ff126e2b5d7c7635fedc587824602c

commit 96e6e3cff7ff126e2b5d7c7635fedc587824602c
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Wed Sep 27 23:00:34 2017

use USVString for URLs at Worklet.

use USVString for URLs instead of DOMString at Worklet.

Bug:  567358 
Change-Id: Ia1d777693ce9a71f4369122e389018dc0e5b4921
Reviewed-on: https://chromium-review.googlesource.com/686679
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#504789}
[modify] https://crrev.com/96e6e3cff7ff126e2b5d7c7635fedc587824602c/third_party/WebKit/Source/core/workers/Worklet.idl

Blockedon: 773772
Labels: -M-56
Blockedon: 773778
Blockedon: 773786
Status: Fixed (was: Assigned)
Ian,

Is this in desktop, android, and webview? Is it in Opera?

Joe Medley | Technical Writer, Chrome DevRel | jmedley@google.com |
 816-678-7195
*If an API's not documented it doesn't exist.*
Hey Joe,

Yes Desktop, Android, Webview.
M65 for Paint, M66 for Audio.

Not sure about Opera, I don't see why not.

Ian

Sign in to add a comment