New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 22 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature


Sign in to add a comment

Make CanvasRenderingContext2D renderable in both worker and main thread on non-accelerated mode

Project Member Reported by junov@chromium.org, Dec 1 2015 Back to list

Issue description

Spec detail in flux: it is possible that a new interface will be created that is a subset CanvasRenderingContext2D in order to exclude certain APIs that do not make sense with offscreencanvases, such as scrollPathIntoView, drawFocusIfNeeded and HitRegion APIs.

 

Comment 1 by junov@chromium.org, Dec 1 2015

Blocking: chromium:563816

Comment 2 by junov@chromium.org, Dec 1 2015

Blocking: chromium:563858

Comment 3 by junov@chromium.org, Mar 8 2016

Owner: junov@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e81032f06d758c0e79fec2158f1b928f3487036

commit 3e81032f06d758c0e79fec2158f1b928f3487036
Author: junov <junov@chromium.org>
Date: Mon Mar 14 22:10:19 2016

Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. It only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG= 563856 ,  563832 

Review URL: https://codereview.chromium.org/1775153002

Cr-Commit-Position: refs/heads/master@{#381085}

[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-clearRect-in-worker-expected.html
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-clearRect-in-worker.html
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor-expected.txt
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker-expected.html
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker.html
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-strokeRect-in-worker-expected.html
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-strokeRect-in-worker.html
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferToImageBitmap-expected.txt
[add] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferToImageBitmap.html
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.idl
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContext.h
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Comment 5 by junov@chromium.org, Mar 14 2016

Cc: -xlai@chromium.org junov@chromium.org
Owner: xlai@chromium.org
This is a start.
@xlai: handing off to you to get the rest of the APIs working.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/743ca082b662386b4df43a5dc556f9a1be701785

commit 743ca082b662386b4df43a5dc556f9a1be701785
Author: xlai <xlai@chromium.org>
Date: Tue Mar 22 16:36:50 2016

Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

A subset of existing Web APIs shared with non-Offscreen
canvas from CanvasPathMethods are also tested, including:

arc, lineTo, bezierCurveTo, moveTo, closePath.

BUG= 563856 

Review URL: https://codereview.chromium.org/1806943005

Cr-Commit-Position: refs/heads/master@{#382584}

[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-paths-in-worker-expected.html
[add] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-paths-in-worker.html
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/Source/modules/canvas2d/Path2D.idl
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/Source/modules/offscreencanvas/OWNERS
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/Source/modules/offscreencanvas2d/OWNERS
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl
[modify] https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 7 by xlai@chromium.org, Mar 29 2016

Blockedon: 598706
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b697944deb9405ee4e15df5b942a8f8390817a5

commit 1b697944deb9405ee4e15df5b942a8f8390817a5
Author: xlai <xlai@chromium.org>
Date: Tue Apr 05 16:18:22 2016

Add transformation, canvas state, shadow to OffscreenCanvasRenderingContext2D

BUG= 563856 

Review URL: https://codereview.chromium.org/1832613002

Cr-Commit-Position: refs/heads/master@{#385185}

[modify] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transform-shadow-in-worker-expected.html
[add] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transform-shadow-in-worker.html
[modify] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Comment 9 by noel@chromium.org, Apr 20 2016

Cc: darin@chromium.org jianli@chromium.org mpd@google.com ericu@chromium.org
 Issue 32276  has been merged into this issue.

Comment 10 by xlai@chromium.org, Apr 20 2016

Blockedon: 599659

Comment 11 by xlai@chromium.org, Apr 26 2016

Blockedon: 606925

Comment 12 by xlai@chromium.org, Apr 26 2016

Summary: Make CanvasRenderingContext2D renderable in a worker and in main thread (was: Make CanvasRenderingContext2D renderable in a worker)
Unless a spec change is proposed, we'll assume OffscreenCRC2D is renderable in both worker and main thread. Thus the renaming of this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5433e667fc2a2a1e62e969a8d7539081c4dde9c3

commit 5433e667fc2a2a1e62e969a8d7539081c4dde9c3
Author: xlai <xlai@chromium.org>
Date: Wed Apr 27 21:15:28 2016

Add createGradient and createPattern to OffscreenCanvas2D in worker

Implemented more color-related API functions for OffscreenCRC2D.
But createPattern() on main thread has not been completed due to
 crbug.com/563870 .

BUG= 563856 

Review-Url: https://codereview.chromium.org/1919363002
Cr-Commit-Position: refs/heads/master@{#390188}

[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-gradients-in-worker-expected.html
[add] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-gradients-in-worker.html
[add] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-pattern-in-worker-expected.html
[add] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-pattern-in-worker.html
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/canvas2d/CanvasGradient.idl
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/canvas2d/CanvasPattern.idl
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.idl
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/5433e667fc2a2a1e62e969a8d7539081c4dde9c3/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Project Member

Comment 14 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23378f8baae5d52320bb4652984b3f045f0bd95e

commit 23378f8baae5d52320bb4652984b3f045f0bd95e
Author: xlai <xlai@chromium.org>
Date: Mon May 02 18:33:02 2016

Add drawImage() originClean() getSecurityOrigin() to OffscreenCanvas

This patch adds m_originClean flag to OffscreenCanvas and
 ensures that OCRC2D also use the value of this flag instead
of keeping its own redundant copy. It propagates the value of
 originClean in transferToImageBitmap().

This patch also expose drawImage() API functions in ORCRC2D in workers.

BUG= 563870 ,  563856 

Review-Url: https://codereview.chromium.org/1928043002
Cr-Commit-Position: refs/heads/master@{#391002}

[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-in-worker-expected.html
[add] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-in-worker.html
[add] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-transferToImageBitmap-expected.txt
[add] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-transferToImageBitmap.html
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.idl
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Project Member

Comment 15 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015

commit 2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015
Author: xlai <xlai@chromium.org>
Date: Fri May 06 20:32:46 2016

Implement wouldTaintOrigin and expose createPattern for OCRC2D on main thread

BUG= 606925 ,  563856 

Review-Url: https://codereview.chromium.org/1954533002
Cr-Commit-Position: refs/heads/master@{#392139}

[modify] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-pattern-expected.html
[add] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-pattern.html
[add] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-createPattern-expected.txt
[add] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-createPattern.html
[modify] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Project Member

Comment 16 by bugdroid1@chromium.org, May 12 2016

Comment 17 by xlai@chromium.org, May 13 2016

Summary: Make CanvasRenderingContext2D renderable in both worker and main thread on non-accelerated mode (was: Make CanvasRenderingContext2D renderable in a worker and in main thread)
Project Member

Comment 18 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a

commit b5ad91ea5bbd69c5615cc89c6c46257f4525f23a
Author: xlai <xlai@chromium.org>
Date: Fri May 13 16:50:49 2016

Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG= 563856 

Review-Url: https://codereview.chromium.org/1971353002
Cr-Commit-Position: refs/heads/master@{#393550}

[add] https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker-expected.txt
[add] https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker.html
[modify] https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Comment 19 by xlai@chromium.org, May 13 2016

Status: Fixed (was: Started)

Comment 20 by xlai@chromium.org, May 13 2016

Blocking: 611796

Sign in to add a comment