New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 15 users

Issue metadata

Status: Verified
Owner:
Not currently working on Chromium
Closed: Oct 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Add about:labs options for GPU acceleration

Reported by hbridge@google.com, Sep 17 2010

Issue description

Instead of a command line switch, we should have an about:labs option for accelerated 2D canvas.

CC'ing Miranda who I hear can help guide us in how to implement it.
 

Comment 1 by kerz@chromium.org, Sep 29 2010

Labels: Area-UI

Comment 2 by hbridge@google.com, Oct 4 2010

Status: Assigned

Comment 3 by hbridge@google.com, Oct 6 2010

Labels: -Feature-GPU-canvas2d Feature-GPU
Summary: Add about:labs options for GPU acceleration
For WebGL and the compositor, we'll need to reinstate the --enable-* flags that were removed by:
http://code.google.com/p/chromium/issues/detail?id=54469

and add the necessary entries to src/chrome/labs.cc

Hopefully after we get the about:labs UI, it will be possible to change the default from Enabled to Disabled without having to keep adding and removing flags.


Status: Started
about:labs doesn't currently support enabling a Lab by default and allowing a user to opt out. thakis has expressed a firm opinion against such a behavior on the labs page. This would imply not adding labs for already defaulted features such as compositor and webgl.

Also, there is a question as to if we would desire a labs option per platform? The labs preferences are synchronized with all other prefs. If we wanted to enable e.g. canvas acceleration on Windows but not Macintosh we would need to enter a unique lab option for each platform (or consider adding a per-platform feature to labs [IMHO overcomplicated, +thakis]).

Comment 7 by thakis@google.com, Oct 8 2010

re per-os labs: I wouldn't worry about this too much. Most people don't run chrome on multiple platforms I would think. We can wait with making the lab available on mac until it works well enough for labs (i.e. not very well :-) ).

Comment 8 by hbridge@google.com, Oct 11 2010

We're planning to change the option for compositing and webgl to off by default for the 8 branch to give us more time to stabilize it, that was the purpose of the lab.
Labels: Mstone-9
Changing milestone from Mstone8 to Mstone-9
Labels: -Mstone-9 Mstone-8
This one stays m8 I'm pretty sure :-)
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=62233

------------------------------------------------------------------------
r62233 | scheib@google.com | Mon Oct 11 19:39:42 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=62233&r2=62232&pathrev=62233
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.cc?r1=62233&r2=62232&pathrev=62233

Lab strings for accelerated compositor, canvas 2d, and WebGL added. Canvas Lab exposed.

BUG= 56053 
TEST=None: manually load about:labs

Review URL: http://codereview.chromium.org/3698003
------------------------------------------------------------------------
Labels: -Mstone-8 Mstone-9
Since we are passed the branch, moving all mstone-8 issues to mstone-9 for triage/punting
Labels: resolveByM8
This is desired for m8
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=63535

------------------------------------------------------------------------
r63535 | enne@chromium.org | Fri Oct 22 11:15:19 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_policy.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_init_wrapper_mac.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=63535&r2=63534&pathrev=63535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=63535&r2=63534&pathrev=63535

Disable GPU features AcceleratingCompositing and WebGL by default.

Flags have been switched to reversed logic, and about_flags.cc modified to expose these to users in GUI.

BUG= 56053 ,  59092 
TEST=Use about:flags to toggle features, confirm state with e.g. http://webglsamples.googlecode.com/hg/aquarium/aquarium.html http://webkit.org/blog-files/3d-transforms/poster-circle.html Vince's change for about:flags.

Review URL: http://codereview.chromium.org/3978002
------------------------------------------------------------------------
Labels: Mstone-10
Moving all P2 bugs w/ owners into Mstone-10.  I'll leave this to the owners discretion if they want to move the work back into M9, however, my caveat would be that the priority should be on completing P0/P1 bugs in the span of the next few weeks.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=63544

------------------------------------------------------------------------
r63544 | enne@chromium.org | Fri Oct 22 12:43:42 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/about_flags.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/common/sandbox_init_wrapper_mac.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/renderer/render_thread.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/common/chrome_switches.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/renderer/render_view.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/common/chrome_switches.h?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=63544&r2=63543&pathrev=63544
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/common/sandbox_policy.cc?r1=63544&r2=63543&pathrev=63544

Merge 63535 - Disable GPU features AcceleratingCompositing and WebGL by default.

Flags have been switched to reversed logic, and about_flags.cc modified to expose these to users in GUI.

BUG= 56053 ,  59092 
TEST=Use about:flags to toggle features, confirm state with e.g. http://webglsamples.googlecode.com/hg/aquarium/aquarium.html http://webkit.org/blog-files/3d-transforms/poster-circle.html Vince's change for about:flags.

Review URL: http://codereview.chromium.org/3978002

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/4016003
------------------------------------------------------------------------
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=63547

------------------------------------------------------------------------
r63547 | enne@chromium.org | Fri Oct 22 12:50:12 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_policy.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_init_wrapper_mac.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=63547&r2=63546&pathrev=63547
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=63547&r2=63546&pathrev=63547

Revert 63535 - Disable GPU features AcceleratingCompositing and WebGL by default.

(This change got checked into trunk only to get merged into M8.)

Flags have been switched to reversed logic, and about_flags.cc modified to expose these to users in GUI.

BUG= 56053 ,  59092 
TEST=Use about:flags to toggle features, confirm state with e.g. http://webglsamples.googlecode.com/hg/aquarium/aquarium.html http://webkit.org/blog-files/3d-transforms/poster-circle.html Vince's change for about:flags.

Review URL: http://codereview.chromium.org/3978002

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/3974004
------------------------------------------------------------------------

Comment 18 by enne@chromium.org, Oct 22 2010

Status: Fixed
Checked into trunk and then merged to M8 in r63544.

Comment 19 by enne@chromium.org, Oct 22 2010

With Google Chrome 8.0.552.18 (Official Build 63841), about:flags has the GPU features which can be enabled and disabled.

Sometimes GPU process is being launched even when the flags are disabled. Didn't we disable it completely for M8?
Status: Verified
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Internals-Graphics -Feature-GPU -Area-UI -Mstone-10 Cr-Internals-GPU Cr-Internals-Graphics Cr-UI M-10
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Components: -Internals>Graphics
Moving old issues out of Internal>Graphics to delete this obsolete component ( crbug.com/685425  for details)

Sign in to add a comment