New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 556939 link

Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

[C++11 library] Get rid of linked_ptr

Project Member Reported by lima...@gmail.com, Nov 17 2015

Issue description

We can use scoped_ptr in STL containers.
so that linked_ptr[1] should be replaced with scoped_ptr.

[1]linked_ptr: https://code.google.com/p/chromium/codesearch#chromium/src/base/memory/linked_ptr.h




 

Comment 1 by lima...@gmail.com, Nov 17 2015

Blocking: chromium:554287
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/244f7061468d1fa88f20229e0a8648237f5ffe51

commit 244f7061468d1fa88f20229e0a8648237f5ffe51
Author: limasdf <limasdf@gmail.com>
Date: Wed Nov 18 00:41:13 2015

linked_ptr: Add deprecation notice.

C++ 11 enables containers that contain move-only type, scoped_ptr.

BUG= 556939 

Review URL: https://codereview.chromium.org/1455453002

Cr-Commit-Position: refs/heads/master@{#360236}

[modify] http://crrev.com/244f7061468d1fa88f20229e0a8648237f5ffe51/base/memory/linked_ptr.h

Comment 3 by lima...@gmail.com, Nov 19 2015

Status: Available
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d962ea0c83e6512f0364ceb3b29fff91bf739a

commit 81d962ea0c83e6512f0364ceb3b29fff91bf739a
Author: limasdf <limasdf@gmail.com>
Date: Fri Nov 20 08:39:18 2015

Use scoped_ptr instead of linked_ptr from /content/renderer

R=avi@chromium.org
BUG= 556939 

Review URL: https://codereview.chromium.org/1457963002

Cr-Commit-Position: refs/heads/master@{#360779}

[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/media/video_capture_impl_manager.h
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/npapi/webplugin_delegate_proxy.h
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/pepper/event_conversion.cc
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/pepper/event_conversion.h
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/pepper/host_var_tracker.h
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/pepper/video_decoder_shim.cc
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/pepper/video_decoder_shim.h
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/presentation/presentation_dispatcher.cc
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/presentation/presentation_dispatcher.h
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/render_view_impl.cc
[modify] http://crrev.com/81d962ea0c83e6512f0364ceb3b29fff91bf739a/content/renderer/render_view_impl.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 1 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4695e89361e0fdc2eaa3b3ba57362fa6e05f10cf

commit 4695e89361e0fdc2eaa3b3ba57362fa6e05f10cf
Author: tfarina <tfarina@chromium.org>
Date: Tue Dec 01 22:09:53 2015

tools/gn: replace usage of linked_ptr by using scoped_ptr

With C++11, we can use scoped_ptr in STL containers now.

BUG= 556939 
TEST=gn gen + gn_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1480423003

Cr-Commit-Position: refs/heads/master@{#362520}

[modify] http://crrev.com/4695e89361e0fdc2eaa3b3ba57362fa6e05f10cf/tools/gn/loader_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b946dc7afe1ad7a11a423d1519ad4f880b62a44c

commit b946dc7afe1ad7a11a423d1519ad4f880b62a44c
Author: kinuko <kinuko@chromium.org>
Date: Wed Jan 06 05:33:17 2016

Cleanup ResourceDispatcher::PendingRequestInfo

Some preliminary cleanups for RequestPeer lifetime fix.
- Changes hash_map<> to map<scoped_ptr<>>, remove default ctor
- Replaces some linked_ptr with scoped_ptr ( crbug.com/556939 )

BUG= 507170 ,  556939 

Review URL: https://codereview.chromium.org/1561563002

Cr-Commit-Position: refs/heads/master@{#367782}

[modify] http://crrev.com/b946dc7afe1ad7a11a423d1519ad4f880b62a44c/content/child/resource_dispatcher.cc
[modify] http://crrev.com/b946dc7afe1ad7a11a423d1519ad4f880b62a44c/content/child/resource_dispatcher.h
[modify] http://crrev.com/b946dc7afe1ad7a11a423d1519ad4f880b62a44c/content/child/site_isolation_stats_gatherer.cc
[modify] http://crrev.com/b946dc7afe1ad7a11a423d1519ad4f880b62a44c/content/child/site_isolation_stats_gatherer.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/591bbce72bf16e013ba7dea4005fc0d89d70b744

commit 591bbce72bf16e013ba7dea4005fc0d89d70b744
Author: kinuko <kinuko@chromium.org>
Date: Tue Jan 19 06:29:59 2016

Use scoped_ptr for loaders map in ResourceDispatcherHostImpl

Mostly for cleanup, but this seems to have minor perf-win (5%-ish)
on a few frequently called per-request methods like
ResourceDispatcherHostImpl::RemovePendingRequest.

(With 1000+ data points on my relatively fast Mac, the method takes
72.77 us by average in the original code, while it takes
66.67 us by average with scoped_ptr version.)

BUG= 556939 

Review URL: https://codereview.chromium.org/1603503002

Cr-Commit-Position: refs/heads/master@{#370076}

[modify] http://crrev.com/591bbce72bf16e013ba7dea4005fc0d89d70b744/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] http://crrev.com/591bbce72bf16e013ba7dea4005fc0d89d70b744/content/browser/loader/resource_dispatcher_host_impl.h

Blockedon: chromium:581625
BTW, we had  bug 137767  previously. Merge?

Comment 14 by lima...@gmail.com, Jan 29 2016

I've merged  crbug.com/137767 (..use ScopedVector instead) into  crbug.com/554289  (Remove ScopedVector) .

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2588941279b28a6cf205896b955402e36535af6d

commit 2588941279b28a6cf205896b955402e36535af6d
Author: dcheng <dcheng@chromium.org>
Date: Tue Feb 02 17:42:24 2016

Remove linked_ptr usage in //base.

And clean up some code that didn't IWYU.

BUG= 556939 

Review URL: https://codereview.chromium.org/1641563002

Cr-Commit-Position: refs/heads/master@{#372977}

[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/base/supports_user_data.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/base/supports_user_data.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/base/threading/sequenced_worker_pool.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/chrome/browser/printing/cloud_print/privet_notifications.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/components/guest_view/browser/guest_view_base.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/components/guest_view/browser/guest_view_base.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/components/guest_view/browser/guest_view_event.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/components/guest_view/browser/guest_view_event.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/extension_options/extension_options_guest.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/extension_view/extension_view_guest.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/web_view/web_view_find_helper.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/web_view/web_view_find_helper.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/web_view/web_view_guest.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/web_view/web_view_guest_delegate.h
[modify] http://crrev.com/2588941279b28a6cf205896b955402e36535af6d/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Blockedon: 595949
Blockedon: 137767
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4

commit f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4
Author: lazyboy <lazyboy@chromium.org>
Date: Wed Aug 31 00:37:08 2016

Some linked_ptr -> unique_ptr conversion in extensions/browser.

Change ExtensionService::AddProviderForTesting() to take
unique_ptr instead of raw pointer.

BUG= 556939 
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2294653002
Cr-Commit-Position: refs/heads/master@{#415518}

[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/api/input_ime/input_ime_api.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/api/mdns/mdns_api_unittest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/extension_migrator_unittest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/extension_service.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/external_provider_impl.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/chrome/browser/extensions/external_provider_impl_unittest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/alarms/alarms_api_unittest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/api_resource_manager.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/cast_channel/logger.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/cast_channel/logger.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/networking_private/networking_private_linux.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/networking_private/networking_private_linux.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/storage/local_value_store_cache.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/storage/local_value_store_cache.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/storage/settings_test_util.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/api/system_storage/system_storage_apitest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/blob_holder.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/blob_holder.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/content_verifier_io_data.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/content_verifier_io_data.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/declarative_user_script_manager.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/declarative_user_script_manager.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/event_listener_map.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/event_listener_map.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/extension_prefs.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/external_provider_interface.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/lazy_background_task_queue.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/lazy_background_task_queue.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/process_manager.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/updater/extension_downloader.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/updater/request_queue.h
[modify] https://crrev.com/f33109d5e1ca94a1e12ed34eb2f55cbb1d767cc4/extensions/browser/value_store/value_store_unittest.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b65b322f74351da8b61fe35889348649b56d213d

commit b65b322f74351da8b61fe35889348649b56d213d
Author: lazyboy <lazyboy@chromium.org>
Date: Fri Sep 02 01:49:30 2016

Remove some unused linked_ptr.h includes in c/b/extensions/api

BUG= 556939 
Test=None

Review-Url: https://codereview.chromium.org/2305703003
Cr-Commit-Position: refs/heads/master@{#416161}

[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/developer_private/developer_private_mangle.h
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/developer_private/inspectable_views_finder.h
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/feedback_private/feedback_service.h
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
[modify] https://crrev.com/b65b322f74351da8b61fe35889348649b56d213d/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cbdfe0a10dd8521d09d79100457964b9da54166

commit 4cbdfe0a10dd8521d09d79100457964b9da54166
Author: lazyboy <lazyboy@chromium.org>
Date: Fri Sep 02 05:32:32 2016

Remove all extensions/renderer and c/r/extensions linked_ptr usage.

All of them seem trivial, make them use std::unique_ptr.

BUG= 556939 
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2301113003
Cr-Commit-Position: refs/heads/master@{#416195}

[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/chrome/renderer/extensions/cast_streaming_native_handler.h
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/components/guest_view/renderer/guest_view_container.cc
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/components/guest_view/renderer/guest_view_container.h
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/object_backed_native_handler.cc
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/object_backed_native_handler.h
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/request_sender.cc
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/request_sender.h
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/resource_bundle_source_map.h
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/user_script_set_manager.cc
[modify] https://crrev.com/4cbdfe0a10dd8521d09d79100457964b9da54166/extensions/renderer/user_script_set_manager.h

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aeef2005e69892c90c3adec9607f4ef378fd533

commit 4aeef2005e69892c90c3adec9607f4ef378fd533
Author: lazyboy <lazyboy@chromium.org>
Date: Wed Sep 07 21:28:59 2016

Remove most ScopedVector usage from c/b/extensions.

Replace them with vector<unique_ptr<T>>.

After this CL there will be only 3 places where ScopedVector
would still be around. Since those (language_settings_private_delegate.cc,
web_navigation_apitest.cc and chrome_content_browser_client_extensions_part.cc)
are non-trivial, I will try to remove ScopedVector from them in subsequent CLs.

BUG= 556939 
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2310683002
Cr-Commit-Position: refs/heads/master@{#417042}

[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/chromeos/customization/customization_document_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/gcd_private/privet_v3_session.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/gcd_private/privet_v3_session.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/storage/setting_sync_data.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/storage/syncable_settings_storage.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/tab_capture/offscreen_tab.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/extension_management.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/extension_management.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/extension_service.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/external_policy_loader_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/external_provider_impl.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/external_provider_impl.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/chrome/browser/extensions/window_open_apitest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/components/sync/device_info/device_count_metrics_provider_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/components/sync/device_info/device_info_service.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/components/sync/device_info/device_info_service.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/components/sync/device_info/device_info_service_unittest.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/components/sync/device_info/device_info_sync_service.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/components/sync/device_info/device_info_sync_service.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/components/sync/device_info/device_info_tracker.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/extensions/browser/external_provider_interface.h
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/extensions/browser/management_policy.cc
[modify] https://crrev.com/4aeef2005e69892c90c3adec9607f4ef378fd533/extensions/browser/management_policy.h

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b89260d9065dd236703f46cb7b7ba7dd4a642709

commit b89260d9065dd236703f46cb7b7ba7dd4a642709
Author: avi <avi@chromium.org>
Date: Mon Oct 03 17:04:35 2016

Remove stl_util's deletion functions from net/udp/.

BUG= 555865 ,  556939 

Review-Url: https://codereview.chromium.org/2387923002
Cr-Commit-Position: refs/heads/master@{#422440}

[modify] https://crrev.com/b89260d9065dd236703f46cb7b7ba7dd4a642709/net/udp/udp_socket_unittest.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7cd11a992b871c29e005a67697dc6f3fbb6db77

commit e7cd11a992b871c29e005a67697dc6f3fbb6db77
Author: avi <avi@chromium.org>
Date: Tue Oct 11 02:00:35 2016

Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG= 555865 ,  556939 

Review-Url: https://codereview.chromium.org/2383393002
Cr-Commit-Position: refs/heads/master@{#424338}

[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/content/browser/net/quota_policy_cookie_store.h
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/content/browser/net/quota_policy_cookie_store_unittest.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/cookies/cookie_monster.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/cookies/cookie_monster.h
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/cookies/cookie_monster_perftest.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/cookies/cookie_monster_store_test.h
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
[modify] https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 21 2016

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8

commit 8fc2d0b9f0705710151612e0a4af42fe85ec2ce8
Author: limasdf <limasdf@gmail.com>
Date: Sun Nov 06 04:54:25 2016

Remove some linked_ptr c/b/extension

Use std::unique_ptr instead of deprecated linked_ptr.

BUG= 556939 

Review-Url: https://codereview.chromium.org/2466523002
Cr-Commit-Position: refs/heads/master@{#430184}

[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/mdns/dns_sd_registry.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/mdns/dns_sd_registry.h
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/platform_keys/verify_trust_api.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/settings_private/settings_private_event_router.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/settings_private/settings_private_event_router.h
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/storage/managed_value_store_cache.h
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/storage/sync_storage_backend.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/storage/sync_storage_backend.h
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/streams_private/streams_private_api.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/api/streams_private/streams_private_api.h
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/extension_action_manager.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/extension_action_manager.h
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/install_verifier.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/install_verifier.h
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/location_bar_controller.cc
[modify] https://crrev.com/8fc2d0b9f0705710151612e0a4af42fe85ec2ce8/chrome/browser/extensions/location_bar_controller.h

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8374a2aa576bd914fb2ebcf61b886ac88d129557

commit 8374a2aa576bd914fb2ebcf61b886ac88d129557
Author: lazyboy <lazyboy@chromium.org>
Date: Fri Nov 25 15:59:27 2016

Remove unused linked_ptr include in extension.h

Seems BackgroundModeData was depending on it transitively, add explicit
include there instead.

BUG= 556939 
Test=None

Review-Url: https://codereview.chromium.org/2499803002
Cr-Commit-Position: refs/heads/master@{#434512}

[modify] https://crrev.com/8374a2aa576bd914fb2ebcf61b886ac88d129557/chrome/browser/background/background_mode_manager.h
[modify] https://crrev.com/8374a2aa576bd914fb2ebcf61b886ac88d129557/extensions/common/extension.h

Project Member

Comment 35 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/090622c5da065ed0fa7c4db26719b7eb58198377

commit 090622c5da065ed0fa7c4db26719b7eb58198377
Author: ratsunny <ratsunny@gmail.com>
Date: Fri Dec 09 13:38:28 2016

Remove unused linked_ptr inclusion

TBR=jam@chromium.org
BUG= 556939 

Review-Url: https://codereview.chromium.org/2546183004
Cr-Commit-Position: refs/heads/master@{#437526}

[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/browser/browsing_data/local_data_container.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/browser/safe_browsing/client_side_model_loader.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/browser/safe_browsing/threat_details_history.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/renderer/media/cast_session_delegate.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/test/base/chrome_test_launcher.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/chrome/test/chromedriver/session_commands_unittest.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/components/guest_view/renderer/guest_view_container_dispatcher.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/components/login/screens/screen_context.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/components/signin/core/browser/about_signin_internals.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/components/sync/engine_impl/sync_scheduler_impl.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/extensions/browser/api/declarative_webrequest/webrequest_condition.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/net/cookies/cookie_monster.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/ui/app_list/views/contents_view.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/ui/events/gestures/gesture_recognizer_impl.h
[modify] https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377/ui/wm/core/shadow_controller.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd5087e031d189ae2292b7cd05d846961ae086a5

commit bd5087e031d189ae2292b7cd05d846961ae086a5
Author: ratsunny <ratsunny@gmail.com>
Date: Sat Dec 17 05:19:25 2016

Also made change to LayerAnimationSequence, replace raw pointer
with unique_ptr to stress ownership transfer behavior.

And replace linked_ptr with unique_ptr in LayerAnimationSequence.

BUG= 556939 

Review-Url: https://codereview.chromium.org/2550933002
Cr-Commit-Position: refs/heads/master@{#439326}

[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ash/rotator/screen_rotation_animation.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ash/rotator/screen_rotation_animation_unittest.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ash/rotator/window_rotation.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ash/wm/session_state_animator_impl.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ash/wm/window_animations.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/app_list/views/pulsing_block_view.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_animation_element.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_animation_element.h
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_animation_element_unittest.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_animation_sequence.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_animation_sequence.h
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_animator.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_animator_unittest.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/gfx/interpolated_transform.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/gfx/interpolated_transform.h
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/gfx/interpolated_transform_unittest.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/views/animation/flood_fill_ink_drop_ripple.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/views/animation/ink_drop_highlight.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/views/animation/square_ink_drop_ripple.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/wm/core/window_animations.cc
[modify] https://crrev.com/bd5087e031d189ae2292b7cd05d846961ae086a5/ui/wm/core/window_animations_unittest.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beeae20314c0be11c05e181e94120ff12e320676

commit beeae20314c0be11c05e181e94120ff12e320676
Author: avi <avi@chromium.org>
Date: Tue Dec 20 16:02:57 2016

Remove Autofill's ContainsNonNullEntryForNonNullKey.

Its last caller was removed in r306479.

BUG= 556939 

Review-Url: https://codereview.chromium.org/2586413002
Cr-Commit-Position: refs/heads/master@{#439814}

[modify] https://crrev.com/beeae20314c0be11c05e181e94120ff12e320676/components/autofill/content/renderer/password_autofill_agent.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad900d319365284907e63f8a416030e362012c55

commit ad900d319365284907e63f8a416030e362012c55
Author: digit <digit@chromium.org>
Date: Mon Feb 13 20:41:07 2017

ipc: Use std::unique_ptr instead of linked_ptr

BUG= 556939 

Review-Url: https://codereview.chromium.org/2687323002
Cr-Commit-Position: refs/heads/master@{#450069}

[modify] https://crrev.com/ad900d319365284907e63f8a416030e362012c55/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/ad900d319365284907e63f8a416030e362012c55/ipc/ipc_channel_nacl.h

Project Member

Comment 41 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/636f441be350ec76e73b4e4f407bf8a7e86984fd

commit 636f441be350ec76e73b4e4f407bf8a7e86984fd
Author: hajimehoshi <hajimehoshi@chromium.org>
Date: Mon Feb 27 01:16:25 2017

Revert of Some linked_ptr removal in chromeos file_browser_handler. (patchset #5 id:80001 of https://codereview.chromium.org/2707193005/ )

Reason for revert:
This might be the cause of crash: crbug/696375

Original issue's description:
> Some linked_ptr removal in chromeos file_browser_handler.
>
> BUG= 556939 
>
> Review-Url: https://codereview.chromium.org/2707193005
> Cr-Commit-Position: refs/heads/master@{#453064}
> Committed: https://chromium.googlesource.com/chromium/src/+/37ab3be841440d4ec5abf1160acf32c905796d13

TBR=hirono@chromium.org,lazyboy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 556939 

Review-Url: https://codereview.chromium.org/2717213002
Cr-Commit-Position: refs/heads/master@{#453134}

[modify] https://crrev.com/636f441be350ec76e73b4e4f407bf8a7e86984fd/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/636f441be350ec76e73b4e4f407bf8a7e86984fd/chrome/browser/chromeos/extensions/file_manager/job_event_router.cc
[modify] https://crrev.com/636f441be350ec76e73b4e4f407bf8a7e86984fd/chrome/browser/chromeos/extensions/file_manager/job_event_router.h
[modify] https://crrev.com/636f441be350ec76e73b4e4f407bf8a7e86984fd/chrome/browser/chromeos/extensions/file_manager/job_event_router_unittest.cc
[modify] https://crrev.com/636f441be350ec76e73b4e4f407bf8a7e86984fd/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/636f441be350ec76e73b4e4f407bf8a7e86984fd/chrome/browser/chromeos/file_manager/volume_manager.h

Project Member

Comment 44 by bugdroid1@chromium.org, Mar 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926

commit a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926
Author: lazyboy <lazyboy@chromium.org>
Date: Sat Mar 04 01:32:38 2017

[Reland] Some linked_ptr removal in chromeos file_browser_handler.

Original CL: https://chromium.googlesource.com/chromium/src/+/37ab3be841440d4ec5abf1160acf32c905796d13
was reverted due to unit_tests failure on chromeos debug bots.
There was an ownership issue in volume_manager.cc which this
CL fixes.

BUG= 556939 , 696375
Test=No visible changes. Ran VolumeManagerTest.* in debug, which passes now.

Review-Url: https://codereview.chromium.org/2723753002
Cr-Commit-Position: refs/heads/master@{#454742}

[modify] https://crrev.com/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926/chrome/browser/chromeos/extensions/file_manager/job_event_router.cc
[modify] https://crrev.com/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926/chrome/browser/chromeos/extensions/file_manager/job_event_router.h
[modify] https://crrev.com/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926/chrome/browser/chromeos/extensions/file_manager/job_event_router_unittest.cc
[modify] https://crrev.com/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926/chrome/browser/chromeos/file_manager/volume_manager.h

Project Member

Comment 45 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fea9fd0d6465f685327f5a9dc9a4112ca0b773c

commit 9fea9fd0d6465f685327f5a9dc9a4112ca0b773c
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Fri Jul 21 01:29:41 2017

Remove linked_ptr from c/b/ui/webui

Use std::unique_ptr instead of deprecated linked_ptr.

BUG= 556939 

Change-Id: I656bb98d38e4c72983d886742fab8b0f9164a454
Reviewed-on: https://chromium-review.googlesource.com/578655
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#488537}
[modify] https://crrev.com/9fea9fd0d6465f685327f5a9dc9a4112ca0b773c/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
[modify] https://crrev.com/9fea9fd0d6465f685327f5a9dc9a4112ca0b773c/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

Project Member

Comment 46 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25fb50f66c4c56bd787745ab9e74a9aac7f5f4d

commit e25fb50f66c4c56bd787745ab9e74a9aac7f5f4d
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Fri Jul 21 05:15:58 2017

Remove linked_ptr from c/b/media_galleries

Use std::unique_ptr instead of deprecated linked_ptr.

BUG= 556939 

Change-Id: Icf51f7747b2467afe7ffe3995cd7d4e749b31e11
Reviewed-on: https://chromium-review.googlesource.com/578302
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488587}
[modify] https://crrev.com/e25fb50f66c4c56bd787745ab9e74a9aac7f5f4d/chrome/browser/media_galleries/gallery_watch_manager.cc
[modify] https://crrev.com/e25fb50f66c4c56bd787745ab9e74a9aac7f5f4d/chrome/browser/media_galleries/gallery_watch_manager.h

Project Member

Comment 47 by bugdroid1@chromium.org, Jul 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3abb78dc7ca88b9bd08671b263a9df75c6cc21e5

commit 3abb78dc7ca88b9bd08671b263a9df75c6cc21e5
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Sun Jul 23 04:48:52 2017

Cleanup linked_ptr -> unique_ptr from profile_manager.h/cc

linked_ptr is deprecated, see bug.

BUG= 556939 

Change-Id: I2d4812a93ab40009eb4971e4863da529862e898d
Reviewed-on: https://chromium-review.googlesource.com/578582
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488878}
[modify] https://crrev.com/3abb78dc7ca88b9bd08671b263a9df75c6cc21e5/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/3abb78dc7ca88b9bd08671b263a9df75c6cc21e5/chrome/browser/profiles/profile_manager.h

Comment 48 by a...@chromium.org, Jul 29 2017

Blockedon: 582001
Project Member

Comment 49 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55d119cd0e7000b55eff7c898b096268d0555985

commit 55d119cd0e7000b55eff7c898b096268d0555985
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Oct 11 02:34:55 2017

Remove linked_ptr from HidReportDescriptor

This type is deprecated and easily replaced by std::unique_ptr.

Bug:  556939 
Change-Id: I874bfdd9caf6366e0a9a119367d5e00ad9c2152f
Reviewed-on: https://chromium-review.googlesource.com/711214
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507863}
[modify] https://crrev.com/55d119cd0e7000b55eff7c898b096268d0555985/device/hid/hid_report_descriptor.cc
[modify] https://crrev.com/55d119cd0e7000b55eff7c898b096268d0555985/device/hid/hid_report_descriptor.h

Project Member

Comment 50 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c153d786cfd11fddd3fb6c780eb3e55a874589b9

commit c153d786cfd11fddd3fb6c780eb3e55a874589b9
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Nov 21 04:33:51 2017

vavda use InputBuffer and VaapiPicture as unique_ptr

This CL teaches vaapi files to treat InputBuffers and VaapiPictures
as move-only unique_ptr, and not as linked_ptr: the latter is been
deprecated now that we have move-only support in STL containers [1].

Only actual code change is in VaVDA::AssignPictureBuffers() where
 picture->Allocate()
is moved to before
 pictures_.insert(..std::move(picture)...).

[1] https://cs.chromium.org/chromium/src/base/memory/linked_ptr.h?type=cs&sq=package:chromium&l=72

Bug: 717265,  556939 

TEST=compiled-run chrome and vda unittests [2] on soraka.
Things working as on ToT, no regression in the produced
values observed.

[2] /tmp/video_decode_accelerator_unittest --test_video_data=test-25fps.vp9:320:240:250:250:35:150:12

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5e2840a22ec961a437405f43d83207301d5a95bc
Reviewed-on: https://chromium-review.googlesource.com/775815
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518113}
[modify] https://crrev.com/c153d786cfd11fddd3fb6c780eb3e55a874589b9/media/gpu/vaapi/vaapi_drm_picture.cc
[modify] https://crrev.com/c153d786cfd11fddd3fb6c780eb3e55a874589b9/media/gpu/vaapi/vaapi_picture.h
[modify] https://crrev.com/c153d786cfd11fddd3fb6c780eb3e55a874589b9/media/gpu/vaapi/vaapi_tfp_picture.cc
[modify] https://crrev.com/c153d786cfd11fddd3fb6c780eb3e55a874589b9/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/c153d786cfd11fddd3fb6c780eb3e55a874589b9/media/gpu/vaapi_video_decode_accelerator.h
[modify] https://crrev.com/c153d786cfd11fddd3fb6c780eb3e55a874589b9/media/gpu/vaapi_video_decode_accelerator_unittest.cc

Project Member

Comment 51 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b443aed30f565fd7e136777cddd2abfe70df24

commit e1b443aed30f565fd7e136777cddd2abfe70df24
Author: Wez <wez@chromium.org>
Date: Wed Apr 04 17:06:18 2018

Migrate ProtocolHandlerMap from linked_ptr<> to unique_ptr<>.

Also migrates //headless from its own unique_ptr<> based ProtocolHandler
map to use content::ProtocolHandlerMap.

Bug:  556939 
Change-Id: I4ceea7f048542da1dd7a1f4a68d6ab91f75ff813
Reviewed-on: https://chromium-review.googlesource.com/989397
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548102}
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.h
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/content/public/browser/browser_context.h
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/extensions/shell/browser/shell_browser_context.cc
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/headless/public/headless_browser_context.h
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/storage/browser/fileapi/file_system_url_request_job_factory.cc
[modify] https://crrev.com/e1b443aed30f565fd7e136777cddd2abfe70df24/storage/browser/fileapi/file_system_url_request_job_factory.h

Project Member

Comment 52 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35d56183a7f8a7ec06193500426aa548b0c5dedd

commit 35d56183a7f8a7ec06193500426aa548b0c5dedd
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Mon Apr 23 23:27:11 2018

Some linked_ptr removal from web_request_api_helpers.cc

linked_ptr is long deprecated, used unique_ptr instead.


Bug:  556939 
Change-Id: Ibfd38af13cd5646265bdfa4570e6e30c05db1ab2
Reviewed-on: https://chromium-review.googlesource.com/1020521
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552894}
[modify] https://crrev.com/35d56183a7f8a7ec06193500426aa548b0c5dedd/extensions/browser/api/web_request/web_request_api_helpers.cc

Project Member

Comment 53 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6efea56e28e3863e09a9267de68ebd3da3fcb8b

commit b6efea56e28e3863e09a9267de68ebd3da3fcb8b
Author: Sungguk Lim <limasdf@gmail.com>
Date: Wed May 02 04:00:16 2018

Remove linked_ptr from components/policy/*

Use std::unique_ptr instead of deprecated linked_ptr

Bug:  556939 
Change-Id: Iefb3dcb3ae891fe4b0fd0dd70be408517bcd9d85
Reviewed-on: https://chromium-review.googlesource.com/1034942
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sungguk Lim <limasdf@gmail.com>
Cr-Commit-Position: refs/heads/master@{#555303}
[modify] https://crrev.com/b6efea56e28e3863e09a9267de68ebd3da3fcb8b/components/policy/core/common/remote_commands/remote_commands_queue.cc
[modify] https://crrev.com/b6efea56e28e3863e09a9267de68ebd3da3fcb8b/components/policy/core/common/remote_commands/remote_commands_queue.h

Project Member

Comment 54 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/187d0e4e6fb79c924c6e1ffe19fb8290087f1da3

commit 187d0e4e6fb79c924c6e1ffe19fb8290087f1da3
Author: Sungguk Lim <limasdf@gmail.com>
Date: Fri May 04 09:50:20 2018

Remove linked_ptr from component/syncs/base

Use std::unique_ptr instead of deprecated linked_ptr

Bug:  556939 
Change-Id: Ifb89741b5815b388961a67aebf6d1f7cf07d7b7d
Reviewed-on: https://chromium-review.googlesource.com/1040325
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Sungguk Lim <limasdf@gmail.com>
Cr-Commit-Position: refs/heads/master@{#556019}
[modify] https://crrev.com/187d0e4e6fb79c924c6e1ffe19fb8290087f1da3/components/sync/base/cryptographer.cc
[modify] https://crrev.com/187d0e4e6fb79c924c6e1ffe19fb8290087f1da3/components/sync/base/cryptographer.h
[modify] https://crrev.com/187d0e4e6fb79c924c6e1ffe19fb8290087f1da3/components/sync/engine/engine_util.cc

Project Member

Comment 55 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e512a53512ef53c47dce97147801dbf0abedbd8

commit 7e512a53512ef53c47dce97147801dbf0abedbd8
Author: Lei Zhang <thestig@chromium.org>
Date: Thu May 17 04:44:14 2018

Make LauncherSearchIconImageLoader ref counted.

Get rid of deprecated linked_ptr usage. Use RefCounted because the
object has shared ownership.

BUG= 556939 

Change-Id: Iab75d2a4cf834227764d4ac1888e3efa690b2ce2
Reviewed-on: https://chromium-review.googlesource.com/1053992
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559422}
[modify] https://crrev.com/7e512a53512ef53c47dce97147801dbf0abedbd8/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader.h
[modify] https://crrev.com/7e512a53512ef53c47dce97147801dbf0abedbd8/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_impl.cc
[modify] https://crrev.com/7e512a53512ef53c47dce97147801dbf0abedbd8/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_impl.h
[modify] https://crrev.com/7e512a53512ef53c47dce97147801dbf0abedbd8/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/7e512a53512ef53c47dce97147801dbf0abedbd8/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc
[modify] https://crrev.com/7e512a53512ef53c47dce97147801dbf0abedbd8/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.h

Project Member

Comment 56 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe58d1a30355efe4ee7247a639f72ee724b65a53

commit fe58d1a30355efe4ee7247a639f72ee724b65a53
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Jun 21 23:31:10 2018

Get rid of link_ptr usage in BackgroundModeManager.

BUG= 556939 

Change-Id: I96e2fc6f76cfb85e9dac760ab77e93b9a6a7a10e
Reviewed-on: https://chromium-review.googlesource.com/1053274
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569449}
[modify] https://crrev.com/fe58d1a30355efe4ee7247a639f72ee724b65a53/chrome/browser/background/background_mode_manager.cc
[modify] https://crrev.com/fe58d1a30355efe4ee7247a639f72ee724b65a53/chrome/browser/background/background_mode_manager.h

Project Member

Comment 57 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abb887f1fe0523ed4ab633530a3a55fd3e479731

commit abb887f1fe0523ed4ab633530a3a55fd3e479731
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Thu Jul 12 16:59:51 2018

[Extensions] Remove linked_ptr usage from extension_messages.cc

This CL also makes ExtensionMsg_Load_Params non-copyable. There
shouldn't be any behavior change in this CL.

Bug:  556939 
Change-Id: If7d11919f8fee0442578371d44d6b715d08efe3a
Reviewed-on: https://chromium-review.googlesource.com/1132572
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574606}
[modify] https://crrev.com/abb887f1fe0523ed4ab633530a3a55fd3e479731/extensions/browser/renderer_startup_helper.cc
[modify] https://crrev.com/abb887f1fe0523ed4ab633530a3a55fd3e479731/extensions/common/extension_messages.cc
[modify] https://crrev.com/abb887f1fe0523ed4ab633530a3a55fd3e479731/extensions/common/extension_messages.h
[modify] https://crrev.com/abb887f1fe0523ed4ab633530a3a55fd3e479731/extensions/common/extension_messages_unittest.cc

Blockedon: 910591
Project Member

Comment 59 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a

commit eb740f109b981723ce5dbbcee507d0f5e6c8bd1a
Author: Avi Drissman <avi@chromium.org>
Date: Fri Nov 30 22:50:21 2018

Remove linked_ptr from media/.

BUG= 556939 

Change-Id: I66fe86602ab965622b1db26e5468f8d596c851e9
Reviewed-on: https://chromium-review.googlesource.com/c/1356867
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612827}
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/base/audio_shifter.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/base/audio_shifter.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/blink/multibuffer_data_source.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/logging/log_deserializer.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/logging/log_deserializer.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/logging/raw_event_subscriber_bundle.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/logging/raw_event_subscriber_bundle.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/logging/stats_event_subscriber.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/logging/stats_event_subscriber.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/test/utility/udp_proxy.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/cast/test/utility/udp_proxy.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/v4l2/v4l2_jpeg_decode_accelerator.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/v4l2/v4l2_jpeg_decode_accelerator.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/vt_video_decode_accelerator_mac.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/windows/dxva_picture_buffer_win.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/windows/dxva_picture_buffer_win.h
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/windows/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/eb740f109b981723ce5dbbcee507d0f5e6c8bd1a/media/gpu/windows/dxva_video_decode_accelerator_win.h

Blockedon: 910779
Project Member

Comment 62 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebcb3137a889825ae0cb670ccc9c044209e12b1e

commit ebcb3137a889825ae0cb670ccc9c044209e12b1e
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 03 16:18:11 2018

Remove linked_ptr from chrome/browser/ui/.

BUG= 556939 

Change-Id: I0bb5e64f47203e3f71f0bf8eef8eaa6c449ad7b0
Reviewed-on: https://chromium-review.googlesource.com/c/1357552
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613111}
[modify] https://crrev.com/ebcb3137a889825ae0cb670ccc9c044209e12b1e/chrome/browser/ui/hung_plugin_tab_helper.cc
[modify] https://crrev.com/ebcb3137a889825ae0cb670ccc9c044209e12b1e/chrome/browser/ui/hung_plugin_tab_helper.h

:clap: so nice to see this keep moving
Cc: danakj@chromium.org bauerb@chromium.org
 Issue 137767  has been merged into this issue.
Blockedon: 913604
Blockedon: 914401
Blockedon: 914453
Blockedon: -914453
Project Member

Comment 74 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912ce72500fd38d25f770b89390888efd39e4bda

commit 912ce72500fd38d25f770b89390888efd39e4bda
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 17 17:58:42 2018

Remove linked_ptr from sync_sessions.

BUG= 556939 

Change-Id: I6c0b8e066b315e0b80160c3b4b5d4912be8bf62b
Reviewed-on: https://chromium-review.googlesource.com/c/1378580
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617153}
[modify] https://crrev.com/912ce72500fd38d25f770b89390888efd39e4bda/components/sync_sessions/favicon_cache.cc
[modify] https://crrev.com/912ce72500fd38d25f770b89390888efd39e4bda/components/sync_sessions/favicon_cache.h

Project Member

Comment 75 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3

commit ddb92bdd44ce9dcbad4769ab4b90ec53940518a3
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 17 19:04:43 2018

Remove linked_ptr from random bits of Chromium.

BUG= 556939 

Change-Id: I2520b0313a1ec5d180a5ec15a2883b338c640c2e
Reviewed-on: https://chromium-review.googlesource.com/c/1379117
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617176}
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/chrome/browser/vr/service/xr_runtime_manager_unittest.cc
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/chrome/tools/service_discovery_sniffer/service_discovery_sniffer.h
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/ios/chrome/browser/browser_state/chrome_browser_state.h
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/ios/chrome/browser/browser_state/chrome_browser_state.mm
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/ios/chrome/browser/net/net_types.h
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/media/gpu/v4l2/v4l2_jpeg_encode_accelerator.h
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/tools/android/forwarder2/device_controller.cc
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/tools/android/forwarder2/device_controller.h
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/tools/android/forwarder2/host_controllers_manager.cc
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/tools/android/forwarder2/host_controllers_manager.h
[modify] https://crrev.com/ddb92bdd44ce9dcbad4769ab4b90ec53940518a3/tools/android/forwarder2/util.h

Project Member

Comment 76 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff72781b2bd10a9d23950748d42b9e1b538b8ab6

commit ff72781b2bd10a9d23950748d42b9e1b538b8ab6
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 18 17:08:08 2018

Remove linked_ptr from sync.

BUG= 556939 

Change-Id: I5844f49797be8fcf79bf5ff7e848f164ff5ec9a3
Reviewed-on: https://chromium-review.googlesource.com/c/1379267
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617539}
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/driver/generic_change_processor.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/engine/engine_util.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/engine/engine_util.h
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/engine_impl/js_mutation_event_observer_unittest.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/syncable/base_node.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/syncable/change_record.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/syncable/change_record.h
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/syncable/change_record_unittest.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/syncable/change_reorder_buffer.cc
[modify] https://crrev.com/ff72781b2bd10a9d23950748d42b9e1b538b8ab6/components/sync/syncable/change_reorder_buffer.h

Project Member

Comment 77 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c81c4ea7dd504df864602f92929bbf1764455e4a

commit c81c4ea7dd504df864602f92929bbf1764455e4a
Author: Avi Drissman <avi@chromium.org>
Date: Thu Dec 20 18:58:16 2018

Remove linked_ptr from content settings.

BUG= 556939 

Change-Id: Ib4d1da45ba37cf8b1886a61ccd551e2eafc1b351
Reviewed-on: https://chromium-review.googlesource.com/c/1377523
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618282}
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/chrome/browser/notifications/notification_channels_provider_android.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/chrome/browser/notifications/notification_channels_provider_android_unittest.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_ephemeral_provider.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_ephemeral_provider_unittest.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_global_value_map.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_origin_identifier_value_map.h
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_policy_provider.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_pref.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_rule.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_rule.h
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/content_settings_rule_unittest.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/c81c4ea7dd504df864602f92929bbf1764455e4a/components/content_settings/core/test/content_settings_mock_provider.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf112e3243bb0b315ebc6a435f2cfba3edf4e6f

commit dcf112e3243bb0b315ebc6a435f2cfba3edf4e6f
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Dec 21 23:33:45 2018

[Extensions] Remove linked_ptr from web_request_api_unittest.cc

Remove a lingering linked_ptr usage.

Bug:  556939 
Change-Id: I45840cfce318214aa4598dd5124c5cf134794d29
Reviewed-on: https://chromium-review.googlesource.com/c/1388927
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618669}
[modify] https://crrev.com/dcf112e3243bb0b315ebc6a435f2cfba3edf4e6f/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Owner: a...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment