Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 16 users
Status: Fixed
Owner:
User never visited
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 120756

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
provide way to disable non-gallery extension installs
Project Member Reported by erikkay@chromium.org, Sep 14 2010 Back to list
Perhaps there should be a way for users or enterprises to disable extension installs from unknown sources.  By default the extension gallery would be allowed and users or enterprises could add other sources to a whitelist of trusted galleries.

 
Labels: Security
Labels: -Security
Labels: Feature-Enterprise Feature-Apps
See also  bug 73426  for the whitelist feature.
Owner: bolms@chromium.org
Status: Assigned
Labels: -mstone-x
Labels: Feature-Security
Comment 8 by aa@chromium.org, Mar 28 2012
Labels: Mstone-20
Owner: jhurwich@chromium.org
Comment 9 by aa@chromium.org, Mar 28 2012
This is getting to be a bigger and bigger problem. We really need to figure out the UI issues and get it done.
Comment 10 by aa@chromium.org, Mar 28 2012
Blocking: 120756
Comment 11 by aa@chromium.org, Apr 30 2012
Owner: aa@chromium.org
Status: Started
Project Member Comment 12 by bugdroid1@chromium.org, May 2 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=134980

------------------------------------------------------------------------
r134980 | aa@chromium.org | Wed May 02 13:24:50 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.cc?r1=134980&r2=134979&pathrev=134980
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.cc?r1=134980&r2=134979&pathrev=134980
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=134980&r2=134979&pathrev=134980
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.h?r1=134980&r2=134979&pathrev=134980
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_common.gypi?r1=134980&r2=134979&pathrev=134980
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.h?r1=134980&r2=134979&pathrev=134980
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=134980&r2=134979&pathrev=134980
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=134980&r2=134979&pathrev=134980
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.cc?r1=134980&r2=134979&pathrev=134980

Add the --disable-off-store-extension-install switch.

Subsequent changes will add a first-class UI in chrome://extensions/
to meet this use case.

BUG= 55584 

Review URL: https://chromiumcodereview.appspot.com/10266015
------------------------------------------------------------------------
Project Member Comment 13 by bugdroid1@chromium.org, May 5 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=135525

------------------------------------------------------------------------
r135525 | aa@chromium.org | Fri May 04 20:11:41 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_gtk.h?r1=135525&r2=135524&pathrev=135525
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.h?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_drag_dest_gtk.h?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.css?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_view.h?r1=135525&r2=135524&pathrev=135525
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.cc?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_gtk.cc?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.js?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_web_contents_view.cc?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_web_contents_view.h?r1=135525&r2=135524&pathrev=135525
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extensions_ui.cc?r1=135525&r2=135524&pathrev=135525

Add a first-class off-store install UI to chrome://extensions/.

This patch implements GTK only. Other ports will be separate CLs.

BUG= 55584 

Review URL: https://chromiumcodereview.appspot.com/10270031
------------------------------------------------------------------------
Project Member Comment 14 by bugdroid1@chromium.org, May 5 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=135528

------------------------------------------------------------------------
r135528 | aa@chromium.org | Fri May 04 20:25:28 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_gtk.h?r1=135528&r2=135527&pathrev=135528
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.h?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_drag_dest_gtk.h?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.css?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_view.h?r1=135528&r2=135527&pathrev=135528
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.cc?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_gtk.cc?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.js?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_web_contents_view.cc?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_web_contents_view.h?r1=135528&r2=135527&pathrev=135528
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extensions_ui.cc?r1=135528&r2=135527&pathrev=135528

Revert 135525 - Add a first-class off-store install UI to chrome://extensions/.

This patch implements GTK only. Other ports will be separate CLs.

BUG= 55584 

Review URL: https://chromiumcodereview.appspot.com/10270031

TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382025
------------------------------------------------------------------------
Project Member Comment 15 by bugdroid1@chromium.org, May 5 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=135557

------------------------------------------------------------------------
r135557 | aa@chromium.org | Sat May 05 14:13:13 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_gtk.h?r1=135557&r2=135556&pathrev=135557
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.h?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_drag_dest_gtk.h?r1=135557&r2=135556&pathrev=135557
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.cc?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_gtk.cc?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_win.cc?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_web_contents_view.cc?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extensions_ui.cc?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_mac.h?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_android.h?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_aura.cc?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.css?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_aura.h?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_view.h?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_android.cc?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_mac.mm?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.js?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.html?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_win.h?r1=135557&r2=135556&pathrev=135557
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_web_contents_view.h?r1=135557&r2=135556&pathrev=135557

Reland 135525 - Add a first-class off-store install UI to chrome://extensions/.

BUG= 55584 
TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10378026
------------------------------------------------------------------------
Labels: -Mstone-20 Mstone-21 MovedFrom-20
M20 is about to sail. If this still need to be part of M20, put them back and add release block label.
Project Member Comment 19 by bugdroid1@chromium.org, May 16 2012
Blocking: -120756 chromium:120756
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=137540

------------------------------------------------------------------------
r137540 | aa@chromium.org | Wed May 16 15:21:55 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.h?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.h?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/bundle_installer.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_constants.h?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer_browsertest.cc?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.h?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=137540&r2=137539&pathrev=137540
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.cc?r1=137540&r2=137539&pathrev=137540

Disable off-store extension installs by default. Also get rid of ExtensionService::IsDownloadFromGallery.

BUG= 55584 

Review URL: https://chromiumcodereview.appspot.com/10356052
------------------------------------------------------------------------
Project Member Comment 20 by bugdroid1@chromium.org, May 17 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=137575

------------------------------------------------------------------------
r137575 | aa@chromium.org | Wed May 16 17:16:37 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.h?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.h?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/bundle_installer.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_constants.h?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer_browsertest.cc?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.h?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=137575&r2=137574&pathrev=137575
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.cc?r1=137575&r2=137574&pathrev=137575

Revert 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::IsDownloadFromGallery.

BUG= 55584 

Review URL: https://chromiumcodereview.appspot.com/10356052

TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10387167
------------------------------------------------------------------------
Comment 21 by aa@chromium.org, May 17 2012
This broke a pyauto test:

[ RUN        ] downloads.DownloadsTest.testDownloadTheme: "Verify downloading and saving a theme file installs the theme."
[12726:12726:2308430173030:ERROR:gl_surface_glx.cc(65)] GLX 1.3 or later is required.
[12726:12726:2308430173158:ERROR:gl_surface_linux.cc(55)] GLSurfaceGLX::InitializeOneOff failed.
2012-05-16 15:52:14,576 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
2012-05-16 15:52:19,608 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
2012-05-16 15:52:24,641 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
2012-05-16 15:52:29,674 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
2012-05-16 15:52:34,704 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
2012-05-16 15:52:39,736 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
2012-05-16 15:52:44,768 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
2012-05-16 15:52:49,549 DEBUG    WaitUntil(pyauto.py:2777 _ReturnThemeSet()) still waiting. Expecting True. Last returned {}.
[     FAILED ] downloads.DownloadsTest.testDownloadTheme
Project Member Comment 22 by bugdroid1@chromium.org, May 17 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=137699

------------------------------------------------------------------------
r137699 | aa@chromium.org | Thu May 17 11:47:09 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.h?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.h?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/bundle_installer.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_constants.h?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer_browsertest.cc?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/downloads.py?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.h?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=137699&r2=137698&pathrev=137699
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.cc?r1=137699&r2=137698&pathrev=137699

Reland 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::IsDownloadFromGallery."

This removes a pyauto test that was failing. The test needs
to be different depending on whether a feature is on or off,
but there's currently no good way to test whether a feature
is enabled from pyauto.

BUG= 55584 
TBR=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10399069
------------------------------------------------------------------------
Please consider adding an option for off-store-install into chrome://flags.
Some users may not be familiar with startup switches.
Project Member Comment 24 by bugdroid1@chromium.org, May 23 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=138624

------------------------------------------------------------------------
r138624 | aa@chromium.org | Wed May 23 15:26:20 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.cc?r1=138624&r2=138623&pathrev=138624

Re-enable off-store installation temporarily.

I want to work on the UI some more.

BUG= 55584 
TBR=yoz@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10427002
------------------------------------------------------------------------
Project Member Comment 25 by bugdroid1@chromium.org, May 27 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=139217

------------------------------------------------------------------------
r139217 | aa@chromium.org | Sun May 27 11:06:22 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.h?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui.h?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui_browsertest.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.h?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobars_browsertest.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/downloads_dom_handler.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_history.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_item_model.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc?r1=139217&r2=139216&pathrev=139217
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.cc?r1=139217&r2=139216&pathrev=139217

Improve the UI for disabling off-store extension install.

Move the check later into install so that:

1) The download bar goes away.
2) There's an error message.
3) The same thing happens when double-clicking a crx, on systems that associate crx with Chrome.

Also, made themes exempt from this policy since there is no danger in installing a theme. This left themes with a dangerous download bar that said 'Installing extensions, themes, and apps can harm your computer', which isn't even true for themes. It was only there to protect against clickjacking. Removed that and replaced with standard install dialog.

Had to update a bunch of strings.

BUG= 55584 
TEST=Run chrome with --enable-off-store-extension-install=0, navigate to a crx file. Should see error dialog.
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10452009
------------------------------------------------------------------------
Project Member Comment 27 by bugdroid1@chromium.org, May 30 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=139640

------------------------------------------------------------------------
r139640 | aa@chromium.org | Wed May 30 14:47:10 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.cc?r1=139640&r2=139639&pathrev=139640
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions/extensions.js?r1=139640&r2=139639&pathrev=139640

Allow user script install by dragging onto chrome://extensions/.

Because otherwise, when off-store extension install is disabled,
there is no way to install user scripts.

BUG= 55584 
TEST=Run chrome with --enable-off-store-extension-install=0, navigate to a .user.js file. Should see error. Now download that file and drag onto chrome://extensions/. Should be offered a drop target, and install should proceed when dropped.

Review URL: https://chromiumcodereview.appspot.com/10449008
------------------------------------------------------------------------
Project Member Comment 28 by bugdroid1@chromium.org, May 30 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=139641

------------------------------------------------------------------------
r139641 | aa@chromium.org | Wed May 30 14:47:47 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=139641&r2=139640&pathrev=139641

Add histogram for off-store installation disallowed.

BUG= 55584 

Review URL: https://chromiumcodereview.appspot.com/10448040
------------------------------------------------------------------------
Project Member Comment 30 by bugdroid1@chromium.org, Jun 5 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=140569

------------------------------------------------------------------------
r140569 | aa@chromium.org | Tue Jun 05 11:46:25 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer_browsertest.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_switch_utils.h?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=140569&r2=140568&pathrev=140569
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=140569&r2=140568&pathrev=140569

Rename --enable-off-store-extension-install to --enable-easy-off...

This is a more accurate name. Off store extension install is
still supported, just not as easily.

BUG= 55584 
TBR=jhawkins

Review URL: https://chromiumcodereview.appspot.com/10511015
------------------------------------------------------------------------
Project Member Comment 31 by bugdroid1@chromium.org, Jun 9 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141355

------------------------------------------------------------------------
r141355 | aa@chromium.org | Fri Jun 08 23:05:48 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/policy_test_cases.py?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/configuration_policy_handler_list.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/configuration_policy_handler.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer_browsertest.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/configuration_policy_handler_unittest.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/configuration_policy_handler.h?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.h?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.h?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/policy/policy_templates.json?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=141355&r2=141354&pathrev=141355
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.cc?r1=141355&r2=141354&pathrev=141355

Add a group policy controlling which sites can install extensions.

BUG= 55584 
TBR=jhawkins@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10542048
------------------------------------------------------------------------
Comment 32 by aa@chromium.org, Jun 12 2012
Status: Fixed
Project Member Comment 33 by bugdroid1@chromium.org, Jun 19 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142921

------------------------------------------------------------------------
r142921 | aa@chromium.org | Mon Jun 18 23:33:28 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui_default.cc?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=142921&r2=142920&pathrev=142921
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer_error.h?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.cc?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui_android.cc?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer_browsertest.cc?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.h?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui.h?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui_android.h?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui_default.h?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.h?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.cc?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser_extensions.gypi?r1=142921&r2=142920&pathrev=142921
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=142921&r2=142920&pathrev=142921

Use an infobar instead of alert box for extension install
error.

Also, setup the 'learn more' link for off-store install
failure, but don't enable yet as we don't quite have anything
to link to.

BUG= 55584 
TBR=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10559056
------------------------------------------------------------------------
Comment 34 by aa@chromium.org, Jun 19 2012
Labels: Merge-Requested
Status: Started
Merge request for just the last CL which barely missed the branch point.
Comment 35 by aa@chromium.org, Jun 19 2012
Labels: ReleaseBlock-Beta
Comment 36 by kareng@google.com, Jun 20 2012
Labels: -Merge-Requested Merge-Approved
Project Member Comment 37 by bugdroid1@chromium.org, Jun 20 2012
Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143213

------------------------------------------------------------------------
r143213 | aa@chromium.org | Wed Jun 20 11:42:09 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/crx_installer_browsertest.cc?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_install_ui.h?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_install_ui_android.h?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_install_ui_default.cc?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_install_prompt.h?r1=143213&r2=143212&pathrev=143213
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/crx_installer_error.h?r1=143213&r2=143212&pathrev=143213 (from /trunk/src/chrome/browser/extensions/crx_installer_error.h revision 142921)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_browsertest.cc?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_install_ui_android.cc?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_install_prompt.cc?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/extension_install_ui_default.h?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/crx_installer.h?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/chrome_browser_extensions.gypi?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/crx_installer.cc?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/download/download_browsertest.cc?r1=143213&r2=143212&pathrev=143213
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/generated_resources.grd?r1=143213&r2=143212&pathrev=143213

Merge 142921 - Use an infobar instead of alert box for extension install
error.

Also, setup the 'learn more' link for off-store install
failure, but don't enable yet as we don't quite have anything
to link to.

BUG= 55584 
TBR=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10559056

TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10581043
------------------------------------------------------------------------
Comment 38 by kareng@google.com, Jun 20 2012
Status: Fixed
closing.
Comment 39 by steng@google.com, Jun 25 2012
Blocking: chromium:120756
Project Member Comment 40 by bugdroid1@chromium.org, Oct 13 2012
Blocking: -chromium:120756
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 41 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Extensions -Feature-Enterprise -Feature-Apps -Feature-Security -Mstone-21 Cr-Platform-Extensions Cr-Platform-Apps Cr-Security Cr-UI M-21 Cr-Enterprise
Project Member Comment 42 by bugdroid1@chromium.org, Mar 14 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment