New issue
Advanced search Search tips

Issue 554590 link

Starred by 13 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 654679

Blocking:
issue 555090



Sign in to add a comment

Deprecate BlinkMacSystemFont meta name in favor of -apple-system

Project Member Reported by kenjibaheux@chromium.org, Nov 11 2015

Issue description

From John Dagget:

"Blink now supports a special font meta-name "BlinkMacSystemFont" for referring to the system font under OSX.
[...]
With OSX 10.11, Apple shipped system fonts that are "hidden" and are not intended to be looked up via the family name. Instead the OS supplies API's that explicitly provide system font objects. (e.g. [NSFont systemFontOfSize:]). For CSS, this means that browsers under OSX need to use some form of meta-name that signals "lookup the system font" rather than using the "hidden" name of the system font (e.g. ".SF NS Text").

Apple chose to use the meta name "-apple-system". Firefox has now implemented support for the same name. However, Blink is instead using "BlinkMacSystemFont". Since this name is specific to OSX and iOS rather than something that is user-agent specific, I'm wondering if it wouldn't make more sense to have Blink use "-apple-system" instead of using a Blink-specific meta name for the same functionality."

This seems reasonable.
We'll probably need to measure the usage of BlinkMacSystemFont without -apple-system to decide if it's safe to deprecate.
 
Cc: e...@chromium.org erikc...@chromium.org thakis@chromium.org
Erik, Emil and al. Any concerns?
Nope!

Comment 3 Deleted

Comment 4 by e...@chromium.org, Nov 11 2015

Make it so. Ideally we should rename this system but that requires consensus with other vendors. Let's change it to -apple-system as a first step.

Comment 5 by kojii@chromium.org, Nov 12 2015

Cc: kojii@chromium.org

Comment 6 by tkent@chromium.org, Nov 13 2015

Labels: -Cr-Blink-webfonts Cr-Blink-Fonts Cr-Blink-CSS

Comment 7 by loyso@chromium.org, Nov 18 2015

Labels: Hotlist-Interop

Comment 8 by mwich...@medium.com, Nov 26 2015

FWIW I heard that W3C is recommending “system-ui”.

Comment 9 by kojii@chromium.org, Nov 26 2015

Blocking: chromium:555090
Components: -Blink>CSS
The work for this lies in font land. Removing CSS

Comment 11 by kojii@chromium.org, Oct 12 2016

Owner: kojii@chromium.org
Status: Assigned (was: Available)

Comment 12 by kojii@chromium.org, Oct 12 2016

Blocking: 654679
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcc99dfb57774beee88deeb95e8f5753d6d10f8b

commit dcc99dfb57774beee88deeb95e8f5753d6d10f8b
Author: kojii <kojii@chromium.org>
Date: Fri Oct 21 07:11:36 2016

Replace internal uses of BlinkMacSystemFont on Mac with system-ui

This patch replaces internal uses of "BlinkMacSystemFont", Blink's
non-standard extension on Mac, with the standard "system-ui" generic
font family.

By eliminating internal uses, the aliasing is moved from FontCache
to CSS resolving time. This allows access to the document, which is
needed for per-document use counter.

BUG=554590,  654679 

Review-Url: https://chromiumcodereview.appspot.com/2388623002
Cr-Commit-Position: refs/heads/master@{#426743}

[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/third_party/WebKit/LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/third_party/WebKit/Source/platform/mac/ThemeMac.mm
[modify] https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b/tools/metrics/histograms/histograms.xml

Comment 14 by kojii@chromium.org, Oct 26 2016

Blocking: -654679

Comment 15 by kojii@chromium.org, Oct 26 2016

Blockedon: 654679

Comment 16 by e...@chromium.org, Nov 30 2017

Can we do this now?

Still ~50% and github uses "BlinkMacSystemFont" without "system-ui". I'll see if we can reach them.
Cc: addyo@chromium.org
Usage sees to be increasing, https://www.chromestatus.com/metrics/feature/timeline/popularity/1654

Doubt we can remove it anytime soon :(

We might want to add a usecounter that only counts when BlinkMacSystemFont is used in a fallback list that does *not* include -apple-system.

Sign in to add a comment