New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users
Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 545886



Sign in to add a comment
Add browser_tests and content_browsertests utilizing the VP9 codec
Project Member Reported by kjellander@chromium.org, Nov 11 2015 Back to list
With VP9 becoming available without a flag in Chrome (launch bug 545886), we should add tests utilizing it to get test coverage and also gather performance data.

Linux, Mac, Windows: browser_tests and content_browsertests
Android: content_browsertests

To achieve this, either issue 554511 must be fixed or the test will need to perform SDP munging during the call setup, to move up the VP9 codec to being the default.


 
Blocking: chromium:545886
Cc: tnakamura@chromium.org
Any progress on this? I'd really like to see this being worked on.
Labels: M-50
Owner: asapersson@chromium.org
Labels: -M-50 M-51
Project Member Comment 6 by bugdroid1@chromium.org, Mar 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21146ff8f2f067aefb441419caff542d3097cb05

commit 21146ff8f2f067aefb441419caff542d3097cb05
Author: asapersson <asapersson@chromium.org>
Date: Mon Mar 07 11:19:39 2016

Add VP9 to chrome_webrtc_perf_browsertest.cc.

60 sec audio-video call ->

60 sec audio-video call VP8
60 sec audio-video call VP9
60 sec audio-video call Default

BUG= chromium:554512 

Review URL: https://codereview.chromium.org/1755073002

Cr-Commit-Position: refs/heads/master@{#379537}

[modify] https://crrev.com/21146ff8f2f067aefb441419caff542d3097cb05/chrome/browser/media/chrome_webrtc_perf_browsertest.cc
[modify] https://crrev.com/21146ff8f2f067aefb441419caff542d3097cb05/chrome/browser/media/webrtc_browsertest_perf.cc
[modify] https://crrev.com/21146ff8f2f067aefb441419caff542d3097cb05/chrome/browser/media/webrtc_browsertest_perf.h

Project Member Comment 7 by bugdroid1@chromium.org, Mar 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34252c4b95fa8fc024dc84cb77f2389da4632c6d

commit 34252c4b95fa8fc024dc84cb77f2389da4632c6d
Author: asapersson <asapersson@chromium.org>
Date: Mon Mar 07 14:10:00 2016

Add VP9 to chrome_webrtc_video_quality_browsertest.cc.

BUG= chromium:554512 

Review URL: https://codereview.chromium.org/1752293003

Cr-Commit-Position: refs/heads/master@{#379552}

[modify] https://crrev.com/34252c4b95fa8fc024dc84cb77f2389da4632c6d/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

├ůsa,
Can we close this bug or is more work needed?
Project Member Comment 9 by bugdroid1@chromium.org, Mar 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b64e3cb6324560bf9525d804acf6894ee214a73c

commit b64e3cb6324560bf9525d804acf6894ee214a73c
Author: asapersson <asapersson@chromium.org>
Date: Mon Mar 21 14:41:02 2016

Remove tests using the default codec (i.e. VP8) from chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc.

The tests have been replaced by:
- WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8
- WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityVp8

BUG= chromium:554512 

Review URL: https://codereview.chromium.org/1817983002

Cr-Commit-Position: refs/heads/master@{#382283}

[modify] https://crrev.com/b64e3cb6324560bf9525d804acf6894ee214a73c/chrome/browser/media/webrtc_perf_browsertest.cc
[modify] https://crrev.com/b64e3cb6324560bf9525d804acf6894ee214a73c/chrome/browser/media/webrtc_video_quality_browsertest.cc

Status: Fixed
Sign in to add a comment