New issue
Advanced search Search tips

Issue 554410 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 579196



Sign in to add a comment

Remove sha256_legacy_support_win.h and ECDSA disabling logic post XP

Project Member Reported by davidben@chromium.org, Nov 11 2015

Issue description

Per http://chrome.blogspot.com/2015/11/updates-to-chrome-platform-support.html, XP support will be gone sometime next year. After that, remove the code we added to account for missing features in XP's certificate verifier.
 
Blocking: chromium:579196
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c0aa77c46d827484a01662cc0eb383e7de6d93f

commit 3c0aa77c46d827484a01662cc0eb383e7de6d93f
Author: davidben <davidben@chromium.org>
Date: Mon Jan 25 22:07:59 2016

Remove Windows XP SHA-256 and ECDSA logic.

We can assume the system verifier handles both SHA-256 and ECDSA now.
No need to inject SHA-256 support or disable ECDSA ciphers.

BUG= 554410 

Review URL: https://codereview.chromium.org/1610833004

Cr-Commit-Position: refs/heads/master@{#371329}

[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/base/win/win_util.cc
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/base/win/win_util.h
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/components/component_updater/component_updater_url_constants.cc
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/components/component_updater/component_updater_url_constants.h
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/components/component_updater/configurator_impl.cc
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/components/component_updater/configurator_impl.h
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/content/browser/browser_main_runner.cc
[delete] http://crrev.com/efa847a54ec8dbb71ab7d630a05fb289c2991a78/net/cert/sha256_legacy_support_win.cc
[delete] http://crrev.com/efa847a54ec8dbb71ab7d630a05fb289c2991a78/net/cert/sha256_legacy_support_win.h
[delete] http://crrev.com/efa847a54ec8dbb71ab7d630a05fb289c2991a78/net/cert/sha256_legacy_support_win_unittest.cc
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/net/data/ssl/certificates/README
[delete] http://crrev.com/efa847a54ec8dbb71ab7d630a05fb289c2991a78/net/data/ssl/certificates/sha256.pem
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/net/data/ssl/scripts/generate-test-certs.sh
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/net/net.gypi
[modify] http://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f/net/socket/ssl_client_socket_openssl.cc

Status: Fixed
Good-bye and good riddance!
Labels: M-50
Adding release ;)

Sign in to add a comment