Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 554220 Implement correct request matching for pushed responses
Starred by 8 users Project Member Reported by, Nov 10 2015 Back to list
Status: Started
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Sign in to add a comment
When matching a request to pushed responses, Chrome needs to validate all relevant headers to ensure the pushed response is a valid match for the request. In particular, if the response contains a non-empty Vary header, the varied headers in the request should match those in the response's PUSH_PROMISE.

For further discussion, see here:!topic/net-dev/kuPNwmKZWzg
Comment 2 by, Apr 15 2016
Status: Available
Comment 5 by, Oct 5 2016
QUIC implementation of server push respects the Vary header.
Comment 6 by, Nov 29 2016
In addition to Vary, a PUSH_PROMISE can in theory be a Range request that gets a pushed 206 response. Chrome needs to support this as well, at minimum by matching the Range header of the request with the Range header from the PUSH_PROMISE.

ckrasic@ -- From looking at the code (linked below), it looks like QUIC supports pushed responses with Vary but not pushed 206 responses?
tombergan@ - correct, QUIC's push support does not consider range requests.
 Issue 727655  has been merged into this issue.
Project Member Comment 13 by, Today (19 hours ago)
The following revision refers to this bug:

commit 602c40ce2fb52c32518c074ebe56c2795d60a4bd
Author: Bence Béky <>
Date: Wed Jul 26 05:22:56 2017

Small cleanup in HTTP/2 and QUIC server push code.

* Remove unused QuicChromiumClientSession::GetStreamIdForPush().
* Remove unused SpdySession::GetStreamIdForPush().
* Add early returns in SpdySession::GetPushStream().
* Minor cleanup in SpdySession::TryCreatePushStream().
* Better error messages; change tests accordingly.

No functional change except for more informative error messages
(both in LOG() and in GOAWAY frames).


Change-Id: If7d67c33d291a9dd2bd5b3721cf65aa17a7134d9
Commit-Queue: Bence Béky <>
Reviewed-by: Helen Li <>
Cr-Commit-Position: refs/heads/master@{#489557}

Sign in to add a comment