New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 4
Type: Bug



Sign in to add a comment

Button form controls show differently on different zoom level

Reported by ld...@zscaler.com, Oct 22 2015

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.71 Safari/537.36

Steps to reproduce the problem:
1. Go to jsfiddle, http://jsfiddle.net/rvzcj3nb/
2. Change zoom in level to 110%
3. Change zoom in level to 100%

You will see the different UI of file chooser

What is the expected behavior?
It should be show exactly the same if not better user interface than chrome. 

What went wrong?
file chooser shows with gray background

Did this work before? Yes It worked on version 46.0.23*

Chrome version: 46.0.2490.71  Channel: n/a
OS Version: OS X 10.10.5
Flash Version: Shockwave Flash 19.0 r0
 
fileupload.gif
170 KB View Download

Comment 1 by rsesek@chromium.org, Oct 22 2015

Cc: wiltzius@chromium.org alokp@chromium.org
Labels: Cr-Blink-Forms
This is working as intended, but I agree the UI is improved. The issue is that when the page is zoomed, the native Aqua form controls don't scale well, so we fallback to drawing with the built-in theme. If you use <input type="radio"> or <input type="checkbox"> you'll see better controls. But I agree button-based are not great looking.

+wiltzius and +alokp who I think worked on this?

Comment 2 by tkent@chromium.org, Oct 23 2015

Labels: -Cr-UI
Status: aval
Summary: Button form controls show differently on different zoom level (was: input file UI show differently on different zoom level)
This is an intentional behavior for now.  If the zoom level is not 100%, we switch button rendering from the native one to CSS one.

It's possible to make the CSS rendering similar to naive one, but it's not an easy task because native button appearance is very different in OSX versions.

Comment 3 by tkent@chromium.org, Oct 23 2015

Labels: -Pri-2 Pri-4 Cr-Blink-Forms-Button
Status: Available

Comment 4 by tkent@chromium.org, Feb 19 2016

Components: -Blink>Forms

Comment 5 by tkent@chromium.org, May 23 2016

 Issue 575498  has been merged into this issue.

Comment 6 by tkent@chromium.org, Jun 14 2016

Cc: tkent@chromium.org
 Issue 619554  has been merged into this issue.
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 15 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by tkent@chromium.org, Jun 15 2017

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Comment 9 by tkent@chromium.org, Jul 11 2017

 Issue 740409  has been merged into this issue.

Comment 10 by tkent@chromium.org, Jul 26 2017

Cc: -tkent@chromium.org
Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16d7a50a904b8507aad24235aedfea55dfdeedcc

commit 16d7a50a904b8507aad24235aedfea55dfdeedcc
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jul 26 05:31:43 2017

macOS: Fix 'ButtonFace' CSS color, and update the CSS button rendering

* This CL fixes 'ButtonFace' CSS system color
 It was a fixed gray, and now it returns a real button color retrieved
 from OS. It's white nowadays.

* Update CSS-rendered default button to match macOS 10.12.
 - Has border-radius
 - Update border-color and border-style
 The CSS-rendered button is used instead of OS-native rendering in
 non-100% zoom level, or with additional CSS properties. It should be
 similar to OS-native buttons.

This CL affects only macOS, and doesn't change the default size of
buttons.

Implementation:

* themeMac.css, LayoutThemeMac.mm:
 The main change. Update ButtonFace definition and button default style.

* colorSuggestionPicker.css, PaintPropertyTreeBuilderTest.cpp, and many
tests:
  Set border-radius:0 to keep existing behavior.

* auto-click.js, feature-policy-vibrate.html,
iframe-that-performs-parent-navigation.html,
iframe-that-performs-parent-navigation-async.html, and
vibrate-from-iframe.html:
  Update mouse-click position for border-radius.

* Other tests:
 - Update rendering result due to the rendering change, or
 - Update only rendering tree dump because native button rendering
  is used.

Bug:  546679 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0ef2ae135a6ac0677040d48c435fedc3af379481
Reviewed-on: https://chromium-review.googlesource.com/584149
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489558}
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-custom-pseudo.html
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/fast/forms/button-with-ellipsis.html
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/fast/forms/button/button-with-float.html
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/fast/forms/button/content-with-margins-inside-button.html
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/resources/feature-policy-vibrate.html
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation-async.html
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html
[delete] https://crrev.com/602c40ce2fb52c32518c074ebe56c2795d60a4bd/third_party/WebKit/LayoutTests/platform/linux/html/details_summary/details-replace-summary-child-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-19b-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-23-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-23-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-24-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-24-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-64-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-68-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-68-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-69-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-69-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-23-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-23-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-24-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-24-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-64-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-68-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-68-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-69-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-69-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-23-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-23-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-24-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-24-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-64-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-68-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-68-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-69-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-69-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/selection/selection-button-text-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/html-media-capture/capture_audio_cancel-manual-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/html-media-capture/capture_image_cancel-manual-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/html-media-capture/capture_video_cancel-manual-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/css/continuationCrash-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/css/margin-top-bottom-dynamic-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/dynamic/positioned-movement-with-positioned-children-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/files/file-in-input-display-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/001-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/001-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/basic-buttons-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/blankbuttons-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-default-title-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-default-title-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-positioned-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-sizes-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-style-color-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-style-color-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-table-styles-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-text-transform-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button/button-align-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button/button-cannot-be-nested-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button/button-white-space-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/control-clip-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/control-clip-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/control-clip-overflow-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/control-restrict-line-height-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/file/file-input-direction-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/file/file-input-disabled-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/file/input-file-re-render-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/form-element-geometry-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/formmove3-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/input-appearance-height-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/input-button-sizes-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/input-first-letter-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/input-first-letter-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/input-value-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/select-baseline-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/select-baseline-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/submit/submit-appearance-basic-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/submit/submit-appearance-basic-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/targeted-frame-submission-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/textarea/reset-textarea-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/selectors/064-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/html/details_summary/details-replace-summary-child-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/html/details_summary/details-replace-text-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/html/tabular_data/col_width_resizing_table-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/http/tests/filesystem/input-display-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/inline-svg-in-xhtml-expected.txt
[add] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/http/tests/filesystem/input-display-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-19b-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-23-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-23-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-24-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-24-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-64-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-68-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-68-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-69-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-69-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-23-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-23-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-24-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-24-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-64-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-68-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-68-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-69-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-69-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-23-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-23-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-24-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-24-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-64-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-68-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-68-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-69-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-69-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/selection-button-text-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/css/continuationCrash-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/css/margin-top-bottom-dynamic-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/dynamic/positioned-movement-with-positioned-children-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/basic-buttons-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/blankbuttons-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-default-title-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-positioned-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-sizes-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-style-color-expected.png
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-style-color-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-table-styles-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeedcc/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-text-transform-expected.txt
[modify] https://crrev.com/16d7a50a904b8507aad24235aedfea55dfdeed
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fc7e65aadb5e61fbd0855212242018cba09d3a4

commit 9fc7e65aadb5e61fbd0855212242018cba09d3a4
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jul 28 14:52:53 2017

macOS: Update UA stylesheet for buttons, and remove border-adjustment behavior for -webkit-appearance:button

This CL makes the default size of CSS-rendered buttons same as
buttons with -webkit-appearance:button/push-button.

* Before this CL
UA stylesheet:
  padding: 2px 6px 3px 6px;
  border-width: 2px;

Style adjustment for -webkit-appearance:push-button:
  padding: 2px 8px 3px 8px; (adjusted by blink::ThemeMac)
  border-width: 0; (adjusted by blink::Theme)

Style adjustment for -webkit-appearance:button:
  padding: 2px 6px 3px 6px; (no adjustment)
  border-width: 0 2px 0 2px; (adjusted by blink::ThemeMac)

So, push-button and button had same sizes, and CSS fallback buttons
were taller than them.

* After this CL:
UA stylesheet:
  padding: 1px 7px 2px 7px;
  border-width: 1px;

Style adjustment for -webkit-appearance:push-button:
  padding: 2px 8px 3px 8px; (adjusted by blink::ThemeMac)
  border-width: 0; (adjusted by blink::Theme)

Style adjustment for -webkit-appearance:button:
  padding: 1px 7px 2px 7px; (no adjustment)
  border-width: 1px; (no adjustment)

As for push-button and button, their size are not changed by this CL,
and the size of CSS fallback buttons matches to them.

In general, style adjustment by theme code should be reduced in order
to improve platform predictability.

This CL affects only macOS.

Bug:  546679 
Change-Id: I4f10d546bf01851ff8ff1c6679bd4a1a56ea474a
Reviewed-on: https://chromium-review.googlesource.com/590392
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490390}
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/fast/css/cache/matched-properties-cache-partial-match-expected.html
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/fast/css/cache/matched-properties-cache-partial-match.html
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-68-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-69-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/html/css3-modsel-69-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-68-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-69-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xhtml/css3-modsel-69-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-68-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-69-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/selectors3/xml/css3-modsel-69-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/block/positioning/inline-block-relposition-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/dynamic/positioned-movement-with-positioned-children-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/001-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/001-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/basic-buttons-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/basic-buttons-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-default-title-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-default-title-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-positioned-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-sizes-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-style-color-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-style-color-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button-text-transform-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button/button-align-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button/button-cannot-be-nested-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/button/button-white-space-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/control-clip-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/control-clip-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/control-clip-overflow-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/input-first-letter-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/input-first-letter-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/select-baseline-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/select-baseline-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/submit/submit-appearance-basic-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/submit/submit-appearance-basic-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/selectors/064-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/html/tabular_data/col_width_resizing_table-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/inline-svg-in-xhtml-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/flexbox/button-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-68-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-69-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-69-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-68-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-69-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-69-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-68-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-69-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-69-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/block/positioning/inline-block-relposition-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/dynamic/positioned-movement-with-positioned-children-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/basic-buttons-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/basic-buttons-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-default-title-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-positioned-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-sizes-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-style-color-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-style-color-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-text-transform-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button/button-cannot-be-nested-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button/button-white-space-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/control-clip-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/input-first-letter-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/select-baseline-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/select-baseline-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/submit/submit-appearance-basic-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/submit/submit-appearance-basic-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/selectors/064-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/html/tabular_data/col_width_resizing_table-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/svg/custom/inline-svg-in-xhtml-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/flexbox/button-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-68-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-69-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/html/css3-modsel-69-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/xhtml/css3-modsel-19b-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/xhtml/css3-modsel-23-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/xhtml/css3-modsel-23-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/xhtml/css3-modsel-24-expected.png
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/xhtml/css3-modsel-24-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/xhtml/css3-modsel-64-expected.txt
[modify] https://crrev.com/9fc7e65aadb5e61fbd0855212242018cba09d3a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/selectors3/xhtml/css3-modsel-68-expected.png
[modify] https://crrev.com/9fc7e65aad

Comment 13 by tkent@chromium.org, Jul 31 2017

Labels: M-62
Status: Fixed (was: Started)
The summary of changes:

Before these CLs, the default style for buttons was:
  background-color: ButtonFace; (-> #C0C0C0)
  boder: 2px outset ButtonFace;
  padding: 2px 6px 3px 6px;

After these CLs, it is:
  background-color: ButtonFace; (-> #FFFFFF)
  border-color: #D8D8D8 #D1D1D1 #BABABA;
  border-radius: 4px;
  border-style: solid;
  border-width: 1px;
  padding: 1px 7px 2px 7px;


chromestatus.com entry: https://www.chromestatus.com/feature/5743649186906112


This change broke some existing designs.

For example on CanIUse.com, there’s “Current aligned”, “Usage relative” and “Date relative” buttons which should have no border-radius (http://caniuse.com/#feat=css-grid).

Similarly on Twitter, there’s menu with “Keyboard shortcuts” and “Log out” buttons which shouldn’t have border-radius either (https://twitter.com/?lang=en).

I know this isn’t necessarily very serious, just FYI.
chrome-mac-button-border-radius-bug.png
49.8 KB View Download
This changed half the internet for some of us.

It happens only on chrome on Mac.
buttons_on_outlook_web_app.png
18.8 KB View Download
tabs_at_galaxus.ch.png
24.3 KB View Download

Comment 17 by tkent@chromium.org, Oct 30 2017

For the default border-radius behavior, please follow https://bugs.chromium.org/p/chromium/issues/detail?id=752450#c7

Sign in to add a comment