Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 11 users
Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment
Extension icons and MD
Project Member Reported by estade@chromium.org, Oct 21 2015 Back to list
Extensions show icons on several UI surfaces which are now being changed for Material Design. The following is probably not an exhaustive list:

a) 16px icon (used as that extension's page favicon, used in search chip for  extensions like [1], etc.)
b) 19px page action icon
c) 19px browser action icon

Ideally in the MD world, the page and browser actions should be 16px while the search chip icon should be ~14px. We can scale down, but it won't look amazing.

[1] https://chrome.google.com/webstore/detail/omnibox-site-search/cckcidchbmodjccllbmegoignhmidncg
 
Cc: rdevlin....@chromium.org
Owner: tdander...@chromium.org
Status: Assigned
CL to shrink the extension action icons to 16x16 in MD: https://codereview.chromium.org/1454753002/
Project Member Comment 2 by bugdroid1@chromium.org, Nov 17 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60a14060edc30c719915991b6c02dfd33f335676

commit 60a14060edc30c719915991b6c02dfd33f335676
Author: tdanderson <tdanderson@chromium.org>
Date: Tue Nov 17 17:46:11 2015

Resize extension action icons to 16x16 in material design

Shrink the 19x19 extension action icons to 16x16
in top chrome material design so they match the
size and alignment of the other icons in the toolbar.

BUG= 546206 
TEST=manual

Review URL: https://codereview.chromium.org/1454753002

Cr-Commit-Position: refs/heads/master@{#360103}

[modify] http://crrev.com/60a14060edc30c719915991b6c02dfd33f335676/chrome/browser/ui/extensions/extension_action_view_controller.cc

Comment 3 by laforge@google.com, Dec 3 2015
Labels: -Proj-MaterialDesign Proj-MaterialDesign-NativeUI
Cc: tkonch...@chromium.org
Labels: Needs-Feedback
Could you please provide us with sample mocks so that we can verify the fix from test team end.
This issue is not marked as Fixed, so there is nothing to verify at this time.
Cc: tdander...@chromium.org
Owner: estade@chromium.org
Handing over to Evan - is there anything left to do here?
Comment 7 by estade@chromium.org, Dec 11 2015
ah, there's still this one: https://developer.chrome.com/extensions/omnibox

Another place to update the docs (should say "provide a 14x14") and another place to update calling code (should ask for 14 instead of 16).
mmh these should be 16x16 as well no ? I'm using 16x16 icons in omnibox.
Comment 9 by estade@chromium.org, Dec 11 2015
But you're building padding into the icons. Here's what a 16x16 extension icon looks like in this chip.
bm.png
6.3 KB View Download
right, forgot it's in a chip :) 
ok so to be a bit clearer. Chrome chip icons are 16x16 but built-in with a padding.
for extension, you are right that they should deliver 14x14 to have a satisfying padding if they design the icon full-bleed.
Screen Shot 2015-12-11 at 1.16.04 PM.png
10.0 KB View Download
Project Member Comment 12 by bugdroid1@chromium.org, Jan 12 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f65e10046c2f5e56ab4cf0b5dbe9962753542f6

commit 6f65e10046c2f5e56ab4cf0b5dbe9962753542f6
Author: estade <estade@chromium.org>
Date: Tue Jan 12 22:07:08 2016

Use better algorithm to scale browser action icons

BUG= 546206 

Review URL: https://codereview.chromium.org/1572773002

Cr-Commit-Position: refs/heads/master@{#368998}

[modify] http://crrev.com/6f65e10046c2f5e56ab4cf0b5dbe9962753542f6/chrome/browser/ui/extensions/icon_with_badge_image_source.cc

Labels: -Needs-Feedback
Evan, can we mark this as Fixed?
Status: Fixed
A small question I have about this as an extension developer: how are you going to communicate the change to extension developers?

Just monkey-patching the documentation will catch developers unaware and unable to prepare in advance.

Chromium-extensions group is not an effective channel to reach developers, seeing the amount of noise there and how well did it go for toolbar redesign announcement.

Also, this already rolled out to Linux stable (was that intended?), see https://bugs.chromium.org/p/chromium/issues/detail?id=612765 - so it's a bit late..
This is a fair point.  We really do need a better way of communicating upcoming changes to developers.  chromium-extensions@ is better than nothing, but is very noisy.  Ideally, we'd at least be able to have a "What's new" and "Upcoming" section on the homepage of the documentation (and allow for people to subscribe to updates) or something similar.  There's been some discussions around how we can do this, but nothing's definitive yet.
Comment 18 by woxxom@gmail.com, Jul 19 2016
This change made the icons less legible.

1. A lot of extensions won't be updated to provide a 16px icon for the toolbar, so a distorted scaled-down version will be displayed. Many extensions simply work and are abandoned by their authors who moved on with their lives.

2. A 16x16px icon is too small, there's too little space to include nicely drawn details so many icons will look alike.

3. Since the icons are small and the overlayed infobadges cover parts of the icon there will be many users who have similar looking icons, so they'll have to examine carefully before clicking the one they need, losing their time.
@rdevlin #17
Ironically, there exists such a page, but it has been abandoned since M44: https://developer.chrome.com/extensions/whats_new

It would be great if the extensions/apps team could maintain something similar to https://developers.google.com/web/updates/
This change came through without updating developer documentation. I created an Issue for that, it would be great if it was triaged: https://bugs.chromium.org/p/chromium/issues/detail?id=647182
Sign in to add a comment