New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 54469 link

Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2010
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
M-8

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Turn WebGL and accelerated compositing on by default

Reported by vangelis@chromium.org, Sep 4 2010

Issue description

Add flags to explicitly disable the functionality:

--disable-webgl
--disable-accelerated-compositing


 
Status: Assigned
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58711 

------------------------------------------------------------------------
r58711 | vangelis@chromium.org | 2010-09-07 10:46:09 -0700 (Tue, 07 Sep 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_init_wrapper_mac.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_policy.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=58711&r2=58710
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc?r1=58711&r2=58710

Turning WebGL and the accelerated compositor on by default (linux and windows only for the compositor),
removing the --enable-webgl flag and adding --disable-webgl and --disable-accelerated-compositing.
On the mac --enable-accelerated-compositing still needs to be supplied to enable the compositor.
BUG= 54469 
Review URL: http://codereview.chromium.org/3342016
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58730 

------------------------------------------------------------------------
r58730 | mark@chromium.org | 2010-09-07 12:09:41 -0700 (Tue, 07 Sep 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_init_wrapper_mac.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_policy.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=58730&r2=58729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc?r1=58730&r2=58729

Back out r58711. It appears to have caused video/media-related ui_tests
failures on Windows:

MediaTest.VideoBearTheora
MediaTest.VideoBearSilentTheora
MediaTest.VideoBearWebm
MediaTest.VideoBearSilentWebm
UILayoutTest.MediaUILayoutTest

BUG= 54469 
TEST=tree
Review URL: http://codereview.chromium.org/3333019
------------------------------------------------------------------------

Comment 4 by karen@chromium.org, Sep 8 2010

Labels: Mstone-8
------------------------------------------------------------------------
r58792 | vangelis@chromium.org | Tue Sep 07 22:53:04 PDT 2010
Changed paths:
 M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
 M /trunk/src/chrome/common/sandbox_policy.cc
 M /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc
 M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
 M /trunk/src/chrome/renderer/render_thread.cc
 M /trunk/src/chrome/common/chrome_switches.cc
 M /trunk/src/chrome/renderer/render_view.cc
 M /trunk/src/chrome/common/chrome_switches.h
 M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
Enable webgl and accelerated compositing by default on all platforms. Removes
--enable-webgl and --enable-accelerated-compositing flags and replaces them by
--disable-webgl and --disable-accelerated-compositing. This CL is practically identical
to:
http://src.chromium.org/viewvc/chrome?view=rev&revision=58711

which was checked in the later reverted in:

http://src.chromium.org/viewvc/chrome?view=rev&revision=58730 

due to UI test failures related to video playback via the compositor. The main difference
is that mac is no longer excluded so the two features are now turned on on all 3 platforms.

The issue with the failing UI tests was corrected upstream in WebKit:
http://trac.webkit.org/changeset/66923

so this WebKit change must be rolled in before the chromium change lands.

BUG= 54469 
TEST=NONE


Review URL: http://codereview.chromium.org/3348012
------------------------------------------------------------------------
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58903

------------------------------------------------------------------------
r58903 | vangelis@chromium.org | Wed Sep 08 17:54:19 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=58903&r2=58902&pathrev=58903
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=58903&r2=58902&pathrev=58903
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=58903&r2=58902&pathrev=58903

Turns on by default accelerated compositing on the mac. Removes --enable-accelerated-compositing
flag altogether as it's no longer useful.
BUG= 54469 


Review URL: http://codereview.chromium.org/3303020
------------------------------------------------------------------------
Status: Fixed
Accelerated compositing and WebGL are now on by default on all platforms. Marking as Fixed.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-WebKit -Feature-GPU -Mstone-8 Cr-Content M-8 Cr-Internals-GPU
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink

Sign in to add a comment