New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 20 users
Status: Fixed
Owner:
Closed: Sep 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
M-7

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
"Upgrade Now" always in the wrench menu in Views based interface
Reported by keic...@gmail.com, Sep 1 2010 Back to list
Chrome Version       : 

Chromium	7.0.512.0 (Developer Build 58076)
WebKit	534.7
V8	2.3.11
User Agent	Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.512.0 Safari/534.7
Command Line	"C:\Users\keichee\Desktop\chrome-win32\chrome.exe" --enable-logging --log-level=0 --restore-last-session

URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 4: ok
  Firefox 3.x: ok
         IE 7: ok
         IE 8: ok

What steps will reproduce the problem?
1. go to settings
2. click update chromium
3. click restart

What is the expected result?
update to latest revision

What happens instead?
just restart, no update happen

Please provide any additional information below. Attach a screenshot if
possible.

must update to latest revision, yes it will update 30+ times a day, but its worth it. data, errors, bugs that can be posted by a developer, or fanatic of latest revision of chromium

 
Labels: -Area-Undefined Area-UI
Related to r58040?
Comment 2 by dhw@chromium.org, Sep 1 2010
Labels: Mstone-7
Status: Untriaged
Summary: update chromium in wrench menu (was: NULL)
Is the "Update Chromium" even supposed to show up for Chromium builds?
Comment 3 by ghceo...@gmail.com, Sep 1 2010
Screenshot
Untitled.png
77.0 KB View Download
Comment 4 by keic...@gmail.com, Sep 1 2010
@thestig
the link r58040 is a broken link
Comment 5 by dhw@chromium.org, Sep 1 2010
@4, the autolink is broken because Chromium does not store the revisions in the default
location the bug tracker expects.  You can find the full details at:
http://src.chromium.org/viewvc/chrome?view=rev&revision=58040
Comment 6 by dhw@chromium.org, Sep 1 2010
 Issue 54075  has been merged into this issue.
Comment 7 by e...@chromium.org, Sep 1 2010
Labels: OS-Windows
Status: Assigned
Summary: "Upgrade Now" always in the wrench menu in Views based interface (was: NULL)
Windows specific bug; the upgrade now button is hidden on cocoa and gtk.
 Issue 54094  has been merged into this issue.
Comment 9 by sky@chromium.org, Sep 1 2010
Status: Started
Comment 10 by pcha...@gmail.com, Sep 1 2010
Anyway the idea was interesting : a semi-automatical update for Chromium instead of doing entirely manually.

I hope it works soon.
Please note this is also happening in 7.0.512.0 (Official Build 58142), which is Dev candidate for this week.
I'm seeing this on Google Canary. It just updated from 7.0.511.2 to 7.0.512 and it's requesting a restart to update to the newest version. Actually restarting does nothing except shut down Canary and it immediately relaunches (in about 0.1 seconds).
Oh, I forgot to mention that manually updating Chromium changes nothing, it still shows the update Google Chrome and exclamation point, even after I manually download and install the newest version.
Comment 14 by e...@chromium.org, Sep 1 2010
@11 Considering how many reports we're getting about this just from the canary, due you think it's worth cherry picking the fix that sky has out for review right now?
 Issue 54119  has been merged into this issue.
Thanks for the merge, I suspected there was a thread on this but couldn't see it. I'd definitely avoid pushing this to Dev with a bug of this magnitude without a fix for it, mainly because us Canary users use Dev as a fallback and thus would be left browserless until it's solved :P
Labels: ReleaseBlock-Dev
@14, I meant we should not release  a build to DEV with this bug.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58218 

------------------------------------------------------------------------
r58218 | sky@chromium.org | 2010-09-01 12:27:46 -0700 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/wrench_menu.cc?r1=58218&r2=58217
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/menu/submenu_view.cc?r1=58218&r2=58217

Adds support for invisible menu items to bookmark menus and wires it
up for the wrench menu.

BUG= 46221 ,  54017 
TEST=see bug

Review URL: http://codereview.chromium.org/3289001
------------------------------------------------------------------------

Comment 20 by pcha...@gmail.com, Sep 1 2010
That's right, the bug now exists in Canary too...

Labels: -ReleaseBlock-Dev
I just talked to scott, while unpleasant this is not a dev blocker. he will patch it into 512 and we will release soon after.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58220 

------------------------------------------------------------------------
r58220 | sky@chromium.org | 2010-09-01 12:37:40 -0700 (Wed, 01 Sep 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/512/src/chrome/browser/views/wrench_menu.cc?r1=58220&r2=58219
   M http://src.chromium.org/viewvc/chrome/branches/512/src/views/controls/menu/submenu_view.cc?r1=58220&r2=58219

Merge 58218 - Adds support for invisible menu items to bookmark menus and wires it
up for the wrench menu.

BUG= 46221 ,  54017 
TEST=see bug

Review URL: http://codereview.chromium.org/3289001

TBR=sky@chromium.org
------------------------------------------------------------------------

Comment 23 by sky@chromium.org, Sep 1 2010
Status: Fixed
Great to hear there's a fix done already, talk about fast work! :D
Comment 25 by dhw@chromium.org, Sep 2 2010
 Issue 54180  has been merged into this issue.
 Issue 54223  has been merged into this issue.
 Issue 54234  has been merged into this issue.
Comment 28 by keic...@gmail.com, Sep 2 2010
awww i hope theres an update in chromium too.. better yet, make this issue verified fix :D
 Issue 54250  has been merged into this issue.
 Issue 54232  has been merged into this issue.
 Issue 54244  has been merged into this issue.
The Update Chromium is not a valid menu item in 7.0.517.  I'm assuming that this menu item is being hidden based on some of the notations.  Will this item be unhidden in the future or will the idea of semi automatic updates be introduced.
Chromium can not be auto updated. So this should never show up in Chromium.
Comment 34 by keic...@gmail.com, Oct 4 2010
why, theres always the latest in the build.chromium.org
Comment 35 by pcha...@gmail.com, Oct 5 2010
A "semi automatic" update would be more comfortable for Chromium users (an update is present, do you want to take it ?) rather than an entirely manual method (executing manually mini_installer.exe for example, heavy and boring)

But if you have the firm intention not to do it... 
We do have Canary which gets updated almost everyday. Right now it's only for windows. 

http://tools.google.com/dlpage/chromesxs
Project Member Comment 37 by bugdroid1@chromium.org, Oct 12 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 38 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Mstone-7 M-7 Cr-UI
Project Member Comment 39 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment