New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 442145



Sign in to add a comment

Implement Notification.timestamp

Project Member Reported by peter@chromium.org, Oct 2 2015

Issue description

Implement the Notification.timestamp property.

The property can be used by developers to indicate the time at which a notification is actual. For example, a notification for an upcoming meeting could be set in the future, whereas missed messages because the device
was offline can be set in the past.

Spec link:
https://notifications.spec.whatwg.org/#api

PR link:
https://github.com/whatwg/notifications/pull/54
 

Comment 1 by peter@chromium.org, Oct 2 2015

Blocking: chromium:442145
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8afbbe4213c087653171cd2dd7a11c84c183a11

commit b8afbbe4213c087653171cd2dd7a11c84c183a11
Author: peter <peter@chromium.org>
Date: Mon Feb 01 14:01:11 2016

Implement the Notification `timestamp` property.

This CL implements the new Notification.timestamp property that
can be used by developers to indicate the time at which a notification
is actual. For example, a notification for an upcoming meeting could
be set in the future, whereas missed messages because the device
was offline can be set in the past.

On desktop this only affects ordering of the notification for now,
whereas the notification's time is rendered on the toast on Android.

https://notifications.spec.whatwg.org/#api

This feature was approved to be implemented and to ship by the
following Intent to Implement and Ship on blink-dev:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/gCvPWn0rb_c/discussion

BUG= 538720 

Review URL: https://codereview.chromium.org/1388483002

Cr-Commit-Position: refs/heads/master@{#372655}

[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/browser/notifications/notification_ui_manager_android.cc
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/browser/notifications/platform_notification_service_browsertest.cc
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/chrome/test/data/notifications/platform_notification_service.html
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/content/browser/notifications/notification_database_data.proto
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/content/browser/notifications/notification_database_data_conversions.cc
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/content/browser/notifications/notification_database_data_unittest.cc
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/content/child/notifications/notification_data_conversions.cc
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/content/child/notifications/notification_data_conversions_unittest.cc
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/content/common/platform_notification_messages.h
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/content/public/common/platform_notification_data.h
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/Source/modules/notifications/Notification.idl
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/Source/modules/notifications/NotificationData.cpp
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl
[modify] http://crrev.com/b8afbbe4213c087653171cd2dd7a11c84c183a11/third_party/WebKit/public/platform/modules/notifications/WebNotificationData.h

Comment 3 by peter@chromium.org, Feb 1 2016

Status: Fixed

Comment 4 by peter@chromium.org, Feb 1 2016

Labels: M-50

Sign in to add a comment