New issue
Advanced search Search tips
Starred by 32 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: 53-Stable
Launch-M-Target: 53-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----


Sign in to add a comment

Launch Shadow DOM v1

Project Member Reported by hayato@chromium.org, Sep 15 2015 Back to list

Issue description

Change description:
Launch Shadow DOM v1

Changes to API surface:
- Element.attachShadow
- New HTML Element: HTMLSlotElement
- NonDocumentTypeChildNode.assignedSlot
- Event.deepPath

Links:
Public standards discussion: https://github.com/w3c/webcomponents/labels/v1
The spec: http://w3c.github.io/webcomponents/spec/shadow/

Support in other browsers:
Internet Explorer: Not yet
Firefox: Not yet
Safari: Not yet

 
Showing comments 30 - 129 of 129 Older
Project Member

Comment 30 by bugdroid1@chromium.org, Jan 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dac0e9ab63948cef54619661edc119739ac5567

commit 5dac0e9ab63948cef54619661edc119739ac5567
Author: hayato <hayato@chromium.org>
Date: Wed Jan 20 10:21:00 2016

Rename slot.getDistributedNodes() to slot.getAssingedNodes({flatten: true}).

The spec is: https://w3c.github.io/webcomponents/spec/shadow/#idl-def-HTMLSlotElement
The spec discussion is: https://github.com/w3c/webcomponents/issues/323

HTMLSlotElement.getDistributedNodes() was gone.
Now it is available as HTMLSlotElement.getAssignedNodes{{flatten: true})

BUG=531990

Review URL: https://codereview.chromium.org/1604853004

Cr-Commit-Position: refs/heads/master@{#370360}

[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-default-slots.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-1.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-2.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-dom-mutation.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-fallback-api-1.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-fallback-api-2.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-fallback-api-3.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-text-nodes.html
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/Source/core/core.gypi
[add] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/Source/core/html/AssignedNodesOptions.idl
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/Source/core/html/HTMLSlotElement.h
[modify] http://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567/third_party/WebKit/Source/core/html/HTMLSlotElement.idl

Blockedon: chromium:579873
Project Member

Comment 32 by bugdroid1@chromium.org, Jan 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b457ca4d9a86e52c11d906b56f55bdf4c6f1136f

commit b457ca4d9a86e52c11d906b56f55bdf4c6f1136f
Author: yuzus <yuzus@chromium.org>
Date: Thu Jan 21 07:48:56 2016

Implement v1 slot logic in EventPath

This CL makes sure that when an event happens on an element which is assigned to a slot, the event path goes to the slot after the element and goes up the v1 tree.
Described here in spec.
http://w3c.github.io/webcomponents/spec/shadow/#event-paths

BUG=531990

Review URL: https://codereview.chromium.org/1606153002

Cr-Commit-Position: refs/heads/master@{#370648}

[add] http://crrev.com/b457ca4d9a86e52c11d906b56f55bdf4c6f1136f/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-slot.html
[modify] http://crrev.com/b457ca4d9a86e52c11d906b56f55bdf4c6f1136f/third_party/WebKit/Source/core/events/EventPath.cpp

Project Member

Comment 33 by bugdroid1@chromium.org, Jan 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a8b698b864db5dadba51bbda82cc07d3cc2b93

commit 38a8b698b864db5dadba51bbda82cc07d3cc2b93
Author: kochi <kochi@chromium.org>
Date: Thu Jan 21 08:40:16 2016

Implement matching part of ::slotted() pseudo element

This CL is split off of
https://codereview.chromium.org/1523843004/

and implements mathcing part of ::slotted() pseudo element.
This CL depends on parsing part:
https://codereview.chromium.org/1565263003/

Implements ::slotted() pseudo element, whose spec is discussed at
https://github.com/w3c/webcomponents/issues/331

BUG=531990
TEST=new layout tests

Review URL: https://codereview.chromium.org/1575363006

Cr-Commit-Position: refs/heads/master@{#370650}

[add] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change-expected.html
[add] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change.html
[add] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-expected.html
[add] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-shared-style-expected.html
[add] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-shared-style.html
[add] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element.html
[add] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/LayoutTests/fast/selectors/querySelector-pseudo-slotted.html
[modify] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/Source/core/css/CSSSelector.h
[modify] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/Source/core/css/CSSSelectorList.cpp
[modify] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/Source/core/css/RuleFeature.cpp
[modify] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
[modify] http://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

Project Member

Comment 34 by bugdroid1@chromium.org, Jan 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf

commit 5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf
Author: yuzus <yuzus@google.com>
Date: Thu Jan 21 08:52:32 2016

Make EventPath available as Event.deepPath as well.

Spec is the link below.
http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath
This feature is guarded by ShadowDOMV1 RuntimeEnabled flag.

BUG=531990

Review URL: https://codereview.chromium.org/1577163003

Cr-Commit-Position: refs/heads/master@{#370652}

[add] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path.html
[modify] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/Source/core/events/Event.idl
[modify] http://crrev.com/5f8d7ca8eea9c1aac1037fedfb10d7bda0f52ebf/third_party/WebKit/Source/core/frame/UseCounter.h

Project Member

Comment 35 by bugdroid1@chromium.org, Jan 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/103420cd626f0b9fbc7f57c8b85f14e56e301abf

commit 103420cd626f0b9fbc7f57c8b85f14e56e301abf
Author: kochi <kochi@chromium.org>
Date: Thu Jan 21 09:55:47 2016

Rename ShadowDistributed to ShadowV0Distributed

There are other places which "shadow distributed" is used
(e.g. css/RuleSet.h), and those are renamed to "content pseudo" etc. in
https://codereview.chromium.org/1616743002/

For these tests in editing, renaming it to "ShadowV0" should
make more sense because it is tested against V0 distributed
node (i.e. <content>).

This is a name-only change and no functionality/test difference.

BUG=531990

Review URL: https://codereview.chromium.org/1610993003

Cr-Commit-Position: refs/heads/master@{#370656}

[modify] http://crrev.com/103420cd626f0b9fbc7f57c8b85f14e56e301abf/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp
[modify] http://crrev.com/103420cd626f0b9fbc7f57c8b85f14e56e301abf/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Project Member

Comment 36 by bugdroid1@chromium.org, Jan 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3560eab7b023bd3e0e282d8509cf2d75d0d89264

commit 3560eab7b023bd3e0e282d8509cf2d75d0d89264
Author: kochi <kochi@chromium.org>
Date: Thu Jan 21 10:21:20 2016

Use more appropriate symbol names for "shadow distributed"

The term "shadow distributed" has been used to refer
to matching of "::content" pseudo element against
<content> or <shadow> elements.

Shadow DOM V1 introduces the new <slot> element and
::slotted pseudo element, rename all occurrences
of "shadow distributed" to "content pseudo", or
"slotted pseudo" etc. so it should make more sense.

This CL should land after
https://codereview.chromium.org/1575363006

BUG=531990

Review URL: https://codereview.chromium.org/1616743002

Cr-Commit-Position: refs/heads/master@{#370660}

[modify] http://crrev.com/3560eab7b023bd3e0e282d8509cf2d75d0d89264/third_party/WebKit/Source/core/css/RuleSet.cpp
[modify] http://crrev.com/3560eab7b023bd3e0e282d8509cf2d75d0d89264/third_party/WebKit/Source/core/css/RuleSet.h
[modify] http://crrev.com/3560eab7b023bd3e0e282d8509cf2d75d0d89264/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] http://crrev.com/3560eab7b023bd3e0e282d8509cf2d75d0d89264/third_party/WebKit/Source/core/css/SelectorChecker.h
[modify] http://crrev.com/3560eab7b023bd3e0e282d8509cf2d75d0d89264/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

Project Member

Comment 38 by bugdroid1@chromium.org, Jan 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3f3112453d171c88fd0f06b4c8196228f47780c

commit e3f3112453d171c88fd0f06b4c8196228f47780c
Author: yuzus <yuzus@google.com>
Date: Wed Jan 27 06:22:51 2016

Add scoped flag to Event.

Spec is described here: http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042

Review URL: https://codereview.chromium.org/1586563005

Cr-Commit-Position: refs/heads/master@{#371747}

[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/TestExpectations
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html
[add] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/Source/core/events/Event.cpp
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/Source/core/events/Event.h
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/Source/core/events/Event.idl
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/Source/core/events/EventInit.idl
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] http://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c/third_party/WebKit/Source/core/frame/UseCounter.h

Project Member

Comment 39 by bugdroid1@chromium.org, Jan 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08f320e73b375593ed13c621e73a722df63767c2

commit 08f320e73b375593ed13c621e73a722df63767c2
Author: yuzus <yuzus@chromium.org>
Date: Wed Jan 27 08:23:06 2016

Modify v1-distribution PerformanceTest

Change getDistributedNodes to getAssignedNodes to make the performance test run.
BUG=531990

Review URL: https://codereview.chromium.org/1630003004

Cr-Commit-Position: refs/heads/master@{#371757}

[modify] http://crrev.com/08f320e73b375593ed13c621e73a722df63767c2/third_party/WebKit/PerformanceTests/ShadowDOM/v1-distribution.html

Project Member

Comment 40 by bugdroid1@chromium.org, Feb 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9279be7d61887c171d5c1cefa114292c84b9957

commit b9279be7d61887c171d5c1cefa114292c84b9957
Author: yuzus <yuzus@chromium.org>
Date: Mon Feb 01 03:59:07 2016

Change Event.deepPath to a method

In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990

Review URL: https://codereview.chromium.org/1637813002

Cr-Commit-Position: refs/heads/master@{#372596}

[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path.html
[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/Source/core/events/Event.idl
[modify] http://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js

Project Member

Comment 41 by bugdroid1@chromium.org, Feb 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df6916adc8e8fe1daa591955b0575663d4f00990

commit df6916adc8e8fe1daa591955b0575663d4f00990
Author: yuzus <yuzus@chromium.org>
Date: Mon Feb 01 09:14:52 2016

Implement Node.treeRoot

Node.treeRoot is implemented to formalize the way that elements figure out the root/shadowroot.
See the discussion here: https://github.com/w3c/webcomponents/issues/80
See the Spec change here: https://github.com/w3c/webcomponents/commit/6864a40fe4efa8a737e78512e3c85319ddc5bf8b
See the Spec here: http://w3c.github.io/webcomponents/spec/shadow/#widl-Node-treeRoot
BUG=579873, 531990

Review URL: https://codereview.chromium.org/1642503002

Cr-Commit-Position: refs/heads/master@{#372626}

[add] http://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990/third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html
[modify] http://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] http://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990/third_party/WebKit/Source/core/dom/Node.cpp
[modify] http://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990/third_party/WebKit/Source/core/dom/Node.h
[modify] http://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990/third_party/WebKit/Source/core/dom/Node.idl
[modify] http://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990/third_party/WebKit/Source/core/frame/UseCounter.h

Project Member

Comment 42 by bugdroid1@chromium.org, Feb 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27e76c7d430f4ed19298d25fde0db4ebd5cb7f4

commit c27e76c7d430f4ed19298d25fde0db4ebd5cb7f4
Author: yuzus <yuzus@chromium.org>
Date: Mon Feb 01 09:48:33 2016

Fix layout test for Event.scoped

Fix the layout test related to this CL : https://codereview.chromium.org/1586563005/
Changes are made so that the test will handle the cases where events do not happen.
BUG=531990, 575042

Review URL: https://codereview.chromium.org/1641573002

Cr-Commit-Position: refs/heads/master@{#372627}

[modify] http://crrev.com/c27e76c7d430f4ed19298d25fde0db4ebd5cb7f4/third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html

Project Member

Comment 43 by bugdroid1@chromium.org, Feb 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/429b5ee96832287dd7c0747e6115227ac2447b31

commit 429b5ee96832287dd7c0747e6115227ac2447b31
Author: yuzus <yuzus@chromium.org>
Date: Mon Feb 01 10:22:30 2016

Make HTMLSlotElement.distributedNodeNextTo & distributedNodePreviousTo faster

Currently distributedNodeNextTo & distributedNodePreviousTo are calculated using vector (O(N)). This CL makes this calculation O(1) by introducing a hashmap.
According to Performance Test, the calculation became 7.7% faster, in case of N=1000. (N being the number of distributed nodes)

With this CL:    avg 79094.69485003888 runs/s
Without this CL: avg 73466.4783609413  runs/s

BUG=531990

Review URL: https://codereview.chromium.org/1611413005

Cr-Commit-Position: refs/heads/master@{#372632}

[add] http://crrev.com/429b5ee96832287dd7c0747e6115227ac2447b31/third_party/WebKit/PerformanceTests/ShadowDOM/SlotDistibutedNextPrevious.html
[modify] http://crrev.com/429b5ee96832287dd7c0747e6115227ac2447b31/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] http://crrev.com/429b5ee96832287dd7c0747e6115227ac2447b31/third_party/WebKit/Source/core/html/HTMLSlotElement.h

Project Member

Comment 44 by bugdroid1@chromium.org, Feb 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d60c3cd683e0f6fd1585ed0e6ce68184980a6823

commit d60c3cd683e0f6fd1585ed0e6ce68184980a6823
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Feb 01 19:11:32 2016

Revert of Change Event.deepPath to a method (patchset #3 id:40001 of https://codereview.chromium.org/1637813002/ )

Reason for revert:
This breaks new DevTools frontend while remote debugging old backends.

Original issue's description:
> Change Event.deepPath to a method
>
> In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
> See the discussion here: https://github.com/w3c/webcomponents/issues/361
> Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
> See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
> BUG=531990
>
> Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
> Cr-Commit-Position: refs/heads/master@{#372596}

TBR=samli@chromium.org,hayato@chromium.org,kochi@chromium.org,kojii@chromium.org,yuzus@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=531990

Review URL: https://codereview.chromium.org/1651193003

Cr-Commit-Position: refs/heads/master@{#372713}

[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path.html
[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/Source/core/events/Event.idl
[modify] http://crrev.com/d60c3cd683e0f6fd1585ed0e6ce68184980a6823/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js

Project Member

Comment 45 by bugdroid1@chromium.org, Feb 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c496adcb1c77856494692e0ea3ca358ba2f0415

commit 5c496adcb1c77856494692e0ea3ca358ba2f0415
Author: hayato <hayato@chromium.org>
Date: Mon Feb 08 07:50:12 2016

Rename ComposedTree to FlatTree

The spec change is: https://github.com/w3c/webcomponents/commit/9b7f16e90b88594ed783ff7e0f971fad084e5f4d

Blink should follow the change of the terminologies in the spec.
There is no change on web-facing APIs.

This CL is the result of the (almost) mechanical renaming, using:

> zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/ComposedTree/FlatTree/g'
> zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/composed tree/flat tree/g'
> zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/Composed tree/Flat tree/g'
> zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/Composed Tree/Flat Tree/g'

Other renaming, which would require a more careful investigation, will be done in another CL.

BUG=531990

Review URL: https://codereview.chromium.org/1675163002

Cr-Commit-Position: refs/heads/master@{#374095}

[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/editing/selection/double-click-on-shadow-tree.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/editing/text-iterator/findString-shadow-roots.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/attr-dir-inherit.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/attr-title-inherit.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-fonts-load.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty-expected.txt
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/event-dispatching.js
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator.html
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/core.gypi
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/Document.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/ElementTraversal.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/Node.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/Node.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/NodeTraversal.h
[rename] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp
[rename] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.h
[rename] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EditingStrategy.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EditingStrategy.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EditingStrategyTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/Editor.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EphemeralRange.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/EphemeralRange.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/FindOptions.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/PendingSelection.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/Position.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/Position.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/PositionIterator.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/PositionIterator.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/PositionTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/PositionWithAffinity.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/PositionWithAffinity.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/RenderedPosition.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/RenderedPosition.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/SelectionAdjuster.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/SelectionEditor.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisiblePosition.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisibleSelection.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIteratorTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/serializers/Serialization.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/input/TouchActionUtil.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/testing/CoreTestPrinters.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/testing/Internals.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/core/testing/Internals.idl
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/web/TextFinder.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/web/TextFinder.h
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] http://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

Project Member

Comment 46 by bugdroid1@chromium.org, Feb 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa35fb84c80c0928afbc9d92660bb97d34b40fc4

commit aa35fb84c80c0928afbc9d92660bb97d34b40fc4
Author: hayato <hayato@chromium.org>
Date: Mon Feb 08 11:50:29 2016

Restrict the types of nodes that could be assigned to a slot.

The spec change is: https://github.com/w3c/webcomponents/issues/351

BUG=531990

Review URL: https://codereview.chromium.org/1671823002

Cr-Commit-Position: refs/heads/master@{#374099}

[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-text-nodes.html
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/Source/core/dom/Element.idl
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/Source/core/dom/Node.h
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/Source/core/dom/NonDocumentTypeChildNode.h
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/Source/core/dom/NonDocumentTypeChildNode.idl
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/Source/core/dom/Text.idl
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] http://crrev.com/aa35fb84c80c0928afbc9d92660bb97d34b40fc4/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Project Member

Comment 47 by bugdroid1@chromium.org, Feb 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c11d345c76dbf3ad45fdb45d7818f3709f551bf0

commit c11d345c76dbf3ad45fdb45d7818f3709f551bf0
Author: hayato <hayato@chromium.org>
Date: Tue Feb 09 02:12:13 2016

Rename 'composed tree' to 'flat tree' in the layout tests.

This is a follow-up patch of r374095, renaming layout tests file names and their contents.

BUG=531990

Review URL: https://codereview.chromium.org/1675193002

Cr-Commit-Position: refs/heads/master@{#374267}

[rename] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-expected.txt
[rename] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-shadow-reprojection-expected.txt
[rename] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-shadow-reprojection.html
[rename] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal.html
[rename] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty-expected.txt
[rename] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty.html
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/event-dispatching.js
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-details-summary-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-to-younger-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-empty-shadow-element-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt
[modify] http://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt

Project Member

Comment 48 by bugdroid1@chromium.org, Feb 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2226eb587c03a85ae9d5503566c9102fae3cdee9

commit 2226eb587c03a85ae9d5503566c9102fae3cdee9
Author: hayato <hayato@chromium.org>
Date: Tue Feb 09 13:24:20 2016

Rename "tree of trees" to "composed tree".

This is another renaming after r374095.
This CL is the result of the (almost) mechanical renaming, using:

> git ls-files | egrep '(html|txt|cpp|h|idl|js)$' | xargs sed -i -e 's/tree of trees/composed tree/g' \
> -e 's/Tree of trees/Composed tree/g' -e 's/TreeOfTrees/ComposedTree/g' -e 's/treeOfTrees/composedTree/g'

BUG=531990

Review URL: https://codereview.chromium.org/1684533002

Cr-Commit-Position: refs/heads/master@{#374364}

[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/access-key.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/attr-dir-inherit.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/attr-lang-inherit.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/closed-mode-deep-combinator-and-shadow-pseudo.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-document-position.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-treescope-position.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/contains-with-shadow-dom-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/contains-with-shadow-dom.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-distributed-nodes.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host1.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host2.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host3-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host3.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host5.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/distributed-node-focus.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-closed-shadowroot.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-closed-shadowroot2.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-empty-shadow-element.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-for-user-agent-shadow-tree.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-in-shadow-tree.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-multiple-shadow-roots-2.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-multiple-shadow-roots.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-shadow-insertion-point-in-oldest-shadow-root.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-dom-mutation.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-slide-on-shadow-host.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-with-dom-mutation.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-remove-node-crash.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-re-distribution.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-shadow-insertion-points.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-skips-user-agent-shadow-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-skips-user-agent-shadow.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/get-element-by-id-in-shadow-root.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-with-distribution-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-with-distribution.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/move-style-scoped-to-another-shadowroot-crash.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-host-parameter-matches-shadow-host-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-host-parameter-matches-shadow-host.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-for-multiple-shadowroots.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-distribution.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/event-dispatching.js
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-events.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-mouse-event-adjust-offset.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-pseudo-element-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-pseudo-element.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-activeElement.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-blur-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-blur.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-touch-listener-crash.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-styles-select-host.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-under-shadow-root-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-under-shadow-root.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/stylesheets-order-in-shadow-dom-expected.txt
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/stylesheets-order-in-shadow-dom.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/surround-contents-with-shadow-dom.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/text-node-distributed-crash.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/tooltips-in-shadow.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-retargeting.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/LayoutTests/fast/dom/shadow/update-text-of-style-in-shadow-dom.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/PerformanceTests/Events/EventsDispatchingInDeeplyNestedShadowTrees.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/PerformanceTests/Events/EventsDispatchingInShadowTrees.html
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/Source/core/dom/Node.cpp
[modify] http://crrev.com/2226eb587c03a85ae9d5503566c9102fae3cdee9/third_party/WebKit/Source/core/events/EventPath.cpp

Project Member

Comment 49 by bugdroid1@chromium.org, Feb 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d

commit cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d
Author: kochi <kochi@chromium.org>
Date: Wed Feb 10 08:19:25 2016

Make 'mode' required parameter for Element.attachShadow

As 'mode' is a required parameter in the spec, omission should
throw an exception.

BUG=531990
TEST=imported/web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt

Review URL: https://codereview.chromium.org/1685063002

Cr-Commit-Position: refs/heads/master@{#374628}

[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host2.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host3.html
[delete] http://crrev.com/a2d73bc7e3205decb9c6dd9732bd102a732b484e/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4-expected.txt
[delete] http://crrev.com/a2d73bc7e3205decb9c6dd9732bd102a732b484e/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host5.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-method-with-delegatesFocus.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-shadowhost-display-none.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-slide-on-shadow-host.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-with-dom-mutation.html
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt
[modify] http://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d/third_party/WebKit/Source/core/dom/shadow/ShadowRootInit.idl

Project Member

Comment 50 by bugdroid1@chromium.org, Feb 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43dc9606c8ab76d4378d61d964dcac73fd6bb9ca

commit 43dc9606c8ab76d4378d61d964dcac73fd6bb9ca
Author: hayato <hayato@chromium.org>
Date: Mon Feb 15 07:24:16 2016

Set distribution recalc flag when a slot assignment changes

We need to set the recalc flag when a slot assignment changes.
Unless that, the distributed nodes of a slot in a child tree is not updated.

BUG=531990

Review URL: https://codereview.chromium.org/1681683005

Cr-Commit-Position: refs/heads/master@{#375414}

[add] http://crrev.com/43dc9606c8ab76d4378d61d964dcac73fd6bb9ca/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-dynamic.html
[modify] http://crrev.com/43dc9606c8ab76d4378d61d964dcac73fd6bb9ca/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

Project Member

Comment 52 by bugdroid1@chromium.org, Feb 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6

commit 13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6
Author: hayato <hayato@chromium.org>
Date: Wed Feb 17 08:11:23 2016

Update slot's m_distributedIndices correctly

This CL fixes a bug in https://codereview.chromium.org/1611413005.

In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices,
to update this slot's m_distributedIndices correctly.

BUG=531990

Review URL: https://codereview.chromium.org/1695243005

Cr-Commit-Position: refs/heads/master@{#375824}

[modify] http://crrev.com/13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Project Member

Comment 53 by bugdroid1@chromium.org, Feb 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f277728808e60a8b6e7fa9d562bfc3c02501de7d

commit f277728808e60a8b6e7fa9d562bfc3c02501de7d
Author: hayato <hayato@chromium.org>
Date: Thu Feb 18 04:25:08 2016

Support slotchange events

This is a proof of concept to support *slotchange* events at the end of a microtask.

The spec discussion is here: https://github.com/w3c/webcomponents/issues/288

Because slot elements are guarded by ShadowDOMV1 flag, this new events will be seen only when the flag is enabled.

BUG=531990

Review URL: https://codereview.chromium.org/1695163003

Cr-Commit-Position: refs/heads/master@{#376090}

[add] http://crrev.com/f277728808e60a8b6e7fa9d562bfc3c02501de7d/third_party/WebKit/LayoutTests/fast/dom/shadow/slotchange-event.html
[modify] http://crrev.com/f277728808e60a8b6e7fa9d562bfc3c02501de7d/third_party/WebKit/Source/core/dom/Node.cpp
[modify] http://crrev.com/f277728808e60a8b6e7fa9d562bfc3c02501de7d/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] http://crrev.com/f277728808e60a8b6e7fa9d562bfc3c02501de7d/third_party/WebKit/Source/core/events/Event.cpp
[modify] http://crrev.com/f277728808e60a8b6e7fa9d562bfc3c02501de7d/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] http://crrev.com/f277728808e60a8b6e7fa9d562bfc3c02501de7d/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] http://crrev.com/f277728808e60a8b6e7fa9d562bfc3c02501de7d/third_party/WebKit/Source/core/html/HTMLSlotElement.h

Project Member

Comment 54 by bugdroid1@chromium.org, Feb 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/074da65f2d82b187dc44c5c5be09d3fec100d63d

commit 074da65f2d82b187dc44c5c5be09d3fec100d63d
Author: yuzus <yuzus@chromium.org>
Date: Thu Feb 18 05:48:15 2016

Change Event.deepPath to a method

In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990

Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
Cr-Commit-Position: refs/heads/master@{#372596}

Review URL: https://codereview.chromium.org/1637813002

Cr-Commit-Position: refs/heads/master@{#376103}

[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path.html
[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/Source/core/events/Event.idl
[modify] http://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js

Project Member

Comment 55 by bugdroid1@chromium.org, Feb 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d38b39363add3ad9dd401f71cb4b1cf704e892

commit 02d38b39363add3ad9dd401f71cb4b1cf704e892
Author: pfeldman <pfeldman@chromium.org>
Date: Thu Feb 18 19:17:21 2016

Revert of Change Event.deepPath to a method (patchset #4 id:60001 of https://codereview.chromium.org/1637813002/ )

Reason for revert:
Breaks devtools. Landed without devtools review.

Original issue's description:
> Change Event.deepPath to a method
>
> In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
> See the discussion here: https://github.com/w3c/webcomponents/issues/361
> Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
> See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
> BUG=531990
>
> Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
> Cr-Commit-Position: refs/heads/master@{#372596}
>
> Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d
> Cr-Commit-Position: refs/heads/master@{#376103}

TBR=samli@chromium.org,hayato@chromium.org,kochi@chromium.org,kojii@chromium.org,yuzus@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=531990

Review URL: https://codereview.chromium.org/1710893003

Cr-Commit-Position: refs/heads/master@{#376223}

[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path.html
[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/Source/core/events/Event.idl
[modify] https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js

Project Member

Comment 56 by bugdroid1@chromium.org, Feb 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314

commit 78dc6befc74f8b7b823eb071c16ea2bc6a3c3314
Author: yuzus <yuzus@chromium.org>
Date: Fri Feb 19 05:16:40 2016

Change Event.deepPath to a method

In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990

Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
Cr-Commit-Position: refs/heads/master@{#372596}

Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d
Cr-Commit-Position: refs/heads/master@{#376103}

Review URL: https://codereview.chromium.org/1637813002

Cr-Commit-Position: refs/heads/master@{#376395}

[modify] https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314/third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path.html
[modify] https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/78dc6befc74f8b7b823eb071c16ea2bc6a3c3314/third_party/WebKit/Source/core/events/Event.idl

Project Member

Comment 57 by bugdroid1@chromium.org, Feb 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cc0aa3593626f37fb44e99174f1fa3730e1f14c

commit 3cc0aa3593626f37fb44e99174f1fa3730e1f14c
Author: hayato <hayato@chromium.org>
Date: Fri Feb 19 17:40:30 2016

Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled.

This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled.

Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world.

BUG=531990

Review URL: https://codereview.chromium.org/1715623002

Cr-Commit-Position: refs/heads/master@{#376480}

[modify] https://crrev.com/3cc0aa3593626f37fb44e99174f1fa3730e1f14c/third_party/WebKit/Source/core/dom/Node.cpp

Project Member

Comment 58 by bugdroid1@chromium.org, Feb 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a26d2ff5e41ff3281546f9a56514d352281eb5

commit c8a26d2ff5e41ff3281546f9a56514d352281eb5
Author: rune <rune@opera.com>
Date: Mon Feb 22 07:51:42 2016

Don't expose HTMLSlotElement if Shadow DOM V1 is not enabled.

Invoking toString on the element serialized to [object HTMLSlotElement]
which is not correct until we ship.

R=hayato@chromium.org,kochi@chromium.org
BUG=531990

Review URL: https://codereview.chromium.org/1717823002

Cr-Commit-Position: refs/heads/master@{#376701}

[modify] https://crrev.com/c8a26d2ff5e41ff3281546f9a56514d352281eb5/third_party/WebKit/Source/core/html/HTMLTagNames.in

Hi, 
I would love to try the latest V1 and slots, is there a way to set ShadowDOMV1 flag? I cannot find it in about://flags, I also tried adding it in CLI without success.

With latest Canary 50.0.2658.0 `attachShadow` works, but `<slot>` does nothing http://jsbin.com/paruzu/3/edit?html,js,output 

Comment 60 by kochi@chromium.org, Feb 25 2016

tomalecpub@ All the Blink experimental flags can be enabled by
chrome://flags/#enable-experimental-web-platform-features
or passing --enable-experimental-web-platform-features on commandline.

Comment 61 by kochi@chromium.org, Feb 25 2016

tomalecpub@ FYI, if you didn't enable the flag, you should have get an error on attachShadow(), such as

"TypeError: myEl.attachShadow is not a function"

on developer console.

All features related to Shadow DOM v1 should be hidden behind the ShadowDOMV1
flag and should not be exposed.  If you see any instance that V1 feature is
available without enabling the flag, please let us know.  Thanks!
kochi@ Thanks for the answer. 
It does not work in Stable yet, does it?
In Stable with --enable-experimental-web-platform-features I do not get an error, but `<slot>` still does nothing.


In Canary with flag enabled, I'm still not able to use slot inside a `<table>` http://jsbin.com/karitudolu/1/edit?html,js,output and `<select>` http://jsbin.com/biroqohozu/edit?html,js,output  elements.

Is it a bug, or did I get the spec wrong?

Comment 64 by kochi@chromium.org, Feb 26 2016

tomalecpub@ you could infer from the change date in this issue when
any implementation appear in M48 (stable), M49 (beta) or M50 (dev/canary) :)
The implementation is still in progress, and not all feature described in
the spec may not be available even in canary.

Your 2 jsbins look identical (both <select>?).
Could you file a bug for each, blocking this issue (531990)?
Thanks for trying it out!

Comment 67 by kochi@chromium.org, Feb 29 2016

Thanks for the reports, will take a look.
Project Member

Comment 68 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c035a193b7186d58bc072d96a893dad21edeced

commit 4c035a193b7186d58bc072d96a893dad21edeced
Author: hayato <hayato@chromium.org>
Date: Fri Mar 04 06:40:32 2016

Refactoring: Have isDefaultSlotName function

Minor refactoring for a default slot.

BUG=531990

Review URL: https://codereview.chromium.org/1763993002

Cr-Commit-Position: refs/heads/master@{#379231}

[modify] https://crrev.com/4c035a193b7186d58bc072d96a893dad21edeced/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

Project Member

Comment 69 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff5b9d9a9f99edf1392f35558686f9b3edd2663

commit 5ff5b9d9a9f99edf1392f35558686f9b3edd2663
Author: hayato <hayato@chromium.org>
Date: Fri Mar 04 08:33:36 2016

Check slot's distribution state more strictly

- Add more asserts
- Introduce willUpdateDistribution and make clearDistribution, it is now a private function, call it

BUG=531990

Review URL: https://codereview.chromium.org/1760153002

Cr-Commit-Position: refs/heads/master@{#379248}

[modify] https://crrev.com/5ff5b9d9a9f99edf1392f35558686f9b3edd2663/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] https://crrev.com/5ff5b9d9a9f99edf1392f35558686f9b3edd2663/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/5ff5b9d9a9f99edf1392f35558686f9b3edd2663/third_party/WebKit/Source/core/html/HTMLSlotElement.h

Comment 72 by kochi@chromium.org, Mar 15 2016

Blockedon: 487125
Project Member

Comment 73 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/162018f9147e5e2abc3f17e431c1c5495768c350

commit 162018f9147e5e2abc3f17e431c1c5495768c350
Author: hayato <hayato@chromium.org>
Date: Tue Mar 15 12:08:51 2016

Refactor ScopedFocusNavigation

- Make the function names shorter
- Make ScopedFocusNavigation::createFor() takes only one parameter, instead of two, because it receives the same elements

BUG=531990

Review URL: https://codereview.chromium.org/1805483002

Cr-Commit-Position: refs/heads/master@{#381209}

[modify] https://crrev.com/162018f9147e5e2abc3f17e431c1c5495768c350/third_party/WebKit/Source/core/page/FocusController.cpp

Comment 74 by kochi@chromium.org, Mar 22 2016

Blockedon: 596770
Project Member

Comment 75 by bugdroid1@chromium.org, Mar 25 2016

Blockedon: 599743
Blockedon: 598972
Blockedon: -599743
Project Member

Comment 80 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1c03227f44063cd2b42a79fa17ffbcd673191fe

commit a1c03227f44063cd2b42a79fa17ffbcd673191fe
Author: hayato <hayato@chromium.org>
Date: Thu Apr 07 03:23:46 2016

Rename function names to match the DOM Standard

containsIncludingShadowDOM -> isShadowIncludingInclusiveAncestorOf
rootInComposedTree -> shadowIncludingRoot

BUG=531990

Review URL: https://codereview.chromium.org/1868433002

Cr-Commit-Position: refs/heads/master@{#385643}

[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/dom/NodeChildRemovalTracker.h
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/editing/DragCaretController.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Blockedon: 601303
Blockedon: 601348
Project Member

Comment 84 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42739d8adae310a94b87f153878a0f1d4365618b

commit 42739d8adae310a94b87f153878a0f1d4365618b
Author: hayato <hayato@chromium.org>
Date: Tue Apr 12 07:21:09 2016

Clarify that Blink does not support a re-distribution across v0 and v1 shadow trees

I do not have a plan to support a re-distribution across v0 and v1 shadow trees.
It would be better to clarify it in the comment.

BUG=531990

Review URL: https://codereview.chromium.org/1877813002

Cr-Commit-Position: refs/heads/master@{#386606}

[modify] https://crrev.com/42739d8adae310a94b87f153878a0f1d4365618b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

Project Member

Comment 85 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6bc3bb152e2dd11c60140a702f6ef72ccce4152

commit c6bc3bb152e2dd11c60140a702f6ef72ccce4152
Author: hayato <hayato@chromium.org>
Date: Fri Apr 15 09:07:54 2016

Move Node::retarget() to TreeScope::retarget()

It would be better to make TreeScope have this function.
This CL also changes the parameter type from Node to Element because
Element is only the use case, as of now.

BUG=531990

Review URL: https://codereview.chromium.org/1879373002

Cr-Commit-Position: refs/heads/master@{#387562}

[modify] https://crrev.com/c6bc3bb152e2dd11c60140a702f6ef72ccce4152/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/c6bc3bb152e2dd11c60140a702f6ef72ccce4152/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/c6bc3bb152e2dd11c60140a702f6ef72ccce4152/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/c6bc3bb152e2dd11c60140a702f6ef72ccce4152/third_party/WebKit/Source/core/dom/TreeScope.h

Project Member

Comment 86 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a457c140f456055a5d9fda5bea4d2741d9e2cb6d

commit a457c140f456055a5d9fda5bea4d2741d9e2cb6d
Author: hayato <hayato@chromium.org>
Date: Thu Apr 21 08:07:02 2016

Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place, ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRootRareDavaV0 and move some of data into it.
I'll do another clean up in follow-up CLs, moving some of data in ShadowRoot into ShadowRootRareDataV0.

BUG=531990

Review URL: https://codereview.chromium.org/1904703002

Cr-Commit-Position: refs/heads/master@{#388718}

[modify] https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
[modify] https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d/third_party/WebKit/Source/core/dom/shadow/ShadowRootRareData.h
[add] https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d/third_party/WebKit/Source/core/dom/shadow/ShadowRootRareDataV0.h

Project Member

Comment 87 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c47ae70a879d7247c56a842716f4ab67ac25a71d

commit c47ae70a879d7247c56a842716f4ab67ac25a71d
Author: hayato <hayato@chromium.org>
Date: Fri Apr 22 03:50:34 2016

Reduce a shadow root object's size by not inheriting DoublyLinkedList

Using DoublyLinkedList increases a shadow root object's size by adding two pointers,
m_prev and m_next.

Because these pointers are only required for multiple shadow roots,
these pointers can be moved to ShadowRootRareDataV0.

- Maintain a doubly linked list manually, instead of inheriting DoublyLinkedList.
- ElementShadow has only one shadowRoot object, instead of having DoublyLinkedList<ShadowRoot>.
- ElementShadow::m_shadowRoot acts as the oldest shadow root in case for multiple shadow roots.

BUG=531990

Review URL: https://codereview.chromium.org/1904923002

Cr-Commit-Position: refs/heads/master@{#389013}

[modify] https://crrev.com/c47ae70a879d7247c56a842716f4ab67ac25a71d/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
[modify] https://crrev.com/c47ae70a879d7247c56a842716f4ab67ac25a71d/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
[modify] https://crrev.com/c47ae70a879d7247c56a842716f4ab67ac25a71d/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/c47ae70a879d7247c56a842716f4ab67ac25a71d/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
[modify] https://crrev.com/c47ae70a879d7247c56a842716f4ab67ac25a71d/third_party/WebKit/Source/core/dom/shadow/ShadowRootRareDataV0.h

Project Member

Comment 88 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/affcdceef73880b9b2d3b7a889e9da01bca26b8b

commit affcdceef73880b9b2d3b7a889e9da01bca26b8b
Author: hayato <hayato@chromium.org>
Date: Thu Apr 28 10:57:15 2016

Clean up ShadowRootRareData, ShadowRoot and SlotAssignment

A lot of data are being scattered in these classes.

To make it clean and their responsibilities clear, remove ShadowRootRareData,
then move data owned by it into other classes:

- Make SlotAssignment have a responsibility of managing all data related to slot assignments
- Other data are now owned by ShadowRoot directly

BUG=531990

Review-Url: https://codereview.chromium.org/1925043002
Cr-Commit-Position: refs/heads/master@{#390345}

[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
[delete] https://crrev.com/bd6e76400ea944185355bad53499494b1e778019/third_party/WebKit/Source/core/dom/shadow/ShadowRootRareData.h
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h
[modify] https://crrev.com/affcdceef73880b9b2d3b7a889e9da01bca26b8b/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp

Project Member

Comment 89 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08405679e3c56b833b4c6da3135b30485fad279b

commit 08405679e3c56b833b4c6da3135b30485fad279b
Author: dglazkov <dglazkov@chromium.org>
Date: Thu May 05 01:18:06 2016

Revert of Ship Node.rootNode (patchset #2 id:20001 of https://codereview.chromium.org/1783693002/ )

Reason for revert:
Turns out that the change is not Web-compatible. See https://bugs.chromium.org/p/chromium/issues/detail?id=608006 for details.

Original issue's description:
> Ship Node.rootNode
>
> This CL ships Node.rootNode independently from other ShadowDOM features, in response to requests from web developers.
> LGTM-ed on this thread :  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LpXX7Svx8IY
>
> BUG=531990
>
> Committed: https://crrev.com/9ca99ec409a1d6f7baf6dd3cd6929e81c967cac1
> Cr-Commit-Position: refs/heads/master@{#380363}

TBR=tkent@chromium.org,hayato@chromium.org,kochi@chromium.org,yuzus@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=531990

Review-Url: https://codereview.chromium.org/1945823004
Cr-Commit-Position: refs/heads/master@{#391723}

[modify] https://crrev.com/08405679e3c56b833b4c6da3135b30485fad279b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/08405679e3c56b833b4c6da3135b30485fad279b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/08405679e3c56b833b4c6da3135b30485fad279b/third_party/WebKit/Source/core/dom/Node.idl

Comment 90 by kochi@chromium.org, May 10 2016

Blockedon: 610588
Project Member

Comment 91 by bugdroid1@chromium.org, May 11 2016

Labels: merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a505bf8131eb3bff547835f89dd3036ab5c90f

commit f0a505bf8131eb3bff547835f89dd3036ab5c90f
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed May 11 01:32:33 2016

Revert of Ship Node.rootNode (patchset #2 id:20001 of https://codereview.chromium.org/1783693002/ )

Reason for revert:
Turns out that the change is not Web-compatible. See https://bugs.chromium.org/p/chromium/issues/detail?id=608006 for details.

Original issue's description:
> Ship Node.rootNode
>
> This CL ships Node.rootNode independently from other ShadowDOM features, in response to requests from web developers.
> LGTM-ed on this thread :  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LpXX7Svx8IY
>
> BUG=531990
>
> Committed: https://crrev.com/9ca99ec409a1d6f7baf6dd3cd6929e81c967cac1
> Cr-Commit-Position: refs/heads/master@{#380363}

TBR=tkent@chromium.org,hayato@chromium.org,kochi@chromium.org,yuzus@chromium.org
BUG=531990, 608006

Review-Url: https://codereview.chromium.org/1945823004
Cr-Commit-Position: refs/heads/master@{#391723}
(cherry picked from commit 08405679e3c56b833b4c6da3135b30485fad279b)

Review URL: https://codereview.chromium.org/1962403004 .

Cr-Commit-Position: refs/branch-heads/2704@{#492}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/f0a505bf8131eb3bff547835f89dd3036ab5c90f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/f0a505bf8131eb3bff547835f89dd3036ab5c90f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f0a505bf8131eb3bff547835f89dd3036ab5c90f/third_party/WebKit/Source/core/dom/Node.idl

Comment 92 by kochi@chromium.org, May 11 2016

Blockedon: 610952
Blockedon: 610961

Comment 94 by 93m...@gmail.com, May 11 2016

I think this should be blocked on 610092; otherwise pages can abuse closed shadow DOMs to disable extensions from modifying and querying their DOM.

Comment 95 by kochi@chromium.org, May 11 2016

93mrmr@ no, this is for launching Shadow DOM v1 for the Web, not for the extension ecosystem.

Comment 96 by 93m...@gmail.com, May 11 2016

Is it likely that that issue will see resolution before shipping? It would seem like bad form to ship a de facto opt-out of extensions.
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 99 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a

commit 6310c024c916f3f7ea89eb3ffabbc94e59a3c29a
Author: hayato <hayato@chromium.org>
Date: Fri May 27 11:59:39 2016

Rewrite Shadow DOM distribution engine to support partial synchronous distribution for v1

This is a huge engine rewrite to support slotchange [1] events more strictly
and more efficiently.

The summary of the changes is:

1. Make Blink be more spec compliant, regarding slotchange event.

2. Get significant performance improvements.

   Now SlotAssignment has |slotname|-to-|slot| HashMap, via DocumentOrderedMap.
   This HashMap is updated in each insertion/removal/renaming of slots.

   Though DOM Standard [2] requires synchronous calculation of slot assignments
   in each DOM mutation to fire a slotchagne event at the end of microtask,
   this CL does not calculate it synchronously, as an important optimization,
   if we can be sure to delay it. Instead, we do a minimum necessary check to
   detect a slotchange, using the characteristics of slot assignments.

   Especially, appending a child to a shadow host, which happens a lot in
   Polymer, becomes much faster.

3. Make HTMLSlotElement a much smaller footprint element.

   The following member variables are removed:
     m_oldAssignedNodes, m_oldDistributedNodes, m_fallbackNodes, m_oldFallbackNodes,
     m_distributionState and m_assignmentState.

4. Make SlotAssignment::resolveDistribution much simpler because slotchange is
   already detected at early stage.

See the bug 610961 for details to know the basic ideas behind the scene.

The results of micro benchmarks are:

- PerformanceTests/ShadowDOM/v1-distribution.html => About 1.8x faster
  Time:
    Before: avg 3190.3 runs/s
    After:  avg 5885.6 runs/s

- PerformanceTests/ShadowDOM/v1-host-child-append.html => About 6.0x faster
  Time:
    Before: avg  51.6 runs/s
    After:  avg 306.4 runs/s

- PerformanceTests/ShadowDOM/v1-slot-append.html => About 3.4x faster
  Time:
    Before: avg 1647.4 runs/s
    After:  avg 5645.0 runs/s

This CL also reduced the memory usage in micro benchmarks because a slot element
becomes a smaller footprint element.

- PerformanceTests/ShadowDOM/v1-distribution.html
  JS Heap:
    Before: avg 21357790.4 bytes
    After:  avg  3136606.4 bytes

- PerformanceTests/ShadowDOM/v1-host-child-append.html
  JS Heap:
    Before: avg 5860745.6 bytes
    After:  avg 4165614.4 bytes

- PerformanceTests/ShadowDOM/v1-slot-append.html
  JS Heap:
    Before: avg 13256016 bytes
    After:  avg  3540172.8 bytes

Notes:
- Reducing the memory usage is not the primary motivation of this CL.
- These performance tests are being marked skipped. See crbug.com/579107
- This CL also fixes the following bugs. These tests no longer fail.
  - crbug.com/610588
  - imported/wpt/shadow-dom/HTMLSlotElement-interface.html

The future works are:

1. There is a still false-positive case for slotchange event.

   e.g. A preceding slot is inserted together with a following slot.  This would
   not be a significant issue, but should be fixed. As of now, we must pay a
   performance penalty to remove this kind of false-positive.

2. Add more layout tests and add W3C Web Platform tests to be upstreamed.

3. Optimize the performance more and more.

    e.g. It might be possible to optimize
    HTMLSlotElement::hasAssignedNodesSynchronously by using yet another data
    structure.

4. Support SlotAssignment for non shadow trees. e.g. a document tree.

    This is a low-priority task because a document tree is unlikely to have a
    slot.

5. Isolate NeedsRecalDistribution flag for v0 and v1.

    Currently, the same flag is used in both kinds of shadow trees, v0 and v1,
    to support both together in one page.

6. DocumentOrderedMap might not be optimized for our purpose.

    e.g. DocumentOrderedMap has to travers DOM Tree if conflicts happen.
    Just using Document::compareDocumentPosition() might be better, given that
    conflicts is unlikely to happen.

Links:

[1] slotchange event: https://github.com/w3c/webcomponents/issues/288
[2] Relevant DOM Standard sections: https://dom.spec.whatwg.org/
    4.2.2 Shadow tree  4.2.2.1 Slots
      4.2.2.2 Slotables
      4.2.2.3 Finding slots and slotables
      4.2.2.4 Assigning slotables and slots
      4.2.2.5 Signaling slot changes
    4.2.3 Mutation algorithms

BUG=531990,595287,610588,610961,579107

Review-Url: https://codereview.chromium.org/1995203002
Cr-Commit-Position: refs/heads/master@{#396443}

[delete] https://crrev.com/42b137d8600104c1853de10626f6ef1e15e972ab/third_party/WebKit/LayoutTests/imported/wpt/shadow-dom/HTMLSlotElement-interface-expected.txt
[add] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/LayoutTests/shadow-dom/slotchange-host-child-appended.html
[add] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/LayoutTests/shadow-dom/slotchange-node-removed.html
[add] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/LayoutTests/shadow-dom/slotchange-slotname-renamed.html
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/PerformanceTests/ShadowDOM/v1-distribution.html
[add] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/PerformanceTests/ShadowDOM/v1-host-child-append.html
[add] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/PerformanceTests/ShadowDOM/v1-slot-append.html
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/PerformanceTests/Skipped
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/DocumentOrderedMap.h
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.h
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/6310c024c916f3f7ea89eb3ffabbc94e59a3c29a/third_party/WebKit/Source/core/html/HTMLSlotElement.h

Project Member

Comment 100 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0a90bdd71d65c6fbf747cc789f44394a68fc24c

commit a0a90bdd71d65c6fbf747cc789f44394a68fc24c
Author: hayato <hayato@chromium.org>
Date: Tue May 31 07:38:54 2016

Rename Event.deepPath() to Event.composedPath()

We renamed Event.deepPath() to Event.composedPath().

Issue: https://github.com/whatwg/dom/issues/242
DOM Standard: https://dom.spec.whatwg.org/#dom-event-composedpath

For histograms,
TBR=isherman@chromium.org

BUG=531990

Review-Url: https://codereview.chromium.org/2014173002
Cr-Commit-Position: refs/heads/master@{#396799}

[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path-empty.html
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path.html
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot-expected.txt
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot.html
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2-expected.txt
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2.html
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/shadow-dom/scoped-events-by-ua-stopped.html
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/Source/core/events/Event.idl
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/a0a90bdd71d65c6fbf747cc789f44394a68fc24c/tools/metrics/histograms/histograms.xml

Project Member

Comment 101 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7

commit e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7
Author: hayato <hayato@chromium.org>
Date: Tue May 31 12:47:51 2016

Rename Event.scoped to Event.composed with default being false

See https://dom.spec.whatwg.org/#dom-event-composed for the spec.
See https://github.com/whatwg/html/issues/1160 for the context.

For histograms,
TBR=isherman@chromium.org

BUG=531990

Review-Url: https://codereview.chromium.org/2012423004
Cr-Commit-Position: refs/heads/master@{#396819}

[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt
[add] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/shadow-dom/scoped-events-by-ua-stopped.html
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/shadow-dom/slotchange-event.html
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/shadow-dom/slotchange-host-child-appended.html
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/shadow-dom/slotchange-node-removed.html
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/shadow-dom/slotchange-slotname-renamed.html
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/Source/core/events/Event.idl
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/Source/core/events/EventInit.idl
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/e92d0a685af6a88b47d10a6abf5f9aaf29dcdeb7/tools/metrics/histograms/histograms.xml

Project Member

Comment 102 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4b8210a70c2b5315fbff25cadde8b756137d557

commit a4b8210a70c2b5315fbff25cadde8b756137d557
Author: hayato <hayato@chromium.org>
Date: Thu Jun 02 07:32:39 2016

Remove Event.relatedTargetScoped and update event path calculation for relatedTarget

See the context: https://github.com/w3c/webcomponents/issues/486

The spec change:
- https://github.com/w3c/webcomponents/commit/f113e26bfa999bac730c65ea7418fe787500313c
- https://github.com/w3c/webcomponents/commit/b1433e5f3a013ca825f02fb8f7b0e9d6217c0125

BUG=531990

Review-Url: https://codereview.chromium.org/2030513002
Cr-Commit-Position: refs/heads/master@{#397329}

[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html
[delete] https://crrev.com/c25500369dd9a7f49d2b7d276556b2e22ba840c8/third_party/WebKit/LayoutTests/shadow-dom/events-related-target-scoped.html
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/DragEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/Event.idl
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/EventInit.idl
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/EventPath.h
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/FocusEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/GestureEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/MouseRelatedEvent.h
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/PointerEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/RelatedEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/UIEvent.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/UIEvent.h
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/events/UIEventWithKeyState.h
[modify] https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557/third_party/WebKit/Source/core/frame/UseCounter.h

Project Member

Comment 104 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/557ec07b3ab3b1535e71f86310f38b3517acc980

commit 557ec07b3ab3b1535e71f86310f38b3517acc980
Author: hayato <hayato@chromium.org>
Date: Fri Jun 03 11:19:18 2016

Set Event.composed flag correctly for some of UA UIEvents

See https://github.com/w3c/webcomponents/issues/513 for the context.

See also the previous CL: https://codereview.chromium.org/2012423004, where
Event.composed was introduced.

The change is visible only when Shadow DOM v1 is used.

BUG=531990,616654

Review-Url: https://codereview.chromium.org/2030243004
Cr-Commit-Position: refs/heads/master@{#397681}

[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/CompositionEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/FocusEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/TextEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/UIEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/UIEvent.h
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp

Project Member

Comment 105 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd0c6392adc136ea7ac74a67fc0c676318a1b50

commit 6bd0c6392adc136ea7ac74a67fc0c676318a1b50
Author: hayato <hayato@chromium.org>
Date: Mon Jun 06 06:12:44 2016

Cache the result of isScopedInV0 flag in Event object

This makes the micro benchmarks (PerformanceTests/Events/) slightly faster.

BUG=531990,617113

Review-Url: https://codereview.chromium.org/2034413002
Cr-Commit-Position: refs/heads/master@{#397983}

[modify] https://crrev.com/6bd0c6392adc136ea7ac74a67fc0c676318a1b50/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/6bd0c6392adc136ea7ac74a67fc0c676318a1b50/third_party/WebKit/Source/core/events/Event.h

Project Member

Comment 106 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa0e87122906c7957d856576825712667cc0ae8

commit 2fa0e87122906c7957d856576825712667cc0ae8
Author: hayato <hayato@chromium.org>
Date: Thu Jun 09 09:49:15 2016

Clean up layout tests in LayoutTests/shadow-dom/

- Remove "v1-" prefix.
- Clean up styles
- Use makeTestTree() as much as possible

Clean up is not finished. Other clean up CLs will come later.

BUG=531990

Review-Url: https://codereview.chromium.org/2053503003
Cr-Commit-Position: refs/heads/master@{#398827}

[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/attachShadow-safelist.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/default-slots.html
[modify] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-1-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-1.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-2-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-2.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-1.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-2.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-dynamic.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-in-v0.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-with-closed-shadow-tree.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-dom-mutation.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-1-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-1.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-2-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-2.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-3-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-3.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-1.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-2.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-3.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-4.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-in-document-tree.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-text-nodes.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-1.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-2.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-dynamic.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-with-closed-shadow-tree.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dom-mutation.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-1.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-2.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-3.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-4.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-document-tree.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-text-nodes.html

Project Member

Comment 107 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e

commit b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e
Author: hayato <hayato@chromium.org>
Date: Thu Jun 09 10:19:25 2016

Remove unnecessary calling offset{Top,Left}

All APIs should work without calling offsetXXX explicitly.

BUG=531990

Review-Url: https://codereview.chromium.org/2039813008
Cr-Commit-Position: refs/heads/master@{#398832}

[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host2.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host3.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host5.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/default-slots.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-with-delegatesFocus.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/focus-slide-on-shadow-host.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/focus-with-dom-mutation.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/inherit-into-slotted.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/slots-api-in-v0.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/v0-inert-features-in-v1-shadow-trees.html

Project Member

Comment 108 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05dfeece047ff46aa141f167598e2ec8b3cb3da7

commit 05dfeece047ff46aa141f167598e2ec8b3cb3da7
Author: hayato <hayato@chromium.org>
Date: Fri Jun 10 06:55:19 2016

Rewrite and organize tests in LayoutTests/shadow-dom

To separate our concerns, move some tests to LayoutTests/shadow-dom/v0 directory if
they are also testing v0 features for compatibility reasons.

In summary:

- LayoutTests/shadow-dom/
  Used for tests if they are testing only v1 features
- LayoutTests/shadow-dom/v0/
  Used for tests if they are also testing v0 featuers

Clean up is not finished. Other clean up CLs will come later.

BUG=531990

Review-Url: https://codereview.chromium.org/2051373002
Cr-Commit-Position: refs/heads/master@{#399127}

[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/default-slots.html
[add] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path-empty.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot-expected.txt
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html
[modify] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[add] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/slots-default-slot.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html
[add] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/multiple-shadowroot-with-params-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/multiple-shadowroot-with-params.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/slots-api-in-v0.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/slots-in-v0-expected.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/slots-in-v0.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/v0-inert-features-in-v1-shadow-trees.html

Project Member

Comment 109 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa0e87122906c7957d856576825712667cc0ae8

commit 2fa0e87122906c7957d856576825712667cc0ae8
Author: hayato <hayato@chromium.org>
Date: Thu Jun 09 09:49:15 2016

Clean up layout tests in LayoutTests/shadow-dom/

- Remove "v1-" prefix.
- Clean up styles
- Use makeTestTree() as much as possible

Clean up is not finished. Other clean up CLs will come later.

BUG=531990

Review-Url: https://codereview.chromium.org/2053503003
Cr-Commit-Position: refs/heads/master@{#398827}

[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/attachShadow-safelist.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/default-slots.html
[modify] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-1-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-1.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-2-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-2.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-1.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-2.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-dynamic.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-in-v0.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-api-with-closed-shadow-tree.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-dom-mutation.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-1-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-1.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-2-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-2.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-3-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-3.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-1.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-2.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-3.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-4.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-in-document-tree.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0-expected.html
[rename] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0.html
[add] https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8/third_party/WebKit/LayoutTests/shadow-dom/slots-text-nodes.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-1.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-2.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-dynamic.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-with-closed-shadow-tree.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dom-mutation.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-1.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-2.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-3.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-4.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-document-tree.html
[delete] https://crrev.com/e0144dd96e5391c36ee13b2c777b6dec8a762f5d/third_party/WebKit/LayoutTests/shadow-dom/v1-slots-text-nodes.html

Project Member

Comment 110 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e

commit b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e
Author: hayato <hayato@chromium.org>
Date: Thu Jun 09 10:19:25 2016

Remove unnecessary calling offset{Top,Left}

All APIs should work without calling offsetXXX explicitly.

BUG=531990

Review-Url: https://codereview.chromium.org/2039813008
Cr-Commit-Position: refs/heads/master@{#398832}

[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host2.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host3.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host5.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/default-slots.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-with-delegatesFocus.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/focus-slide-on-shadow-host.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/focus-with-dom-mutation.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/inherit-into-slotted.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/slots-api-in-v0.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic.html
[modify] https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e/third_party/WebKit/LayoutTests/shadow-dom/v0-inert-features-in-v1-shadow-trees.html

Project Member

Comment 111 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05dfeece047ff46aa141f167598e2ec8b3cb3da7

commit 05dfeece047ff46aa141f167598e2ec8b3cb3da7
Author: hayato <hayato@chromium.org>
Date: Fri Jun 10 06:55:19 2016

Rewrite and organize tests in LayoutTests/shadow-dom

To separate our concerns, move some tests to LayoutTests/shadow-dom/v0 directory if
they are also testing v0 features for compatibility reasons.

In summary:

- LayoutTests/shadow-dom/
  Used for tests if they are testing only v1 features
- LayoutTests/shadow-dom/v0/
  Used for tests if they are also testing v0 featuers

Clean up is not finished. Other clean up CLs will come later.

BUG=531990

Review-Url: https://codereview.chromium.org/2051373002
Cr-Commit-Position: refs/heads/master@{#399127}

[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/default-slots.html
[add] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path-empty.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deep-path.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot-expected.txt
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot.html
[delete] https://crrev.com/32ab2d4c4cdca33398c7af1e05c058d5f10102ab/third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html
[modify] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[add] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/slots-default-slot.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html
[add] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/multiple-shadowroot-with-params-expected.txt
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/multiple-shadowroot-with-params.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/slots-api-in-v0.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/slots-in-v0-expected.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/slots-in-v0.html
[rename] https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7/third_party/WebKit/LayoutTests/shadow-dom/v0/v0-inert-features-in-v1-shadow-trees.html

Project Member

Comment 112 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e35e056ed2bde8888f123e01c55c747aad0fdfc

commit 0e35e056ed2bde8888f123e01c55c747aad0fdfc
Author: hayato <hayato@chromium.org>
Date: Thu Jun 16 07:24:56 2016

Rewrite LayoutTests/shadow-dom/event-composed-path.html

Make the test more comprehensive and redable.

BUG=531990

Review-Url: https://codereview.chromium.org/2058673002
Cr-Commit-Position: refs/heads/master@{#400101}

[modify] https://crrev.com/0e35e056ed2bde8888f123e01c55c747aad0fdfc/third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html

Project Member

Comment 115 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6502220de4e8cb4dbb28fe0ea21035453b02d3ac

commit 6502220de4e8cb4dbb28fe0ea21035453b02d3ac
Author: hayato <hayato@chromium.org>
Date: Thu Jun 16 14:33:08 2016

Rewrite tests for slots

Make the test more comprehensive, organized, and readable.

BUG=531990

Review-Url: https://codereview.chromium.org/2060793002
Cr-Commit-Position: refs/heads/master@{#400152}

[modify] https://crrev.com/6502220de4e8cb4dbb28fe0ea21035453b02d3ac/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-api-1.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-api-2.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-api-dynamic.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-api-with-closed-shadow-tree.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-default-slot.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-dom-mutation.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-1.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-2.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-3.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-4.html
[add] https://crrev.com/6502220de4e8cb4dbb28fe0ea21035453b02d3ac/third_party/WebKit/LayoutTests/shadow-dom/slots-fallback.html
[delete] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/third_party/WebKit/LayoutTests/shadow-dom/slots-in-document-tree.html
[add] https://crrev.com/6502220de4e8cb4dbb28fe0ea21035453b02d3ac/third_party/WebKit/LayoutTests/shadow-dom/slots.html

Project Member

Comment 117 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae9811073f3613ccec7fb6f18b8562b409af1a57

commit ae9811073f3613ccec7fb6f18b8562b409af1a57
Author: hayato <hayato@chromium.org>
Date: Mon Jun 20 11:21:23 2016

Remove old tests for slotchange events

This test should be deleted at https://codereview.chromium.org/2076933002

BUG=531990

Review-Url: https://codereview.chromium.org/2071133004
Cr-Commit-Position: refs/heads/master@{#400652}

[delete] https://crrev.com/509a7f00acc736e6e528642ed1c982295ad69c25/third_party/WebKit/LayoutTests/shadow-dom/slotchange-event.html

Project Member

Comment 118 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/695bbbd8361fff98468f0602c1df26008410a648

commit 695bbbd8361fff98468f0602c1df26008410a648
Author: hayato <hayato@chromium.org>
Date: Wed Jun 22 04:52:22 2016

Clean up shadow-dom layout tests so that they are well organized

Renames and organize tests in LayoutTests/shadow-dom/ so that we can understand each
test's purpose more easily.

BUG=531990

Review-Url: https://codereview.chromium.org/2074393002
Cr-Commit-Position: refs/heads/master@{#401209}

[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-mode.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-safelist.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-inner-scope-important-expected.txt
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-inner-scope-important.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-multiple-shadow-with-host-rules.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope-expected.txt
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope2-expected.txt
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope2.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-slot-distributed-expected.txt
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-slot-distributed.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-cascade-upgrade-from-v0-to-v1.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-style-inherit-expected.txt
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/css-style-inherit.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/focus-navagation-slots.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-slot-fallback.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-slot-with-tabindex.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/focus-navigation.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/nodetree-labels-node-list.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/nodetree-radio-node-list.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/range-caret-range-from-point-left-of-shadow.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo.html
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators-expected.txt
[rename] https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators.html

Blockedon: 622185
Project Member

Comment 120 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505c030552ed7a13a108f77ce0829409e542b07c

commit 505c030552ed7a13a108f77ce0829409e542b07c
Author: hayato <hayato@chromium.org>
Date: Thu Jun 23 01:49:27 2016

Make sure to lazyReattach a distributed node if it is already attached

For Shadow DOM v0, InsertionPoint::setDistributedNodes() is calling
lazyReattachIfAttached for distributed nodes, if necessary.

The same thing should be done for Shadow DOM v1 too. Unless that, the old layout
object will be re-used wrongly.

BUG=531990,622185

Review-Url: https://codereview.chromium.org/2086013003
Cr-Commit-Position: refs/heads/master@{#401512}

[add] https://crrev.com/505c030552ed7a13a108f77ce0829409e542b07c/third_party/WebKit/LayoutTests/shadow-dom/layout-expected.html
[add] https://crrev.com/505c030552ed7a13a108f77ce0829409e542b07c/third_party/WebKit/LayoutTests/shadow-dom/layout.html
[modify] https://crrev.com/505c030552ed7a13a108f77ce0829409e542b07c/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] https://crrev.com/505c030552ed7a13a108f77ce0829409e542b07c/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/505c030552ed7a13a108f77ce0829409e542b07c/third_party/WebKit/Source/core/html/HTMLSlotElement.h

Project Member

Comment 121 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa38a0afc1d55a8a625b87514d4799877c2d2ef7

commit fa38a0afc1d55a8a625b87514d4799877c2d2ef7
Author: hayato <hayato@chromium.org>
Date: Fri Jun 24 01:51:04 2016

Support Custom Elements v1 in attachShadow

After renaming CustomElement to CustomElementV0, it looks the support of Custom
Elements v1 in attachShadow has been forgotten. Fix it.

BUG=531990,621942

Review-Url: https://codereview.chromium.org/2092703002
Cr-Commit-Position: refs/heads/master@{#401779}

[modify] https://crrev.com/fa38a0afc1d55a8a625b87514d4799877c2d2ef7/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-safelist.html
[modify] https://crrev.com/fa38a0afc1d55a8a625b87514d4799877c2d2ef7/third_party/WebKit/Source/core/dom/Element.cpp

Labels: Launch-M-Approved-53-Stable Launch-M-Target-53-Stable
Blockedon: -610952
Project Member

Comment 124 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5401b41c540d2ace9e9d773ece97a615729b6557

commit 5401b41c540d2ace9e9d773ece97a615729b6557
Author: hayato <hayato@chromium.org>
Date: Wed Jun 29 03:07:12 2016

Remove Node.rootNode

Before shipping Shadow DOM v1, we have to remove this feature because Node.rootNode
is guarded by ShadowDOMV1 flag.

See also https://bugs.chromium.org/p/chromium/issues/detail?id=608006.
Ship of Node.rootNode was reverted there.

BUG=531990

Review-Url: https://codereview.chromium.org/2106683002
Cr-Commit-Position: refs/heads/master@{#402697}

[modify] https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557/third_party/WebKit/LayoutTests/imported/wpt/dom/historical-expected.txt
[delete] https://crrev.com/45859e627709ac2a56e939a00f725a0fca27f75f/third_party/WebKit/LayoutTests/shadow-dom/node-rootNode.html
[modify] https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557/third_party/WebKit/Source/core/dom/Node.idl
[modify] https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557/tools/metrics/histograms/histograms.xml

Project Member

Comment 125 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97235496c3dee67efb24f9a7893232df493dcd1e

commit 97235496c3dee67efb24f9a7893232df493dcd1e
Author: hayato <hayato@chromium.org>
Date: Wed Jun 29 04:55:58 2016

Ship Shadow DOM v1

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/zrZRD2ls5tw/ibbjD3cQAQAJ

BUG=531990

Review-Url: https://codereview.chromium.org/2108533002
Cr-Commit-Position: refs/heads/master@{#402723}

[modify] https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 126 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18d455ee833f6a30dcbe2755380861eb75cd9f6f

commit 18d455ee833f6a30dcbe2755380861eb75cd9f6f
Author: kochi <kochi@chromium.org>
Date: Wed Jun 29 08:52:42 2016

Implement closed shadow adjustment for Element.offsetParent

If |offsetParent| is not an unclosed node of the context
object, search the layout tree up until an unclosed node
is found.

|offsetTop| etc. will be adjusted relative to this
|offsetParent| value.

See also
https://github.com/w3c/webcomponents/issues/497
https://github.com/w3c/csswg-drafts/issues/159
for the discussions about spec clarifications.

BUG=531990

Review-Url: https://codereview.chromium.org/2051703002
Cr-Commit-Position: refs/heads/master@{#402757}

[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
[add] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/LayoutTests/shadow-dom/offsetParent.html
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/html/HTMLElement.h
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/html/HTMLElement.idl
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutInline.h
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/layout/LayoutVideo.h
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/page/PrintContext.cpp
[modify] https://crrev.com/18d455ee833f6a30dcbe2755380861eb75cd9f6f/third_party/WebKit/Source/core/testing/Internals.cpp

Status: Fixed (was: Started)
Let's close this, and fix non-blocking issues as separated issues.

\o/
\o/
Showing comments 30 - 129 of 129 Older

Sign in to add a comment