New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 520460 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 455093



Sign in to add a comment

Implement Request.destination

Project Member Reported by hirosh...@chromium.org, Aug 13 2015

Issue description

Request.context was removed ( Issue 515786 ) and Request.type and Request.destination are introduced instead.
Spec update: https://github.com/whatwg/fetch/issues/93
(We have to wait a while to confirm the spec is stabilized)

"We should do a Intent to Ship" (#6 in  Issue 515786 ).

 
Blocking: chromium:455093

Comment 2 by tkent@chromium.org, Nov 27 2015

Labels: -Cr-Blink-FetchAPI Cr-Blink-Network-FetchAPI
Status: Available (was: Untriaged)
As of https://github.com/whatwg/fetch/pull/582 Request.type has been "folded" into Request.destination just a heads up! I haven't contributed to chromium before but am looking for a good contribution and would like to take a crack at this one with some guidance :) I assume the first step is to update the IDL to add the destination attribute?

Comment 5 by y...@yoav.ws, Dec 21 2017

Cc: y...@yoav.ws

Comment 6 by y...@yoav.ws, Dec 27 2017

Owner: y...@yoav.ws
Status: Started (was: Available)

Comment 7 by y...@yoav.ws, Dec 27 2017

Summary: Implement Request.destination (was: Implement Request.type / Request.destination)
Removing `Request.type` from the description, as it was removed from the spec.

Comment 8 by y...@yoav.ws, Dec 27 2017

Apologies domfarolino@! I didn't see your comment here before (and the fact that you're interested in tackling this issue) and already implemented most if not all of it this morning... :|

Patch is at https://chromium-review.googlesource.com/c/chromium/src/+/844081 and mostly involved adding `destination` to Request.idl, and replacing the `Request.Context()` implementation with a `destination()` one (which is based on the same underlying concept of RequestContext).
No worries Yoav! Thanks for commenting and supplying the patch link. Excited for further contributions :)
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e98a80cde1a08624aaf6c9a06a816991059991af

commit e98a80cde1a08624aaf6c9a06a816991059991af
Author: Yoav Weiss <yoav@yoav.ws>
Date: Sat Jan 06 19:06:39 2018

Remove Request.Context and expose Request.destination

Request.Context was removed from the Fetch spec, and Request.destination
replaced it. Exposing `destination` will enable some use-cases where
Service Worker code needs to know which resource it is dealing with [1].
This CL exposes that property by default.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Rb3B-l_Gnzc/VtYII4mWBAAJ

Bug:  520460 
Change-Id: I75ad00326f2f1e0a93f25132e9b13bea44ccbf2f

[1] https://github.com/whatwg/fetch/issues/634

Change-Id: I75ad00326f2f1e0a93f25132e9b13bea44ccbf2f
Reviewed-on: https://chromium-review.googlesource.com/844081
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527523}
[delete] https://crrev.com/35d4a2da8c8e559bfc20cc633d0e8f3533edc0dc/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/destination/fetch-destination-iframe.https-expected.txt
[delete] https://crrev.com/35d4a2da8c8e559bfc20cc633d0e8f3533edc0dc/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/destination/fetch-destination-no-load-event.https-expected.txt
[delete] https://crrev.com/35d4a2da8c8e559bfc20cc633d0e8f3533edc0dc/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/destination/fetch-destination-worker.https-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/destination/fetch-destination.https-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-idl-expected.txt
[delete] https://crrev.com/35d4a2da8c8e559bfc20cc633d0e8f3533edc0dc/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-structure-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/Source/core/fetch/Request.cpp
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/Source/core/fetch/Request.h
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/Source/core/fetch/Request.idl
[modify] https://crrev.com/e98a80cde1a08624aaf6c9a06a816991059991af/third_party/WebKit/Source/core/fetch/RequestTest.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c34fb0d3f9f9536206ce8619ada99726fd79eafa

commit c34fb0d3f9f9536206ce8619ada99726fd79eafa
Author: Yoav Weiss <yoav@yoav.ws>
Date: Mon Jan 08 21:56:39 2018

Correctly expose audio destination for audio resources

Exposing destination exposed the fact that internally we don't distinguish
Audio from Video fetch contexts. This CL fixes that by splitting the Media
fetch context into those two separate ones.

Bug:  520460 
Change-Id: Ie7601e4eeea92fd416fdc5dca348cac6520bbf2f
Reviewed-on: https://chromium-review.googlesource.com/846983
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#527772}
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer.h
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer_data_source.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer_data_source.h
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer_data_source_unittest.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer_reader.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer_reader.h
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/multibuffer_unittest.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/resource_multibuffer_data_provider.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/resource_multibuffer_data_provider.h
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/resource_multibuffer_data_provider_unittest.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/url_index.cc
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/url_index.h
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/media/blink/webmediaplayer_impl.cc
[delete] https://crrev.com/e77cea9eaadf33e1d26d38d25e52ecb0be9bbb24/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/destination/fetch-destination.https-expected.txt
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/platform/loader/fetch/RawResource.h
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/platform/loader/fetch/Resource.h
[modify] https://crrev.com/c34fb0d3f9f9536206ce8619ada99726fd79eafa/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Comment 12 by y...@yoav.ws, Jan 8 2018

Status: Fixed (was: Started)

Sign in to add a comment