New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Available
Owner: ----
EstimatedDays: ----
NextAction: ----
Pri: 3
Type: Bug

Sign in to add a comment

Issue 520437: Switch iOS to use the Posix login DB

Reported by, Aug 13 2015 Project Member

Issue description

The LoginDatabase on iOS should work as on CrOS -- storing passwords in the database in plain text, relying on the OS-level storage protection.

We need to do 2 steps:

(1) Change the current behaviour of the LoginDatabase on iOS, which stores only IDs of passwords in the database, and the passwords themselves in the iOS keychain.

(2) Move the database code completely upstream, removing any diffs in the downstream copy of Chromium, or special code in the internal iOS repo.

Comment 1 by, Aug 13 2015

Blocking: chromium:507778

Comment 2 by, Aug 13 2015

Labels: Cr-Privacy Cr-Security
This has been discussed with jww@, and tha password manager team, which overlaps with privacy a lot, but still, adding Privacy and Security labels as a FYI to the respective teams. Affected teams, feel free to remove the labels to reduce spam, if you are fine with the plan.

Comment 3 by, Aug 13 2015

@melandory -- given, feel free to grab this one. But from our recent conversation I believe it is not currently on top of your list, so I kept it with me in case I get to it faster. Did not mean to steal it from you, though, so happy to give it back to you.

Comment 4 by, Aug 14 2015

I won't get to this until back from holiday.
@melandory -- don't wait for me if you want to grab this (but it is OK if you don't find time, there is no rush).

Comment 5 by, Oct 6 2015


Comment 6 by, Nov 4 2015

Status update: upstream will be patched to match downstream pretty soon (, after that we'll proceed to actually get rid of the iOS-specific code for LoginDatabase and migrate iOS to use the same as Linux and CrOS do.

Comment 7 by, Nov 6 2015

Project Member

Comment 9 by, Nov 6 2015

Bug update: Thanks to melandory@'s #7 and #8, the downstream diff for //components/password_manager should disappear completely.

The rest of this bug is upstream-only, switching iOS to use the Posix login DB.

Comment 10 by, Nov 24 2015

Blocking: -chromium:507778

Comment 11 by, Dec 9 2015

Labels: refactoring

Comment 12 by, Apr 11 2016

Labels: Hotlist-Tech-Debt
Summary: Switch iOS to use the Posix login DB (was: Upstream LoginDatabase for iOS)

Comment 13 by, Apr 21 2016

Labels: -Hotlist-Tech-Debt Hotlist-TechnicalDebt

Comment 14 by, May 31 2016

Components: -Security -Privacy
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)

Comment 15 by, Jun 6 2016

Labels: -refactoring Hotlist-Refactoring

Comment 17 by, Apr 17 2018

Also,  suggests that `NSFileProtectionComplete` should be the storage class for files with passwords.

(Removing melandory@, who switched teams, from Cc.)

Comment 18 by, Nov 29

vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.

Sign in to add a comment