New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
M-7

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 51956: Sync: Autofill entries get overwritten between two clients

Reported by annapop@chromium.org, Aug 12 2010 Project Member

Issue description

ENVIRONMENT
Google Chrome	6.0.490.0 (Official Build 55537) dev
WebKit	534.6
V8	2.3.6.1
User Agent	Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/534.6 (KHTML, like Gecko) Chrome/6.0.490.0 Safari/534.6
Command Line	 /opt/google/chrome/google-chrome --user-data-dir=./datadirs/6.0.490.0_dev_A5 --enable-log --log-level=0

REPRO STEPS
0. Two Linux clients A and B, both online and signed into the same sync account;
1. Client A: In Wrench -> Options -> Personal Stuff -> [AutoFill options] add autofill entry name 1A;
2. Client B: In Wrench -> Options -> Personal Stuff -> [AutoFill options] add autofill entry name 1B.

ACTUAL RESULTS
After syncing both clients contain only one entry 1B.

EXPECTED RESULTS
Both 1A and 1B should be available between both clients.

ADDITIONAL INFO
This only happens between two Linux clients. 
No repro between a Mac-Linux.
 

Comment 1 by est...@chromium.org, Aug 12 2010

Labels: Feature-Sync

Comment 2 by rsimha@chromium.org, Aug 12 2010

Labels: -Area-Undefined -OS-Linux Area-UI OS-All
Status: Available
Summary: Sync: Autofill entries get overwritten between two clients
Update: I'm seeing this in all OSs when I run the sync integration tests. The test case that fails is TwoClientLiveAutofillSyncTest.Client1HasData.

Comment 3 by phajdan.jr@chromium.org, Aug 12 2010

Labels: Tests-Fails

Comment 4 by bugdro...@gmail.com, Aug 12 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55948 

------------------------------------------------------------------------
r55948 | rsimha@chromium.org | 2010-08-12 14:20:34 -0700 (Thu, 12 Aug 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_test.cc?r1=55948&r2=55947

Marking Client1HasData test as failed due to  bug 51956 .

The TwoClientLiveAutofillSyncTest.Client1HasData test fails due to bug
51956. Marking it as FAILS until the bug is fixed.

TBR=tim@chromium.org

BUG= 51956 
TEST=TwoClientLiveAutofillSyncTest.Client1HasData

Review URL: http://codereview.chromium.org/3146013
------------------------------------------------------------------------

Comment 5 by rsimha@chromium.org, Aug 17 2010

Labels: Mstone-7

Comment 6 by bugdro...@gmail.com, Aug 18 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56469 

------------------------------------------------------------------------
r56469 | rsimha@chromium.org | 2010-08-17 17:45:26 -0700 (Tue, 17 Aug 2010) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_test.cc?r1=56469&r2=56468
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/two_client_live_preferences_sync_test.cc?r1=56469&r2=56468

Fix failing sync integration tests.

TwoClientLivePreferencesSyncTest.Security was failing due to a couple of
EXPECT_NEs that ought to have been EXPECT_EQs.

TwoClientLiveAutofillSyncTest.Client1HasData was failing due to a change
in autofill behavior introduced in r55781 to fix security bug  crbug.com/51727 .

This changelist also includes a clarification in the logic used by
TwoClientLiveAutofillSyncTest.BothHaveData.

BUG= 51727 , 51956 
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3169019
------------------------------------------------------------------------

Comment 7 by dhollowa@chromium.org, Aug 18 2010

@rsimha are you planning to merge these fixes to 472?  I expect tests will be failing there if not.

Comment 8 by lafo...@chromium.org, Aug 26 2010

Labels: MrBotRecommends
This an automated note...
Recommendations based on labels Feature-Sync and os-all from activity in the last 60 days
	akalin@chromium.org
	rsimha@chromium.org(Recommended)
	nick@chromium.org
	chron@chromium.org
	tim@chromium.org
	skrul@chromium.org

Comment 9 by lafo...@chromium.org, Aug 26 2010

Status: Assigned

Comment 10 by rsimha@chromium.org, Aug 27 2010

Status: Available
My checkin (in the bug comments) did not fix the bug -- it was meant to accommodate a change in design in how autofill manages duplicate entries.

This bug still needs to be investigated by a sync developer.

Comment 11 by rsimha@chromium.org, Aug 27 2010

Status: Assigned

Comment 12 by akalin@chromium.org, Sep 29 2010

Status: WontFix
Anna, Dudley says to talk to him about expected behavior.  Also, Tim is reworking this for M8.

Comment 13 by bugdroid1@chromium.org, Oct 12 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Feature-Sync -Tests-Fails -Mstone-7 M-7 Cr-Services-Sync Cr-UI Cr-Tests-Fails

Comment 15 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment