New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocked on:
issue 508675
issue 522100



Sign in to add a comment

Deprecate/remove createTouch*

Project Member Reported by rbyers@chromium.org, Aug 10 2015

Issue description

TouchEvent.initTouchEvent is not standardized.  Once blink ( issue 508675 ) and WebKit (https://bugs.webkit.org/show_bug.cgi?id=147740) ship constructors, we can probably deprecate and eventually remove it.

At that time we should probably also deprecate document.createTouch and document.createTouchList (assuming the TECG agrees to mark them deprecated in the spec) and eventually remove them from blink.
 

Comment 1 by rbyers@chromium.org, Aug 18 2015

Blockedon: chromium:508675 chromium:522100
Cc: dtapu...@chromium.org
Actually, I found a surprising amount of usage - see  issue 522100 .  Perhaps we shouldn't be in any rush to deprecate this (especially not until a shipping version of mobile Safari supports the constructors).

Comment 2 by phil...@opera.com, Nov 27 2015

Use counter data:
https://www.chromestatus.com/metrics/feature/timeline/popularity/872
https://www.chromestatus.com/metrics/feature/timeline/popularity/874

That is very low usage, but is deprecation/removal still the plan here?
We didn't have Touch constructors until a few weeks ago. We have to let those get out and be migrated to. We should probably certainly mark them for deprecation. Safari indicated they'd add support for the constructors as well.

Comment 4 by rbyers@chromium.org, Nov 27 2015

I don't want to deprecate until Safari is shipping constructors.  It's not important enough to force developers to have to write two different code paths here IMHO.
Status: ExternalDependency
Summary: Deprecate/remove createTouch* (was: Deprecate/remove initTouchEvent and createTouch*)
WebKit added TouchEvent constructors here: https://bugs.webkit.org/show_bug.cgi?id=147740

Now we just wait for them to ship?
Cc: rbyers@chromium.org
Owner: ----
Yep, we should revisit once these constructors are available in shipping Safari.
Labels: -Type-Bug Type-Launch-OWP
Status: Available (was: ExternalDependency)
Labels: -Pri-2 Pri-3
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Owner: eirage@chromium.org
Status: Assigned (was: Available)
Ella usage looks pretty low. We should probably put together an intent to ship on this and give it a go.
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36cc2b3601062d644b4a861b84e61d60744e335

commit b36cc2b3601062d644b4a861b84e61d60744e335
Author: Ella Ge <eirage@chromium.org>
Date: Thu Feb 15 21:19:05 2018

deprecate createTouch and createTouchList

This Cl add deprecate warning for document.createTouch and
createTouchList. This two feature has been deprecate from
spec and has very low usage now.


To be removed in M68

intent to deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc

Bug:  518868 
Change-Id: Id043619f55a241e982fc6347cab26061ed664112
Reviewed-on: https://chromium-review.googlesource.com/915035
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537105}
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-expected.txt
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash-expected.txt
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/third_party/WebKit/Source/core/dom/Document.idl
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/b36cc2b3601062d644b4a861b84e61d60744e335/tools/metrics/histograms/enums.xml

Labels: Hotlist-Interop
Project Member

Comment 14 by bugdroid1@chromium.org, May 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1129d0d679e25123091792887b463ac9c2606297

commit 1129d0d679e25123091792887b463ac9c2606297
Author: Ella Ge <eirage@chromium.org>
Date: Fri May 11 16:54:49 2018

remove createTouch

Removes document.createTouch and related tests

createTouchList has relatively high UseCount(around 0.015%), see
https://www.chromestatus.com/metrics/feature/timeline/popularity/2368
We need to address these use cases before remove it.

Postpone createTouchList removal to M69


intent to deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc

PR to touch-events spec:
https://github.com/w3c/touch-events/pull/96

Bug:  518868 
Change-Id: If086b51b775e4be59320c4a1329988787ff6f870
Reviewed-on: https://chromium-review.googlesource.com/1041128
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557907}
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/WebKit/LayoutTests/external/wpt/touch-events/create-touch-touchlist.html
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/WebKit/LayoutTests/external/wpt/touch-events/historical.html
[delete] https://crrev.com/2969739effcde2fdba105d25d8db903bdfdb5db0/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-expected.txt
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt
[delete] https://crrev.com/2969739effcde2fdba105d25d8db903bdfdb5db0/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch.html
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/WebKit/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js
[delete] https://crrev.com/2969739effcde2fdba105d25d8db903bdfdb5db0/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash-expected.txt
[delete] https://crrev.com/2969739effcde2fdba105d25d8db903bdfdb5db0/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/blink/renderer/bindings/bindings.gni
[delete] https://crrev.com/2969739effcde2fdba105d25d8db903bdfdb5db0/third_party/blink/renderer/bindings/core/v8/custom/v8_document_custom.cc
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/blink/renderer/core/dom/document.idl
[modify] https://crrev.com/1129d0d679e25123091792887b463ac9c2606297/third_party/blink/renderer/core/frame/deprecation.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2c1f195b6e16986e3278cd5bd6410d0984589e8

commit b2c1f195b6e16986e3278cd5bd6410d0984589e8
Author: Ella Ge <eirage@chromium.org>
Date: Fri Jun 01 02:12:50 2018

remove createTouchList

This Cl removes document.createTouchList and related tests.

Use count is drop to a safer value, ready to remove in M69.
UseCounter:
https://www.chromestatus.com/metrics/feature/timeline/popularity/2368

intent to deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc

PR to touch-events spec:
https://github.com/w3c/touch-events/pull/96

Bug:  518868 
Change-Id: Ia4451d0d32bf5bbb6d9c9c543ac77187c5161b42
Reviewed-on: https://chromium-review.googlesource.com/1055799
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563490}
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[delete] https://crrev.com/22a0792712f4aabeaea571f1063e83c7728d340b/third_party/WebKit/LayoutTests/external/wpt/touch-events/create-touch-touchlist.html
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/WebKit/LayoutTests/external/wpt/touch-events/historical.html
[delete] https://crrev.com/22a0792712f4aabeaea571f1063e83c7728d340b/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt
[delete] https://crrev.com/22a0792712f4aabeaea571f1063e83c7728d340b/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-crash.html
[delete] https://crrev.com/22a0792712f4aabeaea571f1063e83c7728d340b/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt
[delete] https://crrev.com/22a0792712f4aabeaea571f1063e83c7728d340b/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list.html
[delete] https://crrev.com/22a0792712f4aabeaea571f1063e83c7728d340b/third_party/WebKit/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js
[delete] https://crrev.com/22a0792712f4aabeaea571f1063e83c7728d340b/third_party/WebKit/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/blink/renderer/core/dom/document.idl
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/blink/renderer/core/frame/deprecation.cc
[modify] https://crrev.com/b2c1f195b6e16986e3278cd5bd6410d0984589e8/third_party/blink/renderer/core/input/touch_event_manager.h

Status: Fixed (was: Assigned)

Sign in to add a comment