New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 51693 link

Starred by 35 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

RLZ should not be invoked on Chromium builds

Reported by gwilson@chromium.org, Aug 10 2010

Issue description

1.  Download latest Chromium build (I repro'ed with 6.0.491.0)
1.5. Remove any RLZ keys under HKCU\Software\Google\Common\RLZ
2.  Start wireshark/fiddler/etc.
3.  Start Chromium
4.  See that after a few seconds, the rlz ping goes by.

RLZ should only invoke on promotional builds of Google Chrome with non-organic brand codes, and not Chromium.
 
Hi, 

Just a clarification, you added the "OS-Windows" tag, is this a specific Windows issue?

Cheers,
Giuseppe.
Yes, RLZ is currently Windows-only, so this regression should only affect Windows builds.

Comment 3 by Deleted ...@, Aug 11 2010

Why remove RLZ from registry? Chromium is a free product, and it must be free from Google's marketing policy, even if user has any promotional info from other products!
It's just part of the repro steps, to remove any previous RLZ state on the test machine (to ensure an immediate ping).  

You won't have to remove any registry keys when this is fixed.

Comment 5 by bugdro...@gmail.com, Aug 13 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56032 

------------------------------------------------------------------------
r56032 | rogerta@google.com | 2010-08-13 09:09:39 -0700 (Fri, 13 Aug 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=56032&r2=56031
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.cc?r1=56032&r2=56031
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_rlz_module.cc?r1=56032&r2=56031
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/rlz/rlz.cc?r1=56032&r2=56031
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url.cc?r1=56032&r2=56031
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_model.cc?r1=56032&r2=56031
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_unittest.cc?r1=56032&r2=56031

Fix for  issue 51693 , which was a regression from integrating the open source
version of RLZ into Chromium.  Chromium should never send RLZ pings to Google,
only Google Chrome should do so.

Removing dependency from rlz chrome extenion api to RLZTracker since it is
not required.

BUG= 51693 
TEST=Install Chromium on a clean machine and make sure no pings are sent to
http://client1.google.com/tools/pso/ping?...

Review URL: http://codereview.chromium.org/3146007
------------------------------------------------------------------------

Status: Fixed
Labels: -Regression bulkmove Type-Regression
1.  Download latest Chromium build (I repro'ed with 6.0.491.0)
1.5. Remove any RLZ keys under HKCU\Software\Google\Common\RLZ
2.  Start wireshark/fiddler/etc.
3.  Start Chromium
4.  See that after a few seconds, the rlz ping goes by.

RLZ should only invoke on promotional builds of Google Chrome with non-organic brand codes, and not Chromium.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-Internals -Type-Regression Cr-Internals Type-Bug-Regression

Sign in to add a comment