New issue
Advanced search Search tips

Issue 51643 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2010
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-7

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Custom cells in wrench should have highlighted state on hover

Project Member Reported by thakis@chromium.org, Aug 10 2010

Issue description

What steps will reproduce the problem?
1. Open wrench menu, keep mouse down
2. Drag to the "Copy" button

What is the expected result?

The "Copy" button should look active, like normal popup menu items do, too.

What happens instead?

It's only shown as active when the mouse button is released.

 

Comment 1 by rsesek@chromium.org, Aug 11 2010

Status: Assigned
Summary: Custom cells in wrench should have highlighted state on hover
This should happen in all hover states, not just click-drag-release.

Comment 2 by rsesek@chromium.org, Aug 16 2010

Labels: -Mstone-6 Mstone-7

Comment 3 by rsesek@chromium.org, Aug 16 2010

 Issue 52336  has been merged into this issue.

Comment 4 by rsesek@chromium.org, Aug 17 2010

Status: Started

Comment 5 by bugdro...@gmail.com, Aug 17 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56430 

------------------------------------------------------------------------
r56430 | rsesek@chromium.org | 2010-08-17 15:39:59 -0700 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_tracked_button.h?r1=56430&r2=56429
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_tracked_button.mm?r1=56430&r2=56429

[Mac] Implement highlight-on-hover for the Wrench menu buttons.

R=pinkerton, shess, mark
BUG= 51643 
TEST=Open Wrench menu in sticky and non-sticky mode. Hover over buttons and they highlight.

Review URL: http://codereview.chromium.org/3137013
------------------------------------------------------------------------

Comment 6 by rsesek@chromium.org, Aug 18 2010

Status: Fixed
Fix is on 10.6 only.  There's a bug in the way 10.5 draws the parts of the custom button cell that makes the highlighted state look terrible, so it's explicitly disabled.

Comment 7 by bugdro...@gmail.com, Aug 18 2010

Labels: Verifier-Deepakg
Verified label updated by AutoAllocator, contact AmolK or KrisR for details
Status: Verified
Verified in 7.0.503.0 (Official Build 57033) dev on 10.6.4.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-7 M-7 Cr-UI
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment