New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 51597 link

Starred by 16 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Aug 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug
M-6

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Plugin grouping (about:plugins) broke flash development

Project Member Reported by cpu@chromium.org, Aug 9 2010

Issue description

People that develop using Adobe tools should be able to debug flash movies hosted in chrome.

So when you install say CS5, it installs the 'debugger' version of the plugin. Now you need to be able to disable the built-in plugin and enable the debugger one.

This is no longer possible given the grouping of plugins enable/disable.

When fixing this take in consideration the Adobe's technical note about this
http://kb2.adobe.com/cps/839/cpsid_83950.html

Note the changes so the instructions can be adjusted as needed.

 

Comment 1 by cpu@chromium.org, Aug 9 2010

I've been told the grouping accomplishes some other goals, so instead of reverting _it_ seems we need to find a way to have the cake and eat it too.

In any case this needs to be sorted ASAP

Comment 2 by mal@google.com, Aug 9 2010

Labels: ReleaseBlock-Stable Mstone-6
Status: Assigned
It looks like the plugin coalescing was implemented by mavrommatis with review from jam@. jam@ is out of the office for a few weeks, so I've also cc'd bauerb@ and viettrungluu@ who might know something about the code here.

Comment 3 by bau...@google.com, Aug 9 2010

In theory, if you click on "Details" at the top right of about:plugins, there should be a link to enable/disable individual plug-ins. Not sure why it doesn't show up though.
Labels: -Area-Undefined
Status: Started
Looks like a stray tag in the HTML file.

Comment 5 by bugdro...@gmail.com, Aug 10 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55541 

------------------------------------------------------------------------
r55541 | bauerb@chromium.org | 2010-08-10 01:30:21 -0700 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/plugins.html?r1=55541&r2=55540
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_group.cc?r1=55541&r2=55540

Re-enable the link to disable invididual plug-ins in a group.

BUG= 51597 
TEST=In about:plugins, click on "Details". There should be a link to enable/disable each individual plug-in in a plug-in group.

Review URL: http://codereview.chromium.org/3038055
------------------------------------------------------------------------

Comment 6 by bugdro...@gmail.com, Aug 10 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55562 

------------------------------------------------------------------------
r55562 | bauerb@chromium.org | 2010-08-10 06:05:32 -0700 (Tue, 10 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/resources/plugins.html?r1=55562&r2=55561
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/common/plugin_group.cc?r1=55562&r2=55561

Merge 55541 - Re-enable the link to disable invididual plug-ins in a group.

BUG= 51597 
TEST=In about:plugins, click on "Details". There should be a link to enable/disable each individual plug-in in a plug-in group.

Review URL: http://codereview.chromium.org/3038055

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/3146006
------------------------------------------------------------------------

Comment 7 by bauerb@chromium.org, Aug 10 2010

Status: Fixed

Comment 8 by mal@google.com, Aug 13 2010

 Issue 49867  has been merged into this issue.
 Issue 52068  has been merged into this issue.

Comment 10 by dhw@chromium.org, Aug 14 2010

 Issue 52146  has been merged into this issue.
disable is now listed twice for every plugin unnecessarily 
There is one link for each plug-in in a group to disable it, and one
link to disable the whole group at once. If the group consists only of
one plug-in, these two links of course do the same.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-Flash -Mstone-6 M-6 Cr-UI Cr-Content-Plugins-Flash
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 6 2013

Labels: Cr-Blink
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-Plugins-Flash Cr-Internals-Plugins-Flash

Sign in to add a comment