New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 51325 link

Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression
M-6

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

various m6 toolbar regressions on linux

Reported by snkiz...@gmail.com, Aug 5 2010

Issue description

Chrome Version       : 6.0.486.0
URLs (if applicable) : N/A
Other browsers tested: N/A
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
Firefox 3.x:
IE 7:
IE 8:

What steps will reproduce the problem?
1. open chromium
2. look at toolbar
3.

What is the expected result?
I expect to see back, forward, reload and the home button before the omnibox

What happens instead?
Home button icon is missing, but the button is still there when you mouse over the area. Its about 3 pixels wide.

Please provide any additional information below. Attach a screenshot if
possible.
see screenshot
 
home-ico-missing-chromium.png
133 KB View Download
Labels: -Area-Undefined Area-UI Feature-Browser

Comment 3 by sh...@chromium.org, Aug 5 2010

Labels: OS-Linux
My best guess from the screenshot is that this is for Linux?  I can't repro for OSX.

Comment 4 by snkiz...@gmail.com, Aug 5 2010

yes for linux, sorry forgot to mention that. it Ubu 10.04.1 Just updated this morning and got this issue. I tend to update once a week from the daily ppa. the more I look at it, the more it seems the toolbar is slightly over sized as well, but I don't have any recent screenies to compare it.

Comment 5 by snkiz...@gmail.com, Aug 5 2010

I should have thought of this sooner, I switched back to "use classic theme" and there is the button. The toolbar is also reduced to normal, but reload/stop button is having issues. Reload is a little messed up and when stop is active its drawing ontop of the reload button.

I've tried a number of gtk/icon themes, all with the same result when using gtk in chromium. last weeks build was fine.
Labels: -Pri-2 Pri-1 Regression Mstone-6
Status: Started

Comment 7 by snkiz...@gmail.com, Aug 5 2010

downgraded to 6.0.472.14 for comparison here is a screenshot.
home-ico-there-chromium.png
363 KB View Download
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55159 

------------------------------------------------------------------------
r55159 | estade@chromium.org | 2010-08-05 17:13:10 -0700 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=55159&r2=55158

[GTK] undo more toolbar destruction - unbreak GTK+ theme mode home button

BUG= 51325 
TEST=showing home button in gtk+ should work

Review URL: http://codereview.chromium.org/3083018
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55161 

------------------------------------------------------------------------
r55161 | estade@chromium.org | 2010-08-05 17:24:27 -0700 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=55161&r2=55160

Merge 55159 - [GTK] undo more toolbar destruction - unbreak GTK+ theme mode home button

BUG= 51325 
TEST=showing home button in gtk+ should work

Review URL: http://codereview.chromium.org/3083018

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/3041053
------------------------------------------------------------------------

Cool that rev. fixed the home button, but the omnibox is still over sized. Does a separate bug need to be filed?

Also the stop/reload button is still weird when using chrome's builtin decos, again separate bug??
hmmm, when I glanced at it I thought the large omnibox was due to your theme. I'll take a look.
Nope see my second screenie, same theme. I'm trying to get a screencast for chromium builin stop/reload issue but never done it before.
Its quick and dirty but here is a short screencast of what I mean.
chromium-buttons-1.ogv
906 KB Download

Comment 14 by evan@chromium.org, Aug 6 2010

Tony is also getting the oversize omnibox, if you need him to do any local debugging.
no, I found the problem. It was caused by swapping around the widget
hierarchy, disrupting some sizing code. Hopefully my change here:
http://codereview.chromium.org/3086021/show will make it more
future-proof. The best future-proofing would come from unit testing,
it's just that in this case, unit testing would be hard because of the
required interaction with the system setup.

The stop/reload issue arose because the old stop/reload code depended
on the fact that custom buttons didn't draw subwidgets, but I had to
add that capability to get the wrench menu right. Again, I'm not sure
how to add a unit test to avoid this sort of regression (unless we
added a pixel test, which obviously has its own problems).
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55253 

------------------------------------------------------------------------
r55253 | estade@chromium.org | 2010-08-06 10:40:53 -0700 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=55253&r2=55252
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/reload_button_gtk.cc?r1=55253&r2=55252

GTK toolbar -

- fix vertical height in gtk theme mode
- fix reload button showing two images when switching from gtk to chrome theme mode

BUG= 51325 
TEST=1) switch from gtk to chrome theme mode, look at stop/reload 2) change desktop document font size from 10 to 18 in gtk theme mode, the omnibox should size appropriately for each font.

Review URL: http://codereview.chromium.org/3086021
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55256 

------------------------------------------------------------------------
r55256 | estade@chromium.org | 2010-08-06 10:48:04 -0700 (Fri, 06 Aug 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=55256&r2=55255
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/reload_button_gtk.cc?r1=55256&r2=55255

Merge 55253 - GTK toolbar -

- fix vertical height in gtk theme mode
- fix reload button showing two images when switching from gtk to chrome theme mode

BUG= 51325 
TEST=1) switch from gtk to chrome theme mode, look at stop/reload 2) change desktop document font size from 10 to 18 in gtk theme mode, the omnibox should size appropriately for each font.

Review URL: http://codereview.chromium.org/3086021

TBR=erg
Review URL: http://codereview.chromium.org/3097001
------------------------------------------------------------------------

Issue 51406 has been merged into this issue.
Status: Fixed

Comment 20 by kerz@chromium.org, Aug 6 2010

Labels: ReleaseBlock-Stable

Comment 21 by evan@chromium.org, Aug 9 2010

 Issue 51489  has been merged into this issue.

Comment 22 by evan@chromium.org, Aug 9 2010

 Issue 51443  has been merged into this issue.
 Issue 51492  has been merged into this issue.
Summary: various m6 toolbar regressions on linux
more general title
 Issue 51605  has been merged into this issue.
 Issue 51649  has been merged into this issue.
 Issue 51867  has been merged into this issue.
 Issue 52013  has been merged into this issue.
Issue 51765 has been merged into this issue.
Labels: -Regression bulkmove Type-Regression
Chrome Version       : 6.0.486.0
URLs (if applicable) : N/A
Other browsers tested: N/A
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
Firefox 3.x:
IE 7:
IE 8:

What steps will reproduce the problem?
1. open chromium
2. look at toolbar
3.

What is the expected result?
I expect to see back, forward, reload and the home button before the omnibox

What happens instead?
Home button icon is missing, but the button is still there when you mouse over the area. Its about 3 pixels wide.

Please provide any additional information below. Attach a screenshot if
possible.
see screenshot
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Feature-Browser -Mstone-6 -Type-Regression Type-Bug-Regression M-6 Cr-UI Cr-UI-Browser-Core
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment