Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 51105 About:conflicts page
Starred by 16 users Project Member Reported by clemw@chromium.org, Aug 3, 2010 Back to list
Status: Fixed
Owner: finnur@chromium.org
Closed: Jan 2011
Cc: hbridge@google.com, huanr@chromium.org, clemw@chromium.org, finnur@chromium.org, eroman@chromium.org, mattm@chromium.org, chrome-conops-escalation@google.com
Components:
OS: Windows
Pri: 2
Type: Feature
M-9

Blocked on:
issue 53474
issue 57239
issue 61723

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Create page at about:dlls that does the following:

1. Enumerates the dlls in the current process
2. For LSPs, enumerates the entries in the winsock catalog
3. Checks if any of these dlls or LSPs fits a blacklist of known 3rd party crashers
4. If they fit the blacklist, serves known ways to resolve the issue (i.e. "Try disabling Speedbit Video Accelerator")
5. Collects data on the occurrence of different dlls and LSPs.

Goal: decrease 3rd party crashes by improving user access to relevant information.
 
Comment 1 Deleted
Comment 2 Deleted
Comment 3 by huanr@chromium.org, Aug 5, 2010
Labels: -Area-Undefined -Mstone-X -Feature-Unknown -Dev-TestPlan-No -Dev-LegalReview-No -Dev-PrivacyReview-No -Dev-SecurityReview-No -Dev-UIReview-No Area-Internals Mstone-7
Status: Available
Comment 4 by tha...@chromium.org, Aug 5, 2010
Labels: OS-Windows
Comment 5 by clemw@chromium.org, Aug 18, 2010
I mocked up a draft of the page, attached. Some notes:

1. Dlls with warnings would be those that fit a hard-coded blacklist
2. Help tips would be hard-coded for dlls on the blacklist
3. Software fields would be populated with dll metadata

Please provide feedback.
about dlls.png
50.0 KB View Download
Comment 6 by lafo...@chromium.org, Aug 26, 2010
Labels: -Mstone-7 Mstone-8
Seeing no checkins I'm punting this to m8.
Comment 7 Deleted
Comment 8 by clemw@chromium.org, Aug 27, 2010
Attached is a list of dlls known to conflict with Chrome. It also lists the software title, bug number, and help content for each "Learn more" link.
dllcrashers.png
52.8 KB View Download
Comment 9 by clemw@chromium.org, Sep 2, 2010
Blockedon: 53474
Comment 10 by clemw@chromium.org, Sep 29, 2010
Blockedon: -53474 57239
Comment 11 Deleted
Comment 12 by clemw@chromium.org, Sep 30, 2010
CC'ing Finnur who's interested in implementing this.
Status: Assigned
Labels: -Mstone-8 Mstone-9
This is blocked on a bug marked for M9. Makes sense to also target this for M9, which I think was the intent.
Comment 15 by finnur@chromium.org, Oct 21, 2010
Summary: About:compatibility page (was: NULL)
This feature has been renamed about:compatibility.
Comment 16 by lafo...@chromium.org, Oct 21, 2010
Labels: -Mstone-9 Mstone-10
Moving P2s with an owner to Mstone 10, bring back to M9 if you think it's important and you don't have higher priority work.
Comment 17 by finnur@chromium.org, Oct 26, 2010
Labels: -Mstone-10 Mstone-9
Blockedon: 61723
Labels: -mstone-9 Mstone-10
Given our current velocity, we need to punt 500 bugs from m9.  Moving p2 bugs, that are not started and have an owner, to the next milestone.  If this issue absolutely needs to be fixed in the current milestone please move it back, however, at this time the focus should be on p1 bugs.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=65366

------------------------------------------------------------------------
r65366 | finnur@chromium.org | Mon Nov 08 03:17:05 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/wrench_menu_model.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=65366&r2=65365&pathrev=65366
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/conflicts_ui.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=65366&r2=65365&pathrev=65366
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/conflicts_ui.h?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/google_chrome_strings.grd?r1=65366&r2=65365&pathrev=65366
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_conflicts.html?r1=65366&r2=65365&pathrev=65366
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_unittest_win.cc?r1=65366&r2=65365&pathrev=65366
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=65366&r2=65365&pathrev=65366
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.h?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_resource.h?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chromium_strings.grd?r1=65366&r2=65365&pathrev=65366
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=65366&r2=65365&pathrev=65366

First cut of the about:conflicts page, listing all DLLs loaded in the Chrome process.

BUG=http://crbug.com/51105, http://crbug.com/57239
TEST=Unit tests included.

Review URL: http://codereview.chromium.org/4524002
------------------------------------------------------------------------
Comment 21 by finnur@chromium.org, Nov 16, 2010
Summary: About:conflicts page (was: NULL)
Feature has been renamed.
Comment 24 by bugdro...@gmail.com, Nov 19, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=66756

------------------------------------------------------------------------
r66756 | finnur@chromium.org | Fri Nov 19 02:35:36 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_conflicts.html?r1=66756&r2=66755&pathrev=66756
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=66756&r2=66755&pathrev=66756
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.h?r1=66756&r2=66755&pathrev=66756

Add registered shell extensions to enumerated module list on about:conflicts.

BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/5092007
------------------------------------------------------------------------
Comment 26 by bugdro...@gmail.com, Nov 20, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=66880

------------------------------------------------------------------------
r66880 | finnur@chromium.org | Sat Nov 20 02:00:19 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=66880&r2=66879&pathrev=66880
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.h?r1=66880&r2=66879&pathrev=66880

Polish the Enumerate Modules implementation a bit.

1) De-dup the registered DLLs since a lot of the same DLLs will be registered multiple times, ie. mswsock.dll
2) Every module loaded from a %temp% dir should be viewed as suspicious.
3) Add some histogram counters (xml changes coming in a followup CL).

BUG=http://crbug.com/51105
TEST=None

Review URL: http://codereview.chromium.org/5183007
------------------------------------------------------------------------
Comment 27 by finnur@chromium.org, Nov 22, 2010
Issue 57239 has been merged into this issue.
Comment 28 by bugdro...@gmail.com, Nov 26, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=67446

------------------------------------------------------------------------
r67446 | finnur@chromium.org | Fri Nov 26 02:23:39 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=67446&r2=67445&pathrev=67446

Remove the test DLLs from the blacklist.
Demo is done.

TBR=huanr
BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/5307004
------------------------------------------------------------------------
Comment 29 by bugdro...@gmail.com, Nov 29, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=67598

------------------------------------------------------------------------
r67598 | finnur@chromium.org | Mon Nov 29 14:19:18 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_conflicts.html?r1=67598&r2=67597&pathrev=67598
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_unittest_win.cc?r1=67598&r2=67597&pathrev=67598
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=67598&r2=67597&pathrev=67598
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=67598&r2=67597&pathrev=67598
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.h?r1=67598&r2=67597&pathrev=67598

EnumerateModules: Address UI review comments.

Make it a simple list with columns. Sort by status (conflicts at the
top), then by location and module name. Also, convert the type of DLL
to an enum so we can dedup the list (and for non-loaded DLLs show that
they are not loaded yet, but are of type: Shell Extension / WinSock.

Make sure lower bound version specified on the blacklist is inclusive
(first version that broke) and the higher bound version is exclusive
(first version that worked).

This allows us to pointpoint exactly when the failure started and
when the fix was introduced, instead of doing 0.9999 shenanigans.

Specify an upper bound for the idmmbc.dll conflict, since Henry's
outreach produced a fix in version 6.03 of the download manager.

BUG= 51105 
TEST=Unit test

Review URL: http://codereview.chromium.org/5278012
------------------------------------------------------------------------
Comment 30 by bugdro...@gmail.com, Nov 30, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=67624

------------------------------------------------------------------------
r67624 | finnur@chromium.org | Mon Nov 29 16:28:26 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/toolbar_view.cc?r1=67624&r2=67623&pathrev=67624

Adjust the position of the Wrench menu badge.

It was two pixels to far to the left.

TBR=glen
BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/5348005
------------------------------------------------------------------------
Comment 31 by bugdro...@gmail.com, Nov 30, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=67702

------------------------------------------------------------------------
r67702 | finnur@chromium.org | Tue Nov 30 02:18:59 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/conflicts_ui.cc?r1=67702&r2=67701&pathrev=67702

Add UMA counter for when about:conflicts is viewed.

BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/5259008
------------------------------------------------------------------------
Project Member Comment 32 by bugdroid1@chromium.org, Dec 6, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=68346

------------------------------------------------------------------------
r68346 | finnur@chromium.org | Mon Dec 06 04:54:49 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_conflicts.html?r1=68346&r2=68345&pathrev=68346

Polish the about:conflicts page.

Address review comments from Nico and add a separating line as
requested by Glen.

BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/5640001
------------------------------------------------------------------------
Project Member Comment 33 by bugdroid1@chromium.org, Dec 8, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=68656

------------------------------------------------------------------------
r68656 | finnur@chromium.org | Wed Dec 08 14:55:08 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=68656&r2=68655&pathrev=68656
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=68656&r2=68655&pathrev=68656

Update the blacklist to reflect latests statistics.

Also change the URL as per Support.

BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/5629005
------------------------------------------------------------------------
Project Member Comment 34 by bugdroid1@chromium.org, Dec 9, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=68676

------------------------------------------------------------------------
r68676 | finnur@chromium.org | Wed Dec 08 16:22:29 PST 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/597/src/chrome/browser/enumerate_modules_model_win.cc?r1=68676&r2=68675&pathrev=68676
 M http://src.chromium.org/viewvc/chrome/branches/597/src/chrome/app/generated_resources.grd?r1=68676&r2=68675&pathrev=68676

Merge 68656 - Update the blacklist to reflect latests statistics.

Also change the URL as per Support.

BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/5629005

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/5522013
------------------------------------------------------------------------
Comment 35 by kerz@chromium.org, Dec 9, 2010
Labels: -Mstone-10 MovedFrom-10 Mstone-11
P2 bugs with an owner that are not marked as started are being automatically moved to mstone:11.
Comment 36 by clemw@chromium.org, Dec 9, 2010
Labels: -Mstone-11 Mstone-9
Status: Started
Project Member Comment 37 by bugdroid1@chromium.org, Jan 6, 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=70600

------------------------------------------------------------------------
r70600 | finnur@chromium.org | Thu Jan 06 00:57:45 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_model.cc?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.h?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_model.h?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_main.cc?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_test.h?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_conflicts.html?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_unittest_win.cc?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc?r1=70600&r2=70599&pathrev=70600
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/recon_diagnostics.h?r1=70600&r2=70599&pathrev=70600

Integrate about:conflicts with --diagnostics

This should enable the user to find conflicting dlls that are crashing Chrome on startup.

This changelist introduces a limited_mode for scanning, since the diagnostics tests run without the help of many Chrome services, so we can't use the File thread for asynchronous scanning or the notification system.

Also changed the scanning so that if no signature/description is given in the blacklist, then we mark the DLL as a confirmed match if the name and the location match (before we used to match it as a 'suspected' match). A very sizable chunk of the blacklist is malware, which has no signature, so this gives us the ability to trigger the wrench badge on finding malware (that part remains opt-in through about:flags).

Also added failure count to diagnostics output (sometimes the error scrolls off screen, so having a note at the bottom helps).

BUG= 51105 
TEST=All diagnostics tests run as part of the unit tests.

Review URL: http://codereview.chromium.org/6098004
------------------------------------------------------------------------
Project Member Comment 38 by bugdroid1@chromium.org, Jan 7, 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=70727

------------------------------------------------------------------------
r70727 | finnur@chromium.org | Fri Jan 07 02:16:30 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=70727&r2=70726&pathrev=70727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/conflicts_ui.cc?r1=70727&r2=70726&pathrev=70727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_conflicts.html?r1=70727&r2=70726&pathrev=70727

Polish about:conflicts a bit as requested by Clem/UI review.

Add column header for data.
Move the Learn more link to appear last.

BUG= 51105 
TEST=None


Review URL: http://codereview.chromium.org/5981012
------------------------------------------------------------------------
Project Member Comment 39 by bugdroid1@chromium.org, Jan 9, 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=70860

------------------------------------------------------------------------
r70860 | finnur@chromium.org | Sun Jan 09 04:57:58 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=70860&r2=70859&pathrev=70860

Make sure the histogram counters for about:conflicts get uploaded.

BUG= 51105 
TEST=None

Review URL: http://codereview.chromium.org/6098009
------------------------------------------------------------------------
Comment 40 by finnur@chromium.org, Jan 11, 2011
Status: Fixed
I am calling this on done. Any further work can be filed as a separate bug.

Separately, I checked in a change that fixes the UMA metrics for when the Wrench menu is opened. UMA metrics should therefore be in place for this feature for M10.
Comment 41 by clemw@chromium.org, Feb 18, 2011
Labels: ConOps
Comment 42 by jtan@chromium.org, Mar 24, 2011
Labels: -ConOps Hotlist-ConOps
Project Member Comment 43 by bugdroid1@chromium.org, Oct 13, 2012
Blockedon: -chromium:53474 -chromium:57239 -chromium:61723 chromium:53474 chromium:57239 chromium:61723
Blocking: -chromium:60119 chromium:60119
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 44 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-Internals -Mstone-9 M-9 Cr-Internals
Project Member Comment 45 by bugdroid1@chromium.org, Mar 13, 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment