New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

"Load unpacked extension" button crashes Chrome

Project Member Reported by juncai@chromium.org, Jul 16 2015

Issue description

Version: <Version 46.0.2458.0 (64-bit)>
OS: <Ubuntu>

What steps will reproduce the problem?
1. Start Chrome.
2. Go to chrome://flags.
3. Find "Experimental Extension APIs", and click its "Enable" link.
4. Restart Chrome.
5. clicking the settings icon and choosing More tools > Extensions.
6. Make sure the Developer mode checkbox has been selected.
7. Click the Load unpacked extension button and then Chrome crashes.

What is the expected output? What do you see instead?
The expected output is that Chrome will open a dialog to select the app that user wants to load; instead of that, Chrome crashes.

Please use labels and text to provide additional information.
stacktrace:

[10350:10350:0716/132651:INFO:CONSOLE(6)] "SW registered", source: https://www.google.com/_/chrome/newtab?espv=2&ie=UTF-8 (6)
[10350:10350:0716/132657:WARNING:CONSOLE(0)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source:  (0)
[10350:10350:0716/132701:FATAL:desktop_window_tree_host_x11.cc(2043)] Check failed: modal_dialog_xid_. 
#0 0x7fbf2164524e base::debug::StackTrace::StackTrace()
#1 0x7fbf21681bc2 logging::LogMessage::~LogMessage()
#2 0x7fbf277a2b33 views::DesktopWindowTreeHostX11::DisableEventListening()
#3 0x7fbf28170f4c libgtk2ui::SelectFileDialogImplGTK::SelectFileImpl()
#4 0x7fbf22e2257d ui::SelectFileDialog::SelectFile()
#5 0x7fbf28475f39 extensions::api::EntryPicker::EntryPicker()
#6 0x7fbf2845f613 extensions::api::DeveloperPrivateChooseEntryFunction::ShowPicker()
#7 0x7fbf2845f308 extensions::api::DeveloperPrivateLoadUnpackedFunction::Run()
#8 0x7fbf27e92999 extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal()
#9 0x7fbf27e9250a extensions::ExtensionFunctionDispatcher::Dispatch()
#10 0x7fbf27ed24b4 extensions::ExtensionWebContentsObserver::OnRequest()
#11 0x7fbf27ed2a25 ExtensionHostMsg_Request::Dispatch<>()
#12 0x7fbf27ed244c extensions::ExtensionWebContentsObserver::OnMessageReceived()
#13 0x7fbf282be336 extensions::ChromeExtensionWebContentsObserver::OnMessageReceived()
#14 0x7fbf264a233a content::WebContentsImpl::OnMessageReceived()
#15 0x7fbf264b40e4 content::WebContentsImpl::OnMessageReceived()
#16 0x7fbf264b4127 content::WebContentsImpl::OnMessageReceived()
#17 0x7fbf261848e8 content::RenderFrameHostImpl::OnMessageReceived()
#18 0x7fbf2630697a content::RenderProcessHostImpl::OnMessageReceived()
#19 0x7fbf26306d4c content::RenderProcessHostImpl::OnMessageReceived()
#20 0x7fbf227e9062 IPC::ChannelProxy::Context::OnDispatchMessage()
#21 0x7fbf207c4511 base::internal::RunnableAdapter<>::Run()
#22 0x7fbf207c4481 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIM24WebRtcLoggingHandlerHostFvRKSsEEENS0_8TypeListIJRKPS3_S5_EEEE8MakeItSoES8_SC_S5_
#23 0x7fbf227ed071 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS6_7MessageEEEEFvPS8_SB_ENS0_8TypeListIJSF_S9_EEEEENSH_IJNS0_12UnwrapTraitsISF_EENSK_IS9_EEEEENS0_12InvokeHelperILb0EvSE_NSH_IJRKSF_SB_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#24 0x7fbf20820bce base::Callback<>::Run()
#25 0x7fbf217807c6 base::debug::TaskAnnotator::RunTask()
#26 0x7fbf216939ac base::MessageLoop::RunTask()
#27 0x7fbf21693be8 base::MessageLoop::DeferOrRunPendingTask()
#28 0x7fbf21693db2 base::MessageLoop::DoWork()
#29 0x7fbf2177c5dc base::MessagePumpGlib::HandleDispatch()
#30 0x7fbf2177cda1 base::(anonymous namespace)::WorkSourceDispatch()
#31 0x7fbf1ec06e04 g_main_context_dispatch
#32 0x7fbf1ec07048 <unknown>
#33 0x7fbf1ec070ec g_main_context_iteration
#34 0x7fbf2177c6df base::MessagePumpGlib::Run()
#35 0x7fbf216933df base::MessageLoop::RunHandler()
#36 0x7fbf216cfaa4 base::RunLoop::Run()
#37 0x7fbf20f332a8 ChromeBrowserMainParts::MainMessageLoopRun()
#38 0x7fbf26670974 content::BrowserMainLoop::RunMainMessageLoopParts()
#39 0x7fbf260de3f5 content::BrowserMainRunnerImpl::Run()
#40 0x7fbf260dd8d8 content::BrowserMain()
#41 0x7fbf215a6cb6 content::RunNamedProcessTypeMain()
#42 0x7fbf215a868d content::ContentMainRunnerImpl::Run()
#43 0x7fbf215a6432 content::ContentMain()
#44 0x7fbf2072be52 ChromeMain
#45 0x7fbf2072be02 main
#46 0x7fbf17b4aec5 __libc_start_main
#47 0x7fbf2072bce4 <unknown>

Aborted (core dumped)

 

Comment 1 by juncai@chromium.org, Jul 16 2015

Actually steps:
2. Go to chrome://flags.
3. Find "Experimental Extension APIs", and click its "Enable" link.
4. Restart Chrome.
are not necessary to reproduce the bug. Just do the following steps and it will reproduce the bug.

1. Start Chrome.
2. clicking the settings icon and choosing More tools > Extensions.
3. Make sure the Developer mode checkbox has been selected.
4. Click the Load unpacked extension button and then Chrome crashes.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae7a498705ae28e2d08567928df640a7d48fa37

commit bae7a498705ae28e2d08567928df640a7d48fa37
Author: juncai <juncai@chromium.org>
Date: Thu Jul 16 23:51:11 2015

Revert of Make File-Picker modal on Linux (patchset #8 id:140001 of https://codereview.chromium.org/1045443002/)

Reason for revert:
This patch causes DCHECK failure. Refer to:
https://code.google.com/p/chromium/issues/detail?id=510957

Original issue's description:
> Make File-Picker modal on Linux
>
> Chromium for Linux opens a Gtk file-picker for file browsing, but it is not
> modal because there is no GtkWindow as parent of file-picker.
>
> This patch allows the X11 host window to disable input event handling to make
> a file-picker modal.
>
> BUG= 408481 
>
> Committed: https://crrev.com/b440cbb929e62a238f97590d79bd78333adef7ce
> Cr-Commit-Position: refs/heads/master@{#338870}

BUG= 408481 , 510957 

Review URL: https://codereview.chromium.org/1243503002

Cr-Commit-Position: refs/heads/master@{#339173}

[modify] http://crrev.com/bae7a498705ae28e2d08567928df640a7d48fa37/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
[modify] http://crrev.com/bae7a498705ae28e2d08567928df640a7d48fa37/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] http://crrev.com/bae7a498705ae28e2d08567928df640a7d48fa37/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[modify] http://crrev.com/bae7a498705ae28e2d08567928df640a7d48fa37/ui/views/widget/desktop_aura/x11_desktop_handler.cc

Cc: thomasanderson@chromium.org timbrown@chromium.org
Status: WontFix (was: Untriaged)
This bug has not been touched in over 2 years. In order to help us setup a more active triage process for new incoming bugs, we are closing these old, likely obsolete, bugs.

If this bug is still relevant to you, we want to know about it! Please confirm the bug is still reproducible, and reopen/add a comment.

Sign in to add a comment