Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users
Status: Fixed
Owner:
Out of office
Closed: Aug 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment
Sweep all paged spaces in V8 concurrently.
Project Member Reported by hpayer@chromium.org, Jul 6 2015 Back to list
Add concurrent sweeping support for code and map space.

 
Prework landed:

commit 4621210cfed738b8171b075f816f0c7329489c9d
Author: hpayer <hpayer@chromium.org>
Date:   Fri Jul 3 05:13:43 2015 -0700

    Record code slots that may point to evacuation candidate objects after deoptimizing them.
    
    BUG=chromium:506811
    LOG=n
    
    Review URL: https://codereview.chromium.org/1225573002
    
    Cr-Commit-Position: refs/heads/master@{#29466}


Prework landed:

commit 8fdcd13b5248161a40bda8663828791c1c902b06
Author: hpayer <hpayer@chromium.org>
Date:   Tue Jun 30 09:28:59 2015 -0700

    Disable zapping of code space.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1214333002
    
    Cr-Commit-Position: refs/heads/master@{#29386}
Prework landed:

commit 80b3f16951251d342ebaf9174872d50e46f048a5
Author: hpayer <hpayer@chromium.org>
Date:   Tue Jun 30 06:32:02 2015 -0700

    Directly remove slot buffer entries in deoptimized code objects.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1221643004
    
    Cr-Commit-Position: refs/heads/master@{#29379}

Project Member Comment 5 by bugdroid1@chromium.org, Jul 20 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/23ca3ec88f3d38e68bb497213e8dd6b51205cbbe

commit 23ca3ec88f3d38e68bb497213e8dd6b51205cbbe
Author: hpayer <hpayer@chromium.org>
Date: Mon Jul 20 12:07:06 2015

Revert of Reland concurrent sweeping of code space. (patchset #5 id:80001 of https://codereview.chromium.org/1225733002/)

Reason for revert:
Tests became flaky.

Original issue's description:
> Reland concurrent sweeping of code space.
>
> BUG= chromium:506778 , chromium:506957 , chromium:507211 
> LOG=n
>
> Committed: https://crrev.com/806b81f11e3bfaef0d4330c7669e6934074be9cb
> Cr-Commit-Position: refs/heads/master@{#29748}

TBR=jochen@chromium.org,mvstanton@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:506778 , chromium:506957 , chromium:507211 

Review URL: https://codereview.chromium.org/1242743002

Cr-Commit-Position: refs/heads/master@{#29751}

[modify] http://crrev.com/23ca3ec88f3d38e68bb497213e8dd6b51205cbbe/src/frames.cc
[modify] http://crrev.com/23ca3ec88f3d38e68bb497213e8dd6b51205cbbe/src/heap/heap.cc
[modify] http://crrev.com/23ca3ec88f3d38e68bb497213e8dd6b51205cbbe/src/heap/mark-compact.cc
[modify] http://crrev.com/23ca3ec88f3d38e68bb497213e8dd6b51205cbbe/src/heap/mark-compact.h
[modify] http://crrev.com/23ca3ec88f3d38e68bb497213e8dd6b51205cbbe/src/heap/store-buffer.cc

Comment 8 by hpayer@chromium.org, Aug 10 2015
Status: Fixed
Project Member Comment 9 by bugdroid1@chromium.org, Aug 10 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/be5c115952cfd53072bbac3c4f2b6dd068dfde53

commit be5c115952cfd53072bbac3c4f2b6dd068dfde53
Author: hpayer <hpayer@chromium.org>
Date: Mon Aug 10 12:31:00 2015

Filter out recorded slots of deoptimized code objects directly after deoptimization.

BUG= chromium:507211 
LOG=n

Review URL: https://codereview.chromium.org/1257653011

Cr-Commit-Position: refs/heads/master@{#30089}

[modify] http://crrev.com/be5c115952cfd53072bbac3c4f2b6dd068dfde53/src/heap/mark-compact.cc
[modify] http://crrev.com/be5c115952cfd53072bbac3c4f2b6dd068dfde53/src/heap/mark-compact.h

Comment 11 Deleted
Comment 12 Deleted
Comment 13 Deleted
Sign in to add a comment