New issue
Advanced search Search tips

Issue 50659 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
M-6

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Menu probably not rebuilt when "you've been updated" dot appears

Project Member Reported by thakis@chromium.org, Jul 29 2010

Issue description

I got the update dot, but didn't have the corresponding menu entry. rsesek says that the menu is probably not rebuilt for existing windows.

Seems like a blocker for the "you've been updated" feature.
 

Comment 1 by rsesek@chromium.org, Jul 30 2010

Labels: Mstone-6
Status: Assigned

Comment 2 by thakis@chromium.org, Jul 30 2010

Got this today on another machine. I can confirm that when I open a new window, the new window's menu is correct.
Status: Started
Labels: -Pri-2 Pri-1

Comment 5 by kerz@chromium.org, Aug 2 2010

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
CL out for review: http://codereview.chromium.org/3124002/show

Comment 7 by rsesek@chromium.org, Aug 10 2010

Status: Fixed
Merged to 472.

Comment 8 by bugdro...@gmail.com, Aug 10 2010

Labels: Verifier-Deepakg
Verified label updated by AutoAllocator, contact AmolK or KrisR for details

Comment 9 by bugdro...@gmail.com, Aug 10 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55568 

------------------------------------------------------------------------
r55568 | rsesek@chromium.org | 2010-08-10 08:47:34 -0700 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=55568&r2=55567
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller.h?r1=55568&r2=55567
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm?r1=55568&r2=55567

[Mac] Insert the Update Chrome item to existing Wrench menus when notified.

BUG= 50659 
TEST=Wait for upgrade. Get yellow ball on Wrench menu. Open menu, see Update Chrome item.

Review URL: http://codereview.chromium.org/3124002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55585 

------------------------------------------------------------------------
r55585 | rsesek@chromium.org | 2010-08-10 10:59:47 -0700 (Tue, 10 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/toolbar_controller.mm?r1=55585&r2=55584
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/wrench_menu_controller.h?r1=55585&r2=55584
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/wrench_menu_controller.mm?r1=55585&r2=55584

Merge 55568 - [Mac] Insert the Update Chrome item to existing Wrench menus when notified.

BUG= 50659 
TEST=Wait for upgrade. Get yellow ball on Wrench menu. Open menu, see Update Chrome item.

Review URL: http://codereview.chromium.org/3124002

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/3139003
------------------------------------------------------------------------

Verified in 7.0.530.0.
Status: Verified
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-6 M-6 Cr-UI
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment