Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 9 users
Status: Fixed
Owner:
User never visited
Closed: Aug 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug
M-6

Blocking:
issue 51100

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
If Firefox is default and running, Chrome can't be launched after install
Reported by sunandt@chromium.org, Jul 28 2010 Back to list
What steps will reproduce the problem?
1. Make Firefox as default browser and have it running
2. Install Chrome 6.0.472.0(Dev channel build)

What is the expected output? 
Search ballot should be seen

What do you see instead?
Search ballot is not seen. Even trying to launch Chrome manually doesn't work
and creates zombies.
 
Labels: -Pri-1 Pri-0
Changing Priority to '0' because we are failing to launch just after install.
Labels: OS-Windows
Status: Started
Sunand, are you using FF4?  Which version of Firefox are you running?
FF version: 3.5.11
I just experienced the same problem when installing version 6.0.472.11 dev on Windows XP. I was installing from FF (version 3.5.7), with IE still the default browser. I looked at the process list and saw two chrome.exe processes running. I killed one of them and then the Search Ballot was shown (Firefox still running). I selected Google and afterwards 6.0.472.11 dev seemed to be running fine.

If I install from IE the Search Ballot is shown after installation.

On the machine I used the problem did reproduce, just uninstall Chrome and try to install it again.
I have a fix for this going in soon. The problem is that the window that's supposed to pop up and warn that Firefox is open isn't firing correctly. 
Sigh.  The fix for this isn't hard, though it will take some juggling -- now that we don't have a parent window for the "close FF or you can't import" dialog, we have to do some message loop stuff in order to get the window running properly.  And we need to add a way to distinguish between headless import that is allowed to show UI (like this dialog), and headless that can't show UI -- we can't go by the presence of a parent window any more.  And I have a patch for this that is almost working -- but my Windows machine just crashed hard, and will probably  have to spend the rest of the day reimaging.  Leaving for 4-day wkend tomorrow means patch will go in next week.
hey Miranda,

Just confirming that this bug is a ReleaseBlock-Beta (one of three remaining), and we will hold back the 6.0 beta release until we get this fix in. Please keep us updated; thanks!

 Jeff
Win machine reimaged, installing VS 2008.  ETA tonight for patch finish.
hey Miranda,

While you're at it, would it be possible to add some UMA tracking so we can see how often the "close FF or you can't import" dialog appears?
I can do that -- I'd like to add it as a separate patch if you don't mind, though, just to keep things clean for this urgent bug fix.
sounds good, thanks.
Hi Miranda,

Can you give us an update on the status of your fix?

thanks,
Jeff
Have LGTM, waiting for last bot on trunk -- should go into trunk ASAP.  Branch had conflicts of course, so I had to repatch and resync -- just finishing testing, will commit as soon as I merge the patch to trunk.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54920 

------------------------------------------------------------------------
r54920 | mirandac@chromium.org | 2010-08-04 10:38:46 -0700 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run.h?r1=54920&r2=54919
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run_win.cc?r1=54920&r2=54919
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/importer.cc?r1=54920&r2=54919
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/importer_lock_view.cc?r1=54920&r2=54919
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/importing_progress_view.cc?r1=54920&r2=54919

Fix Firefox import lock dialog on Windows.

BUG= 50577 
TEST= run chrome first_run with import while Firefox is default browser and open.  Dialog should pop up telling user to close FF.
Review URL: http://codereview.chromium.org/2868077
------------------------------------------------------------------------

Committed fix to 472 as http://codereview.chromium.org/3081015/show.
thanks!
Status: Fixed
Project Member Comment 20 by bugdroid1@chromium.org, Oct 12 2012
Blocking: -chromium:51100 chromium:51100
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 21 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-FirstRun -Mstone-6 Cr-UI-Browser-FirstRun M-6 Cr-UI
Project Member Comment 22 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment