New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 49716 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression
M-6

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Fullscreen somewhat broken if entered through unified menu button

Project Member Reported by thakis@chromium.org, Jul 21 2010

Issue description

Chrome Version       : Trunk build at r53124, 10.6.4

What steps will reproduce the problem?
1. Click the fullscreen button on the unified menu

What is the expected result?

Chrome should go fullscreen; moving mouse to top should show overlay.

Instead, chrome goes fullscreen but the menu stays visible, and the overlay does not appear. Doesn't happen in the 6.0.466.4 dev; also doesn't happen if fullscreen is toggled via cmd-shift-f
 

Comment 1 by rsesek@chromium.org, Jul 21 2010

Full screen seems finicky. I can repro this easily by using the wrench menu, but I was also able to do this (after quitting and relaunching) using just Cmd+Shift+F.

Comment 2 by rsesek@chromium.org, Jul 21 2010

Labels: ForMerge
Status: Started
As I suspected, the issue was caused by entering full screen from the nested run loop of the menu. CL forthcoming.

Comment 4 by bugdro...@gmail.com, Jul 21 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53185 

------------------------------------------------------------------------
r53185 | rsesek@chromium.org | 2010-07-21 08:33:15 -0700 (Wed, 21 Jul 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm?r1=53185&r2=53184

[Mac] Use |-performSelector:withDelay:| to execute commands from the Wrench menu.

This avoids doing work from within the menu's nested run loop, which can lead to
wonky behavior.

BUG= 49716 
TEST=Enter full screen from Wrench menu a few times. The overlay always appears.

Review URL: http://codereview.chromium.org/3014021
------------------------------------------------------------------------

Comment 5 by ismail@chromium.org, Jul 22 2010

Status: Verified
Chrome version: 6.0.472.4 r53216

Comment 6 by rsesek@chromium.org, Jul 23 2010

 Issue 49857  has been merged into this issue.
Labels: -Regression bulkmove Type-Regression
Chrome Version       : Trunk build at r53124, 10.6.4

What steps will reproduce the problem?
1. Click the fullscreen button on the unified menu

What is the expected result?

Chrome should go fullscreen; moving mouse to top should show overlay.

Instead, chrome goes fullscreen but the menu stays visible, and the overlay does not appear. Doesn't happen in the 6.0.466.4 dev; also doesn't happen if fullscreen is toggled via cmd-shift-f
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Feature-FullScreen -Mstone-6 -Type-Regression Type-Bug-Regression M-6 Cr-UI Cr-UI-Browser-FullScreen
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment