New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 496282 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
OOO
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug


Sign in to add a comment

Remove dezippering

Project Member Reported by rtoy@chromium.org, Jun 3 2015

Issue description

According to https://github.com/WebAudio/web-audio-api/issues/76#issuecomment-107679878 dezippering must be removed from all audioparams.

This is the second time it's been decided and it seem pretty clear that automatic dezippering will be removed at last.

 

Comment 1 by rtoy@chromium.org, Nov 2 2015

Blockedon: chromium:550533

Comment 2 by rtoy@chromium.org, Nov 13 2015

Blockedon: chromium:555647

Comment 3 by rtoy@chromium.org, Nov 13 2015

Blockedon: chromium:555742

Comment 4 by rtoy@chromium.org, Sep 27 2016

 Issue 649681  has been merged into this issue.

Comment 5 by rtoy@chromium.org, Aug 7 2017

Blockedon: 752985

Comment 6 by rtoy@chromium.org, Aug 7 2017

Blockedon: 752986

Comment 7 by rtoy@chromium.org, Aug 7 2017

Blockedon: 752987

Comment 8 by rtoy@chromium.org, Sep 11 2017

Blocking: 763994

Comment 9 by rtoy@chromium.org, Sep 13 2017

Blocking: 764396
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb779ec2d7c646046f9c560ec064fc254e8f3e5

commit ecb779ec2d7c646046f9c560ec064fc254e8f3e5
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Sep 18 18:53:17 2017

AudioParam dezippering is deprecated

When the value setter is called for AudioParam's that have
dezippering, print a deprecation warning to the console.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/SMTnKE3zAwAJ
Feature: https://www.chromestatus.com/features/5287995770929152

Bug:  496282 
Test: manually tested that the deprecation messages are printed
Change-Id: I0fc027ce1d79b247d1bc2219e70446ac29563f6b
Reviewed-on: https://chromium-review.googlesource.com/668681
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502624}
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/LayoutTests/http/tests/webaudio/autoplay-crossorigin-expected.txt
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/ecb779ec2d7c646046f9c560ec064fc254e8f3e5/tools/metrics/histograms/enums.xml

but i still dont understand why? whats the difference of this to the setTargetAtTime()   !!

Comment 12 by rtoy@chromium.org, Jan 16 2018

The issue is that the value setter would do dezippering in some unspecified way whether you wanted it or not and with some unspecified time constant for the dezippering.

To simplify the spec, the spec removed all dezippering, making the value setter basically equivalent to setValutAtTime().

So if you want dezippering, you should call setTargetAtTime().

Comment 13 by chto...@gmail.com, Jan 31 2018

Still get the warning in last stable Chrome (and even Canary), is it intended?

GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.

Comment 14 by rtoy@chromium.org, Jan 31 2018

Owner: rtoy@chromium.org
Status: Started (was: Available)
Yeah, we were a little slow in making the change and didn't make 64. It will, however, be in 66.  All of the relevant CLs have landed and we have one more to do to remove the actual messages.

Chrome status should now say the change will be in 66.
How would we go about preserving the same behavior as pre-66? Is there a specific argument to setTargetAtTime() that will make things operate the same after the release of 66?

Comment 16 by rtoy@chromium.org, Feb 1 2018

This is why the spec got rid of dezippering; no one knew what was and what the time constants were.

But looking over the different CLs that removed dezippering, here is what I see:

DelayNode: 20 ms
GainNode: 5 ms
StereoPanner: 50 ms
Oscillator: 50 ms
BiquadFilter: 50 ms

The dezippering for the PannerNode was removed ages ago when panner automations were added, so I don't know what they were.

If you used Firefox to test your application and never noticed any audible differences, then you probably don't need to do anything because Firefox never implemented dezippering for anything, except the delay node.

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b924b4656a95b54f2a1182cb5386b6b7d089c8

commit b9b924b4656a95b54f2a1182cb5386b6b7d089c8
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Feb 05 19:11:49 2018

Remove dezippering deprecation messages

Dezippering has been removed so remove the deprecation messages

Bug:  496282 
Change-Id: I09e0ad2c95ac009280ec95fab634e46cc186bd7f
Reviewed-on: https://chromium-review.googlesource.com/891419
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534447}
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/LayoutTests/http/tests/webaudio/autoplay-crossorigin-expected.txt
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
[modify] https://crrev.com/b9b924b4656a95b54f2a1182cb5386b6b7d089c8/third_party/WebKit/public/platform/web_feature.mojom

Comment 18 by rtoy@chromium.org, Feb 6 2018

Status: Fixed (was: Started)
With the removal of the deprecation warnings, dezippering has now been removed from Chrome as required by the spec.

Sign in to add a comment