New issue
Advanced search Search tips

Issue 49448 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-7

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Cut/Copy/Paste buttons on new menu look weird in clicked-then-mouse-out state

Project Member Reported by thakis@chromium.org, Jul 18 2010

Issue description

What steps will reproduce the problem?
1. Open unified menu
2. Click-and-hold "Cut" button
3. Drag mouse somewhere else

What is the expected result?

The button shouldn't look weird. Instead, it does.

Would be ok if it looked like it does in its non-pressed state.
 

Comment 1 by rsesek@chromium.org, Jul 18 2010

Can you post a screen shot?  Also is this on 10.5?

Comment 2 by thakis@chromium.org, Jul 18 2010

yes, 10.5.8.
Picture 31.png
581 KB View Download

Comment 3 by rsesek@chromium.org, Jul 18 2010

Is there a difference if you mouse to the left towards the label (keeping the pointer within the bounds of the custom view) versus off the top or bottom (outside of the custom view)?

Comment 4 by thakis@chromium.org, Jul 18 2010

No, as soon as the mouse pointer leaves the button by 1px in any direction, this happens.

I just noticed that the +/- and fullscreen buttons work fine.

Comment 5 by kerz@chromium.org, Jul 19 2010

Labels: Mstone-6
Status: Assigned

Comment 6 by rsesek@chromium.org, Jul 27 2010

Labels: -Mstone-6 Mstone-7
Not going to get to this.
Status:
Is this still reproducible on trunk?  Those buttons are no longer an NSSegmentedControl, so this issue is probably obsolete.
Status: Assigned

Comment 9 by thakis@google.com, Aug 5 2010

Now the whole row with the buttons goes blank on mouse down.

Comment 10 by thakis@google.com, Aug 5 2010

I tried debugging this, and I sometimes get the following crash:


[65538:267:231269109025204:ERROR:/Users/thakis/src/chrome-git/src/chrome/browser/chrome_browser_application_mac.mm(62)] Someone is preparing to raise an exception!  NSInvalidArgumentException *** *** -[NSGradient initWithColors:atLocations:colorSpace:]: the color NSNamedColorSpace System selectedMenuItemColor cannot be converted into color space Generic RGB colorspace


That seems like a likely cause.
Thanks for looking into this.  What if you change //chrome/browser/cocoa/wrench_menu_butotn_cell.mm line 29 from:
    end = [NSColor selectedMenuItemColor];

To:
    end = [NSColor colorWithDeviceRed:0.157 green:0.384 blue:0.929 alpha:1.0];

This doesn't explain the original behavior, though, because |-selectedMenuItemColor| is only recently used on trunk.
This fixes the line being completely invisible.

The behavior that this bug is about is still happening, but the two
colors that appear on drag-out are now different.

(Side note: On 10.6, I don't get the blue hover if I do click-and-hold)
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55327 

------------------------------------------------------------------------
r55327 | rsesek@chromium.org | 2010-08-06 19:59:31 -0700 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_button_cell.mm?r1=55327&r2=55326

[Mac] Do not use |+[NSColor selectedMenuItemColor]| in a gradient due to color space issues.

BUG= 49448 
TEST=On both 10.5 and 10.6, open the Wrench menu and click a button. Button has blue gradient.

Review URL: http://codereview.chromium.org/3046052
------------------------------------------------------------------------

I think this is as fixed as it ever will be.  Thakis, if you can confirm it doesn't look terrible a la comment 9, I think I'll mark this as Fixed.  I don't think there's anything I can do about the weird partial drawing; it seems like a 10.5 bug.
Status: WontFix
The problem described in comment 9 is fixed.

Would be nice if the buttons would be highlighted on hover in the click-hold-drag-release caseā€¦
File a bug and your wish may come true ;).
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-7 M-7 Cr-UI
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment