New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 49320 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression
M-6

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Changes to preferences Startup- "open following pages" saved

Reported by srikanthk@chromium.org, Jul 16 2010

Issue description

Platform:
  Hostname: testings-mac-mini-3.local
  Mac OS X Version 10.6.4 (Build 10F569)
  Processor: 4 Intel 2.66 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 6.0.466.2 r52428  <<<Release/Debug>>>
  QuickTime Player: 7.6.6
  QuickTime PlayerX: 114

What steps will reproduce the problem?
1. Open 5 different web pages in different tabs.
2. Preferences > Startup > Select " open following pages"  click on the Use Current.
3. Close preferences , reopen preferences.

What is the expected output?
 Changes saved. 

What do you see instead?
Changes are not saved.

Other preferences changes home pages and change of search are saved. 
 
Labels: Mstone-6
Status: Assigned
Labels: Regression

Comment 3 by rsesek@chromium.org, Jul 27 2010

Labels: ForMerge
Status: Started

Comment 4 by bugdro...@gmail.com, Jul 28 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53961 

------------------------------------------------------------------------
r53961 | rsesek@chromium.org | 2010-07-28 10:12:42 -0700 (Wed, 28 Jul 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/custom_home_pages_model.h?r1=53961&r2=53960
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/custom_home_pages_model.mm?r1=53961&r2=53960
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm?r1=53961&r2=53960
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/preferences_window_controller.mm?r1=53961&r2=53960

[Mac] Fix the custom homepages preferences to:

1) Make it actually work again.
2) Change the model so that it doesn't get into an infinite recursion cycle
   trying to update the model, notify observers, and then re-update.

BUG= 49320 
TEST=Chromium-->Preferences. Add custom home pages. Close Preferences and reopen. They are still there.
TEST=Open 3 web pages in tabs. Chromium-->Preferences. Use Current homepages. Close Preferences and reopen. They are still there.
TEST=With custom homepages set, go to Chromium-->Preferences-->UtH-->Reset to Defaults. Go back to Basics. No more custom homepages.

Review URL: http://codereview.chromium.org/3023023
------------------------------------------------------------------------

Comment 5 by bugdro...@gmail.com, Jul 28 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53982 

------------------------------------------------------------------------
r53982 | rsesek@chromium.org | 2010-07-28 11:38:53 -0700 (Wed, 28 Jul 2010) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/custom_home_pages_model.h?r1=53982&r2=53981
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/custom_home_pages_model.mm?r1=53982&r2=53981
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm?r1=53982&r2=53981
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/preferences_window_controller.mm?r1=53982&r2=53981

Merge 53961 - [Mac] Fix the custom homepages preferences to:

1) Make it actually work again.
2) Change the model so that it doesn't get into an infinite recursion cycle
   trying to update the model, notify observers, and then re-update.

BUG= 49320 
TEST=Chromium-->Preferences. Add custom home pages. Close Preferences and reopen. They are still there.
TEST=Open 3 web pages in tabs. Chromium-->Preferences. Use Current homepages. Close Preferences and reopen. They are still there.
TEST=With custom homepages set, go to Chromium-->Preferences-->UtH-->Reset to Defaults. Go back to Basics. No more custom homepages.

Review URL: http://codereview.chromium.org/3023023

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/3045020
------------------------------------------------------------------------

Comment 6 by rsesek@chromium.org, Jul 28 2010

Status: Fixed
Status: Verified
6.0.472.14 (Official Build 54133) dev
Labels: -Regression bulkmove Type-Regression
Summary: Changes to preferences Startup- "open following pages" saved
Platform:
  Hostname: testings-mac-mini-3.local
  Mac OS X Version 10.6.4 (Build 10F569)
  Processor: 4 Intel 2.66 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 6.0.466.2 r52428  &lt;&lt;&lt;Release/Debug&gt;&gt;&gt;
  QuickTime Player: 7.6.6
  QuickTime PlayerX: 114

What steps will reproduce the problem?
1. Open 5 different web pages in different tabs.
2. Preferences &gt; Startup &gt; Select &quot; open following pages&quot;  click on the Use Current.
3. Close preferences , reopen preferences.

What is the expected output?
 Changes saved. 

What do you see instead?
Changes are not saved.

Other preferences changes home pages and change of search are saved.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 10 by laforge@google.com, Oct 17 2012

Labels: -Feature-Preferences Feature-Settings MovedToSettings
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Mstone-6 -Type-Regression -Feature-Settings Type-Bug-Regression M-6 Cr-UI-Settings Cr-UI
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment