Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 13 users
Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----
Product-Review: ----


Sign in to add a comment
Ship passive event listeners ('passive' member of EventListenerOptions)
Project Member Reported by rbyers@chromium.org, May 19 2015 Back to list
Lots of ads frameworks install touch events handlers for the purposes of passively monitoring user input.  In such cases they will never call preventDefault so there's really not reason for us to block scrolling on them, but we don't know that so we have no choice.

We should have an API for passive touch event listening.

Pointer Events ( issue 196799 ) will give us this, but we may want to provide something sooner (and perhaps shouldn't require developers to replace their event model to get this benefit).

scroll-blocks-on (issue 347272) is also designed to address this use case (along with some others).  I propose we block on that, although once we're confident in the API we could choose to ship the non-controversial piece (removing blocking requirements) without waiting for solutions to the controversial parts (increasing blocking).  So let's track this scenario in it's own bug.
 
Comment 1 by rbyers@chromium.org, May 21 2015
One related standards group discussion (for wheel events) here: https://lists.w3.org/Archives/Public/public-pointer-events/2015AprJun/0042.html
Labels: Hotlist-Ads
Blocking: chromium:347272
Comment 5 by rbyers@chromium.org, Aug 17 2015
Blocking: chromium:451469
Comment 6 by rbyers@chromium.org, Aug 18 2015
Blocking: chromium:521307
Comment 7 by rbyers@chromium.org, Sep 22 2015
Cc: rbyers@chromium.org
Owner: dtapu...@chromium.org
Proposed spec (https://github.com/whatwg/dom/pull/82) now seems to have a fair amount of consensus.  To Dave who will be working on implementation (while I continue spec work in parallel).
Comment 8 by rbyers@chromium.org, Sep 29 2015
Summary: Enable passive monitoring of input events without blocking scrolling (EventListenerOptions) (was: Should be possible to passively monitor input events without blocking scrolling)
Comment 9 by rbyers@chromium.org, Oct 15 2015
Blockedon: chromium:543611
When we land this, we should also add UMA metrics to quantify the usage and benefit it provides.  Maybe something like:
1) Classify each touch event as:
   a) no listeners
   b) some listeners active
   c) all listeners passive
   optionally (if it's not too hard) split b into 'd) mix of passive and active listeners'
2) For each touch event where all listeners are passive, how long would scrolling have been blocked without the passive listener optimization?

Eg. I'd like to be able to evangelize the API by publishing stats like "sites that have opted into passive event listeners save a median of xxms in scroll response on some low-end Android devices".

Blockedon: chromium:543685
Blocking: chromium:565980
Blockedon: chromium:568183
Blocking: -chromium:565980
Cc: tdres...@chromium.org
Labels: OWP-Type-ChangeAPI
Labels: -Type-Feature Type-Launch-OWP OWP-Standards-OfficialSpec
Summary: Ship passive event listeners ('passive' member of EventListenerOptions) (was: Enable passive monitoring of input events without blocking scrolling (EventListenerOptions))
Spec: https://dom.spec.whatwg.org/#dom-eventlisteneroptions-passive
Project Member Comment 18 by bugdroid1@chromium.org, Jan 12 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ef8848791589f46db76d1d6ad7fa32d73895e1

commit 89ef8848791589f46db76d1d6ad7fa32d73895e1
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Jan 12 17:36:50 2016

Support registering and dispatching passive event listeners.

Add support for being able to register passive event listeners and
being able to dispatch content to them.

BUG= 489802 

Review URL: https://codereview.chromium.org/1563623002

Cr-Commit-Position: refs/heads/master@{#368907}

[add] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_dispatch.html
[add] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_query.html
[modify] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/Source/core/events/Event.cpp
[modify] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/Source/core/events/Event.h
[modify] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/Source/core/events/EventListenerOptions.idl
[modify] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/Source/core/events/RegisteredEventListener.h
[modify] http://crrev.com/89ef8848791589f46db76d1d6ad7fa32d73895e1/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Labels: M-50
Project Member Comment 20 by bugdroid1@chromium.org, Jan 28 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd423123b7c269a40334624e10ec4b10c2d0682d

commit cd423123b7c269a40334624e10ec4b10c2d0682d
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Jan 28 19:18:11 2016

Purge the ScrollBlocksOn code.

The ScrollBlocksOn code needs to be removed since passive event listeners
is the approach going forward.

BUG= 489802 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1642093002

Cr-Commit-Position: refs/heads/master@{#372129}

[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/blink/web_layer_impl.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/blink/web_layer_impl.h
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/layers/layer.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/layers/layer.h
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/layers/layer_impl.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/layers/layer_impl.h
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/layers/layer_unittest.cc
[delete] http://crrev.com/f3aa3bae8b0541ccc151b6e24d6ae4fcab4fa2ea/cc/layers/scroll_blocks_on.h
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/layers/scrollbar_layer_unittest.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/proto/layer.proto
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/test/layer_tree_json_parser.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/trees/layer_tree_host_impl.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/trees/layer_tree_host_impl_unittest.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/cc/trees/property_tree.h
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/third_party/WebKit/public/blink_headers.gypi
[modify] http://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d/third_party/WebKit/public/platform/WebLayer.h
[delete] http://crrev.com/f3aa3bae8b0541ccc151b6e24d6ae4fcab4fa2ea/third_party/WebKit/public/platform/WebScrollBlocksOn.h

Issue 451469 has been merged into this issue.
Blocking: -chromium:451469
Project Member Comment 23 by bugdroid1@chromium.org, Jan 29 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0b6981de62e9a234d031eab793da8d7752197b

commit ee0b6981de62e9a234d031eab793da8d7752197b
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jan 29 15:14:48 2016

Move have_wheel_event_handlers to WebLayerTreeView.

Since having wheel event handlers was based on the document in general
there was no need for the hit testing code for determining the layer in
cc. So it makes more sense to have these fields on the layer tree view.

BUG= 489802 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1639363002

Cr-Commit-Position: refs/heads/master@{#372346}

[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/blink/web_layer_impl.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/blink/web_layer_impl.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/debug/debug_rect_history.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/input/input_handler.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/layers/layer.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/layers/layer.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/layers/layer_impl.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/layers/layer_impl.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/layers/layer_unittest.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/proto/layer.proto
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/proto/layer_tree_host.proto
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/test/layer_tree_json_parser.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/test/layer_tree_json_parser_unittest.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/draw_property_utils.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host_common.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host_common_unittest.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host_impl.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host_impl.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host_impl_unittest.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_host_unittest.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_impl.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/cc/trees/layer_tree_impl.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/content/renderer/gpu/render_widget_compositor.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/content/renderer/gpu/render_widget_compositor.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/content/test/web_layer_tree_view_impl_for_testing.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/content/test/web_layer_tree_view_impl_for_testing.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/public/platform/WebLayer.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/third_party/WebKit/public/platform/WebLayerTreeView.h
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/ui/events/blink/input_handler_proxy.cc
[modify] http://crrev.com/ee0b6981de62e9a234d031eab793da8d7752197b/ui/events/blink/input_handler_proxy_unittest.cc

Project Member Comment 24 by bugdroid1@chromium.org, Jan 29 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f7ce9caac6d3ea2938ac067cf769bc53d2781cc

commit 7f7ce9caac6d3ea2938ac067cf769bc53d2781cc
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jan 29 23:11:22 2016

Follow on to moving wheel_event_handlers to LayerTreeView

Through reading some code I discovered a potential issue in commit
ee0b6981de62e9a234d031eab793da8d7752197b
(https://codereview.chromium.org/1639363002)

I moved the callback to setting the wheel event handlers onto the
ChromeClient. It appears WebPagePopupImpl extends the EmptyChromeClient
and it should likely call the appropriate things on the layer tree view
it owns. Also added setTouchAction call since I think it should
be implemented.

BUG= 489802 

Review URL: https://codereview.chromium.org/1650673002

Cr-Commit-Position: refs/heads/master@{#372452}

[modify] http://crrev.com/7f7ce9caac6d3ea2938ac067cf769bc53d2781cc/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] http://crrev.com/7f7ce9caac6d3ea2938ac067cf769bc53d2781cc/third_party/WebKit/Source/web/WebViewImpl.cpp

Project Member Comment 26 by bugdroid1@chromium.org, Feb 3 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f024e55c380b2ea3cdb5eb7f52dc922b393d4968

commit f024e55c380b2ea3cdb5eb7f52dc922b393d4968
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Feb 03 01:19:46 2016

Move scroll event handlers from layer to layer tree view.

As similarily done with wheel event handlers move the scroll event
handlers to the layer tree view.

BUG= 489802 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1646603004

Cr-Commit-Position: refs/heads/master@{#373112}

[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/blink/web_layer_impl.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/blink/web_layer_impl.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/debug/debug_rect_history.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/layers/layer.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/layers/layer.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/layers/layer_impl.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/layers/layer_impl.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/layers/layer_unittest.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/proto/layer_tree_host.proto
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/test/layer_tree_json_parser.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/test/layer_tree_json_parser_unittest.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_host.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_host.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_host_impl.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_host_impl.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_host_impl_unittest.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_host_unittest.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_impl.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/cc/trees/layer_tree_impl.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/content/renderer/gpu/render_widget_compositor.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/content/renderer/gpu/render_widget_compositor.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/content/test/web_layer_tree_view_impl_for_testing.cc
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/content/test/web_layer_tree_view_impl_for_testing.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/public/platform/WebLayer.h
[modify] http://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968/third_party/WebKit/public/platform/WebLayerTreeView.h

Project Member Comment 27 by bugdroid1@chromium.org, Feb 5 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f206a40dcff89bf50517b1b4e109c25c277bad43

commit f206a40dcff89bf50517b1b4e109c25c277bad43
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Feb 05 21:36:02 2016

Communicate whether passive event listeners exist to cc.

cc does nothing with these new fields being set other than plumbing them
through the pipeline to be later queried on the layer_impl.

Add an additional field whether touch event listeners exist on the layer
(which unfortunately is effectively implement as an entire document field
in the blink EventListenerRegistry; this can be improved). There still
exists TouchRegionRects that indicate the areas of blocking event
listeners; but whether a passive event listener exists will be indicated
in this field. It is intended that this model will be replicated
with property trees when it is ready.

BUG= 489802 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1577263004

Cr-Commit-Position: refs/heads/master@{#373915}

[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/debug/debug_rect_history.cc
[add] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/input/event_listener_properties.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/input/input_handler.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/layers/layer_impl.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/proto/layer_tree_host.proto
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/proto/layer_tree_settings.proto
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_host.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_host.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_host_impl.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_host_impl.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_host_impl_unittest.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_host_unittest.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_impl.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_impl.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_settings.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/cc/trees/layer_tree_settings.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/content/renderer/gpu/render_widget_compositor.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/content/renderer/gpu/render_widget_compositor.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/content/test/web_layer_tree_view_impl_for_testing.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/content/test/web_layer_tree_view_impl_for_testing.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/dom/Node.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[add] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/tests/data/touch-event-handler-both.html
[add] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/tests/data/touch-event-handler-passive.html
[add] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/tests/data/touch-event-handler.html
[add] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/tests/data/wheel-event-handler-both.html
[add] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/Source/web/tests/data/wheel-event-handler-passive.html
[add] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/public/platform/WebEventListenerProperties.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/third_party/WebKit/public/platform/WebLayerTreeView.h
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/ui/events/blink/input_handler_proxy.cc
[modify] http://crrev.com/f206a40dcff89bf50517b1b4e109c25c277bad43/ui/events/blink/input_handler_proxy_unittest.cc

Project Member Comment 29 by bugdroid1@chromium.org, Feb 12 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/364349a3c0f701a0397ef5ffaaf948ad037fb369

commit 364349a3c0f701a0397ef5ffaaf948ad037fb369
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Feb 12 00:15:32 2016

Add knowledge about blocking and passive event listeners.

Originally we though we could just get away with assuming blocking
represented blocking and passive. But it is the case when there
are touch event listeners that aren't hit we must fire touch events
to the main thread which aren't really necessarily.

Change this to be an enumeration of kBlockingAndPassive.

BUG= 489802 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1686833002

Cr-Commit-Position: refs/heads/master@{#375054}

[modify] http://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369/cc/input/event_listener_properties.h
[modify] http://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369/cc/layers/layer_impl.cc
[modify] http://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369/cc/trees/layer_tree_host_impl_unittest.cc
[modify] http://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369/content/renderer/gpu/render_widget_compositor.cc
[modify] http://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] http://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] http://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369/third_party/WebKit/public/platform/WebEventListenerProperties.h

Project Member Comment 30 by bugdroid1@chromium.org, Feb 18 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bd451acef1d65d36b09a60ffef3e8a6515434a6

commit 0bd451acef1d65d36b09a60ffef3e8a6515434a6
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Feb 18 17:08:10 2016

Plumb firing passive event listeners.

Detect whether passive event listeners exist when handling wheel
and touch events. If the events can be handled on the compositor thread
and an event posted to main thread dispatch that. Add an event queue
for wheel and touch so that we can coalesce pending events for the main
thread.

BUG= 489802 

Review URL: https://codereview.chromium.org/1631963002

Cr-Commit-Position: refs/heads/master@{#376182}

[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/blimp/client/feature/compositor/blimp_input_handler_wrapper.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/browser/android/in_process/synchronous_input_event_filter.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/browser/android/in_process/synchronous_input_event_filter.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/browser/renderer_host/input/input_router_impl.cc
[add] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/browser/renderer_host/input/touch_input_browsertest.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/common/input/input_event_ack_state.h
[add] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/common/input/input_event_dispatch_type.h
[add] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/common/input/web_input_event_queue.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/common/input_messages.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/content_common.gypi
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/content_renderer.gypi
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/content_tests.gypi
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/public/test/browser_test_utils.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/public/test/render_view_test.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/android/synchronous_compositor_filter.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/android/synchronous_compositor_filter.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/idle_user_detector.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/idle_user_detector.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_event_filter.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_event_filter.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_event_filter_unittest.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_handler_manager_client.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/input_handler_wrapper.h
[add] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/non_blocking_event_queue.cc
[add] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/non_blocking_event_queue.h
[add] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/non_blocking_event_queue_unittest.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/render_widget_input_handler.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/input/render_widget_input_handler_delegate.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/mus/render_widget_mus_connection.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/mus/render_widget_mus_connection.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/render_view_impl.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/render_widget.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/render_widget.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/0bd451acef1d65d36b09a60ffef3e8a6515434a6/ui/events/blink/input_handler_proxy_unittest.cc

Project Member Comment 31 by bugdroid1@chromium.org, Mar 17 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46616920c2a0d3e15381fff7111143574c60c7d1

commit 46616920c2a0d3e15381fff7111143574c60c7d1
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Mar 17 22:52:01 2016

Change the non-blocking event queue to the main thread event queue.

A problem with the design in that blocking touch events could get
ahead of the non-blocking events was revealed in discussions. Change
the queue so that it processes all events going to the main thread.
It may elect to put blocking events in queues that it maintains so that
events are not re-ordered when dispatched to the main thread.

Force the ack behavior in the renderer to match the disposition
of the event. The benefit of this is uncancelable touch events
now can be coalesced if the main thread is behind.

BUG= 489802 

Review URL: https://codereview.chromium.org/1780953003

Cr-Commit-Position: refs/heads/master@{#381821}

[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/android/in_process/synchronous_input_event_filter.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/android/in_process/synchronous_input_event_filter.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/renderer_host/input/input_router_impl_perftest.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/renderer_host/input/touch_event_queue.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/common/input/input_event_dispatch_type.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/common/input/web_input_event_traits.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/common/input/web_input_event_traits.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/content_renderer.gypi
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/content_tests.gypi
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/public/test/render_view_test.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/android/synchronous_compositor_filter.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/android/synchronous_compositor_filter.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/input_event_filter.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/input_event_filter.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/input_event_filter_unittest.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/input_handler_manager_client.h
[add] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/main_thread_event_queue.cc
[add] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/main_thread_event_queue.h
[rename] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/main_thread_event_queue_unittest.cc
[delete] https://crrev.com/712e7b24ad99261376251d3d789c69339f9e5904/content/renderer/input/non_blocking_event_queue.cc
[delete] https://crrev.com/712e7b24ad99261376251d3d789c69339f9e5904/content/renderer/input/non_blocking_event_queue.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/input/render_widget_input_handler_delegate.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/mus/compositor_mus_connection_unittest.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/mus/render_widget_mus_connection.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/mus/render_widget_mus_connection.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/render_widget.cc
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/render_widget.h
[modify] https://crrev.com/46616920c2a0d3e15381fff7111143574c60c7d1/content/renderer/render_widget_unittest.cc

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/b25b27f6254eba94ef2e7dcb39b8180fe3834a46

commit b25b27f6254eba94ef2e7dcb39b8180fe3834a46
Author: dtapuska 
Date: Fri Mar 18 14:28:09 2016

Enable Passive Event Listeners as stable.

Approved Intent to Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/8hsz3bOFBpY/kUHDGmTPDQAJ

Turn on passive event listeners as a stable feature.

BUG=489902

Review URL: https://codereview.chromium.org/1811123002

Cr-Commit-Position: refs/heads/master@{#381958}

[modify] https://crrev.com/b25b27f6254eba94ef2e7dcb39b8180fe3834a46/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
Blocking: 599609
Blocking: 598248
Blocking: 601661
Labels: -M-50 M-51
Status: Fixed
Blocking: 601990
It seems that the passive event listeners optimization doesn't work for "click", "contextmenu" and other type of events, e.g.:

addEventListener("click",function(e){let i=1;while(i++<1e8);},{passive:true})
addEventListener("contextmenu",function(e){let i=1;while(i++<1e8);},{passive:true})

Any plans?
The primary use case for passive listeners is to speed up scrolling.  In "click" and "contextmenu" cases there is no scrolling.  So no, at the moment there aren't any plans to use "passive" to help performance in scenarios involving events like "click" (we're generally stuck waiting for JavaScript in such cases regardless, but at least the tolerance for delay is a little higher).
Project Member Comment 40 by bugdroid1@chromium.org, Jun 23 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e95fc1fa03174e0064d73638d9e6ad364ecdb514

commit e95fc1fa03174e0064d73638d9e6ad364ecdb514
Author: rbyers <rbyers@chromium.org>
Date: Thu Jun 23 20:24:43 2016

Add use counters for the passive option to addEventListener

We've long tracked the primary metric - how often do scrolls block
unnecessarily (via the Event.PassiveListeners histogram) but the results
are complex.  To help interpret the results let's also just count
how common it is for a page to use the 'passive' option anywhere.
This isn't directly meaningful by itself in terms of outcomes, but
is still useful as a rough indication of developer adoption for the API.

BUG= 489802 
TBR=rkaplow

Review-Url: https://codereview.chromium.org/2090903003
Cr-Commit-Position: refs/heads/master@{#401703}

[modify] https://crrev.com/e95fc1fa03174e0064d73638d9e6ad364ecdb514/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/e95fc1fa03174e0064d73638d9e6ad364ecdb514/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/e95fc1fa03174e0064d73638d9e6ad364ecdb514/tools/metrics/histograms/histograms.xml

Project Member Comment 41 by bugdroid1@chromium.org, Jul 8 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e27383ef83667f3b1ec6043411b9731fb3e7c43

commit 9e27383ef83667f3b1ec6043411b9731fb3e7c43
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jul 08 01:12:46 2016

Remove runtime setting for passive event listeners.

Remove the runtime setting as it has been stable for a few releases now.

BUG= 489802 

Review-Url: https://codereview.chromium.org/2132823002
Cr-Commit-Position: refs/heads/master@{#404295}

[modify] https://crrev.com/9e27383ef83667f3b1ec6043411b9731fb3e7c43/third_party/WebKit/Source/core/events/AddEventListenerOptions.idl
[modify] https://crrev.com/9e27383ef83667f3b1ec6043411b9731fb3e7c43/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Sign in to add a comment