New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 489259 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

loadUrl("javascript:") broken in WebView M43 onward

Project Member Reported by miguelg@chromium.org, May 18 2015

Issue description

Gustav, can you have a look? I can help repro if needed.


Device name: Nexus 6
Android version: 5.1
WebView version (from system settings -> Apps -> Android System WebView):
Application: M43
Application version: 1.5.9.0

100% reproable, happy to show it to people in London. You don't really need to have an account since the step that fails is right before prompting for the data.

URLs (if applicable): https://play.google.com/store/apps/details?id=com.htsu.hsbcpersonalbanking&hl=en_GB


Steps to reproduce:
1. Try to log in

Expected result: You are prompted to introduce your security details

Actual result: Infinte spinner

This is the logcat output I get: Notice the "Uncaught SyntaxError: Unexpected token ILLEGAL", source:  (1) towards the end.



I/chromium( 2590): [INFO:CONSOLE(2479)] "true", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/lib/js/dove.js (2479)
I/chromium( 2590): [INFO:CONSOLE(2491)] "data value is + ", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/lib/js/dove.js (2491)
I/chromium( 2590): [INFO:CONSOLE(1197)] "Enter getIPServerDomain. The getIPDomainUrl is  https://www.mobile.security.hsbc.co.uk/gsa/%3Fidv_cmd%3Didv.SaaSSecurityCommand%26CHANNEL%3DMOBILE%26SaaS_FUNCTION_NAME%3DDetermineSiteID%26nextPage%3DMOBILE_RETRIEVE_DOMAIN_URL%26locale%3Den", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1197)
I/chromium( 2590): [INFO:CONSOLE(1326)] "No need to forceLogoff for IP. Going to setter. The key is serverIPDomain", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1326)
I/chromium( 2590): [INFO:CONSOLE(1290)] "In the formDomain function.", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1290)
I/chromium( 2590): [INFO:CONSOLE(1295)] "siteID is www1; temp domain name is .mobile.security.hsbc.co.uk", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1295)
I/chromium( 2590): [INFO:CONSOLE(1300)] "The siteID is NOT null. The domain is www1.mobile.security.hsbc.co.uk", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1300)
I/chromium( 2590): [INFO:CONSOLE(1290)] "In the formDomain function.", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1290)
I/chromium( 2590): [INFO:CONSOLE(1295)] "siteID is www1; temp domain name is .mobile.security.hsbc.co.uk", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1295)
I/chromium( 2590): [INFO:CONSOLE(1300)] "The siteID is NOT null. The domain is www1.mobile.security.hsbc.co.uk", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/web/SAAS_authentication/logon/logon.js (1300)
I/chromium( 2590): [INFO:CONSOLE(184)] "currentIPDomain = www1.mobile.security.hsbc.co.uk", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/lib/js/timeout.js (184)
I/chromium( 2590): [INFO:CONSOLE(372)] "final url = https://www.saas.hsbc.co.uk/1/2/%3Fidv_cmd%3Didv.GetCommToken%26nextPage%3Dhsbc.pib.view-accounts%26CHANNEL%3DMOBILE%26function%3DSaas_Authentication", source: file:///data/data/com.htsu.hsbcpersonalbanking/files/resource/148/websrc/1.5.9/web/wr1431948901541/lib/js/timeout.js (372)

I/chromium( 2590): [INFO:CONSOLE(1)] "Uncaught SyntaxError: Unexpected token ILLEGAL", source:  (1)


I/chromium(14434): [INFO:library_loader_hooks.cc(112)] Chromium logging enabled: level = 0, default verbosity = 0
I/BrowserStartupController(14434): Initializing chromium process, singleProcess=true
W/chromium(14434): [WARNING:resource_bundle.cc(286)] locale_file_path.empty()
I/chromium(14434): [INFO:aw_browser_main_parts.cc(63)] Load from apk succesful, fd=37 off=47152 len=3371
I/chromium(14434): [INFO:aw_browser_main_parts.cc(76)] Loading webviewchromium.pak from, fd:38 off:7638120 len:1165478
V/WebViewFactory(14946): RelroFileCreator (64bit = false),  32-bit lib: /system/app/WebViewGoogle/lib/arm/libwebviewchromium.so, 64-bit lib: 
I/chromium(15022): [INFO:library_loader_hooks.cc(104)] Chromium logging enabled: level = 0, default verbosity = 0
I/BrowserStartupController(15022): Initializing chromium process, singleProcess=true
W/chromium(15022): [WARNING:resource_bundle.cc(304)] locale_file_path.empty()
I/chromium(15022): [INFO:aw_browser_main_parts.cc(65)] Load from apk succesful, fd=34 off=43796 len=3029
I/chromium(15022): [INFO:aw_browser_main_parts.cc(78)] Loading webviewchromium.pak from, fd:35 off:230172 len:1089587

 
Cc: miguelg@chromium.org

Comment 2 by sgu...@chromium.org, May 18 2015

Cc: kristianm@chromium.org
This seems to be caused by
https://codereview.chromium.org/1022993002

investigating further...

Comment 4 by torne@chromium.org, May 19 2015

Summary: loadUrl("javascript:") broken in WebView M43 onward (was: HSBC app broken with WebView M43)
Retitling as we've discovered the details of the issue. Fix in flight: https://codereview.chromium.org/1131083004/

Comment 5 by torne@chromium.org, May 19 2015

 Issue 489241  has been merged into this issue.

Comment 6 by torne@chromium.org, May 19 2015

Labels: -Pri-2 Pri-1 M-44
Project Member

Comment 7 by bugdroid1@chromium.org, May 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1649ce638403abeb04c03d219221af7dc2817e57

commit 1649ce638403abeb04c03d219221af7dc2817e57
Author: gsennton <gsennton@chromium.org>
Date: Tue May 19 11:54:08 2015

Fix loadUrl for javascript urls.

A recent update
https://codereview.chromium.org/1022993002
broke the loading of javascript URLs. This patch reverts only the part
of the update which is broken.

BUG= 489259 

Review URL: https://codereview.chromium.org/1131083004

Cr-Commit-Position: refs/heads/master@{#330507}

[modify] http://crrev.com/1649ce638403abeb04c03d219221af7dc2817e57/android_webview/java/src/org/chromium/android_webview/AwContents.java

Thank you for the fix, do you know when it is likely to roll out?

Comment 9 by torne@chromium.org, May 19 2015

We're still looking at other M43 issues so we don't have a schedule yet, but we won't be releasing M43 to stable without this fix, don't worry (it will be in the next beta release).

If you're having problems in the meantime, you can opt out of the beta and uninstall the update to get back to the stable version.

Comment 10 by torne@chromium.org, May 19 2015

Labels: Merge-Request-43 Merge-Request-44

Comment 11 by laforge@google.com, May 19 2015

Labels: -Merge-Request-43 Merge-Review-43 Hotlist-Merge-Review
[Automated comment] Reverts referenced in bugdroid comments, needs manual review.

Comment 12 by laforge@google.com, May 19 2015

Labels: -Merge-Request-44 Merge-Review-44
[Automated comment] Reverts referenced in bugdroid comments, needs manual review.

Comment 13 by k...@google.com, May 19 2015

Labels: -Merge-Review-43 -Merge-Review-44 Merge-Approved-44 Merge-Approved-43

Comment 14 by boliu@chromium.org, May 19 2015

Sorry about the breaking change. Can you make sure you take what you learned here, and add some tests to make sure this doesn't happen again?
Project Member

Comment 15 by bugdroid1@chromium.org, May 19 2015

Labels: -Merge-Approved-43 merge-merged-2357
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b67ed7bab5fd93be602fdbfa26602b380f97ce71

commit b67ed7bab5fd93be602fdbfa26602b380f97ce71
Author: gsennton <gsennton@chromium.org>
Date: Tue May 19 17:01:27 2015

Fix loadUrl for javascript urls.

A recent update
https://codereview.chromium.org/1022993002
broke the loading of javascript URLs. This patch reverts only the part
of the update which is broken.

NOPRESUBMIT=true
NOTRY=true
BUG= 489259 

(cherry picked from commit 22abb71d9c3f0d6ed7f7252385e49673ad5c5fea)

Review URL: https://codereview.chromium.org/1131523006

Cr-Commit-Position: refs/branch-heads/2357@{#410}
Cr-Branched-From: 59d4494849b405682265ed5d3f5164573b9a939b-refs/heads/master@{#323860}

[modify] http://crrev.com/b67ed7bab5fd93be602fdbfa26602b380f97ce71/android_webview/java/src/org/chromium/android_webview/AwContents.java

Project Member

Comment 16 by bugdroid1@chromium.org, May 19 2015

Labels: -Merge-Approved-44 merge-merged-2403
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6389899ae44ec15e0df751eba690a201aa089318

commit 6389899ae44ec15e0df751eba690a201aa089318
Author: gsennton <gsennton@chromium.org>
Date: Tue May 19 17:10:50 2015

Fix loadUrl for javascript urls.

A recent update
https://codereview.chromium.org/1022993002
broke the loading of javascript URLs. This patch reverts only the part
of the update which is broken.

NOPRESUBMIT=true
NOTRY=true
BUG= 489259 

(cherry picked from commit 22abb71d9c3f0d6ed7f7252385e49673ad5c5fea)

Review URL: https://codereview.chromium.org/1131043005

Cr-Commit-Position: refs/branch-heads/2403@{#14}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}

[modify] http://crrev.com/6389899ae44ec15e0df751eba690a201aa089318/android_webview/java/src/org/chromium/android_webview/AwContents.java

Comment 17 by torne@chromium.org, May 19 2015

Status: Fixed
Project Member

Comment 18 by bugdroid1@chromium.org, May 19 2015

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/b67ed7bab5fd93be602fdbfa26602b380f97ce71

commit b67ed7bab5fd93be602fdbfa26602b380f97ce71
Author: gsennton <gsennton@chromium.org>
Date: Tue May 19 17:01:27 2015

Comment 19 by owale@chromium.org, May 20 2015

Status: Verified
----Verification Attempt----
WebView build: 43.0.2357.76 & 44.0.2403.10
Steps Performed To Verify Fix:

As per #0 &  issue 489241 

Verification Succeeded (yes/no): Yes
Project Member

Comment 20 by bugdroid1@chromium.org, May 22 2015

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/6389899ae44ec15e0df751eba690a201aa089318

commit 6389899ae44ec15e0df751eba690a201aa089318
Author: gsennton <gsennton@chromium.org>
Date: Tue May 19 17:10:50 2015

Sign in to add a comment