New issue
Advanced search Search tips
Starred by 6 users
Status: Fixed
Owner:
Closed: May 2015
EstimatedDays: ----
NextAction: ----
OS: Windows, Mac
Pri: 2
Type: Bug

Blocking:
issue 493212



Sign in to add a comment
Enable NPAPI flag still present in Chrome 45 Canary.
Reported by msimprov...@gmail.com, May 17 2015 Back to list
UserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2404.0 Safari/537.36

Steps to reproduce the problem:
1. Update to Chrome 45.
2. Open chrome://flags/#enable-npapi

What is the expected behavior?
The Enable NPAPI flag is removed.

What went wrong?
"Enables the use of NPAPI plugins. This flag will be removed in Chrome 45, along with NPAPI support. See g.co/npapi"
Apparently the Enable NPAPI flag has not yet been removed in Chrome 45.

Did this work before? Yes 44.0.2403.0 (before the Enable NPAPI flag planned to be removed)

Chrome version: 45.0.2404.0  Channel: canary
OS Version: 6.3
Flash Version: Shockwave Flash 18.0 r0

Suspecting: r312374
wfh@, can you please take a look?
 
Comment 1 by wfh@chromium.org, May 17 2015
Labels: -Arch-x86_64 OS-Mac M-45 ReleaseBlock-Beta
Owner: wfh@chromium.org
Status: Assigned
I admire your enthusiasm to remove the flag, but M44 only branched this morning so unsurprising that the code hasn't landed to remove this yet.

M45 doesn't branch for a few weeks, so still have some time to land this...
M45 just landed in the canary channel this morning.
Comment 3 by m.go...@gmail.com, May 18 2015
Re #2: Canary is almost the top of the branch so the change from M44 to M45 was just a number bump, nothing more. The text in chrome://flags says about the stable M45, NPAPi will most likely be removed before the beta arrives; there are about 6-8 weeks to do that.
Comment 4 by wfh@chromium.org, May 29 2015
Blocking: chromium:493212
Project Member Comment 5 by bugdroid1@chromium.org, May 29 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c

commit cfdd80f3d2a845a2267dd9ffe81011609f74eb0c
Author: wfh <wfh@chromium.org>
Date: Fri May 29 17:56:27 2015

Disable NPAPI support by removing the --enable-npapi switch, chrome://flags and enterprise policy override.

--enable-npapi-for-testing will remain temporarily until the rest of the NPAPI code and tests are removed.

This is a selective revert of 0539f2f5214fc17fdd5d1964be0ceedf98fdb9ce and 26d09db19381c2236a2890c045761465c78bc958.

BUG= 493212 , 489066 

Review URL: https://codereview.chromium.org/1158423003

Cr-Commit-Position: refs/heads/master@{#332006}

[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/app/generated_resources.grd
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/browser/BUILD.gn
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/browser/about_flags.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/browser/content_settings/content_settings_browsertest.cc
[delete] http://crrev.com/c1995be807fd95a833d93eef029a8642782b0d6e/chrome/browser/plugins/enable_npapi_plugins_policy_handler.cc
[delete] http://crrev.com/c1995be807fd95a833d93eef029a8642782b0d6e/chrome/browser/plugins/enable_npapi_plugins_policy_handler.h
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/browser/plugins/plugin_prefs.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/browser/plugins/plugin_prefs.h
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/browser/plugins/plugin_prefs_factory.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/chrome_browser.gypi
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/common/pref_names.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/chrome/common/pref_names.h
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/browser/plugin_browsertest.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/browser/plugin_service_impl.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/browser/plugin_service_impl.h
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/public/browser/plugin_service.h
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/public/common/content_switches.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/public/common/content_switches.h
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/shell/app/shell_main_delegate.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/test/fake_plugin_service.cc
[modify] http://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c/content/test/fake_plugin_service.h

Comment 6 by wfh@chromium.org, May 29 2015
Status: Fixed
Comment 7 Deleted
Fix successfully verified on Chrome 45.0.2430.0 canary.

1. Opened chrome://flags
2. No Enable NPAPI flag found.
Sign in to add a comment