New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 87 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Task


Sign in to add a comment
link

Issue 485650: Use page zoom logic to implement device scale

Reported by osh...@chromium.org, May 7 2015 Project Member

Issue description

As of  crbug.com/177836 , scaling done by page zoom (ctrl+-, not pinch zoom) and scale done by devie scale factor are basically same, and should be indistinguishable from web site.

Currently we have number of issues at fractional scale factor (
 crbug.com/424498 ,  crbug.com/411490 , crbug.com/427791), which doesn't occur at the same zooming
leve.

I'd like to propose that we should use the page zoom to implement DSF feature. The actual
zooming to be applied becomes DSF x page zoom applied by a user.

Key benefits are:
1) Above issues are already handled properly in page zoom.
2) Simplify the code base by eliminating device scale factor code.
 2.1) I've been told that Blink team wants to remove device specific information from blink, so I hope this is also consistent with that direction.

Required work should be relatively small. Most of work would be just plumbling work, and making sure coordinates passed between blink and chrome are consistent. 

I'd like to start working on proof-of-concept CL (but no commit), so please let me know what you think. And please add anyone who should be on this bug but I missed.

Thanks!
 
Showing comments 106 - 205 of 205 Older

Comment 106 by e...@chromium.org, Jan 29 2016

Issue 582559 has been merged into this issue.

Comment 107 by bugdroid1@chromium.org, Feb 4 2016

Project Member

Comment 108 by osh...@chromium.org, Feb 5 2016

Blockedon: chromium:584709

Comment 109 by bugdroid1@chromium.org, Feb 5 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62acb0672da4163297a36dfaeb047ac740af5b83

commit 62acb0672da4163297a36dfaeb047ac740af5b83
Author: oshima <oshima@chromium.org>
Date: Fri Feb 05 19:46:50 2016

Enable use-zoom-for-dsf on chromeos devices.

BUG=485650, 584709 

Review URL: https://codereview.chromium.org/1670953002

Cr-Commit-Position: refs/heads/master@{#373881}

[modify] http://crrev.com/62acb0672da4163297a36dfaeb047ac740af5b83/content/common/content_switches_internal.cc

Comment 110 by bugdroid1@chromium.org, Feb 17 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8269081fddb6ba6f281294562073c85a4ce59514

commit 8269081fddb6ba6f281294562073c85a4ce59514
Author: oshima <oshima@chromium.org>
Date: Wed Feb 17 02:20:40 2016

ScrollableArea::pixelsPerLine  should return viewport pixels in use-zoom-for-dsf mode

BUG=485650
TEST=manual. Use arrow key to scroll on 2x device.

Review URL: https://codereview.chromium.org/1672973002

Cr-Commit-Position: refs/heads/master@{#375761}

[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/core/page/SpatialNavigation.cpp
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/platform/HostWindow.h
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
[modify] http://crrev.com/8269081fddb6ba6f281294562073c85a4ce59514/third_party/WebKit/Source/web/PopupMenuImpl.cpp

Comment 111 by bugdroid1@chromium.org, Feb 18 2016

Project Member

Comment 112 by bugdroid1@chromium.org, Feb 25 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ae5c77d75789aa53731b5ed088344b65931225

commit 31ae5c77d75789aa53731b5ed088344b65931225
Author: oshima <oshima@chromium.org>
Date: Thu Feb 25 22:46:09 2016

Enable use-zoom-for-dsf by default on chromeos
not just on devices.

Test issue has been resolved so we can now enable on everywhere.

BUG=485650

Review URL: https://codereview.chromium.org/1729233003

Cr-Commit-Position: refs/heads/master@{#377692}

[modify] https://crrev.com/31ae5c77d75789aa53731b5ed088344b65931225/content/common/content_switches_internal.cc
[modify] https://crrev.com/31ae5c77d75789aa53731b5ed088344b65931225/content/renderer/render_view_browsertest.cc

Comment 113 by bugdroid1@chromium.org, Feb 28 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/131114a6dd70fabb949d7f05f3c9759bcf701281

commit 131114a6dd70fabb949d7f05f3c9759bcf701281
Author: oshima <oshima@chromium.org>
Date: Sun Feb 28 05:42:57 2016

Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor.

RenderWidget::OnDeviceScaleFactorChanegd calls
setPaintedDeviceScaleFactor, which does not work for pepper.

I apparently forgot to handle this in https://codereview.chromium.org/1609193002.

BUG= 589869 ,485650

Review URL: https://codereview.chromium.org/1745523002

Cr-Commit-Position: refs/heads/master@{#378153}

[modify] https://crrev.com/131114a6dd70fabb949d7f05f3c9759bcf701281/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/131114a6dd70fabb949d7f05f3c9759bcf701281/content/renderer/render_widget_fullscreen_pepper.h

Comment 114 by bugdroid1@chromium.org, Mar 1 2016

Project Member
Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab5b607f62fc15e879a6c0c939774660a620796b

commit ab5b607f62fc15e879a6c0c939774660a620796b
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Mar 01 17:37:19 2016

Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor.

RenderWidget::OnDeviceScaleFactorChanegd calls
setPaintedDeviceScaleFactor, which does not work for pepper.

I apparently forgot to handle this in https://codereview.chromium.org/1609193002.

BUG= 589869 ,485650
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1745523002

Cr-Commit-Position: refs/heads/master@{#378153}
(cherry picked from commit 131114a6dd70fabb949d7f05f3c9759bcf701281)

Review URL: https://codereview.chromium.org/1752813002 .

Cr-Commit-Position: refs/branch-heads/2661@{#26}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/ab5b607f62fc15e879a6c0c939774660a620796b/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/ab5b607f62fc15e879a6c0c939774660a620796b/content/renderer/render_widget_fullscreen_pepper.h

Comment 115 by bugdroid1@chromium.org, Mar 2 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/481728208e8d056b858f0b2a9e074138133e8ac2

commit 481728208e8d056b858f0b2a9e074138133e8ac2
Author: oshima <oshima@chromium.org>
Date: Wed Mar 02 00:43:42 2016

Rebaeline expectations for all fast/hidpi tests

BUG= 577300 ,485650
R=wkorman

Review URL: https://codereview.chromium.org/1753923003

Cr-Commit-Position: refs/heads/master@{#378630}

[modify] https://crrev.com/481728208e8d056b858f0b2a9e074138133e8ac2/third_party/WebKit/LayoutTests/TestExpectations

Comment 116 by bugdroid1@chromium.org, Mar 2 2016

Project Member
Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/481728208e8d056b858f0b2a9e074138133e8ac2

commit 481728208e8d056b858f0b2a9e074138133e8ac2
Author: oshima <oshima@chromium.org>
Date: Wed Mar 02 00:43:42 2016

Comment 117 by bugdroid1@chromium.org, Mar 2 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9265ee3eae2094e0e615b8d10279d0e4fc3557a2

commit 9265ee3eae2094e0e615b8d10279d0e4fc3557a2
Author: Walter Korman <wkorman@google.com>
Date: Wed Mar 02 19:06:14 2016

Disable fast/hidpi/static rebaselines again temporarily.

BUG= 577300 ,485650
TBR=oshima

Review URL: https://codereview.chromium.org/1754893005 .

Cr-Commit-Position: refs/heads/master@{#378791}

[modify] https://crrev.com/9265ee3eae2094e0e615b8d10279d0e4fc3557a2/third_party/WebKit/LayoutTests/TestExpectations

Comment 118 by bugdroid1@chromium.org, Mar 3 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4bc1bd8b475f778491e682cc29411f56d00cfa0

commit a4bc1bd8b475f778491e682cc29411f56d00cfa0
Author: wkorman <wkorman@chromium.org>
Date: Thu Mar 03 01:28:52 2016

Add trailing slash to virtual fast/hidpi/static tests for rebaseline.

The Blink rebaseline bot canonicalizes entries representing a directory to
terminate with a path separator in
TestExpectationParser._collect_matching_tests(). However, in
AutoRebaseline.get_test_prefix_list() we check test presence in a test prefix
list (obtained via TestExpectations.get_needs_rebaseline_failures()), and the
test used as the key is non-canonicalized.

A more long term fix is to ensure we canonicalize the test before checking for
presence, but in interim manually specifying the directories needing rebaseline
to include the expected path separator should allow the tests to be rebaselined
properly.

BUG= 577300 ,485650
TBR=oshima

Review URL: https://codereview.chromium.org/1754963003

Cr-Commit-Position: refs/heads/master@{#378905}

[modify] https://crrev.com/a4bc1bd8b475f778491e682cc29411f56d00cfa0/third_party/WebKit/LayoutTests/TestExpectations

Comment 119 by bugdroid1@chromium.org, Mar 4 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e16a6fa53ebd538abd802b189f1063bad267b575

commit e16a6fa53ebd538abd802b189f1063bad267b575
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Mar 04 20:52:28 2016

Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport coordinates.  This needs to be converted to DIP for browser somewhere. For now, this CL convert it in browser  side rather than renderer side because the code that computes the selection bounds is in cc/  rather than content/renderer. Consider move that part ot content/renderer and move this to there instead.

BUG= 585043 
TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual.
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1740193002

Cr-Commit-Position: refs/heads/master@{#378500}
(cherry picked from commit 93b827d99389ad0ce61362695ad641b14ca33180)

Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor.

RenderWidget::OnDeviceScaleFactorChanegd calls
setPaintedDeviceScaleFactor, which does not work for pepper.

I apparently forgot to handle this in https://codereview.chromium.org/1609193002.

BUG= 589869 ,485650

Review URL: https://codereview.chromium.org/1745523002

Cr-Commit-Position: refs/heads/master@{#378153}
(cherry picked from commit 131114a6dd70fabb949d7f05f3c9759bcf701281)

Review URL: https://codereview.chromium.org/1768653002 .

Cr-Commit-Position: refs/branch-heads/2661@{#84}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/e16a6fa53ebd538abd802b189f1063bad267b575/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
[modify] https://crrev.com/e16a6fa53ebd538abd802b189f1063bad267b575/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/e16a6fa53ebd538abd802b189f1063bad267b575/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e16a6fa53ebd538abd802b189f1063bad267b575/content/renderer/render_view_impl.cc
[modify] https://crrev.com/e16a6fa53ebd538abd802b189f1063bad267b575/content/test/data/touch_selection.html

Comment 120 by bokan@chromium.org, Mar 15 2016

Blocking: 521835

Comment 121 by osh...@chromium.org, Mar 17 2016

Blocking: 574447

Comment 122 by osh...@chromium.org, Mar 17 2016

Labels: -M-49 M-51

Comment 123 by pdr@chromium.org, Mar 17 2016

Cc: -pdr@chromium.org

Comment 124 by cbiesin...@chromium.org, Mar 23 2016

Components: -Blink Blink>PageZoom Blink>Layout

Comment 125 by bsep@chromium.org, Apr 20 2016

Issue 427791 has been merged into this issue.

Comment 126 by bsep@chromium.org, Apr 20 2016

Cc: tkonch...@chromium.org
 Issue 421183  has been merged into this issue.

Comment 127 by bsep@chromium.org, Apr 21 2016

Blocking: 605745

Comment 128 by osh...@chromium.org, May 6 2016

Cc: piman@chromium.org sunxd@chromium.org jaydasika@chromium.org dtapu...@chromium.org vollick@chromium.org
 Issue 605671  has been merged into this issue.

Comment 129 by e...@chromium.org, May 10 2016

 Issue 610805  has been merged into this issue.

Comment 130 by bugdroid1@chromium.org, May 11 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/531c45d269a7c0079c18cb45a1aff2ceb1608032

commit 531c45d269a7c0079c18cb45a1aff2ceb1608032
Author: oshima <oshima@chromium.org>
Date: Wed May 11 21:50:04 2016

Scale tickmark's coordinates to dip to viewport in use-zoom-for-dfs mode

BUG=485650

Review-Url: https://codereview.chromium.org/1969083002
Cr-Commit-Position: refs/heads/master@{#393076}

[modify] https://crrev.com/531c45d269a7c0079c18cb45a1aff2ceb1608032/content/renderer/pepper/pepper_plugin_instance_impl.cc

Comment 131 by bugdroid1@chromium.org, May 12 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49b5c0c953b9d2fd9fdc6715c128eea22a35fbbd

commit 49b5c0c953b9d2fd9fdc6715c128eea22a35fbbd
Author: oshima <oshima@chromium.org>
Date: Thu May 12 14:00:23 2016

Scale the scroll offset from viewport to dip in use-zoom-for-dsf mode,
as the pepper plugin operates in DIP.

BUG=485650

Review-Url: https://codereview.chromium.org/1972803002
Cr-Commit-Position: refs/heads/master@{#393241}

[modify] https://crrev.com/49b5c0c953b9d2fd9fdc6715c128eea22a35fbbd/content/renderer/pepper/pepper_plugin_instance_impl.cc

Comment 132 by osh...@chromium.org, May 13 2016

Cc: jam...@chromium.org kuscher@chromium.org
 Issue 411490  has been merged into this issue.

Comment 133 by e...@chromium.org, May 17 2016

Blocking: 612013

Comment 134 by bsep@chromium.org, May 18 2016

Blockedon: 612874

Comment 135 by bugdroid1@chromium.org, May 18 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcc58292dabf419324cddbad21242ddc8be3896

commit cbcc58292dabf419324cddbad21242ddc8be3896
Author: oshima <oshima@chromium.org>
Date: Wed May 18 19:21:31 2016

Disable input scaling only when an input came from renderer

I didn't realized that touch events are directly sent to guest views. This fixes the issue by only skip scaling when events are sent back from renderer.

BUG=485650,  600453 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1977513002
Cr-Commit-Position: refs/heads/master@{#394499}

[modify] https://crrev.com/cbcc58292dabf419324cddbad21242ddc8be3896/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/cbcc58292dabf419324cddbad21242ddc8be3896/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/cbcc58292dabf419324cddbad21242ddc8be3896/content/browser/renderer_host/render_widget_host_impl.h

Comment 136 by abodenha@chromium.org, May 18 2016

Labels: -M-51 M-52
We all good for 52 here, right?

Comment 137 by rbyers@chromium.org, May 19 2016

Blocking: 610460

Comment 138 by bsep@chromium.org, May 20 2016

Blockedon: 613414

Comment 139 by bugdroid1@chromium.org, May 21 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c8a16bac8b21dc80361efd894a9d2375fb5bec

commit d1c8a16bac8b21dc80361efd894a9d2375fb5bec
Author: oshima <oshima@chromium.org>
Date: Sat May 21 00:37:01 2016

Mark FrameHost::deviceScaleFactor as deprecated.

This will be gone when transition is completed, but still needed for traditional mode. I added the comment when (not) to use it, and renamed to deviceScaleFactorDeprecated().

I'll create a similar CL for Page::deviceScaleFactor() later.

BUG=485650

Review-Url: https://codereview.chromium.org/1996223003
Cr-Commit-Position: refs/heads/master@{#395219}

[modify] https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec/third_party/WebKit/Source/core/frame/FrameHost.cpp
[modify] https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec/third_party/WebKit/Source/core/frame/FrameHost.h
[modify] https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec/third_party/WebKit/Source/core/page/DragController.cpp

Comment 140 by tkent@chromium.org, May 23 2016

Components: -Blink>PageZoom
Deprecating Blink>PageZoom

Comment 141 by osh...@chromium.org, May 23 2016

Quick update.

This is enabled on ChromeOS starting from m52. I'm hoping this sticks this time.

Next targets are Windows and Linux, and we're planning to turn this on for 53 (hopefully soon).
(big thanks to bsep@ for helping on Windows side)

I'll look into android and mac next to see how much work left on these platform. I haven't decided which platform to work on next yet, but I'll keep you posted.

Comment 142 by bugdroid1@chromium.org, May 24 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79f1dd40fc3a6591b1a30aa911eaf1fbb339e49

commit e79f1dd40fc3a6591b1a30aa911eaf1fbb339e49
Author: oshima <oshima@chromium.org>
Date: Tue May 24 01:11:51 2016

Allow use-zoom-for-dsf flag on clank

BUG=485650

Review-Url: https://codereview.chromium.org/2006863003
Cr-Commit-Position: refs/heads/master@{#395501}

[modify] https://crrev.com/e79f1dd40fc3a6591b1a30aa911eaf1fbb339e49/chrome/browser/about_flags.cc

Comment 143 by abodenha@chromium.org, Jun 17 2016

Blockedon: 621139

Comment 144 by abodenha@chromium.org, Jun 17 2016

Blockedon: 621241

Comment 145 by osh...@chromium.org, Jun 18 2016

Blockedon: -621139

Comment 146 by bugdroid1@chromium.org, Jun 20 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4fde5673829b6dc3f181ceea6214bac0729cb55

commit b4fde5673829b6dc3f181ceea6214bac0729cb55
Author: oshima <oshima@chromium.org>
Date: Mon Jun 20 20:30:30 2016

Apply the zoom factor equivalent to device scale factor to overlay frame.

BUG=485650
TEST=manual

Review-Url: https://codereview.chromium.org/2057493003
Cr-Commit-Position: refs/heads/master@{#400767}

[modify] https://crrev.com/b4fde5673829b6dc3f181ceea6214bac0729cb55/third_party/WebKit/Source/web/InspectorOverlay.cpp

Comment 147 by durga.behera@chromium.org, Jun 21 2016

Labels: Needs-Feedback
Tested the issue on Win 7,Win 10(device scale factor:2.5),Mac retina 10.11.5(device scale factor:2) using 53.0.2774.2 using the below steps.

1) Visiting a page and zooming using ctrl+/-
2) Queried devicepixelratio in console
3) Observed the result varied to device scale factor while zoom in and out.

oshima@ : Could you please review the attached screen shot and let us know if any with the repro steps to verify further.

Notes : 
Result was same whether enabled or disabled the flag "enable-use-zoom-for-dsf".
Pinch zoom on Mac retina does not change the result of devicepixelratio.
485650_June_21.png
1.3 MB View Download

Comment 148 by bugdroid1@chromium.org, Jun 21 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/491e1d537265ecd8c7bddba04173b29708d23e07

commit 491e1d537265ecd8c7bddba04173b29708d23e07
Author: oshima <oshima@chromium.org>
Date: Tue Jun 21 10:51:14 2016

Use correct scale factor value to scale drag image.

This fixes regression in https://codereview.chromium.org/1996223003.

BUG=485650

Review-Url: https://codereview.chromium.org/2081913002
Cr-Commit-Position: refs/heads/master@{#400948}

[modify] https://crrev.com/491e1d537265ecd8c7bddba04173b29708d23e07/third_party/WebKit/Source/core/frame/LocalFrame.cpp

Comment 149 by osh...@chromium.org, Jun 21 2016

Labels: -Needs-Feedback
durga.behera@ yes, that's expected behavior.

Comment 150 by nyerramilli@chromium.org, Jun 21 2016

Cc: nyerramilli@chromium.org
Labels: TE-Verified-M53 TE-Verified-53.0.2774.2
oshima@, thanks for the update

adding TE-Verified labels.

Comment 151 by osh...@chromium.org, Jun 21 2016

Blockedon: 621943

Comment 152 by bugdroid1@chromium.org, Jun 21 2016

Project Member

Comment 153 by aelias@chromium.org, Jun 23 2016

Cc: borisv@chromium.org
 Issue 587659  has been merged into this issue.

Comment 154 by bugdroid1@chromium.org, Jun 23 2016

Project Member
Labels: merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8943b97229c51f6ef0e1eb036089e9b68eff5cf7

commit 8943b97229c51f6ef0e1eb036089e9b68eff5cf7
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Jun 23 20:46:11 2016

Scale menu position back to viewport in pepper plugin

pepper uses DIP, so it needs to be converted to viewport in use-zoom-for-dsf mode.

BUG= 621943 ,485650
TEST=manual

Review-Url: https://codereview.chromium.org/2082893003
Cr-Commit-Position: refs/heads/master@{#401024}
(cherry picked from commit 9373922b7d01101f232c6ccfdedefd76e338e3ab)

Review URL: https://codereview.chromium.org/2094843002 .

Cr-Commit-Position: refs/branch-heads/2743@{#459}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/renderer_ppapi_host_impl.cc
[modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/renderer_ppapi_host_impl.h

Comment 155 by osh...@chromium.org, Jun 25 2016

Blockedon: 621979

Comment 156 by boliu@chromium.org, Jun 28 2016

Blocking: 610377

Comment 157 by jer...@duckware.com, Jul 21 2016

Please include "1/device_scale" into the list of available zoom values.

My device_scale is 1.25, and there is no 80% zoom level for me to get back to 1:1
zoomlevels.jpg
16.6 KB View Download

Comment 158 by tapted@chromium.org, Jul 31 2016

 Issue 612013  has been merged into this issue.

Comment 159 by chrishtr@chromium.org, Aug 1 2016

Cc: dbeam@chromium.org esprehn@chromium.org chrishtr@chromium.org msrchandra@chromium.org vmp...@chromium.org
 Issue 626305  has been merged into this issue.

Comment 160 by rbyers@chromium.org, Sep 7 2016

Note that this was launched for Windows in M53 by bsep ( issue 613414 ).

Comment 161 by dtapu...@chromium.org, Sep 7 2016

Blockedon: 644059

Comment 162 by dtapu...@chromium.org, Sep 7 2016

Blockedon: 644421

Comment 163 by malaykeshav@chromium.org, Sep 8 2016

Cc: malaykeshav@chromium.org

Comment 164 by fmalita@chromium.org, Sep 9 2016

 Issue 643623  has been merged into this issue.

Comment 165 by e...@chromium.org, Oct 31 2016

What platforms still use the old code as of now?

Comment 166 by afakhry@chromium.org, Nov 1 2016

Blockedon: 563730

Comment 167 by sshru...@google.com, Feb 14 2017

oshima@, what is the current status of this work? Predictability program has set an OKR to gain traction on the top 50 starred bugs this quarter: either by closing them, stating what milestone the fix will ship, or setting a NextAction date so that we know when to check back in.

Comment 168 by abodenha@chromium.org, Feb 14 2017

Status: Fixed (was: Started)
The major benefits of this are shipped at 1.25x scale factor.  At this point I think it makes more sense to close this and track anything remaining in the more specific bugs.

Comment 169 by skobes@chromium.org, Feb 14 2017

Is there a bug that tracks turning on --enable-use-zoom-for-dsf for all platforms?

A number of bugs requesting physical-pixel layout precision have been duped into this one, such as  issue 610805  which still repros on Mac canary.

Comment 170 by chrishtr@chromium.org, Feb 15 2017

Status: Assigned (was: Fixed)
Reopening to reply to 169.

Comment 171 by osh...@chromium.org, Mar 3 2017

Blockedon: -621241

Comment 172 by sshruthi@chromium.org, Mar 22 2017

Do we have a response to c#169? Are there bugs tracking remaining work separately?

Comment 173 by malaykeshav@chromium.org, Mar 22 2017

#169 and #172
AFAIK, the bugs for various platforms are:
ChromeOS: This bug
Windows: https://bugs.chromium.org/p/chromium/issues/detail?id=613414
Linux: https://bugs.chromium.org/p/chromium/issues/detail?id=640256

Comment 174 by rbyers@chromium.org, Apr 27 2017

Blockedon: 716231
Filed issue 716231 to get this enabled by default on MacOS (the last platform I believe).

Once that's shipped, can we cleanup the code to remove the setting entirely?

oshima@ are you still the right owner for this?

Comment 175 by rbyers@chromium.org, Apr 27 2017

Blocking: 714278

Comment 176 by osh...@chromium.org, May 4 2017

We also need to enable this on android, and that requires more work. I was originally thinking of working on it, but I'm not working on ARC++/Tablet work and don't have time to spare.

malaykeshav@ is currently working on improving high DPI support on ChromeOS, and he may be able to spare sometime on Android side after his current work is done.

Comment 177 by bokan@chromium.org, May 11 2017

Cc: petermayo@chromium.org

Comment 178 by aelias@chromium.org, May 11 2017

Blocking: 226173

Comment 179 by dk...@chromium.org, May 31 2017

Owner: flackr@chromium.org
@flackr - Rick suggested that someone from your team might be taking this on? If so, could you provide a next action date for when folks following along should check back in?

Comment 180 by flackr@chromium.org, May 31 2017

Cc: flackr@chromium.org
Owner: petermayo@chromium.org
Peter has been working on a cc snapping issue and has run into the inconsistency with device scale factor where we're snapping incorrectly / inconsistently. This should fix all of those issues :-). We're pretty busy with animation worklet currently but we should have a better idea when we plan Q3 OKR's.

Comment 181 by dk...@chromium.org, Jun 28 2017

NextAction: 2017-07-17
Adding a NextCheckin date for after Q3 OKR planning - flackr can you provide an update on when we might tackle this then?

Comment 182 by aelias@chromium.org, Jun 28 2017

Blockedon: 737777

Comment 183 by aelias@chromium.org, Jun 28 2017

I filed  http://crbug.com/737777  about the Android side.  I'm currently planning to take on the task within my team.

Comment 184 by monor...@bugs.chromium.org, Jul 17 2017

The NextAction date has arrived: 2017-07-17

Comment 185 by schenney@chromium.org, Jul 17 2017

Cc: -vollick@chromium.org -le...@chromium.org
aelias@, the NextAction was for Q3 OKR planning. Any update for dknox@?

Comment 186 by aelias@chromium.org, Jul 17 2017

Transitioning Android to page zoom is on Q3 OKRs for Clank-team ("Rendering" slide on http://go/clank-OKRs-q32017).

Comment 187 by aelias@chromium.org, Aug 8 2017

Blocking: -226173

Comment 188 by aelias@chromium.org, Aug 30 2017

Blocking: -610377

Comment 189 by e...@chromium.org, Jan 31 2018

NextAction: 2018-02-28
Has this been done for Android yet?

Comment 190 by boliu@chromium.org, Jan 31 2018

it's actively being worked on for android. see  crbug.com/737777 

Comment 191 by danakj@chromium.org, Jan 31 2018

Comment 192 by bokan@chromium.org, Jan 31 2018

Yes, we hope to have Android done around end of Q1. We still need to implement this on Mac before we can close this out.

Comment 193 by e...@chromium.org, Feb 5 2018

Thanks for the update!

Comment 194 by bugdroid1@chromium.org, Feb 6 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b004c877aa8d098caf8b4735c5896e2ecd9f8980

commit b004c877aa8d098caf8b4735c5896e2ecd9f8980
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Feb 06 04:20:13 2018

Enable Zoom-for-DSF on Fuchsia

Bug:  796979 , 485650
Change-Id: Ifc0d7076c685f12207dc36c550eb36cf97d4faea
Reviewed-on: https://chromium-review.googlesource.com/902795
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534620}
[modify] https://crrev.com/b004c877aa8d098caf8b4735c5896e2ecd9f8980/content/public/common/use_zoom_for_dsf_policy.cc

Comment 195 by monor...@bugs.chromium.org, Feb 28 2018

The NextAction date has arrived: 2018-02-28

Comment 196 by bokan@chromium.org, Feb 28 2018

NextAction: ----

Comment 197 by petermayo@chromium.org, Apr 12 2018

Owner: ----
Status: Available (was: Assigned)

Comment 198 by schenney@chromium.org, Apr 12 2018

flackr@, I'd be much happier if this had an owner. Suggestions?

Comment 199 by bokan@chromium.org, Apr 12 2018

Cc: eirage@chromium.org nzolghadr@chromium.org
The Android-side of this will be landed this quarter. That's being done in input-dev but that's mostly an accident of circumstances (it was started and mostly done by a Clank-er).

That would leave just Mac TODO. I expect much of the work will be Mac specific/UI so it would make sense if someone on Mac team took it over.

Comment 200 by e...@chromium.org, Apr 30 2018

Labels: -Type-Feature Type-Task

Comment 201 by junov@chromium.org, Jul 25 2018

Cc: -junov@chromium.org

Comment 202 by bugdroid1@chromium.org, Jul 31 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0

commit d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0
Author: Ella Ge <eirage@chromium.org>
Date: Tue Jul 31 20:06:02 2018

Enable use-zoom-for-dsf on Android on M70

This CL makes use-zoom-for-dsf enabled by default on Android

This marks Test NoResizeAfterIframeLoad disabled on Android
because it's failing on Android.

This also rebaseline 22 gpu_tests: they are failing on Android
after enabling the flag because the new result are one pixel off
the original reference image. Will test expectations in a followup
CL.

Bug:  737777 , 485650
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If06cf325a831e229fd6bb1889fe1e40ed4bbe764
Reviewed-on: https://chromium-review.googlesource.com/1055812
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579542}
[modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/public/common/use_zoom_for_dsf_policy.cc
[modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/test/gpu/gpu_tests/pixel_test_pages.py

Comment 203 by kbr@chromium.org, Aug 6

Blockedon: 871124

Comment 205 by enne@chromium.org, Aug 31

Issue 610377 has been merged into this issue.
Showing comments 106 - 205 of 205 Older

Sign in to add a comment