New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 480361 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 693761
issue 787485



Sign in to add a comment

--disable-gpu-vsync does not work consistently on Windows

Reported by jer...@duckware.com, Apr 23 2015

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.90 Safari/537.36

Steps to reproduce the problem:
1. run "chrome.exe --disable-gpu-vsync"
2. visit www.vsynctester.com

What is the expected behavior?
very high frame rates

What went wrong?
still appears to be vsync'ed

Did this work before? N/A 

Chrome version: 42.0.2311.90  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 17.0 r0

appears to be D3D11 related, as running with "--disable-d3d11" then causes "--disable-gpu-vsync" to work
 

Comment 1 by Deleted ...@, Jul 11 2015

Enter your commentsWhen i open the browser i use the one at the top of the start panel. If you do not open the one under the google folder where you put the switches on it won't work.
Cc: briander...@chromium.org jmad...@chromium.org kbr@chromium.org geoffl...@chromium.org
Labels: Cr-Internals-GPU
Owner: sunn...@chromium.org
Status: Assigned
Summary: --disable-gpu-vsync does not work consistently on Windows (was: --disable-gpu-vsync does not work on Windows+D3D11)
--disable-gpu-vsync does not work even on D3D9 if you then open a new tab, close it, and return to the app. It would be nice if it worked for benchmarking purposes. Sunny or Brian, do you guys have any insight here?
Brian, didn't you change the vsync flags recently?
Cc: bajones@chromium.org
Labels: Cr-Internals-GPU-Scheduling
This patch landed recently:
https://codereview.chromium.org/1177383005/
but it was after this bug was filed and isn't related to D3D specific code.

+bajones: Do you remember if there was anything different between D3D9 vs D3D11 last time you looked at the disable vsync code?
Not that I'm aware of. There was an issue a while back where ANGLE ignored any attempts to set the swap interval and always left it off, but that's since been corrected. That wouldn't cause this issue, though.

Comment 6 by jer...@duckware.com, Aug 20 2015

When I run this issue under D3D9, I get high frame rates UNTIL the Chrome app window is resized.  After that, frame rate is vsync rate limited.  There is a long history of Chrome issues until the chrome app window is resized under D3D9.

Comment 7 by jer...@duckware.com, Aug 20 2015

To be clear, under D3D11, --disable-gpu-vsync does nothing (browser still vsynced)

Comment 8 by jer...@duckware.com, Oct 26 2016

status update?  The ultimate cause of this is likely related to additional input lag seen in the system (frame delayed to the screen by one frame).

Comment 9 Deleted

[reposted; fixed wrong issue number]

I went back to r303063 -- where "--disable-gpu-vsync" works (unbounded frame rates in Chrome/Windows).

https://codereview.chromium.org/708483003 (landed in r303074) busted that command line option from working.  BUT, as soon as the Chrome app window was resized, that ALSO busted that command line from working.

The issue of resizing the Chrome app window before Chrome worked was addressed in  issue 632785  and  issue 465356 .

Is there something in the back end present that is holding up the frame rates (waiting for vsync)?
Using --disable-gpu-vsync on Windows now causes the Chrome application window to get NO updates (no paints whatsoever).
I just performed a bisect and found that https://codereview.chromium.org/2188063002 causes --disable-gpu-vsync to stop working 100%, only to realize what that fix was -- and then also resizing the Chrome app window also causes it to stop working.

Does this help to pinpoint why "--disable-gpu-vsync" now does not work at all on Windows?
Ultimate cause of --disable-gpu-vsync not working on Windows started after this change:

  https://bugs.chromium.org/p/angleproject/issues/detail?id=814

See last few comments in issue 460919 for details and fix.
Just took a look at that CL. It looks like it did break back then but is currently in a fixed state, in ANGLE's code at least.  Something else within Chrome probably broke as well.

The current code in SwapChain11.cpp is:

UINT swapInterval = mSwapInterval;
#if ANGLE_VSYNC == ANGLE_DISABLED
swapInterval = 0;
#endif

And ANGLE_VSYNC comes from features.h:

#if !defined(ANGLE_VSYNC)
#define ANGLE_VSYNC ANGLE_ENABLED
#endif

 
Before the CL, ANGLE_VSYNC was always *off*.  After the CL, ANGLE_VSYNC was always *on*.

In features.h, #define ANGLE_VSYNC ANGLE_ENABLED is always executed.

ANGLE_VSYNC set to ANGLE_ENABLED means that ANGLE respects the value set by eglSwapInterval.  Setting it to ANGLE_DISABLED is a way for us to force vsync off for performance testing.
And that CL means that on Windows --disable-gpu-vsync NEVER works.  Worse yet, Aero glass is vsyncing -- so vsyncing for DirectX adds an extra frame of input lag for no reason.

With Aero Glass on under Windows, ANGLE should never vsync (as the OS is already vsyncing).
With Aero Glass on, the ANGLE code treats eglSwapInterval as eglSwapInterval+1 -- because the Windows OS is the +1 component.
Understood, but it's a problem with Chrome's usage of ANGLE, it should be turning vsync off by calling eglSwapInterval(0) but there are many complicated code paths involved which I don't understand myself.  ANGLE is currently working as intended, respecting the value set by eglSwapInterval, it doesn't make any assumptions about Chrome's scheduling.
OK, I don't care where the fix is implemented.  I just want this issue fixed.  So how does this issue get fixed?

Under Windows, --disable-gpu-vsync NEVER works and there are TWO vsyncs on every frame Google presents (one by ANGLE, and one by Aero Glass) -- as if there was a eglSwapInterval(2)
Cc: sunn...@chromium.org
Owner: jbau...@chromium.org
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1dd762facbeb164cedf88e07ba7f46458d49659

commit c1dd762facbeb164cedf88e07ba7f46458d49659
Author: jbauman <jbauman@chromium.org>
Date: Fri Feb 17 06:35:53 2017

Fix --disable-gpu-vsync on windows.

The GLSurfaceEGL wasn't being properly notified about the new vsync
interval.

BUG= 480361 

Review-Url: https://codereview.chromium.org/2700433005
Cr-Commit-Position: refs/heads/master@{#451249}

[modify] https://crrev.com/c1dd762facbeb164cedf88e07ba7f46458d49659/ui/gl/gl_surface.cc
[modify] https://crrev.com/c1dd762facbeb164cedf88e07ba7f46458d49659/ui/gl/gl_surface.h

What is the intended behavior of each of these under Windows?

  --disable-gpu-vsync
  --disable-gpu-vsync=gpu
  --disable-gpu-vsync=beginframe

I ask because --disable-gpu-vsync=gpu results in Chrome with a blank screen and no updates (before and after CL)
It looks like new  issue 693761  will handle the sub-issue of what 'value' means in --disable-gpu-vsync=value.  If you agree, then "--disable-gpu-vsync" proper works and this issue can be closed.

Comment 25 by kbr@chromium.org, Feb 18 2017

Blocking: 693761
oh no, --disable-gpu-vsync does not actually work:

(1) if you resize the Chrome application window, it looks like ANGLE vsync turns back on.

(2) in r451462+, using --disable-gpu-vsync causes Chrome application window to be blank and not update at all.
Cc: staraz@chromium.org
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9bbb44814c924c58e80bb0e8b64a9a634fd2198

commit d9bbb44814c924c58e80bb0e8b64a9a634fd2198
Author: eseckler <eseckler@chromium.org>
Date: Thu Mar 02 22:12:14 2017

[cc] Forward BeginFrameAcks through DirectCFS and CFSSupport.

Also updates unit tests to check that acks are indeed forwarded.

BUG= 697086 ,646774,  696030 ,  480361 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2727553004
Cr-Commit-Position: refs/heads/master@{#454400}

[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/surfaces/compositor_frame_sink_support.cc
[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/surfaces/compositor_frame_sink_support.h
[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/surfaces/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/test/fake_compositor_frame_sink_client.cc
[modify] https://crrev.com/d9bbb44814c924c58e80bb0e8b64a9a634fd2198/cc/test/fake_compositor_frame_sink_client.h

latest fix appears to address/fix issue of Chrome application window starting blank when using --disable-gpu-vsync (since r451462+).

There is still the issue that resizing the Chrome application window (started with --disable-gpu-vsync) causes Chrome to somehow go back to vsync.
Cc: stanisc@chromium.org jbau...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Resizing the Chrome application window (started with --disable-gpu-vsync) causes Chrome to somehow go back to vsync.

Will this be fixed?

Comment 32 by fsamuel@google.com, Oct 24 2017

Owner: eseckler@chromium.org
Status: Assigned (was: Available)
+eseckler for triage. Is this still an issue?
Owner: sunn...@chromium.org
My fix didn't address the resize issue that seems to be related to angle (?), only the regression due to r451462. Not sure who the best person for the former would be. Maybe sunnyps@ can identify a suitable owner?
Components: Internals>GPU>ANGLE
Do you know what ANGLE needs to do on resize to make this work?
Blocking: 787485
Project Member

Comment 36 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8680afd3a5b1cb26b0c7a43ab8cf739a59be812c

commit 8680afd3a5b1cb26b0c7a43ab8cf739a59be812c
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Thu Mar 08 02:06:19 2018

gpu: Make --disable-gpu-vsync work with direct composition

This broke because the direct composition path doesn't use swap interval
set by eglSwapInterval in ANGLE. Since we only care about disabling via
command line, it's ok to just handle that instead of SetSwapInterval.

This will still not work when we use a direct composition surface
instead of swap chain but that only happens when we use overlays. There
may be no way to make this case work since the swap chain is not
controlled by Chrome.

Tested with vsynctester.com on my home desktop.

R=kbr,piman
BUG= 480361 , 787485 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ife5804b4e9bcede41bb29cd01e54e81f0d278b62
Reviewed-on: https://chromium-review.googlesource.com/954020
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541687}
[modify] https://crrev.com/8680afd3a5b1cb26b0c7a43ab8cf739a59be812c/gpu/ipc/service/direct_composition_child_surface_win.cc
[modify] https://crrev.com/8680afd3a5b1cb26b0c7a43ab8cf739a59be812c/gpu/ipc/service/direct_composition_child_surface_win.h

comment 6 above still applies (not fixed): "When I run this issue under D3D9, I get high frame rates UNTIL the Chrome app window is resized.  After that, frame rate is vsync rate limited"
Project Member

Comment 38 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fb274d86d50a1163bba281a1e8d343b32e98345

commit 0fb274d86d50a1163bba281a1e8d343b32e98345
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Fri Mar 09 02:48:59 2018

gpu: Remove SwapInterval from command buffer

We don't call this from outside GPU process. It's hard to properly
support this anyway except for enabling/disabling vsync which we do
based on command-line flags in PassThroughImageTransportSurface.

Follow-up CL will remove SetSwapInterval from GLContext and add
SetVSyncEnabled to GLSurface which will be used for enabling/disabling
vsync.

R=piman
BUG= 480361 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If742a9c6b7a87644b76d42b6f602cd440826550b
Reviewed-on: https://chromium-review.googlesource.com/956550
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542006}
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/gles2_cmd_buffer_functions.txt
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/0fb274d86d50a1163bba281a1e8d343b32e98345/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h

Labels: Needs-Feedback
Tested the issue using #67.0.3366.0 on Win 10 as per the steps mentioned in original comment.

@Sunnyps: Could you please find the attached screen cast and confirm about the fix

Thanks!!
480361.webm
29.3 MB Download
Please keep in mind that there are TWO independent vsync mechanisms within Chrome.  One is internal (get vsync time from DWM and start then), the other is via ANGLE (present(1)).  For testing purposes, it would sure be nice to be able to disable one, or the other, or both.
Project Member

Comment 42 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d

commit 14a7d06c52cd0205bbe4227f6a2887f0ae16b91d
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Tue May 08 02:50:12 2018

gpu: GLContext::SetSwapInterval -> GLSurface::SetVSyncEnabled

Replace GLContext::SetSwapInterval with GLSurface::SetVSyncEnabled. The
correct place for this is GLSurface because we want to set the correct
state when recreating the surface on resize.

This fixes --disable-gpu-vsync on D3D9 (--disable-d3d11).

R=piman
BUG= 480361 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib441fda75a86f12c13827a38c37ada05fcf8cb47
Reviewed-on: https://chromium-review.googlesource.com/956898
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556656}
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/command_buffer/service/gl_context_virtual.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/command_buffer/service/gl_context_virtual.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/direct_composition_child_surface_win.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/direct_composition_child_surface_win.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/direct_composition_surface_win.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/image_transport_surface_android.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/image_transport_surface_linux.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/image_transport_surface_mac.mm
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/image_transport_surface_win.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/pass_through_image_transport_surface.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/gpu/ipc/service/pass_through_image_transport_surface.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_cgl.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_cgl.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_egl.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_egl.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_glx.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_glx.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_osmesa.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_osmesa.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_stub.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_stub.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_wgl.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_context_wgl.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface_egl.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface_egl_unittest.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface_glx.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface_glx.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface_wgl.cc
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/gl_surface_wgl.h
[modify] https://crrev.com/14a7d06c52cd0205bbe4227f6a2887f0ae16b91d/ui/gl/init/gl_factory_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment