Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 2 users
Status: Verified
Owner:
Closed: Jul 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-6

Blocked on:
issue google-toolbox-for-mac:53

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
Buttons in Wrench Menu
Project Member Reported by rsesek@chromium.org, Jun 29 2010 Back to list
Need to put the Edit Copy/Cut/Paste and the Zoom controls as buttons inside the NSMenu, like in Cole's mocks.
 
Comment 1 by rsesek@chromium.org, Jun 29 2010
Labels: OS-Mac
Labels: polish Mstone-6
Status: Assigned
Blockedon: google-toolbox-for-mac:53
Status: Started
Comment 4 by bugdro...@gmail.com, Jul 15 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52485 

------------------------------------------------------------------------
r52485 | rsesek@chromium.org | 2010-07-15 08:44:20 -0700 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/menus/simple_menu_model.cc?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_resource.h?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Toolbar.xib?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller.h?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller.mm?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller_unittest.mm?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=52485&r2=52484
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/wrench_menu_model.cc?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/wrench_menu_model.h?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=52485&r2=52484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=52485&r2=52484

[Mac] Put buttons into the new unified Wrench menu.

This also makes changes to MenuController to support NIB-based initialization.
Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru).

BUG= 47848 
TEST=Click on Wrench menu and see buttons. Buttons perform their function.

Review URL: http://codereview.chromium.org/2923009
------------------------------------------------------------------------

Comment 5 by rsesek@chromium.org, Jul 15 2010
Status: Fixed
Comment 6 by ismail@chromium.org, Jul 20 2010
Status: Verified
Chrome version: 6.0.471.0 r52878
Labels: -polish bulkmove Type-Polish
Project Member Comment 8 by bugdroid1@chromium.org, Oct 13 2012
Blockedon: -google-toolbox-for-mac:53 google-toolbox-for-mac:53
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 9 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Browser -Mstone-6 -Type-Polish M-6 Cr-UI-Polish Cr-UI Type-Bug Cr-UI-Browser-Core
Project Member Comment 10 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment