New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 681917
issue 874753



Sign in to add a comment
link

Issue 476234: The field set border is broken with <legend> in vertical layout

Reported by hajime.s...@gmail.com, Apr 11 2015

Issue description

Chrome Version
--------------------
44.0.2364.0 canary (64-bit)


Tests
--------------------
I will attach in next comment. 


Actual result
------------------ 
The position of "Lorem ipsum dolor sit" <legend> is about 20px (1 line box width) further on the left. The fieldset border is broken at its left side.


Expected result
------------------ 
The fieldset border should not be broken at its left side.
It should be broken at its right side to give space for the text run "Lorem ipsum dolor sit".


Other Browsers
------------------ 
Firefox 40.0a1 (2015-04-10): Passed
IE 11.0.9600.17501: Passed

For Firefox, Download and install the latest Firefox Nightly from https://nightly.mozilla.org/
-- Start Firefox Nightly
-- Enter 'about:config' as URL
-- Set 'layout.css.vertical-text.enabled' true
-- Restart Firefox Nightly
https://code.google.com/p/chromium/issues/detail?id=456539#c2

For IE11, 'writing-mode: tb-rl' (deprecated property value) is required. 


More info
------------------
- This bug seems to occur only in 'writing-mode: vertical-rl'
-  Bug 46785 : Make fieldsets work with vertical text (https://bugs.webkit.org/show_bug.cgi?id=46785)
- 2 screenshots of actual and expected can be provided if requested
- Suggested labels for this Issue report: Cr-Blink-Layout Cr-Blink-Layout-WritingMode OS-All Pri-3
 

Comment 1 by hajime.s...@gmail.com, Apr 11 2015

I have attached a test file.


Tests
--------------------
Issue476234LegendPositionInFieldsetRL.xht
Issue476234LegendPositionInFieldsetRL.html
892 bytes View Download

Comment 2 by tkent@chromium.org, Apr 13 2015

Labels: Cr-Blink-Layout Cr-Blink-Layout-WritingMode Cr-Blink-Forms Cr-Blink-Forms-FIeldset

Comment 3 by kavvaru@chromium.org, Apr 16 2015

Cc: kavvaru@chromium.org
Labels: OS-All M-44
Status: Untriaged
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.10.2 using chrome latest stable version 42.0.2311.90  and canary 44.0.2371.0 with the below steps

1.Open the attached html file on chrome
2.Observe that the text aligned vertically to right side corner.
3.Also the border is broken just below the foo.

Able to reproduce the issue the issue on ALL OS.This is non regression issue since from M18(18.0.1000.0).Hence marking it as Untriaged.
Could any one from Dev team please look into this issue.

Comment 4 by pennymac@google.com, May 21 2015

Labels: -M-44 MovedFrom-44 M-45
[AUTO] Moving all non essential bugs to the next Milestone.  (This decision is based on the labels attached to your ticket.)


Ref: https://sites.google.com/a/chromium.org/dev/developers/ticket-milestone-punting-1

Comment 5 by tkent@chromium.org, Jun 17 2015

Status: Available

Comment 6 by deokjin8...@samsung.com, Jan 14 2016

I'd like to work on this issue.

Comment 7 by tkent@chromium.org, Feb 19 2016

Components: -Blink>Forms

Comment 8 by tkent@chromium.org, Jun 24 2016

Labels: Hotlist-Interop

Comment 9 by e...@chromium.org, Apr 7 2017

Components: -Blink>Layout -Blink>Layout>WritingMode
Still broken in ToT.

Comment 10 by sheriffbot@chromium.org, Apr 25 2018

Project Member
Labels: Hotlist-Recharge-Cold

Comment 11 by zcorpan@gmail.com, Aug 16

Blocking: 874753

Comment 13 by dholb...@gmail.com, Aug 23

Cc: zcorpan@gmail.com mstensho@chromium.org
 Issue 876889  has been merged into this issue.

Comment 14 by dholb...@gmail.com, Aug 23

Components: Blink>Layout>WritingMode

Comment 15 by dholb...@gmail.com, Aug 23

Cc: dholb...@gmail.com

Comment 16 by tkent@chromium.org, Aug 24

Blocking: 681917

Comment 17 by mstensho@chromium.org, Sep 13

Owner: mstensho@chromium.org
Status: Assigned (was: Available)

Comment 18 by bugdroid1@chromium.org, Sep 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baebf8c198077228950144b2548a8f196ddacf93

commit baebf8c198077228950144b2548a8f196ddacf93
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Sep 13 19:46:47 2018

Paint legends in vertical-rl fieldsets correctly.

Placed the code for calculating the fieldset border offset and cutout
rectangle for the legend in a separate file, to make it shareable with
LayoutNG (when fieldset eventually gets implemented there).

The test that's supposed to test this fails on Mac, due to sub-pixel
issues. The ref uses a table, and tables don't do sub-pixel layout.
The test (using fieldset-vertical.css) could have used
inline-size:fit-content instead of display:table to avoid this issue,
but it does use display:table, because "fit-content" isn't a supported
value in Gecko.

Bug:  476234 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2b6faaecb1dbb609d0525881a1d164f7831e8759
Reviewed-on: https://chromium-review.googlesource.com/1222826
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591120}
[modify] https://crrev.com/baebf8c198077228950144b2548a8f196ddacf93/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/baebf8c198077228950144b2548a8f196ddacf93/third_party/blink/renderer/core/paint/BUILD.gn
[add] https://crrev.com/baebf8c198077228950144b2548a8f196ddacf93/third_party/blink/renderer/core/paint/fieldset_paint_info.cc
[add] https://crrev.com/baebf8c198077228950144b2548a8f196ddacf93/third_party/blink/renderer/core/paint/fieldset_paint_info.h
[modify] https://crrev.com/baebf8c198077228950144b2548a8f196ddacf93/third_party/blink/renderer/core/paint/fieldset_painter.cc

Comment 19 by mstensho@chromium.org, Sep 14

Status: Fixed (was: Assigned)

Sign in to add a comment