New issue
Advanced search Search tips
Starred by 13 users
Status: Archived
Owner:
Closed: Jun 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment
DevTools: make Canvas profiler an extension.
Project Member Reported by pfeldman@chromium.org, Apr 10 2015 Back to list
We can't make Canvas profiler a part of the DevTools since it wraps user objects for sniffing canvas calls and hence is fragile. We don't do this in any other part of the instrumentation.

We can make it an extension though. This bug is for tracking removal of the canvas profiler from the DevTools. There will be a separate initiative of porting the code being removed into github and publishing it as a Chrome extension.
 
Comment 1 Deleted
Project Member Comment 3 by bugdroid1@chromium.org, Apr 12 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e1eb5cbe734ccb5c2605abaa9f808477c324b95

commit 1e1eb5cbe734ccb5c2605abaa9f808477c324b95
Author: pfeldman <pfeldman@chromium.org>
Date: Sun Apr 12 17:10:00 2015

DevTools: remove Canvas profiler from DevTools source base [content]. See details in the bug.

BUG= 475808 

Review URL: https://codereview.chromium.org/1071263003

Cr-Commit-Position: refs/heads/master@{#324798}

[modify] http://crrev.com/1e1eb5cbe734ccb5c2605abaa9f808477c324b95/content/child/blink_platform_impl.cc
[modify] http://crrev.com/1e1eb5cbe734ccb5c2605abaa9f808477c324b95/mojo/services/html_viewer/blink_resource_constants.h

Project Member Comment 4 by bugdroid1@chromium.org, Apr 12 2015
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=193602

------------------------------------------------------------------
r193602 | pfeldman@chromium.org | 2015-04-12T20:13:08.157056Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-stack-trace-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-enum-descriptions.html?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-gradient-capturing.html?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-get-resource-state-expected.txt?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-api-changes.html?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-get-resource-state-buffer-data.html?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptCanvasModule.cpp?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDevToolsAgentImpl.cpp?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/profiler/module.json?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/profiler/CanvasReplayStateView.js?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScript.h?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorInstrumentation.idl?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/PRESUBMIT.py?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCanvasAgent.cpp?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/BUILD.gn?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/profiler/CanvasProfileView.js?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-get-resource-state-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/profiler/canvasProfiler.css?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/scripts/compile_frontend.py?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptModule.h?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptCanvasModuleSource.js?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-stack-trace.html?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/SlowTests?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/devtools/scripts/check_injected_webgl_calls_info.py?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorInstrumentation.cpp?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCanvasInstrumentation.h?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas-profiler-test.js?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-get-resource-state.html?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorInstrumentationCustomInl.h?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/WrapCanvasContext.cpp?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gyp?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error.html?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/common/Settings.js?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/public/blink_resources.grd?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-get-resource-state.html?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/FlakyTests?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/BUILD.gn?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-enum-descriptions-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptModule.cpp?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptCanvasModule.h?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/main/Main.js?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-api-changes-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/webgl/webgl-get-resource-state-buffer-data-expected.txt?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid.html?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCanvasAgent.h?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/profiler/ProfileTypeRegistry.js?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/devtools.gypi?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core_generated.gypi?r1=193602&r2=193601&pathrev=193602
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html?r1=193602&r2=193601&pathrev=193602
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases-expected.txt?r1=193602&r2=193601&pathrev=193602

DevTools: remove Canvas profiler from DevTools source base. See details in the bug.

BUG= 475808 

Review URL: https://codereview.chromium.org/1073863003
-----------------------------------------------------------------
Project Member Comment 6 by bugdroid1@chromium.org, Jun 9 2015
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=196769

------------------------------------------------------------------
r196769 | yurys@chromium.org | 2015-06-09T14:52:20.123152Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScript.h?r1=196769&r2=196768&pathrev=196769
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptBase.cpp?r1=196769&r2=196768&pathrev=196769
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=196769&r2=196768&pathrev=196769
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScript.cpp?r1=196769&r2=196768&pathrev=196769
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptBase.h?r1=196769&r2=196768&pathrev=196769

DevTools: merge InjectedScriptBase into InjectedScript

Canvas profiler that was implemented as a module of injected script was dropped. We don't want to support injected script modules in such form so the base class doesn't make sense anymore.

BUG= 475808 

Review URL: https://codereview.chromium.org/1168423002
-----------------------------------------------------------------
Status: Archived
Comment 8 by rob@robwu.nl, Jul 4 2015
"There will be a separate initiative of porting the code being removed into github and publishing it as a Chrome extension."

Could you share an crbug issue number or link to a Github PR/issue? The Canvas Profiler was a convenient tool for debugging canvas bugs.
Comment 9 by m...@rcel.cz, Jul 27 2015
Is there anything else that gets enabled using chrome://flags/#enable-experimental-canvas-features ? If not, it would be good to remove this flag.
Comment 10 by rob@robwu.nl, Jul 27 2015
#9 --enable-experimental-canvas-features activates several canvas APIs, which does not have anything to do with this (removed) tool.

The feature that was removed could be activated via --enable-devtools-experiments and then toggling "Canvas Inspection" at the settings panel for experiments in the devtools.
Comment 11 Deleted
Comment 12 by Deleted ...@, Aug 11 2015
I'm aware that the chromium team has removed the "Canvas Inspection" from DevTools. Can you please provide a link to the previous Chrome build where the extension is still available for use.
Any updates?
No updates, unfortunately. There's no effort planned in the short-term to port the canvas profiler to an extension. :/


The best canvas inspection tool I've seen for Chrome recently is called Insight:

https://chrome.google.com/webstore/detail/webgl-insight/djdcbmfacaaocoomokenoalbomllhnko?hl=en
https://github.com/3Dparallax/insight

Aside from this, the Firefox canvas inspection tools complement Insight pretty well: https://hacks.mozilla.org/2014/03/introducing-the-canvas-debugger-in-firefox-developer-tools/

gluck
Sign in to add a comment