New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 474914 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Ban cors responses for client requests.

Project Member Reported by horo@chromium.org, Apr 8 2015

Issue description

The Fetch spec has been changed.
https://github.com/whatwg/fetch/commit/9b4754b9929f2863b39ad7b7382ff206bdfa89a8

https://fetch.spec.whatwg.org/
> If one of the following conditions is true, return a network error:
>   response's type is "error".
>   request's mode is not "no-cors" and response's type is "opaque".
>   request is a client request and response's type is neither "basic" nor "default".

related issue on spec: https://github.com/slightlyoff/ServiceWorker/issues/590
 
Labels: Cr-Blink-Fetch

Comment 2 by falken@chromium.org, Apr 15 2015

Labels: M-44
Status: Started
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=193776

------------------------------------------------------------------
r193776 | horo@chromium.org | 2015-04-15T10:26:50.909227Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/fetch-frame-resource.html?r1=193776&r2=193775&pathrev=193776
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/RespondWithObserver.cpp?r1=193776&r2=193775&pathrev=193776

[ServiceWorker] Treat cors response as a network error for client requests.

The fetch spec has changed.
https://github.com/whatwg/fetch/commit/9b4754b9929f2863b39ad7b7382ff206bdfa89a8
Spec issue: https://github.com/slightlyoff/ServiceWorker/issues/590

BUG= 474914 

Review URL: https://codereview.chromium.org/1067303002
-----------------------------------------------------------------

Comment 4 by horo@chromium.org, Apr 16 2015

Status: Fixed

Comment 5 by tkent@chromium.org, Aug 5 2015

Labels: -Cr-Blink-Fetch Cr-Blink-FetchAPI

Comment 6 by tkent@chromium.org, Nov 27 2015

Labels: -Cr-Blink-FetchAPI Cr-Blink-Network-FetchAPI

Sign in to add a comment